67 Commits (9afaf2216b0bf38cfbd9a0c93409959f78d01820)

Author	SHA1	Message	Date
Matt Clay	d4dec59cb0	Fix collection loader builtin handling. (#58897) ... - Support more import statements: from ansible_collections.ansible.builtin.plugins.module_utils import basic from ansible_collections.ansible.builtin.plugins.module_utils.basic import AnsibleModule - Add unit tests for more import statements. - Raise ImportError instead of returning None if load_module fails.	5 years ago
Matt Clay	9e67953b2e	Fix collection loader and add unit tests. (#58701) ... * Use `compile` before `eval` in collection loader. This fixes two issues: 1. File names are available when tracing execution, such as with code coverage. 2. Future statements are not inherited from the collection loader. * Add unit tests for collection loading. These tests verify several things: 1. That unit tests can import code from collections when the collection loader is installed. 2. That tracing reports the correct file and line numbers (to support code coverage). 3. That collection code does not inherit __future__ statements from the collection loader. * Update unit test handling of the collection loader. Since the collection loader is installed simply by importing ansible.plugins.loader, we may already have a collection loader installed when the test runs. This occurs if any other tests are collected which use that import during collection. Until that code is moved into an initialization function to avoid loading during import, the unit tests will need to replace any existing collection loaders so that they reflect the desired configuration. * Insert into sys.modules before calling exec. This is a requirement of PEP 302. It will prevent recursion errors when importing the current module or using a relative import. * Use the correct value for __package__ in modules. This allows using relative imports in collections. * Add warning about modifying code for trace test. * Add test for relative import in collection. * Add __init__.py to collection to satisfy pylint. The relative-beyond-top-level rule in pylint may not be appropriate for collections. However, until that rule is disabled for collections this will keep tests passing.	5 years ago
Mariusz Mazur	2fb06650a7	kubevirt: even more unit tests (#58593)	5 years ago
Sam Doran	6cf6f5a34b	Use atexit to cleanup tmp dirs (#56532) ... * Wrap everything in try/except to avoid leaving files behind * Add unit tests, integration tests, and changelog * Do text the correct way	6 years ago
Toshio Kuratomi	8acf71f78f	Skip tests with unsatisfied deps (#55853) ... * Skip gitlab tests if dependencies aren't met * Skip certain unittests if passlib is not installed * Fix tests with deps on paramiko to skip if paramiko is not installed * Use pytest to skip for cloudstack If either on Python-2.6 or the cs library is not installed we cannot run this test so skip it	6 years ago
Mariusz Mazur	06292566ec	kubevirt: more unit tests (#57739) ... * Add tests for KubeAPIVersion * Legibility improvements for KubevirtVM tests * Create units.utils.kubevirt with common stuff * Add some VMIRS unit tests	6 years ago
Toshio Kuratomi	27c7d5bb01	Move the arguments module into cli/ and context_objects into utils ... * Note: Python2 is not as intelligent at detecting false import loops as Python3. context_objects.py cannot be added to cli/arguments because it would set up an import loop between cli/__init__.py, cli/arguments/context_objects.py, and context.py on Python2. ci_complete	6 years ago
Matt Martz	042a0cff23	Add unit tests for unsafe_proxy (#47887) ... * Add unit tests for unsafe_proxy * Remove unused import * Address comments * Add inheritance test	6 years ago
Matt Clay	3033fd96b0	Move unit test compat code out of `lib/ansible/`. (#46996) ... * Move ansible.compat.tests to test/units/compat/. * Fix unit test references to ansible.compat.tests. * Move builtins compat to separate file. * Fix classification of test/units/compat/ dir.	6 years ago
Sloane Hertel	5467ac3454	[aws unit test utils] only create a recordings directory when the env var is set (#45752) ... * Only create placebo recording test directories when the environment variable PLACEBO_RECORD is set	6 years ago
Matthias Fuchs	7871027c9d	Share the implementation of hashing for both vars_prompt and password_hash (#21215) ... * Share the implementation of hashing for both vars_prompt and password_hash. * vars_prompt with encrypt does not require passlib for the algorithms supported by crypt. * Additional checks ensure that there is always a result. This works around issues in the crypt.crypt python function that returns None for algorithms it does not know. Some modules (like user module) interprets None as no password at all, which is misleading. * The password_hash filter supports all parameters of passlib. This allows users to provide a rounds parameter, fixing #15326. * password_hash is not restricted to the subset provided by crypt.crypt, fixing one half of #17266. * Updated documentation fixes other half of #17266. * password_hash does not hard-code the salt-length, which fixes bcrypt in connection with passlib. bcrypt requires a salt with length 22, which fixes #25347 * Salts are only generated by ansible when using crypt.crypt. Otherwise passlib generates them. * Avoids deprecated functionality of passlib with newer library versions. * When no rounds are specified for sha256/sha256_crypt and sha512/sha512_crypt always uses the default values used by crypt, i.e. 5000 rounds. Before when installed passlibs' defaults were used. passlib changes its defaults with newer library versions, leading to non idempotent behavior. NOTE: This will lead to the recalculation of existing hashes generated with passlib and without a rounds parameter. Yet henceforth the hashes will remain the same. No matter the installed passlib version. Making these hashes idempotent. Fixes #15326 Fixes #17266 Fixes #25347 except bcrypt still uses 2a, instead of the suggested 2b. * random_salt is solely handled by encrypt.py. There is no _random_salt function there anymore. Also the test moved to test_encrypt.py. * Uses pytest.skip when passlib is not available, instead of a silent return. * More checks are executed when passlib is not available. * Moves tests that require passlib into their own test-function. * Uses the six library to reraise the exception. * Fixes integration test. When no rounds are provided the defaults of crypt are used. In that case the rounds are not part of the resulting MCF output.	6 years ago
Sloane Hertel	f53f29352d	Move AWS placebo fixtures into test/units/utils so module_utils tests can use them (#37300)	7 years ago
Dag Wieers	4efec414e7	test/: PEP8 compliancy (#24803) ... * test/: PEP8 compliancy - Make PEP8 compliant * Python3 chokes on casting int to bytes (#24952) But if we tell the formatter that the var is a number, it works	8 years ago
Matt Clay	10d9318de7	PEP 8 indent cleanup. (#20800) ... * PEP 8 E121 cleanup. * PEP 8 E126 cleanup. * PEP 8 E122 cleanup.	8 years ago
James Cammarata	159aa26b36	FEATURE: adding variable serial batches ... This feature changes the scalar value of `serial:` to a list, which allows users to specify a list of values, so batches can be ramped up (commonly called "canary" setups): - hosts: all serial: [1, 5, 10, "100%"] tasks: ...	8 years ago
Marius Gedminas	5d29a2eabd	Python 3: shlex.split() wants unicode ... On Python 2, shlex.split() raises if you pass it a unicode object with non-ASCII characters in it. The Ansible codebase copes by explicitly converting the string using to_bytes() before passing it to shlex.split(). On Python 3, shlex.split() raises ('bytes' object has no attribute 'read') if you pass a bytes object. Oops. This commit introduces a new wrapper function, shlex_split, that transparently performs the to_bytes/to_unicode conversions only on Python 2. Currently I've only converted one call site (the one that was causing a unit test to fail on Python 3). If this approach is deemed suitable, I'll convert them all.	9 years ago
Toshio Kuratomi	aeff960d02	Cleanup combine_vars ... * Dedupe combine_vars() code (removed from VariableManager) * Fix merge_hash algorithm to preserve the type * unittest combine_vars and merge_hash	9 years ago