Commit Graph

2708 Commits (9aa93fa30761169fdfa7f76725976e329081f3c5)

Author SHA1 Message Date
jctanner 12eaefb7e6 Merge pull request from sayap/git-sha1
git: Always return the before/after revisions, even in check mode.
Michael DeHaan 8666f8ea24 Merge pull request from mmoya/features
Improve change detection in mysql_variables
James Tanner 4f674ec522 Fixes Enumerate user homedir if not passed as an argument
Maykel Moya b90a250165 Improve change detection in mysql_variables
mysql_variables bindly executes a SET var = value query even when
the variable already has the requested value.

With this patch the query is executed only if the current value is
different to the requested one.
Thomas Ronner aee68511e6 Fix illegal set operation in FreeBSD section of user module.
Michael DeHaan 8a516d1479 Various standardization to the proposed gce_storage module to bring things in line with updates to the S3 module.
Some typo fixes.

Further testing required.
Michael DeHaan 4bdf3da25a Merge pull request from bennojoy/gcs
support for google cloud storage module
Michael DeHaan baa13a5cc7 Merge pull request from erjohnso/devel
adding Google Compute Engine modules and inventory plugin
Maykel Moya 2592b2c3f9 Do key validation only when key is provided
key_id is optional, the previous code didn't handle the case of key_id
not specified
jctanner 7e8e186b3b Merge pull request from adfinis-sygroup/devel
Remove keys regardless of the options
jctanner c737f222d5 Merge pull request from joemaller/absent_path_fix
ignore src when file module state=absent
jctanner 51a1a54bfb Merge pull request from robparrott/devel
Properly handle DEFAULT section with ConfigParser in ini_file modules
James Tanner 23cbdba65e Fixes Create homedirectory if create=yes and directory is missing
Michael DeHaan db7e4510f2 Merge pull request from mmoya/features
apt_key: Validate key_id and accept a leading '0x'
Maykel Moya 1a79d9ae58 apt_key: Validate key_id and accept a leading '0x'
Lorin Hochstein 1c5bdba977 s3: better check for walrus
Check for Walrus endpoint by looking to see if the endpoint is not AWS.

This fixes a bug where the user specifies an AWS endpoint via S3_URL,
but the code interprets it as Walrus and then fails.
James Tanner 807e602228 mysql_db: if connection is a socket, do not specify hostname
James Tanner 84a692bcf7 Fixes Use module_common functions for mysqldump and return better errors
Yap Sok Ann 8519d586ba git: Don't add --branch while cloning if the version is a SHA-1 hash.
Yap Sok Ann 9f8cdac0aa git: Handle network problem when running `git ls-remote`.
Yap Sok Ann a53e7045a6 git: Always return the before/after revisions, even in check mode.
The return values from check mode and non-check mode should match in all cases,
except when a SHA-1 hash is used as version, as there is no way to check if it
is a valid hash using `git ls-remote`.

Also, to accomodate this change, the force flag for the reset function has been
removed so that we can do the checking in main.
Yap Sok Ann b9558828e8 git: Make function get_remote_head usable when cloning.
This allows the module to return the before/after revisions in all cases.
Yap Sok Ann 2ad4d77c9a git: Remove unnecessary return code checking.
The functions either return rc=0 or call fail_json themselves.
Yap Sok Ann 9af05f4d2f git: Full length SHA-1 in, full length SHA-1 out.
This removes ambiguity at the expense of slight backward incompatibility.
James Tanner 00f3ec645d Fixes Send easy_install to get_bin_path instead of None
James Tanner 7061c99049 fix indentation in easy_install module docstring
James Cammarata 35284818a9 Handle ssh key files that may only have a type/key specified
If a specified key did not have a comment, it would be ignored as
an invalid key.

Fixes 
Stefan Heinemann af704562a9 Set the options of an authorized key comma separated
According to the sshd man page, no spaces are permitted between the
options of an authorized ssh key
Stefan Heinemann 346d46a94c Don't mind the options of a key when removing it
This allows to remove a key without knowing the options in the
authorized_key file
Mickaël Rémond 007a3fe154 Add executable parameter to find gem binary in gem module
This is especially needed with rvm where gem binary can be in unusual locations
Michael DeHaan e131de4de0 Added "debug: var=variableName" capability.
Michael DeHaan 84ff24d92c Merge pull request from dmkoch/digitalocean-droplet-options
Add "virtio" and "private_networking" options for DigitalOcean droplets
Michael DeHaan 8349c04d06 Merge pull request from renanivo/devel
create install_options parameter for homebrew module
jctanner 79071aee79 Merge pull request from jyap808/patch-1
Assume state='directory' if recurse is set and previous state was 'direc...
Michael DeHaan b8ec300d4c Add note about feature being new in 1.4
Constantine Peresypkin 499a2fe456 add support for disk_config option to cloud/rax module
Michael DeHaan 6ff4806b90 Merge branch 'devel' of git://github.com/shirou/ansible into devel
Pedro Romano e6062db92f Implement a '_get_easy_install' helper function to find the desired
'easy_install' executable, modeled on '_get_pip'
from the 'pip' module to correctly handle all combinations of explicit
executable and virtualenv.
Pedro Romano 307dd77589 Refactor helper function '_get_pip' to handle the cases where an absolute
path explicit executable is passed to the task and to look for an explicit executable
by basename in a virtualenv if that is specified.
Pedro Romano 57a71043a3 New module argument to specify the executable used for running 'pip'. This allows support for system installation of packages on systems with multiple installations of Python.
Pedro Romano 3c33273071 New module argument to specify the executable used for running 'easy_install'. This allows support for system installation of packages on systems with multiple installations of Python.
Pedro Romano 48e50a9c11 Rename copy/pasted variables more appropriately.
Pedro Romano 5a5d431fa1 Changes examples from using Flask to some other package (Bottle was chosen) as per @mpdehaan's suggestion.
Michael DeHaan 54b5548068 Slight tweak to ovirt module docs.
Michael DeHaan f6eae5571a Update version_added in ovirt module.
Michael DeHaan 5dd25692d4 Merge pull request from vincentvdk/ovirt-mod
added new module "ovirt"
Michael DeHaan de3731a14e Some minor doc updates for the acl module.
Michael DeHaan 658b7d1f47 Merge pull request from bcoca/acl_module
initial draft acl module
Brian Coca 311892a567 added long names to support older version as per feedback
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
Jurrien Bloemen 55062c69d6 Added full path to rhnreg_ks command for working correctly with sudo.
Keith Buck 36a8312de6 Improve the formatting and content for the sysctl module's description.
Eric Johnson 1b07e7a521 update defaults and help for 'name' and 'instance_names'
Eric Johnson 81b5c93c78 address a few review comments
Renan Ivo 776de30e6d update version_added of homebrew module
Renan Ivo 488fb484b7 set default options value to None in homebrew module
Renan Ivo dd1b44acd5 create install_options parameter to homebrew module
Michael DeHaan a130a8e614 Merge pull request from eggsby/devel
supervisorctl: user expansion on config filepath
Joe Maller 8597bf6bba ignore src when file module state=absent
Thomas Omans 1dbdd9d6d1 supervisorctl: user expansion on config filepath
Michael Scherer 914226afc3 Fix issue 4433, make sure status is a int rather than a string
Harrison Gu b5500d9a4d Fix bug for setting ec2 tags
Julian Yap 76cec9d360 Assume state='directory' if recurse is set and previous state was 'directory'
Resolves this issue: https://github.com/ansible/ansible/issues/2067
Andrew Pope 6342046da6 Fixed broken force=yes on files for directories
James Cammarata 49130c688d Adding 'unique' option to authorized_key module and cleanup
A small refactoring of the authorized_key module to accomodate these
changes, plus fixing some things like not rewriting the file on every
new key. These changes bring the original feature for ssh options in-
line with the comments in 

Fixes 
David Minor ed7d3f92a0 Add ssh key options parameter to authorized_key module
Michael DeHaan 41aaad69aa Make add_host clear the inventory pattern cache, add some more aliases. Fixes .
Andy Kluger f97871e0d9 Corrected docs ("monitor" -> "monitoring" and dissociated monitoring from instance_tags in examples)
James Tanner d21a0287a2 Remove all sys.exit calls in the cloud/s3 module
Fixes 
jctanner 861779bb6e Merge pull request from mbarrin/devel
Fixed crash when s3 bucket did not exist for put operation
Matthew Barrington ce0bf71245 Fixed crash when s3 bucket did not exist for put operation
Jimmy Tang a4c8d3ee68 This oneliner change allows apt-key to inherit the http_proxy variable.
Before this fix

  TASK: [apt_repository repo='ppa:vbernat/haproxy-1.5'] *************************
  failed: [134.226.115.202] => {"cmd": ["apt-key", "adv", "--recv-keys", "--keyserver", "keyserver.ubuntu.com", "CFFB779AADC995E4F350A060505D97A41C61B9CD"], "failed": true, "rc": 2}
  stderr: gpg: requesting key 1C61B9CD from hkp server keyserver.ubuntu.com
  gpg: no valid OpenPGP data found.
  gpg: Total number processed: 0

After the fix

  TASK: [apt_repository repo='ppa:vbernat/haproxy-1.5'] *************************
  changed: [134.226.115.202]
Michael DeHaan e4036b1bfc Merge pull request from pileofrogs/devel
mysql_replication switch to DictCursor for compatibility with more mysql server versions
Michael DeHaan ce79efc34a Add missing version_added doc to mysql login port parameter.
James Tanner e3849f1be7 Fixes for older versions of usermod which do not have --append
Michael DeHaan 119b6d73dd Remove examples of module antipattern of setting the choices array for boolean types.
Dylan Martin 345329b69f toned down the error message for unconfigured master/slave
Mads Weitling ce799b9e0e Fix Hg.__init__(...) reading value from self.hg_path
Mads Weitling 740a33bcab Fix 'hg module fails with: AttributeError: 'AnsibleModule' object has no attribute 'parames''
Michael DeHaan 8d16a39af9 Correct typo
Robert Parrott 54aeaaf486 small change ... in order to get changed signal correct, move DEFAULT section test upward.
Boris Kaul 5a34e572f5 Add support for Rich Rules in firewalld module
Robert Parrott 762135915c fix handling of [DEFAULT] section by ConfigParser. it is there by DEFAULT.
Michael DeHaan 35a3419bee Merge pull request from localvoid/firewalld-fix_timeout
Fix timeout bug in firewalld module
Michael DeHaan 987bf9e451 Merge pull request from bennojoy/nova1
nova compute fix for instance name regex issue
Boris Kaul 194a7dab9f Fix timeout bug in firewalld module
bennojoy 40565ef236 nova compute fix regex in instance name
Jim Kleckner f231c86ff3 Add detail to copy module validate argument
This clarifies the validate command argument and makes it clear that if
it is present, it must include the '%s' argument for the path to the
temporary file to validate.
Joost Cassee bd10aad71f Add in a retry loop for route53 requests
The route53 api doesn't allow multiple overlapping requests, so if
it is still processing a previous request when the next comes in will
return an error.

Fixes 
James Tanner c679491ece s3: add force alias for overwrite and set True by default
James Tanner c55107fa83 Remove debug comment from s3 module
James Tanner 9c3fb9c2b7 4006: return s3 url even if file exists
Javier Candeira f8255b538e fix django_manage migrate command
Michael DeHaan 0e55bd892d For values that are booleans in the module doc, the value in the doc section should be a boolean or truthiness
is engaged in the documentation formatting.  This fixes the update_cache default in the docs to the proper
value of "no"
Michael DeHaan 203a4f10cd Use explicit boolean defaults in apt module to make the code more clear.
James Tanner b7f229d390 Second attempt at preventing ipv6 route enumeration on EL4 machines
James Tanner 4b1600aae5 Revert "Do not enumerate ipv6 routes in CentOS 4"
This reverts commit 5186c408f7.
James Tanner 5186c408f7 Do not enumerate ipv6 routes in CentOS 4
Eric Johnson cfc249931a custom user-agent header
Michael DeHaan d803ce7ab3 Fix documentation of default value in s3 module. Fixes
Michael DeHaan ce0efc8e25 Fix typo, relative to absolute, fixes
Michael DeHaan 135f79f337 Add documentation about how passwords are generated.
Eric Johnson 9ca824c16d adding Google Compute Engine modules and inventory plugin
James Cammarata a2ac5d6df2 Better detection/categorization of ipv4 secondaries/virtual IPs
Fixes 
Fixes 
Michael DeHaan 0e909640c5 Make group_id be a list.
Michael DeHaan c5672cf16e Merge pull request from MattTheRat/devel
addresses  - adds -m to usermod commands
Matt Warren 74c412e249 addresses https://github.com/ansible/ansible/issues/4371 - adding -m to home directory modification
Michael DeHaan 686d998b26 Merge pull request from sayap/ec2_ami
ec2_ami: Account for AWS's "eventual consistency" with AMI creation.
Michael DeHaan 8604212da9 Merge pull request from jhoekx/mysql-user-grant
Add grant parameter to MySQL user module
Michael DeHaan 709993aa27 Merge pull request from bennojoy/s3
minor fixes
Michael DeHaan 39a81c4361 Merge pull request from psvo/cloudformation_results_fix
Fail cloudformation operation when it is not completed successfully
Benno Joy c1198dc12c change "Changed" to changed
Michael DeHaan f6c3dce497 Merge pull request from orkaa/devel
Fixes service update-rc.d functionality on debian
Michael DeHaan a8902e878c Merge pull request from sashka/devel
Remove options and protocols in source line with regex.
Michael DeHaan 4826d4b87a Merge pull request from ryanaudiencepi/monit_fix
Fix monit uppercase and restart problem
Michael DeHaan 42e84e1b34 Merge pull request from wulczer/fix-linode-param-type
The payment term param in the Linode module is an int.
Michael DeHaan 8dae9fa5e7 Fix module formatting in the pkgutil module.
Michael DeHaan 37970112d9 Add "from" as an alias to "msg_from" in the hipchat module, to match docs.
Joshua Kehn cc0c908cee Added validate option to lineinfile
The validate option is constructed similarly to the template command's
validate option. TestRunner.py has been updated to include two new
tests, one for passing and one for failing validation.
Michael DeHaan b74d9bbc90 Merge pull request from stoned/pre-1.6-passlib
Fix compatibility issue with passlib version < 1.6 (as encountered on eg...
Yap Sok Ann a8f95435c3 ec2_ami: Account for AWS's "eventual consistency" with AMI creation.
Calling `ec2.get_image` right after `ec2.create_image` may raise error
"InvalidAMIID.NotFound". This has happend roughly 1 time out of 10 for me.

Other people has bitten by this too:
- 5707f100a0
- http://stackoverflow.com/a/14794952
- https://bitbucket.org/utoolity/bamboo-aws-plugin/pull-request/22/baws-116-fix-ec2-image-task-failing-with/diff
Martijn Lina 4cd3b9d637 replace dashes in rc.conf keys (which are based on freebsd rc.d filenames) to underscores
Michael DeHaan a74c0091b2 Merge pull request from skyl/GenericBsd-get_default_interfaces
fixes 4365 - Mac with cisco vpn client, GenericBsdIfconfigNetwork get_default_interfaces fails with index out of range
Michael DeHaan b9c337e436 "touch" option on file is new in 1.4
bennojoy 01a0fa1352 gc_storage rewrite commit 2
Benno Joy 834c990903 gc_storage rewrite commit 1
Skylar Saveland b47add0f32 fixes 4365 - Mac with cisco vpn client, GenericBsdIfconfigNetwork get_default_interfaces fails with index out of range
Stoned Elipot b03912278e Fix compatibility issue with passlib version < 1.6 (as encountered on eg EL6 systems)
- passlib.apache.HtpasswdFile's 'default_scheme' was called 'default'
before passlib version 1.6
- while here also deal with passlib.apache.HtpasswdFile's older
'autoload' paramter vs the newer 'new' one.
Matt Martz c56659a2a8 Update references for rax_clb_nodes to use rax_clb
Matt Martz fd959a8b7c Move rax_clb_nodes to rax_clb
Jeroen Hoekx 08b0773da5 Add append_privs parameter to MySQL user module.
This adds the privileges given to the existing list of privileges
instead of overwriting any existing ones.
Daniel Koch cdc5e04d7b Add check to make sure dopy is at least version 0.2.2 for digital_ocean module
Adam Miller 323e8d4a8c fixed firewalld get_service_enabled
Alexander Saltanov 2bd6c5e262 Remove options and protocols in source line with regex.
Fixes 
Michael DeHaan a94a141ad5 Merge pull request from jlund/fetch-typo
Fixed a typo in the fetch module documentation
Daniel Koch 8c0e8354bf Add "virtio" and "private_networking" options for DigitalOcean droplets
The dopy manager defaults to False for virtio, but the DigitalOcean web interface defaults to True, which is a pretty safe default and sensible considering the performance gains.

Private networks are a new feature currently available only in the NYC2 region as of Oct 2, 2013.

NOTE: dopy >= 0.2.2 is required for these options to work.
Joshua Lund db8dd1dcc2 Fixed a typo in the fetch module documentation
Andy Kluger ee054a491a Fix for Issue - gem version string processing
This fix assumes that no sane gem version has spaces in it, so when one like that is encountered, it will get truncated at the first space.
James Cammarata d21714a37f Fix for network byte order issues in accelerate
Dylan Martin 6b26a73681 switch to DictCursor
ryanaudiencepi cd6d4f70c0 Monit fix - Use case insensitive comparison
Michael DeHaan df529b9b69 Merge pull request from jlaska/ec2_group_idempotency
Add idempotency support to ec2_group
James Laska e002496f0e Add idempotency support to ec2_group
Nace Oroz 672a0c04e4 Fixes service update-rc.d functionality on debian
Michael DeHaan 42eeac5aba htpasswd documentation formatting fix
bennojoy 00dcf0f1ac minor fixes
bennojoy c374b4e442 support for google cloud storage module
James Cammarata 912e3a7b0b Merge branch 'accelerate_improvements' into devel
Conflicts:
	library/utilities/accelerate
jctanner 351c4d749e Merge pull request from lorin/htpasswd-doc
htpasswd docs: add notes about depending on python-passlib
Michael DeHaan a43ebf0b29 Merge pull request from tgerla/ec2_eip-docs
ec2_eip module: note that there may be a delay reaching the instance
James Cammarata fa80a17aa3 Make recv_data less greedy so it doesn't eat other packets