8 Commits (9a4ff01a4f9b96a310a61b576b77b6b42f51edc8)

Author	SHA1	Message	Date
Alex Schultz	247e43b252	Fix IncludedFile equality check (#69524) ... In the case of a free style strategy, it is possible to end up with multiple hosts trying to include from the same role, however the tasks being included may be different with the use of tasks_from. Previously if you had two hosts that were included the same role when the process_include_results function tries to determine if a included needs to be run on a specific host, it would end up merging two different tasks into which ever one was processed first. This change updates the equality check to also check if the task uuid associated with the IncludedFile is the same. The previous check only checked if the task's parent uuid was the same. This breaks down when both includes have the same parent. - hosts: all strategy: free gather_facts: false tasks: - include_role: name: random_sleep - block: - name: set a fact (1) include_role: name: set_a_fact tasks_from: fact1.yml - name: set a fact (2) include_role: name: set_a_fact tasks_from: fact2.yml - name: include didn't run fail: msg: > set_a_fact didn't run fact1: {{ fact1 | default('not defined')}} fact2: {{ fact2 | default('not defined') }}" when: (fact1 is not defined or fact2 is not defined) Closes #69521	5 years ago
Abhijeet Kasurde	683c467609	Check if task file is specified for import_tasks (#57572) ... Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>	5 years ago
Matt Martz	fbf2d5d2f4	Don't pollute include_variables (#54687) ... * Don't pollute include_variables. Fixes #51667. Fixes #54618. * Rename include_variables to include_args, so we can make the distinction about what they are * Track args and vars separately * oops * oops again * linting fix * Add test	6 years ago
Matt Martz	3b49bbcfde	Give IncludedFile more context via ansible_search_path (#50045) ... * Give IncludedFile more context via ansible_search_path to template lookups. Fixes #49969 * Update units	6 years ago
Matt Clay	3033fd96b0	Move unit test compat code out of `lib/ansible/`. (#46996) ... * Move ansible.compat.tests to test/units/compat/. * Fix unit test references to ansible.compat.tests. * Move builtins compat to separate file. * Fix classification of test/units/compat/ dir.	6 years ago
Matt Martz	cdb79b0e3a	Consider parent also when comparing IncludedFile (#37083) ... * Consider parent also when comparing IncludedFile * Add new tests for IncludedFile and convert to pytest	7 years ago
Brian Coca	d61742147f	fixed test to new sig	7 years ago
Adrian Likins	1653a77f1d	add unit tests for playbook/included_file.py (#18710)	8 years ago