Commit Graph

15 Commits (9543169ccac8a65202f045af87a731fd229ce4f0)

Author SHA1 Message Date
Michael DeHaan daa005085d Add missing version_added doc to mysql login port parameter. 11 years ago
Jeroen Hoekx 19b52e9fb7 Add append_privs parameter to MySQL user module.
This adds the privileges given to the existing list of privileges
instead of overwriting any existing ones.
11 years ago
James Cammarata 619a80c505 Merge branch 'devel' of https://github.com/tomdymond/ansible into tomdymond-devel 11 years ago
James Cammarata 0eaae4ac9c Cleaning up whitspace issues in the mysql_user module 11 years ago
John Hamelink 266255640e Fixed #3767 - mysql_user command fails with dots (and underscores) in
database names.
11 years ago
Tom Dymond b3646176a9 Add option to specify the MySQL server port 11 years ago
Michael DeHaan fab11537b1 Merge pull request #3691 from stoned/mysql_user-doc-fix
module mysql_user: fix 'state' parameter description
11 years ago
Stoned Elipot a0ce78e6e5 module mysql_user: fix 'state' parameter description 11 years ago
Stijn Tintel 7102503bb2 Only revoke GRANT OPTION when user actually has it
When revoking privileges from a user, the GRANT OPTION is always
revoked, even if the user doesn't have it. If the user exists, this
doesn't give an error, but if the user doesn't exist, it does:

mysql> GRANT ALL ON test.* TO 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE ALL ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
ERROR 1141 (42000): There is no such grant defined for user 'test' on
host 'localhost'

Additionally, in MySQL 5.6 this breaks replication because of
http://bugs.mysql.com/bug.php?id=68892.

Rather than revoking the GRANT OPTION and catching the error, check if
the user actually has it and only revoke it when he does.
11 years ago
Michael DeHaan 23e9e5c028 Add version_added information to module parameter. 11 years ago
Andrew de Quincey 28ec499f2a Check if mysql allows login as root/nopassword before trying supplied credentials. 11 years ago
Michael DeHaan 653d78c23d Merge pull request #3177 from stintel/mysql56-compat
Fix MySQL 5.6 compatibility
11 years ago
Jan-Piet Mens 3404a0fc16 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
11 years ago
Stijn Tintel 66ffef5967 Fix MySQL 5.6 compatibility
In MySQL 5.6, the root account created by default during MySQL
installation has the PROXY ... WITH GRANT OPTION privilege for ''@'',
that is, for all users.

The mysql_user module tries to revoke this privilege, but this fails:
_mysql_exceptions.ProgrammingError: (1064, "You have an error in your
SQL syntax; check the manual that corresponds to your MySQL server
version for the right syntax to use near '''@'' FROM 'root'@'localhost''
at line 1")

Quick fix: don't revoke privilege if user is root and the privilege to
revoke contains PROXY.
11 years ago
Michael DeHaan cd97a4cb14 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago