Commit Graph

1424 Commits (92ddab8a695acef889597f7f93df016ad7e34560)

Author SHA1 Message Date
Daniel Hokka Zakrisson 76f3351b02 Move complex_args templating to be with module_args
Keeps every action plugin from having to do the same thing.
12 years ago
Michael DeHaan ffbd4b5a2c Template options sooner on complex args copy 12 years ago
Michael DeHaan 2bb305f6d5 Fix args templating for complex args with the copy module. 12 years ago
Michael DeHaan 969edabdbb Merge pull request #2322 from bcoca/remote_tmp_override
added check for starting $HOME for remote_tmp so as to non root sudo override
12 years ago
Michael DeHaan 44e44cf295 Merge pull request #2320 from jkleckner/minor-spelling-fixes
Minor spelling fixes
12 years ago
Michael DeHaan fe8547cac0 Ensure template arguments if complex are still properly templated 12 years ago
Brian Coca 76f709286e added check for starting $HOME for remote_tmp so as to non root sudo override
Signed-off-by: Brian Coca <bcoca@tablethotels.com>
12 years ago
Jim Kleckner 92844d3dcd Minor spelling fixes 12 years ago
Maykel Moya e898f30f78 Fix copyright 12 years ago
Daniel Hokka Zakrisson 3d49f74df6 Make apt upgrade=dist work and make its argument handling more idiomatic
Fixes #2287.
12 years ago
Daniel Hokka Zakrisson 1784fd80cc When a host list is used, no parser is present 12 years ago
Grant Gavares cd51c7f234 Add socket timeout to uri module.
The uri module can be configured to abort after a specified timeout if
it cannot connect to the configured uri. This prevents a uri action from
hanging indefinitely when the remote endpoint cannot be reached because
it is unavailable, there is a firewall in place etc. The default behavior
is left unchanged: timeout=None

This change also introduces a new type for module_parameters: int
Code was added to perform conversion from string -> int type in
module_common.py.

The new type was required in order to play nice with httplib2 which
refuses to accept (and convert) anything other than a numeric type for
the timeout value.
12 years ago
Yves Dorfsman e45a0fd61d Added a fail_on_missing option to fetch. 12 years ago
Michael DeHaan 6ad390a92b Revert "Revert "for #2196 now gruopby module invalidates host cached variables so they can be reevaluated with new groups""
This reverts commit dc0515a88a.

We didn't need to revert this :)
12 years ago
Daniel Hokka Zakrisson 5d82b4b1b7 group_by needs the untemplated module_args 12 years ago
Michael DeHaan dc0515a88a Revert "for #2196 now gruopby module invalidates host cached variables so they can be reevaluated with new groups"
This reverts commit 2d86671aa5.
12 years ago
Daniel Hokka Zakrisson 43ce2caa4f Fix parse_kv invocation in group_by to use imported name
Fixes #2277.
12 years ago
Daniel Hokka Zakrisson 2ff2f05a0f host.get_variables includes too many variables, use host.vars instead
Not quite as attractive, but allows variable precedence and lazy
resolution to work as intended, rather than resolving them on a
per-inventory basis.
12 years ago
Michael DeHaan 0b4ad2749a Increase error handling in the unlikely case of failing to establish a connection. 12 years ago
Michael DeHaan 5fd807ac64 Merge pull request #2262 from bcoca/json_nice_error
now ansible shows nice message about missing json instead of traceback
12 years ago
Brian Coca 46c913f7a6 now ansible shows nice message about missing json instead of traceback
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan 7ac5e462ef Fixed a small buglet, if using with_items with yum and so on, only optimize the package list if the package list is all strings 12 years ago
Seth Vidal 804b130288 check if the term is a dict so we can take a simple list of files (like first_available_file) takes 12 years ago
Michael DeHaan b6f7a22de5 Merge pull request #2261 from bcoca/groupby_2186
now group by module invalidates host cached variables
12 years ago
Brian Coca 2d86671aa5 for #2196 now gruopby module invalidates host cached variables so they can be reevaluated with new groups
Signed-off-by: Brian Coca <bcoca@tablethotels.com>
12 years ago
Seth Vidal dfad94078b first_found lookup_plugin - replaces first_available_file
- useful in tasks/playbook inclusion
- task-specific inclusion

allows searching paths and files
12 years ago
Daniel Hokka Zakrisson f1eb195ff5 vars_loader should get the path to the inventory + vars_plugins 12 years ago
Daniel Hokka Zakrisson ad08995989 Make inventory basedir for directory based inventory be the directory
This puts host_vars and group_vars inside of the directory, allowing you
to target a single inventory but still have access to the variables.
12 years ago
Daniel Hokka Zakrisson d9c6b60b24 Allow inventory to be a directory containing other inventories 12 years ago
Daniel Hokka Zakrisson 647cd0141c Move all inventory script code into the script parser 12 years ago
Michael DeHaan fb26f059c5 Merge pull request #2232 from dhozac/module-args-dict
Allow specifying args directly to actions using module: syntax
12 years ago
Michael DeHaan e83819599a Merge pull request #2234 from akvadrako/nice-yaml-and-json
add to_nice_yaml|json filters
12 years ago
Michael DeHaan c92bfb7234 Merge branch 'madcow2' of git://github.com/bcoca/ansible into devel 12 years ago
Jimmy Tang 81a34c2d1d Cowsay on OSX macports 12 years ago
Devin Bayer fca1167a0e add to_nice_yaml|json filters 12 years ago
Daniel Hokka Zakrisson ae8d6ac303 Ensure complex_args is considered in all action_plugins 12 years ago
Daniel Hokka Zakrisson 297259725a Allow (local_)action: to be a dict
Use the key module: to set which module to invoke.
12 years ago
Daniel Hokka Zakrisson c04d5ba739 Allow specifying args directly to actions using module: syntax
Makes things like
- name: do complex things with complex module
  complex:
    setting_a: true
    setting_b:
    - foo
    - bar
possible.

Fixes #2228.
12 years ago
Daniel Hokka Zakrisson 4807fbc8b7 Use regular strings to allow tests to work 12 years ago
Michael DeHaan 323ed27106 Merge pull request #2221 from sfromm/fix-ansible-cli-check-mode
Fix CliRunnerCallbacks.on_file_diff in callbacks.py
12 years ago
Stephen Fromm fa07604d43 Fix CliRunnerCallbacks.on_file_diff in callbacks.py
When running ansible -C, I get a traceback that ends with
    AttributeError: Values instance has no attribute 'diff'
This fixes on_file_diff to behave similar to
PlaybookRunnerCallbacks.on_file_diff().
12 years ago
Daniel Hokka Zakrisson cedfec763a jsonify needs to return a string of {}, rather than a dict 12 years ago
Daniel Hokka Zakrisson e4b72c0fd5 Revert to just escaping \ for JSON-args 12 years ago
Daniel Hokka Zakrisson 1601f0b4d7 Use repr to transfer JSON-arguments, so Python doesn't eat things
Fixes transferring newlines in args:, as well as """.
12 years ago
Daniel Hokka Zakrisson bcf7a2c53a Catch all exceptions coming from lookup plugins
Fixes using $TEMPLATE() and hostvars in a task without a name, among
other things.
12 years ago
Brian Coca e9907e9c8a added random cow pick through ANSIBLE_COW_SELECTION env var
Signed-off-by: Brian Coca <bcoca@tablethotels.com>
12 years ago
Michael DeHaan 1366c663eb Merge branch 'copy-diff-take2' of git://github.com/stoned/ansible into better_diff
Conflicts:
	library/file
12 years ago
Daniel Hokka Zakrisson 93f02d614b Merge pull request #2187 from dhozac/argument-type-check
Add type checking for module arguments, converting as much as possible
12 years ago
Stoned Elipot 8816dc7ca7 Make diff header lines more explicit about what the diff is about
This gives a more readable output when producing diff for a task
with multiple items (with_items).
12 years ago
Stoned Elipot 1b8c9bab35 Fix diff when template destination is absent 12 years ago
Daniel Hokka Zakrisson 22e40b6a61 Merge pull request #2198 from skvidal/nolog-params
No_log params
12 years ago
Stoned Elipot 10e9f1fc1e Implement --diff for the copy module. 12 years ago
Seth Vidal f02ea15f0c command: make sure that all _handle_aliases() calls returns {}
module_common: also work if there are no aliases (shell, command, etc) modules
12 years ago
Seth Vidal c95848ae59 - add an aliases attribute as a lookup of aliasname to canonical name
of parameters
- add support for no_log attribute per-parameter which will not log
  that information to syslog
12 years ago
Daniel Hokka Zakrisson e32fbd312f Shell-quote environment contents 12 years ago
Daniel Hokka Zakrisson 27f3ba53f9 Remove debug print for environment 12 years ago
Daniel Hokka Zakrisson 1df56c07d3 If expand_lists is true, make lookup plugin result into a string
Fixes #2196.
12 years ago
Daniel Hokka Zakrisson 7e0ee6809c Don't template delegate_to too early, not all vars are available
Fixes using delegate_to: $item within a playbook include.
12 years ago
Daniel Hokka Zakrisson f03e845920 Allow hyphens in complex variables
Primarily to support ${hostvars.hostname-with-hyphens.<var>}.
12 years ago
Shaun Zinck e7719e4e46 pass in int() args to get_pty
If LINES or COLUMNS was set, get_pty was failing because it was
expecting an int value to be passed in.
12 years ago
Michael DeHaan 294e43ba2f Removing pipe once since it has some issues about evaluating more than once :) 12 years ago
Daniel Hokka Zakrisson 9076f8eb31 Add type checking for module arguments, converting as much as possible
Converts to list from comma-separated strings, and to dicts from
comma-separated, key=value strings.

Fixes #2126.
12 years ago
Michael DeHaan b75b9681a8 more places to use yaml.safe_load 12 years ago
Michael DeHaan a9ea3136cf Use yaml.safe_load as we are just using basic data structures 12 years ago
Michael DeHaan 5b31feb73b Merge pull request #2179 from skinp/host_connection
Add support for connection type in ansible_hosts file
12 years ago
Patrick Pelletier 2b4ddfb0a2 Handle delegate_to case for local connections in hosts file 12 years ago
Michael DeHaan e51707711c Merge pull request #2120 from jpmens/doc_ex1
Add support for additional EXAMPLES string in Ansible modules
12 years ago
Michael DeHaan f7fb681bb2 Fix comment in chroot connection type 12 years ago
Michael DeHaan 5a1aef5372 Merge branch 'local-chroot-support-v2' of git://github.com/mmoya/ansible into testing 12 years ago
Michael DeHaan 93f73739d3 Merge branch 'paramiko-termcap' of git://github.com/madduck/ansible into testing 12 years ago
Patrick Pelletier 4c0e6722c4 Add support for connection type in ansible_hosts file 12 years ago
Maykel Moya 9a493ef388 Add support for running modules chrooted in a local dir
Adds 'chroot' connection for executing modules chrooted to
a local dir. Requires running ansible as root.

chroot dirs should be specified in the inventory like any
other host.

You can do things like:

$ sudo -E ansible -vvv -f 1 "./chroot1,./chroot2" -c chroot \
  all -m setup
$ sudo -E ansible-playbook -vvv -f 1 -i "./chroot1,./chroot2" \
  -c chroot some-playbook.yml

some-playbook.yml:
---
- hosts: all
  tasks:
    - name: echo something
      shell: echo "Yaaay!" >/tmp/foobar.txt
    - name: install less
      apt: pkg=less state=latest
12 years ago
Stoned Elipot 9f2bba01ba Fix diff output vertical spacing 12 years ago
Michael DeHaan 6d604469d8 Always adjust file attributes with the template module. 12 years ago
Jan-Piet Mens 396a07bcc7 Add support for additional EXAMPLES string in Ansible modules
return DOC and EXAMPLES as a list
add moduledev explanation
more
12 years ago
Michael DeHaan ab389d8908 For consistency, add host should take a key named 'name' in addition to 'hostname'. 12 years ago
Michael DeHaan c4779d95b8 Removing unused import, 'make pyflakes' is now clean. 12 years ago
Michael DeHaan 9cf66f4376 Fixes from 'make pep8'. Partial, more to come. 12 years ago
Michael DeHaan 11e7ede4d9 Merge pull request #2112 from kavink/devel
Fixing syntax error
12 years ago
Michael DeHaan 61d01f549f Show a nicer message when attempting to diff unicode files. 12 years ago
Kavin Kankeshwar 359ac9a495 Fixing syntax error
running install_lib
byte-compiling /usr/lib/python2.6/site-packages/ansible/runner/action_plugins/add_host.py to add_host.pyc
SyntaxError: ('invalid syntax', ('/usr/lib/python2.6/site-packages/ansible/runner/action_plugins/add_host.py', 37, 92, '    def run(self, conn, tmp, module_name, module_args, inject, complex_args=None, **kwargs)\n'))
12 years ago
Daniel Hokka Zakrisson 43d22b0c42 Flatten argument to with_items
Fixes #1711.
12 years ago
Michael DeHaan f02b9987fc We all agreed on the list that the ansible module common module snippet, since it's dynamically embedded in modules on the fly, should
be a BSD licensed snippet so that it's ok to write proprietary modules.  The actual license of Ansible (GPLv3) or any modules
written for ansible (any) do not change.
12 years ago
Michael DeHaan 1ecf4a6943 Working on complex argument support. 12 years ago
Michael DeHaan cd32597af0 Make the file module work as expected in check mode 12 years ago
Michael DeHaan fa21b41357 Fixup the pipe_once plugin 12 years ago
Michael DeHaan 0af83317a1 Added a $PIPE_ONCE lookup plugin, that caches the result so it is only evaluated one time. 12 years ago
Michael DeHaan b365e04616 Allow add_host to add hosts to multiple groups, groups is now an alias for groupname. 12 years ago
Rob Parrott ef17fc9f20 add the ability to take variables in the add_host module, and be willing to parse a host:port hostname handed to add_host 12 years ago
Michael DeHaan c8878998d1 update some of many copyright dates but we can just do this when editing each file, not super high priority 12 years ago
James Martin 7129a9e355 Using "OtherLinux" in module_commons, cleander detection in setup. 12 years ago
James Martin 5646bc278b Support for amazon linux distribution facts. 12 years ago
Michel Blanc 0cd0a7fda3 Fixes jina typos
Moved *jina* to *jinja2*
12 years ago
Michel Blanc 1c22f2146e Adds configurable jinja2 extension loading
Jinja extensions adds features to the jinja2 templating engine. This
patch allows module loading for the templating engine vian an
ansible.cfg configuration key (jinja_extensions).
The default behaviour doesn't change (no module loading).
Requested modules can be added coma separated in ansible.cfg

Adds whitespace handling in jinja_extension config

Added whitespace handling in jinja_extension configuration directive, so
things stay safe if user adds spaces around comas in the directives
list.

Adds config example for jinja_extensions

Added config example with multiple extentions for jinja_extensions
12 years ago
Blair Zajac fa8e653011 Simplify and correct comparisons with None. 12 years ago
martin f. krafft ab39909260 Initialise PTY from calling environment
If we need to acquire a PTY for sudo's use, then it should really
inherit the capabilities of the calling environment. This is what
OpenSSH does, and so it makes sense to copy this behaviour for the
paramiko connection type.

Closes: #2065
Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
martin f. krafft 1cf43e9afe Only allocate a PTY when sudo is used
Postpone the paramiko.Channel.get_pty until we know sudo is used. If
sudo is not used, then we do not need a PTY. In fact, the paramiko docs
explicitly state that it's not desirable to allocate a PTY for a simple
exec_command.

Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
Nigel Metheringham c0e28762f0 Allow end of line comments in inventory file
See github issue 2702
https://github.com/ansible/ansible/issues/2072
12 years ago
Daniel Hokka Zakrisson 7e2999ed2d Add directory detection to _remote_md5 and use this in copy
If it is a directory, change the destination path by appending the
basename of the source file, like is done if the destination ends with a
/, and try to get the MD5 of the new path.
12 years ago
Daniel Hokka Zakrisson d632210941 Allow using other users' home directories as well 12 years ago
Daniel Hokka Zakrisson 89e73c123f Fix tilde expansion for fileglob
Use common suffix to determine what part of original term to keep and
how much of the full path to combine to get a usable filename.
12 years ago
Daniel Hokka Zakrisson 57e51f7fdf Clean up some extra_vars redundancy 12 years ago
Chris Hoffman 9057f72881 Removing duplicate import, adding missing import 12 years ago
Daniel Hokka Zakrisson a1e00c93e5 Add ansible_ssh_user/pass to enable inventory-defined users 12 years ago
Daniel Hokka Zakrisson c83e428a7e Default expand_lists to True and set it to False for only_if
Fixes #2026 and #2027.
12 years ago
Michael DeHaan f7497e75e5 Able to use "environment: " on any task to pass proxy details and other useful settings. Can be a variable
or a dictionary.
12 years ago
Michael DeHaan 72a05ae2a0 Move diff code more into runner code. 12 years ago
Michael DeHaan 0ad6ac4086 Fix group depth for nested groups 12 years ago
Michael DeHaan 828119d823 Allow the remote username to come from a variable set in vars_files or vars 12 years ago
Michael DeHaan e6ead2ca74 make things like $FILE(/etc/path/foo.conf) and $ENV(HOME) work without having to use brackets to index them 12 years ago
Michael DeHaan c692de6b80 Cleanup YAML parse error warning code a tiny amount. 12 years ago
Steve Frank 36027ddbba Squashed commit of the following:
Changed ami_tags to instance_tags to better follow naming convention
    Add support for creating tags on the new instances
12 years ago
Michael DeHaan a894791767 Slightly friendlier error on missing hosts file, slightly friendlier error on inventory script returning invalid syntax
(or if inventory is non-script and accidentally executable).
12 years ago
Brian Coca ca5f52b825 now missing hosts file gives nice message and no traceback
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Brian Coca 0e8627b7e8 added block device info gathering, full for linux, partial for freebsd added prettyfing byte function Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
moved moutns out of devices Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Matt Cordial 2ccfc8d2b6 Fix Issue #2025 where templates were not being transfered. 12 years ago
Michael DeHaan a9162a86f2 Very basic --diff option for showing what happens when templates change.
Probably output is not useful if not used with --limit

Works well with --check mode
12 years ago
Daniel Hokka Zakrisson f3305564e2 Add stderr contents to parse errors 12 years ago
Daniel Hokka Zakrisson 19f3cf45f4 Merge pull request #1982 from dex4er/feature_j2_filter_safe_yaml
Use yaml.safe_dump rather than yaml.dump. No more "!!python/unicode".
12 years ago
Daniel Hokka Zakrisson dddfeac9c4 Allow using ${hostvars.<node>} for nodes not in SETUP_CACHE
This allows accessing inventory data from nodes that have not been
talked to (yet).
12 years ago
Daniel Hokka Zakrisson ffd4ae11b8 Merge pull request #1993 from fdavis/timeout_ssh
Add ConnectTimeout=DEFAULT_TIMEOUT to ssh args
12 years ago
Daniel Hokka Zakrisson 70d5dad726 Also catch NameErrors which would indicate missing quotes 12 years ago
Daniel Hokka Zakrisson bc709e7b67 expand_lists should default to False 12 years ago
fdavis 21a5c55921 Add ConnectTimeout=DEFAULT_TIMEOUT to ssh args 12 years ago
Daniel Hokka Zakrisson 98f0a9210e Raise an error when multiple when_* statements are provided
Fixes #1994.
12 years ago
Daniel Hokka Zakrisson d5e63332fe Raise an error if an action doesn't have a string type
Happens with e.g. "command: true" that YAML helpfully converts to a
bool.
12 years ago
Rune Kaagaard 7a8b27f716 Fixing bug with unicode templates.
The utils.md5s() function would break when calculating checksums
for non-ascii characters. Convert to utf-8 first.
12 years ago
Daniel Hokka Zakrisson c1b63d1500 Fix for when conditional is a simple bool already
Fixes #1983.
12 years ago
Piotr Roszatycki 8cf268441e Use yaml.safe_dump rather than yaml.dump. No more "!!python/unicode". 12 years ago
Daniel Hokka Zakrisson 1becc665b2 Fix missing ) in add_host
Fixes #1980.
12 years ago
Michael DeHaan fed82c2188 This implements a basic --check mode which for now is only implemented on template & copy operations. More detail will be shared with the list
shortly.
12 years ago
Daniel Hokka Zakrisson d8d1f2cd7a Split PATH on os.pathsep, that is what it's there for 12 years ago
Daniel Hokka Zakrisson a025cfcb33 Add on_import_for_host callback from non-list case 12 years ago
Daniel Hokka Zakrisson a79373f6b2 Make template_ds the only templater
Instead of having to remember when to use which one, rename template_ds
to template and move the last bit of code from template to varReplace
(which gets used for all string replacements, in the end).

This means that you can template any data type without worrying about
whether it's a string or not, and the right thing will happen.
12 years ago
Michael DeHaan f7aaa5ccc5 Fix copyright, unused imports 12 years ago
Michael DeHaan 857ccf7f6c Add random choice plugin (with_random_choice) 12 years ago
Michael DeHaan 318e3302fb Fix up some version related things on the devel branch. 12 years ago
Daniel Hokka Zakrisson f7e286cf34 Fix error format for invalid vars_files 12 years ago
Seth Vidal 83b9654c63 stop updating SETUP_CACHE in run_play as per comment on pr 1945 12 years ago
Seth Vidal f649777072 - make extra-vars override all other vars and facts in playbooks 12 years ago
Daniel Hokka Zakrisson b79960e13b If failed lookups are fatal, re-raise the exception
Fixes #1938.
12 years ago
Daniel Hokka Zakrisson e166f71fcc Get output before receiving return code
Fixes hangs observed with large amounts of output, as it would get into
a dead-lock.
12 years ago
Michael DeHaan 4d8f3b0924 This standardizes the apt_key module some
* improves error handling and reporting
* uses run_command to reduce code
* fails quicker on errors as opposed to return codes and tracebacks
* can now also specify the key as data versus needing to wget it from a file
12 years ago
Daniel Hokka Zakrisson 5268d49bad Add sudo_flags configuration option to alter sudo behaviour
Default to -H to set $HOME appropriately.
12 years ago
Les Aker f4eed3710b fixed check for required_together 12 years ago
Michael DeHaan 0030a2bd09 Allow handler files to be empty lists. 12 years ago
Michael DeHaan 0c2f67ef66 Merge pull request #1923 from fdavis/ans_env_addition
add env vars for plugins action,callback,connection,lookup,vars,filter
12 years ago
Michael DeHaan 36066d8664 Fixup ec2_facts docs parsing 12 years ago
fdavis 925c1a4611 add env vars for plugins action,callback,connection,lookup,vars,filter 12 years ago
Daniel Hokka Zakrisson 4d71b31f7e Ensure destination and source are available before mangling them
Fixes #1918.
12 years ago