Commit Graph

564 Commits (91ca8d42e77e5d4305145cbf5ccba711cf43cd41)

Author SHA1 Message Date
Toshio Kuratomi 5ec8c28d2a remove debugging that was causing failure 10 years ago
Toshio Kuratomi 8dfc54b517 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
10 years ago
Toshio Kuratomi 24a33d5c10 Revert "Refactor the Linux service_enable() method" needs some debugging
This reverts commit e294e31fd3.
10 years ago
Toshio Kuratomi e294e31fd3 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
10 years ago
Toshio Kuratomi 79a2e586fe Make systemd vs rht detection more robust for centos
Centos 6.x and below use an old RHT style of configuring hostname.
CentOS 7.x and better use systemd.  Instead of depending on the
distribution string which seems to have changed over the course of 6.x
we need to explicitly check the version.

Fixes #8997
10 years ago
James Cammarata 22dbb65b13 Move initscript rc check to later in service status check
Fixes #7284
10 years ago
Michael DeHaan 26cdddaebf Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules. 10 years ago
Patrik Lundin e65ca6876f service: use self.changed in service_enable_rcconf().
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
10 years ago
James Cammarata d6a8d4671a Add additional checks to detect upstart services
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
10 years ago
Eri Bastos 82ec224a93 Proposed fix for issue #7757 10 years ago
James Cammarata 0dda8a7996 Tweaking change to documentation language for cron name param 10 years ago
James Cammarata a415993142 Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel 10 years ago
James Cammarata 2d683cbd30 Merge pull request #8740 from mattparker/patch-1
Name appears to be a required parameter for cron module
10 years ago
James Cammarata 77ef324ab7 Merge pull request #8729 from ercpe/openrc-hostname
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
10 years ago
Matt Parker fd982cf8b7 Update cron documenation
The "name" parameter seems to be rather important as the identifying feature of a cron job.  This is an update to the documentation to further emphasize this.
10 years ago
Matt Parker dc634bc644 Name appears to be a required parameter
As far as I can tell, `name` is a required parameter.  The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear.  Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too.  However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
10 years ago
Johann Schmitz 9945a732f7 Hostname strategy implementation for OpenRC based systems (e.g. Gentoo) 10 years ago
Ding Deng 13db184d7f debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7). 10 years ago
Michael DeHaan 46e9c287a7 Fix documentation builds. 10 years ago
Michael DeHaan 8cab5937c3 Merge pull request #8002 from prune998/patch-2
added missing force flag on mkfs commandline
10 years ago
Michael DeHaan 3bead39c75 Merge branch 'spelling' of git://github.com/cgar/ansible into devel
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
10 years ago
Michael DeHaan 19ef7b3eeb Update docs. 10 years ago
Michael DeHaan bfe8437a21 Updating docs. 10 years ago
Brian Coca db146717b5 bumped to 1.7 10 years ago
Brian Coca 268122d7d0 added control to fail or not on missing key
made split 'smarter' but still overridable
10 years ago
Brian Coca 27bf4d8ec4 added getent module to get system data as facts 10 years ago
Serge van Ginderachter 25b696c2d2 execute the mount after path validation
This avoids a stale situation where name/path contains some impossible path,
but gets configured (faultly) in fstab, and the module only fails after that,
when creating that path.
10 years ago
Jonathan Mainguy c0966eee7c Fixes issue #8339 where Scientific Linux incorrectly tries to use FedoraStrategy of hostnamectl 10 years ago
Michael DeHaan f61ba3d047 Merge pull request #8283 from ps-jay/sys_mount_fstype_doc
Add fstype arg to the mount examples
10 years ago
Michael DeHaan 6300ded89c Merge pull request #8311 from neersighted/wrap_distroversion
Wrap get_distribution_version() in the hostname module
10 years ago
Michael DeHaan 226dacc7e6 Cleaning up explanation of mount module states. 10 years ago
Bjorn Neergaard adcdbdf894 Wrap get_distribution_version() in the hostname module
We wrap get_distribution_version() with a new function,
_get_distribution_version(), that returns `0` when the result is a string or
`None`.

This accounts for the case when get_distribution_version() returns a string,
and we try to compare it to a float. We do this in the hostname module instead
of the module snippets because other modules may want the real string
version.module snippets because other modules may want the real string version.
10 years ago
Michael DeHaan b69f096e8a Merge branch 'ufw' of git://github.com/Trozz/ansible into devel 10 years ago
Michael DeHaan 216f803aa5 Merge pull request #7954 from alimony/patch-3
cron module: Use correct parameter name in error message.
10 years ago
James Cammarata d1d318b028 Merge pull request #8308 from robinro/extend-hostname-distrolist
Extended distributions list for hostname module
10 years ago
Robin Roth e91c318327 Fix extra newline at end of hostname for Fedora
This fixes a bug introduced by 138b45e3.
The hostname has an additional newline at the end which leads to the
state always being 'changed: true' even if the hostname is unchanged.
10 years ago
Robin Roth 7a09f87b8c Extended distributions list for hostname module
Implementations already present
10 years ago
Tom Lazar 146a0f1cb7 FreeBSD 10 compatibility fix
On FreeBSD the whitespace around the ``=`` triggers a (cryptic) ``no such file or directory`` error. removing the whitespace like above fixes this.
10 years ago
Philip Jay 138fffb152 Add fstype arg to the mount examples
Needed fstype in the examples, since fstype is a required argument for
mount.
10 years ago
Berend de Boer 869cc7947e Default for fstab missing, causing KeyError: 'fstab' 10 years ago
James Cammarata 593057515c Merge pull request #8223 from renard/create-fstab-if-not-exists
Create fstab if not exists
10 years ago
Sébastien Gross 48128ec0ab [mount] make sure fstab exists
This is mainly to prevent from failing with no such file or directory
during module execution.
10 years ago
Sébastien Gross f2e2337d07 [mount] Add documentation for fstab option 10 years ago
Hector Acosta ec70bb01ef Add check_mode support to authorized_key. Fixes #7300
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
10 years ago
Yasser Nabi 8a6bbfd3b5 Enable puppet facts
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.

In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.

The benefit is, filtering can be done based on facts set by Puppet.
10 years ago
Michael DeHaan 64b874129f Merge pull request #8139 from peterkh/devel
Fix "TypeError: group id must be integer" if groupid passed in for group key
10 years ago
Ruggero Marchei 8904c61932 fix LooseVersion exception with empty distribution_version 10 years ago
Peter Hall 09a5d8f6d1 Fix "TypeError: group id must be integer" if groupid passed in for group
key
10 years ago
Ruggero Marchei d6bca15aa5 fix issue #8102 10 years ago
Cristian Ciupitu 6a8bc42014 Remove useless code 10 years ago