Commit Graph

23088 Commits (90631aef1bba91f8be5fe55c3b06ef58c0e9d584)
 

Author SHA1 Message Date
Toshio Kuratomi a6643160c5 Fix stat code to return name of group owning the file rather than name of group that the file's owner belongs to.
Followup to #17
8 years ago
Ash Wilson 2dde45cea9 Only fetch details when necessary. 8 years ago
Ash Wilson 93b620ea8a Compare container images to Config.Image. 8 years ago
Sarah Zelechoski 17334b21ea fix syntax in last example 8 years ago
Sam Thursfield 5d2652f31b Fix authorized_key module crashing when given an invalid key
I tried a playbook with the following (accidentally wrong) task:

  tasks:
      - name: authorized key test
        authorized_key: key=/home/sam/.ssh/id_rsa.pub key_options='command="/foo/bar"' user=sam

I got the following traceback:

    TASK: [authorized key test] ***************************************************
    failed: [localhost] => {"failed": true, "parsed": false}
    Traceback (most recent call last):
    File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 2515, in <module>
        main()
    File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 460, in main
        results = enforce_state(module, module.params)
    File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 385, in enforce_state
        parsed_new_key = (parsed_new_key[0], parsed_new_key[1], parsed_options, parsed_new_key[3])
    TypeError: 'NoneType' object has no attribute '__getitem__'

With this fix, I see the expected error instead:

    TASK: [authorized key test] ***************************************************
    failed: [localhost] => {"failed": true}
    msg: invalid key specified: /home/sam/.ssh/id_rsa.pub
8 years ago
Brian Coca c04c84887e fix to return vals docs 8 years ago
James Martin 57cf6e8bb4 Re-wording of feature. 8 years ago
Toshio Kuratomi e5149f3b30 Fix review comments from @bcoca in #745 8 years ago
Toshio Kuratomi 5378b5db98 Minor code formatting 8 years ago
Tim Rupp db6c2bac75 Add missing import of apt.debfile
In cases when the python-apt package is not installed, ansible will
attempt to install it. After this attempt, it tries to import the
needed apt modules, but forgets to import the apt.debfile module.

The result is that playbooks that use the dpkg argument on a machine
that does not initially have the python-apt package available will
fail with the following error

AttributeError: 'module' object has no attribute 'debfile'

This patch adds the appropriate import to the apt module to ensure
that necessary libraries are available in cases when the dpkg argument
is being used on a system that does not initially have the python-apt
package installed
8 years ago
Rowan Wookey 04fcfdad2c Fixed group name not being passed to wait_for_new_instances when replacing instances
Fixed group_name not being passed to wait_for_elb
Minor code clean up
8 years ago
moe bd09ebe5b4 Woops, make collect/delete loop more efficient. 8 years ago
moe 5e1e1a4dff Fixes #744.
The following cases work for me now:
- Create new ASG with tags
- Update tags on ASG (create/change/delete)

In short, the module should now work as expected
wrt tagging. The previous code did not work at all
with latest boto for me (serialization errors) and
the logic was buggy anyway; e.g. removed tags
would never get deleted from ec2.
8 years ago
James Martin cadfd56304 check lb for instance healthy and some refactoring of rolling replace functions.
Optionally waiting for new instances to be in viable state on ASG creation/update.

Properly updating properties and terminating group.
8 years ago
Brian Coca 7f8094e977 undeprecated openstack modules as new ones are not making into release 8 years ago
moncho 0156188a54 Update docker.py
Fix typo that prevents use_tls 'encrypt' option from working properly.
8 years ago
Toshio Kuratomi 5262d768e0 Add another valid status from downloading images 8 years ago
nemunaire 7eebab43ae Convert tuple items to string before format 8 years ago
Robert Marsa b7649cc5ca Added multiple allowed ranges. 8 years ago
Julien Syx c676adde0b Fix the issue #931
Checking that the parameter doesn't exist. The old code had a bug when the parameter was 0.
8 years ago
Toshio Kuratomi d5e3abc5d5 Some code cleanup (removed unused variables and imports) 8 years ago
Toshio Kuratomi f892ca5b8f Also use DOCKER_TLS_VERIFY env var to turn on tls verification 8 years ago
Toshio Kuratomi 1bb98542d3 Fix a potential bug in docker pull 8 years ago
Toshio Kuratomi 0ad023a0ac When no use_tls is not specified and no tls parameters are given we need to not attempt tls. 8 years ago
Alex Rowley eeb867daf0 cloud/amazon/s3: update documentation
update description to show that module can do more than just put files into s3
8 years ago
Toshio Kuratomi 2e93f8e9f7 Make state=running work for backwards compatibility with 1.8 8 years ago
Toshio Kuratomi 1946f05baf Fix lookup of parameter name to be pid instead of pid_mode 8 years ago
Toshio Kuratomi 09a0db1e1f Make pid_mode parameter do minimum docker-py/docker server version checks 8 years ago
Toshio Kuratomi 95df4bcbee Fix for problems found by @dguerri
* TLSConfig['verify'] has to be set to False if we're only encrypting the
  connection, not verifying the host.
* tls_hostname was not set if tls_ca_cert was not present

https://github.com/ansible/ansible-modules-core/pull/926#issuecomment-78573877
8 years ago
Toshio Kuratomi 7c261b3954 Implement comments from @smashwilson:
* if tls_ca_cert is set then use tls to verify the server
* take tls_hostname from the environment variable DOCKER_TLS_HOSTNAME
  if it's not specified in the playbook

https://github.com/ansible/ansible-modules-core/pull/926#issuecomment-78542210
8 years ago
Ian Babrou 3bfe9a7b50 fixed: global name 'e' is not defined 8 years ago
Toshio Kuratomi 3284359894 Alternative implementation of tls for docker
Alternative to #854
8 years ago
Toshio Kuratomi c9b33d5de2 Fix for py2.6 (no dict comprehensions on py2.6) 8 years ago
Toshio Kuratomi c9cc8d0b70 Initialize the value of vpc_id variable 8 years ago
Mario Loria 00613cd4f3 Setting the actual passno and dump defaults, and warning user of consequences in nulling
Using ansible 1.8.4, I found that these two options actually work slightly different than advertised.
8 years ago
Toshio Kuratomi ba90eea165 Also don't fail if files are different and overwrite is false for uploads (this mimics copy and template).
Related to #489
8 years ago
Hagai Kariti 7d16ec283e Fix KeyError in public zones in route53 8 years ago
Toshio Kuratomi a02641b4f3 Documentation style changes 8 years ago
James Bowes 0d3aed3e1f Fix C() formatting typo in file module 8 years ago
Matt Martz bcd9f83521 Prevent an empty error message 8 years ago
Brian Coca 34dbd69e12 updated to keep same info as in extras repo 8 years ago
Ian Babrou 005d02b185 not triggering reload for links and not string env variables 8 years ago
Ash Wilson 7c4e8774d8 Use {0}, {1} style format indices for 2.6 compat 8 years ago
Ash Wilson ff0d0ceb70 Expect module env vars to override Dockerfile ones. 8 years ago
Ash Wilson 4e7d766e8f Include bind mounts in VOLUMES check. 8 years ago
Ash Wilson 959d135b60 Exposed ports, env vars, volumes from the image.
This will account for settings that are provided by the hierarchy of
Dockerfiles used to construct your image, rather than only accounting
for settings provided to the module directly.
8 years ago
Ash Wilson 0d822c0c02 Full image inspection and just repo tags
Hat tip to @bobrik.
8 years ago
Toshio Kuratomi bba322a10e Sort subnets by the order they are specified in the play
Fixes #172
8 years ago
Bret Martin 650a7365f9 Allow vpc_subnet_id to remain unspecified (see bc0c169) 8 years ago
Sam Yaple 42fd85f041 Updated version and fixed default 8 years ago