Commit Graph

3580 Commits (8d968e5001e95f7d1101eef8fc4d3876dfeebcae)

Author SHA1 Message Date
Matt Clay feea6425f3 Fix pip integration test.
(cherry picked from commit ea70b49b11)
8 years ago
Toshio Kuratomi 475cc33546 Revert "Add test for fix using loop_control with delegate_to (#33809)"
This reverts commit adf8927c74.

This test uses features not found in ansible-2.4
8 years ago
Martin Krizek adf8927c74 Add test for fix using loop_control with delegate_to (#33809)
(cherry picked from commit 5c7f203c33)
8 years ago
Matt Martz 32ddcf96df Recursively remove args with omit as as their value, to match suboptions in argument_spec (#35299)
* Recursively remove args with omit as as their value, to match suboptions in argument_spec

* Add test for the new remove_omit function

(cherry picked from commit 7404dc6767)
8 years ago
Yuwei Zhou 6b26ca183d delete subnet should be idempotent (#35037)
(cherry picked from commit 7c201fc9bc)
8 years ago
Matt Martz 2924ad1bbf Don't skip an inventory source just because it has a comma (#35002)
* Don't skip an inventory source just because it has a comma, make sure it's also doesn't exist as a path. Fixes #34931

* Add integration test for inventory path with commas

(cherry picked from commit 1ac04ba52e)
8 years ago
Trishna Guha 128ee6f48f fix conflict nxos tests (#35078)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
8 years ago
saichint d16b5c23c9 fix vxlan idempotent issue (#34750)
(cherry picked from commit c04cd8642d)
8 years ago
Trishna Guha 31519edee6 Enable nxapi nxos_banner test (#35033)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 8a6d699198)
8 years ago
saichint 49df1fbafd Fixes for nxos_bgp (#34590)
* fix bgp issues

* add new tests cases

* review comments

(cherry picked from commit 6f8d3ad70d)
8 years ago
saichint c11c35e32a fix for nxos_vxlan_vtep_vni issues (#34946)
* fix vxlan_vtep_vni issues

* pep8 errors

(cherry picked from commit 3a144b290d)
8 years ago
Trishna Guha 968e048b0d Idempotency test for enabled mode nxos_udld_interface (#35031)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit f806a58a5e)
8 years ago
Jordan Borean 159b0f628d copy tests: only create recursive symlink in tests (#35073)
(cherry picked from commit 9106284c1c)
8 years ago
Jordan Borean 1ddd9dabd8 win_script: fix large args and misc errors in wrapper 8 years ago
Matt Clay 75da39fbce Fix failing zypper_repository integration test.
(cherry picked from commit b1d14d5b06)
(cherry picked from commit 9c0cf0eafa)
8 years ago
Toshio Kuratomi 055cae3c0f Revert "Integration tests for import/include (#33418)"
This reverts commit 8c822018db.

There's some other bugs in 2.4's import/include that aren't blockers for
2.4.3 (becaues they aren't regressions) that prevent the new integration
tests from passing.  Revert the integration tests.
8 years ago
Sam Doran 8c822018db Integration tests for import/include (#33418)
* First pass at include_role tests

* Reorganize test structure

Do all import and include tests in a single target.

* Build out more tests and test with linear and free strategy for each type

* import_role tests

* Set target host for play test

* Basic import_playbook tests

* Basic import/include_tasks tests

* Add recursion test

* import_playbook tests

* Add import_playbook group_vars test

Issue #33177

* Additional group_var tests for import_playbook

* Enable recursion test

* More work on import_tasks

* Run all tests via run.sh, improve conditional tests, add never tag

Add never tag to certain failining tests and explicitly skip it for now until #34104 is merged. Some tasks need to remain commented out because they cause the entire play to fail and aren't skippable by tags because they are syntax and/or variable checks.

Improve test for whether or not a role was run based on a conditional. Since the [import|include]_role does not register a variable, use a variable that is set inside a role as a canary test for whether or not the role was run.

* Use a fail task rather than trigger a failure via bogus command

This should resolve the "unstable" test results.

* Import tag tests

Fix bug it tests where validate tasks weren't run on tag tests.
Add tests for task import/include with tags.

* Remove test for playbook group_var inheritance

(cherry picked from commit 10a8c6bc25)
8 years ago
Matt Martz bd4b92c0b6 Ensure that the become password is written on py3 in the ssh connection plugin. Fixes #34727
(cherry picked from commit 29c1d5cb5d)
8 years ago
Toshio Kuratomi 649ffc10a2 Revert "Ensure that the become password is written on py3 in the ssh connection plugin. Fixes #34727"
This reverts commit fb9e7a85b3.

We may not have a 2.4.3rc3 so reverting this for now
8 years ago
Matt Martz fb9e7a85b3 Ensure that the become password is written on py3 in the ssh connection plugin. Fixes #34727
(cherry picked from commit 29c1d5cb5d)
8 years ago
James Cammarata f1c458303a Backport of b107e397 (Cache tasks as they are queued)
* Cache tasks as they are queued instead of en masse

This also moves the task caching from the PlayIterator to the
StrategyBase class, where it makes more sense (and makes it easier
to not have to change the strategy class methods leading to an API
change).

Fixes #31673

* Cleaning up unit tests due to 502ca780

(cherry picked from commit b107e397cb)
8 years ago
Matt Davis 79d1ba35ad
Cherrypick misc Azure test fixes (#34713)
* Fix test case failure for Azure ACS module (#33623)

* fix azure acs test failure

* change acs location

(cherry picked from commit 8e20ae2de4)

* fix azure test case failure for function apps module (#33658)

(cherry picked from commit f8d7e477f0)

* Fix storage endpoint for Azure Stack (#33946)

* Fix storage endpoint for Azure Stack

https://github.com/Azure/msrestazure-for-python/issues/64

* corrected visual indentation

(cherry picked from commit 6643fe821e)

* Fix incorrect formatting call in azure module (#33561)

Fix corrects formatting call in azure_rm_resourcegroup_facts module.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 6654d69569)
8 years ago
Matt Davis 6f679b45de cherry-pick #34442 8 years ago
Matt Clay 02b1d90cf3 Make xattr test conditional on feature support.
(cherry picked from commit 77726b471f)
8 years ago
Jordan Borean 9a5bca5668 fix windows tests after recent patch (#34548)
(cherry picked from commit 460deb08cb)
8 years ago
James Cammarata 0b7d78d67f
Don't use getattr in _get_parent_attribute to avoid recursion issues (#33595) (#34532)
* Don't use getattr in _get_parent_attribute to avoid recursion issues

Fixes #23609

* Move extend/prepend to field attribute

Also removes _get_attr* methods that were basically just calling
_get_parent_attribute because it needed to set those params.

Also modifies _get_parent_attribute() to pull those values from the
FieldAttributes instead of using the ones passed into the function.

* Better fixes for _get_parent_attribute
8 years ago
Toshio Kuratomi 1546ddb3c3 Fix up the test-set_mode_if_different unittests 8 years ago
Jordan Borean cb92c4bea1 win_package: remove case sensitive check for msi extension (#34476)
(cherry picked from commit da69f5aeae)
8 years ago
Matt Davis 3a853fc9b8 fix win_firewall test failure on 2008/2008r2 (#34391)
* ensure that "starting" profile is known instead of relying on default
8 years ago
Matt Davis cbc07cf9cc backport win_firewall_rule updates
from devel  SHA 89d9444ad5
8 years ago
Trishna Guha 284625f18c
NXOS Commit Integration tests to Ansible (part 2) (#28939) (#33964)
* add nxos_aaa_server IT

* add nxos_aaa_server_host ITs

* Add nxos_gir IT

* Add nxos_gir_profile_management IT

* add newly added tests to nxos.yaml

* fix nxos.yaml indentation

* fix indentation again

* skip nxos_git_profile_management IT for titanium

* change idempotency to non-idempotency check

(cherry picked from commit a130549ead)
8 years ago
Maxime de Roucy 86fbaffc07 fix file attributes changed detection
https://docs.python.org/2/library/stdtypes.html#str.split
str.split([sep[, maxsplit]])
If sep is given, consecutive delimiters are not grouped together and are deemed
to delimit empty strings.

>>> "85563      ----------------C-- /var/lib/libvirt/images".split(' ')[0:2]
['85563', '']
>>> "85563      ----------------C-- /var/lib/libvirt/images".split()[0:2]
['85563', '----------------C--']

(cherry picked from commit c2ac9d0831)
8 years ago
Jordan Borean 5dd40349b2 win_iis_webapppool: stop any passwords from being returned (#33931)
(cherry picked from commit 0ca828ebab)
8 years ago
Ganesh Nalawade 2a007e2b4d
Fix ios_interface integration test failure (#33901) 8 years ago
Ganesh Nalawade 13937ce772
ios_config save (#33791) (#33872)
* Fixing save so it still works. Adding changed as an option for save_when.

* Updating unit tests.

* Updating description to state that changed was added in 2.5.

(cherry picked from commit 3a9083cf48)

* Update Changelog
8 years ago
Matt Martz 926dfb7c04 Add test for clean_copy preservation of keys
(cherry picked from commit 5c63bb0090)
8 years ago
Toshio Kuratomi 109471cb7f Remove files from legacy that pass now that W503 is ignored 8 years ago
John R Barker c7a903c34b Ignore W503 in stable-2.4 (#33716)
* Ignore W503

To avoid backporting from devel (2.5) to 2.4 any code that may fail pep8
backport the current-ignore change.
8 years ago
s-hertel 6a6ae0cede loop doesn't exist in 2.4 8 years ago
Sloane Hertel f2bf74991e Fix using loops with environment and add tests (#32796)
(cherry picked from commit 7bb35e8781)
8 years ago
Trishna Guha 790e290b6b loopback doesn't support passive_interface (#33252)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 25a465ffcb)
8 years ago
Martin Krizek ada8453271 Fix include in loop when stategy=free (#33094)
(cherry picked from commit 3a2a1e054f)
8 years ago
Matt Clay 60bf72d69e Limit pytest < 3.3.0 for python 2.6.
(cherry picked from commit 58286ef93b)
8 years ago
Matt Clay 2b9dd23377 Limit paramiko to < 2.4.0 for python 2.6.
(cherry picked from commit 5f5e150771)
8 years ago
Matt Clay c422d7a8c6 Update FreeBSD completion for ansible-test.
(cherry picked from commit 73132d3906)
8 years ago
Martin Krizek 5340da2a7d selinux: check if policy exists before switching (#31834)
* selinux: check if policy exists before switching

* Check the policy dir

(cherry picked from commit 0592fd47bc)
8 years ago
R. Francis Smith f0741ecaa0 updated pamd rule args regexp to match file paths also (#33432)
* Added . and / to rule args regexp

Things like pam_echo.so file=/etc/foo.txt weren't being matched and
causing incorrect change counts.  Adding / and . fixed that.

Fixes #33351

(cherry picked from commit e957760d52)
8 years ago
Mike Wiebe 9845e5a018 Use show command to support wider platform set for nxos_interface module (#33037)
* Use show command to support wider platform set

* Fix unit tests

(cherry picked from commit 95a2140f4b)
8 years ago
Matt Clay 5fa8480a61 Use an abspath for network inventory ssh key path.
(cherry picked from commit 1ee511f82c)
8 years ago
Matt Clay 51d21b0f41 Update vyos completion in network.txt.
(cherry picked from commit 3a6fad38fa)
8 years ago