Commit Graph

79 Commits (8be0be1564940fca4b392a62363e0f04a2b4a24e)

Author SHA1 Message Date
Major Hayden 97d6807ec5 File module cannot create relative paths
When trying to create a directory relative to the current working
directory, a directory is created at the root of the filesystem
instead.  This patch ensures that directories specified with relative
paths will be created in the current working directory.  Fully
qualified paths aren't affected

Signed-off-by: Major Hayden <major@mhtx.net>
10 years ago
Michael DeHaan d78e16ff36 Move doc fragments back into file module. 10 years ago
RomanDolejsi 7cd6d6fb89 file: prevent replace failure when overwriting empty directory with hard/link (force=yes) 10 years ago
trbs 6567e40b6d In check mode if a symlink does not exist there is no need to check the ownership properties (which causes an exception) 11 years ago
James Cammarata c276dec487 Fix issue with symlink path detection
Fixes #7627
Fixes #7664
11 years ago
James Cammarata 090fd0a224 Fix linking issue to directories in file module
The os.path.isdir() returns True for symlinks that point to directories,
so we also need to check to make sure it's not a symlink too.

Fixes #7657
11 years ago
Brian Coca ffb87adbc2 Correctly examine path for relative links in file module
Fixes #7515
Fixes #7537
11 years ago
James Cammarata 5ec0297c04 Fixing absolute path calculation for file module when linking
Fixes #7403
11 years ago
telsacolton ee60f8f710 Make file hardlink error message reasonble
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
11 years ago
telsacolton 133cbee473 Give reasonable error when symlink fails
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
11 years ago
James Cammarata 8c7aafd5ae Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms 11 years ago
James Cammarata 5ce5ba5e58 Refuse to convert a non-empty directory into a link with the file module
Also adds an integration test for the above.

Fixes #7254
11 years ago
Brian Coca 1e3860c47b now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Erika Heidi 40e7c6eddc Possible docs error: 'path' instead of 'src'
I came to this example today (line 50), and when I tried it, I got an error:

`msg: src and dest are required for creating links`

So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
11 years ago
James Tanner 199992adb6 Fixes #6894 create docs fragment for files 11 years ago
Michael DeHaan 63a1330263 Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
Application to other cloud providers would make very good sense.
11 years ago
James Tanner 7b72004eb4 Merge #5903 from rhaido/ansible
Update files documentation for usage of force=True and hardlinks
11 years ago
Michael DeHaan 38c3332b8a Merge pull request #6597 from tarka/handle-uncreated-symlink-tmpfile
Handle missing symlink tempfile
11 years ago
Steve Smith 5b5af14921 Only unlink the symlink tempfile on error if it was created in the
previous operation.
11 years ago
Brian Coca a395eb3aba fixed issue with tmp file (path can include filename) and added missing
else which made it try to link x2
11 years ago
Brian Coca 4fd957620a now correctly checks absolute path for src= existance for links
also updated docs to be a bit clearer on symlink behaviour
11 years ago
Brian Coca 402cd11c52 fixed issue with directory permissions on copy #6552 11 years ago
James Cammarata d60ac967b9 Merge branch 'file_fixes_clean' of https://github.com/bcoca/ansible into bcoca-file_fixes_clean 11 years ago
Cristian Ciupitu 7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Brian Coca 7ca6343ca3 Fixes and cleanup to file functions and module
- unified set attribute functions ... not sure why 2 identical functions
exist with diff names, now there are 3 while i repoint all modules to 1
- fixed issue with symlinks being created w/o existing src when force=no
- refactored conditionals, simplified where possible
- added tests for symlink to nonexistant source, with both force options
- made symlink on existing attomic (force)
11 years ago
Sven Schliesing b55f99b803 Fix link in documentation
c(dest) -> c(path)
11 years ago
Michael DeHaan 2f12c6ddf6 Simplify file module parameter description. 11 years ago
Mike Grozak 3f74dd6592 Updated the force parameter description; added one example how to create the symlinks pointing to non-absolute paths 11 years ago
Mike Grozak ecd8b5d064 Found a way how to have symlinks towards files without absolute paths in prefixes; fixed incorrect force setting on the hard links, which can not point to non-existing files 11 years ago
Mike Grozak 4f262779cd Started the development of the 'chdir' functionality for file module - creation symlinks without the base directory prefix 11 years ago
jctanner 95131937df Merge pull request #5282 from rhaido/hard_link_fix
file module: Added to the file module the functionality to force conversion hard link...
11 years ago
jctanner 87b58666f9 Merge pull request #5264 from drewlll2ll/file-fix
file module: Fixed missing prev_state == 'directory' in file
11 years ago
Maykel Moya 8f766bdcdd Missing "is" in file module description 11 years ago
Jens Rantil 38d0df65d8 module(file): Fail instead of exit on exception 11 years ago
Jens Rantil 4262e76aec module(file): state what went wrong on exception 11 years ago
Mike Grozak 5a66a95bf3 Added to the file module the functionality to force conversion hard link and symlink when the force attribute is set to 'yes' 11 years ago
drewlll2ll 8fe3b05262 Added prev_state for directory 11 years ago
Jens Rantil b8347a3144 `file` module: Don't catch `SystemExit`
This fixes issue #5159.
11 years ago
James Tanner 4f9aadcc07 Addresses #5023 Fix import comments 11 years ago
James Tanner 38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago
Michael DeHaan 08996d78d6 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
11 years ago
James Tanner 0f3093516d Merge pull request #4375 from pfalcon/ansible
copy: Implement recursive copying if src is a directory.
11 years ago
James Tanner 53ba890312 Fixes #4884 Do not prematurely exit from file module if src not defined 11 years ago
James Tanner 2c57b999fc Addresses #4801 Update file module docs to indicate behavior for relative src paths 11 years ago
sspans 9f322a5178 skip absolute path creation for old_src, not needed with the new relative links 11 years ago
sspans 4957115e51 only require absolute paths for hardlinks 11 years ago
James Tanner c3159fefab Fixes #4516 file module: check prev_state earlier and use that if state is not specified 11 years ago
Michael DeHaan 772bd33a0f Revert "fix conversion from file to hardlink when force=yes"
This reverts commit 4d4518ed52.
11 years ago
Dave Simons 1f86abcba6 fix conversion from file to hardlink when force=yes
Signed-off-by: Dave Simons <dave@inuits.eu>
11 years ago
jctanner 9543169cca Merge pull request #4480 from joemaller/absent_path_fix
ignore src when file module state=absent
11 years ago