Commit Graph

4683 Commits (8ba03a7f054823500481b958c171fa0bed321eb9)
 

Author SHA1 Message Date
Dustin C. Hatch fbcf39e1e1 Correct regex in is_keyid
The `rpm_key` module claims to take a key ID as an argument, however it fails if one is actually given:

    msg: Not a valid key DEADBEEF

The reason for this is the regular expression in the `RpmKey.is_keyid` method is incorrect; it will only match the literal string "0-9a-f" exactly 8 times, rather than exactly 8 characters in the set 0-9 or a-f.
11 years ago
Jonathan Mainguy 2b84ec6b4a Errors out with stderr 1049, unknown database: when importing a database that does not exist 11 years ago
James Cammarata a8368e4dc4 Merge pull request #8092 from ghjm/mysql-exceptions
Added exception handling to database creation and deletion. Fixes #8075.
11 years ago
James Cammarata 7b58e97881 Merge pull request #8093 from ghjm/mysql-dbname
Switched primary and alias names of the name/db parameter. Fixes #8065.
11 years ago
Michael DeHaan 1194a4ee11 Documentation simplification for git module parameter 11 years ago
Graham Mainwaring 2bb80002df Fixed tracebacks when datacenter not found, when notes not given, and when collecting facts after VM creation. Fixes #8067. 11 years ago
Graham Mainwaring 8e6e9a12e7 Switched primary and alias names of the name/db parameter, to match documentation. Fixes #8065. 11 years ago
Graham Mainwaring 6e237bed7a Added exception handling to database creation and deletion. Fixes #8075. 11 years ago
James Cammarata 3d2b201cf9 Merge pull request #8080 from ciupicri/service
Remove unused code
11 years ago
James Cammarata 165acc4897 Merge pull request #8086 from dataxu/dev-fix-typo
Bug Fix - fixed the choices typo got the ec2_asg module
11 years ago
James Cammarata 66b0621e2d Add note about changing resource_tags to required in ec2_vpc 11 years ago
James Cammarata fce2c33c7a Merge branch 'psa-resource-tag-required' into devel 11 years ago
Matt Ferrante ffdd69f2fa fixed the choices typo got the ec2_asg module 11 years ago
James Cammarata d15ca75dd2 Adding version_added for new vm_hw_version field in vpshere_guest 11 years ago
James Cammarata a398b422df Merge branch 'fix-7206' of https://github.com/hiciu/ansible into hiciu-fix-7206 11 years ago
Trond Hindenes ba507553b0 Better result handling 11 years ago
James Cammarata 1fcce0bb7f Merge pull request #8079 from Jmainguy/mysql_db_8070
Makes ansible fail if login_port is defined and login_host is either not...
11 years ago
Cristian Ciupitu 72d6e6d805 Remove useless code 11 years ago
Jonathan Mainguy f4690464b4 Makes ansible fail if login_port is defined and login_host is either not defined, or defined as localhost. This is because if login_host is localhost then MySQLdb will use the socket instead of TCP. This leads to confusion for ansible users as, when a port is defined it gets ignored if login_host is localhost. This is to fix the bug reported by wrosario #8070. Info on MysqlDb can be read here http://mysql-python.sourceforge.net/MySQLdb.html 11 years ago
James Cammarata 778503c859 Merge branch 'issue_7848' of https://github.com/mpeters/ansible into mpeters-issue_7848 11 years ago
James Cammarata 812098b07e Merge branch 'issue_7906' of https://github.com/mpeters/ansible into mpeters-issue_7906 11 years ago
James Cammarata 56b87e8bba Merge branch 'resource-tag-required' of https://github.com/psa/ansible into psa-resource-tag-required 11 years ago
James Cammarata 2e614c8a63 Merge branch 'bug/8057' of https://github.com/ericwb/ansible into ericwb-bug/8057 11 years ago
Trond Hindenes 8e16962596 improvements to win_feature 11 years ago
Andreas Fleig 3c4dbd61fc ini_file: replace lambda with named function
Fixes #6876
11 years ago
James Cammarata 7793bd9638 Merge pull request #8049 from ranjan/dev
Provision VM using virtual network.
11 years ago
Eric Brown 7bbe3dc30c Adds an option to specify the glance endpoint type
Some environments that utilize an SSL terminator with a self-signed
certificate can use the publicURL without getting certificate
verify errors.  This allows using the internalURL with in my case
is HTTP and not HTTPS.

Closes issue: #8057
11 years ago
Trond Hindenes 12df81409e Revert "improved msi"
This reverts commit 7eac2121a5.
11 years ago
Trond Hindenes 39c32125f7 improved msi 11 years ago
James Cammarata 0a33ac418a Merge pull request #8038 from caphrim007/correct-missing-msg-argument
Fix missing msg argument
11 years ago
James Cammarata 4ad4c8802a Merge pull request #8036 from sqs/remove-fragile-RDS-instance-type-validation
Remove validation of RDS DB instance type names because Amazon frequently adds new ones
11 years ago
James Cammarata 62456f5e27 Merge pull request #8022 from psa/vpc-gateway-peering
Fix for #7368 breaks peering connections. Unreak them.
11 years ago
Tim Rupp 821c133ff8 Fix missing msg argument
The following patch adds a missing 'msg=' syntax. An exception is raised
in ansible if this block is reached during the execution of the module

    TypeError: fail_json() takes exactly 1 argument (2 given)

With the 'msg=' added, you get a more informative error. For example

    msg: No settings provided to update_domain().
11 years ago
Michael DeHaan 504fc616d0 Merge pull request #8015 from cchurch/test_win_service
win_service module updates and tests
11 years ago
Quinn Slack 73c65e3db8 Remove validation of RDS DB instance type names because Amazon frequently adds new ones 11 years ago
Ranjan Kumar 8ef95374e7 Provision VM using virtual network. 11 years ago
Paul Armstrong 7b40939231 Fix for #7368 breaks peering connections. Unreak them. 11 years ago
James Cammarata 0a3e8c8e36 Merge pull request #7896 from botify-labs/feature/add-instance-monitoring-to-ec2-lc
Adds support for Cloudwatch detailled monitoring in ec2_lc module.
11 years ago
James Cammarata 2b1af586a2 Make sure subnets and route_tables are initialized before using
Fixes #7712
11 years ago
Chris Church 042d5b761d Return service name, display name, start mode and state from win_service module. 11 years ago
Paul Armstrong 714a9fda64 Make resource_tags required and do whitespace cleanup 11 years ago
Michael Leer 39b34b008c add interfact documentation #7704 11 years ago
Jacopo 91e246a776 Fixed bug with environment path for homebrew_cask 11 years ago
Brian Coca 030ac743a4 now compares permissions correctly 11 years ago
Markus Amalthea Magnuson a58709ac1d Use correct parameter name in error message.
The parameter is called `cron_file` but the error message uses `file` which is confusing.
11 years ago
Hector Acosta 35ca6d535b Check at most 16 characters of the key. Fixes #7936
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
11 years ago
Hector Acosta b5fe46d48c Correctly handle .repo files in zypper_repository module
Before the changes, removing a repository required a repo url. This shouldn't be required since zypper allows removing a repo based on its alias (mapped to name in this module).

The name variable was always required, which is misleading since repofiles provide their own alias. So a runtime check was added to avoid this confusion.

Additionaly, running this module on .repo files weren't idempotent. e.g

Before:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"msg": "Repository named 'devel_languages_python' already exists. Please use another alias.\n", "failed": true}

After:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": false}

Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
11 years ago
James Cammarata 8e6a60dfd6 Merge pull request #7942 from sidred10/devel
Fixed FreeBSD ports install issue
11 years ago
sid 2f02d27744 Fixed FreeBSD ports install issue 11 years ago
Maxim Odinintsev f4c183f5b8 Successfull exit if sync=yes and no package provided 11 years ago