Commit Graph

189 Commits (8a3f8b757be1434df61abc0c0e491920b467ca26)

Author SHA1 Message Date
James Cammarata ceddc37f07 Fix for the cron module on FreeBSD
Apparently crontab on freebsd does not like the file path coming before
the "-u username" portion of the command to install the crontab
11 years ago
Marcin Płonka 61298e4703 Skipping facts not available on AIX WPARs 11 years ago
Michael DeHaan 5e049a5df7 Merge branch 'fix_service_with_initscript' of git://github.com/psvo/ansible into devel 11 years ago
Andy Wilson bc30203abe docfix: grammar in docstring for sysctl module 11 years ago
Petr Svoboda e2f20db534 Fix traceback in service module when svc_cmd is None
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

Fixes issue #3533
11 years ago
Michael Scherer cfa5a0f94d Add urpmi as a package manager for mandriva-based distribution 11 years ago
James Cammarata e32a6110af Removing skipped=True so the task is just marked as not-changed 11 years ago
James Cammarata d98ad7b374 Set result to skipped when vol group is missing and lv state=absent
Fixes issue #3714 - lvol module state=absent fails (with error) if
the volume group doesn't exist
11 years ago
rishid 07ef8c4d84 Verify groups string is not empty before trying add user to groups 11 years ago
Brian Coca 0ae7bcf3e2 fixed bug from prev update
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 1e1f117886 whitespace updates on new lines
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca d8e8aa714e now uses get_bin_path for lvg executables
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 8cc13590b4 Make exceptions handling python 2.4 compatible. 11 years ago
Michael DeHaan fc9aa5f014 Continue on mount errors, don't fail the setup module. 11 years ago
Brian Coca 3f85a82ae9 use global to fail as its not in self
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 1acd9b6325 Update CHANGELOG 11 years ago
Michael DeHaan e589365279 Merge branch 'iss_cron' of git://github.com/dirtyharrycallahan/ansible into dh_cron 11 years ago
Michael DeHaan 588b20c012 Merge pull request #3602 from bcoca/fine_tune_stat_exception
narrowed down exception
11 years ago
Michael DeHaan 3b3b600a98 Merge pull request #3470 from langemeijer/devel
Only append non_unique parameter if a uid is provided as well to user module
11 years ago
Brian Coca b7b1c714f9 narrowed down exception we ignore and fail if any other unexpected one
crops up.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Florian Tham ceff31241b fix fatal error when removing logical volumes 11 years ago
Antti Rasinen 7b8f24adda Make zfs set_property accept values with embedded spaces
Converting the argument list to a string with ' '.join causes
the shell interpreter to misparse spaces in property values.
Since the zfs command does not need shell anywhere, using
a list instead of a string works just as well with run_command. 

Fixes #3545.
11 years ago
Antti Rasinen 7670572578 Fix zfs property parsing
Current property parser breaks when values contain spaces. Since
zfs get -H returns tab separated lines,  it is better to explicitly
split on tabs than on whitespace.
11 years ago
trbs 38b6087495 fix missing json module for issue #3363 print JSON error as string instead 11 years ago
Brian Coca 80b9b01e97 now won't throw exception if we don't have permission to stat a mtab
entry on linux (weird chromebook issue)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 8fe15f0a30 Merge pull request #3426 from trbs/services_sleep_option
sleep option for service module which adds a pauze between stopping and ...
11 years ago
Michael DeHaan 3a84254f6d Merge pull request #3496 from johanwiren/bsd-ipv6-facts
Fix for populating default_ipv6 on BSD systems
11 years ago
Michael DeHaan d1398594ce Merge pull request #3497 from johanwiren/bsd-gateway
Updated setup module to collect gateway fact for BSD systems
11 years ago
Michael DeHaan 952760c605 Merge pull request #3388 from bcoca/fixed_user_create_doc
updated module docs to reflect 'correct' on_create vs on_creation
11 years ago
Johan Wirén 1c247c9eb4 Updated GenericBsdIfconfigNetwork to collect gateway 12 years ago
Johan Wirén 10e9194744 Fix for populating default_ipv6 on BSD systems 12 years ago
Joshua Lund cc275ca2be Added a new with_file example to the authorized_key documentation 12 years ago
Patrick Callahan 8f14ffe56b Bug fixes and enhancements.
Bugs:
(1) no longer allow empty jobs
(2) strip the header added by crontab package used in openSuSE and SuSE
(3) try not to leak temp files when things go wrong
(4) issue returning job names under certain conditions

Enhancements:
(1) Allow all special times not just reboot.
(2) Fail earlier by performing more input validation
(3) Add feature to allow removing cron file under /etc/cron.d

ToDo:
(1) Validate times (minute, hour, ...)
(2) Strip white space from fields such as name and job such that name=foo equals name=' foo'.
(3) More testing
12 years ago
Brian Coca 0664e36aa2 fixed check mode
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Casper Langemeijer 922a71fced Only append non_unique parameter if a uid is provided as well 12 years ago
Aaron Brady efc4bc10d4 Make the CPU facts Hyperthreading aware 12 years ago
trbs 3b2173b6df sleep option for service module which adds a pauze between stopping and starting a service using state=restarted. This helps for bad scripts that exist immediatly after signaling a process to stop. 12 years ago
Antti Rasinen 93fc3391fe Fix service enable on FreeBSD
Some services have a knob (i.e. rc.conf setting) whose name
differs from that of the script. For example, lockd process
is controlled with a script called lockd, but the rc.conf
value is rpc_lockd_enable.

Fixes issue #3382.
12 years ago
Brian Coca 9f75397310 updated module docs to reflect 'correct' on_create vs on_creation
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan 15bf8a8398 Merge pull request #3315 from madduck/fix-service-updatercd-changed
Let update-rc.d set changed flag properly
12 years ago
Michael DeHaan 681696846a Styling: semicolon 12 years ago
Michael DeHaan fc8ffc1864 Styling: blank lines 12 years ago
Serge van Ginderachter f000dcd526 add more support for different size formats 12 years ago
martin f. krafft 85b8538e0e Expand usage of Python 2.6 if statement
Syntax like "'foo' if bar else 'baz'" is not supported by all Python
versions targetted by Ansible. Hence we break it up.

Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
martin f. krafft 3df2e15277 Let update-rc.d set changed flag properly
When update-rc.d is used to enable/disable service, the changed flag was
always true (see #2189). This commit fixes that.

Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
Michael DeHaan 3f8aa8aec5 Fix up some module docs formatting errors. 12 years ago
Patrick Callahan b5b862fe6f bug fix: modify get_device_facts to handle servers with multiple pci domains
On machines with multiple pci domains get_device_facts would fail to
find a matching pci device causing setup to fail. Also on some platforms
there is additional information between the pci information and 'host'.
Modified get_device_facts to call lspci with the -D option and modified
the regex to account for the pci domain and to be more selective.
12 years ago
Michael DeHaan 575e052c6c Merge pull request #3147 from toshywoshy/setup_mtab_without_bind
changed get_mount_facts to ignore mount types 'none'
12 years ago
Michael DeHaan 61ac8d03af Clarify module docs 12 years ago
Michael DeHaan 51ba3d8c3d Merge pull request #3230 from sayap/openrc
Add OpenRC support to the service module.
12 years ago
Brian Coca c9c7b01620 now mount/unmount are searched for instead of hardcoded
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Yap Sok Ann bcca609bc6 Add OpenRC support to the service module. 12 years ago
Michael DeHaan fe9849530c Merge pull request #3120 from chrisgardner/solaris-os-facts
Add Solaris O/S distribution facts
12 years ago
Michael DeHaan 2eb3a9a3c9 Resolve docs conflict. 12 years ago
Michael DeHaan 572f49b11f Fix merge conflict. 12 years ago
Michael DeHaan c3544de1df Merge pull request #3228 from skvidal/facts.d
first cut and docs for facts.d mechanism for setup module
12 years ago
Michael DeHaan 936e61fc28 Merge pull request #3181 from melodous/devel
HP-UX virtualization facts
12 years ago
trbs a4223e119d fixed x-bits in git 12 years ago
Michael DeHaan 78fdedd490 Merge remote branch 'origin' into devel
Conflicts:
	library/web_infrastructure/django_manage
12 years ago
Michael DeHaan f0d66f0cda Merge pull request #3176 from jpmens/sol-epoch
setup epoch time doesn't have tics on Python 2.6.4 (Solaris).
12 years ago
Seth Vidal 36df7e8c95 cut and docs for facts.d mechanism for setup module 12 years ago
Jan-Piet Mens 5c69918d53 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
12 years ago
Raul Melo f9f0f5ce2c HP-UX virtualization facts 12 years ago
Jan-Piet Mens f6521d88f5 setup epoch time doesn't have tics on Python 2.6.4 (Solaris). 12 years ago
Jan-Piet Mens 3f301fd439 Protect None value in setup module 12 years ago
Michael DeHaan 790a145f6c Use get_bin_path for blkid and add some aliases to the filesystem module. 12 years ago
Joshua Lund 51c7441244 Updates to the authorized_key documentation
* Clarified the meaning of 'user'
* Changed 'sshdir' to 'path' in the example
  * 'sshdir' is used internally in the module, but the argument is 'path'
* Made the capitalization consistent in the descriptions
12 years ago
Toshaan Bharvani f76043f404 changed get_mount_facts to ignore mount types 'none' 12 years ago
Raul Melo 2475bc416c Facts for HP-UX 12 years ago
Chris Gardner 2ba47318dc Use first line from /etc/release in "distribution_release" for consistency across Solaris and derivatives. 12 years ago
Michael DeHaan 788680a15d Merge branch 'devel' of git://github.com/trbs/ansible into more_users 12 years ago
Michael DeHaan c3ff4ccb35 These options to bypass the check code seem to need to occur before said checks. 12 years ago
Chris Gardner f0a4a17ff6 Add Solaris O/S facts "distribution" and "distribution_*" 12 years ago
Michael DeHaan caa07e7fab pep8 fixes 12 years ago
Michael DeHaan 15560c9801 Fix module labelled incorrectly. 12 years ago
Michael DeHaan d434252ba4 Docs standardization 12 years ago
Michael DeHaan 417be6f81e Docs standardization 12 years ago
Michael DeHaan b9e72cdd98 Warn when there is a space in the mount module opts parameter. 12 years ago
trbs 3b3afe2283 Add support for Open and NetBSD platforms for user and group modules, including a new login_class parameter for FreeBSD, OpenBSD and NetBSD. 12 years ago
Michael DeHaan 9122efb24a Merge pull request #3083 from mvo5/feature/facts-add-statvfs
add "size_{total,free}" to the "mount" facts
12 years ago
Michael DeHaan 049b77be6d Merge pull request #3076 from mmoya/userspace-arch-facts
Provide userspace_{architecture,bits} facts
12 years ago
Michael DeHaan 514f18acac Merge branch 'solaris-network-facts' of git://github.com/chrisgardner/ansible into devel 12 years ago
Michael DeHaan 47b9db0d98 Remove debug statement in previous patch. 12 years ago
Michael DeHaan eec53347b5 Merge branch 'devel' of git://github.com/trbs/ansible into groups 12 years ago
Stephen Fromm 43d96ba335 cleanup to dmi fact discovery
When invoking dmidecode, first use module.get_bin_path() and secondly
use module.run_command.
Remove sub function execute() from get_dmi_facts().
Simplify get_dmi_facts() by only using two mechanisms to determine dmi
facts:  first try /sys/devices/virtual/dmi and if not available, use
dmidecode executable.
12 years ago
Michael DeHaan d078ad5a13 Merge pull request #3068 from lorin/authkey-default
authorized_key: Set manage_dir default value
12 years ago
Michael DeHaan 4afc0a5c03 Merge pull request #3044 from chrisgardner/solaris_facts
Solaris facts
12 years ago
Michael DeHaan 69d514100c Refine error message. 12 years ago
Michael DeHaan 0b30c74e86 Merge branch 'rc.d-systemd' of git://github.com/glensc/ansible into sysd 12 years ago
Michael Vogt 6acf9a9b3b use statvfs.f_bavail to match the output of "df -B1" 12 years ago
Michael Vogt 73a12b04a4 add "size_{total,free}" to the "mount" facts 12 years ago
Maykel Moya d0843a7f55 Provide userspace_{architecture,bits} facts
When running inside a chroot userspace architecture might not
match that of the actual host.

This patch provides userspace_bits as reported by python's
platform.architecture(). Also provides userspace_architecture fact
if host is an x86 machine.
12 years ago
Chris Gardner 1b8adab2cc Add Solaris network facts. IPv4 and IPv6 both working. 12 years ago
trbs b537aff586 Fix for #3062 additional groups should only be added once.
Also consolidated duplicate groups code into one get_groups_set() method.
Removed unused call to user_group_membership.
Removed sorting operations on set functions cause sets are inherently unordered.
Minor style improvements to match the rest of the code.

The new function will make the order of group names passed to the system command less determistic.
Which was already the case for modify_user_usermod() but not for other methods.
It will also strip out duplicate group names automatically which was not always the case previously.
12 years ago
Lorin Hochstein 8c9cceacbf authorized_key: Set manage_dir default value
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
12 years ago
Michael DeHaan ad1a02aa55 Merge pull request #3064 from sfromm/issue2990
Verify /proc/modules is readable (issue #2990)
12 years ago
Stephen Fromm 00b3a450c7 Verify /proc/modules is readable (issue #2990) 12 years ago
Stephen Fromm 3127bab6d6 Use get_bin_path to find mkfs command (issue #2983) 12 years ago
Chris Gardner 2b71ab6765 Fix typo. Solaris 9 should now correctly ignore 'brand' and use 'implementation'. 12 years ago
Chris Gardner 88115f4ab2 TODO: Separate IPv4 and IPv6 12 years ago