Commit Graph

21846 Commits (88764165ad2bf56af5e23890af87100af85d37ff)

Author SHA1 Message Date
Matt Martz 9a18385fab
Validate that rescue and always have an accompanying block. Fixes #26751 (#41822) 6 years ago
Matt Martz e9a5c53512
Handle typing of vars_files in Play.get_vars_files. Fixes #14708 (#41801) 6 years ago
Nathaniel Case dd932c9ace
Make validate_certs togglable for httpapi (#41538)
* Make validate_certs togglable for httpapi

* Add `version_added`
6 years ago
permitanyany 46dbb3e1e8 Show BGP Status In JSON (#41844) 6 years ago
Nathaniel Case 9aa8c652ba
Netconf bytes fixes (#41607)
* Solve some bytes issues on iosxr

* Solve some bytes issues in junos

* Do the correct thing with tostring based on lxml or not
6 years ago
Simon Dodsley c144adc9de Fix API call to get ActiveCluster information and add (#41744)
connected arrays and volume group counts to default
6 years ago
Sijis Aviles ba3db90e3a Fix: wildcard excludes in unarchive with tar archives (#40935)
* fix: exclude using wildcards for tar archives

Fixes #37842, #22947

* fix: Remove quote() as it munges the exclude format

* test: Refactor to use single archive structure

A common structure archived by different methods should simplify some of
the feature tests.

* test: Use common archive layout to validate exclude feature

* test: Use the same exclude checks for zip/tar archives
6 years ago
Adam Miller c65b7eb52e validate vars_files entries are string_type or list (#40985)
* validate vars_files entries are string_type or list

Fixes #17594

Signed-off-by: Adam Miller <admiller@redhat.com>

* use collections.Sequence to simplify if check

Signed-off-by: Adam Miller <admiller@redhat.com>
6 years ago
Fred-sun 0d4e113975 Update azure_rm_publicipaddress_facts.py example (#41833)
Example describe error
6 years ago
Kevin Breit 4d5d0b63f3 Remove extarneous json.loads() which was moved to the utility. (#41731) 6 years ago
Brian Coca 0102e42272
exclude lookup_terms from config errors (#41740)
* exclude lookup_terms from config errors
* moved direct
6 years ago
Olivier Bourdon 06b73ff8f1 Add random_mac string filter (#39775)
Add new filter to generate random MAC addresses from
string prefix. See docs/docsite/rst/user_guide/playbooks_filters.rst
for more detailed infos.
6 years ago
Brian Coca 2affb5f729 doc fix 6 years ago
Brian Coca 27c43daab8
fix minor issues with debug and item labels (#41331)
* fix minor issues with debug and item labels

 - no more `item=None`, we always have a label now
 - debug should only show expected information, either msg= or the var in var=
 - also fixed method name, deprecated misleading _get_item
6 years ago
Alex Stephen 929ac6155c [gcp] Fix service account email parameter on gcp_compute_instance (#41806) 6 years ago
James Mighion 8f4daf84c8 Revert "Fixes #35622 (#41522)" (#41805)
This reverts commit 8357ae69e7.
6 years ago
Ryan Brown c7a5e9d4eb Remove unused imports from aws_direct_connect_connection module (#41802)
* Remove unused imports from aws_direct_connect_connection module

* Fix tuple notation
6 years ago
HD650 07738cc848 Improve code style 6 years ago
HD650 8b9f707c21 More explanation in docstring 6 years ago
HD650 0586cb1536 Check type of fail_msg and success_msg 6 years ago
zhikangzhang 24189e7639 Point out that fail_msg is new in 2.7 6 years ago
zhikangzhang 2333b4474c Rename argument msg to fail msg
This change make the arguments of assert less ambiguous.
6 years ago
Abhijeet Kasurde 065d9ed6ac FreeIPA: Add support for TTL in dnsrecord (#41768)
Fixes: #33969

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Ryan Brown 5abb63ea56 Remove unused imports from aws_config_aggregator (#41803) 6 years ago
Ondra Machacek 8f144976df ovirt_auth: In case of token is passed u/p is not requierd (#41788) 6 years ago
Sloane Hertel ba7d3dab5c Document compose for aws_ec2 inventory plugin (#40621)
* Document compose for aws_ec2 inventory plugin

* split up examples into several parts with some additional comments
6 years ago
Dag Wieers da49aaf1d9 Add trailing dot and make it a separate item 6 years ago
Camillevau 79982473ca Update docker_container.py
<!--- Your description here -->

 label: docsite_pr
6 years ago
cpollard0 f93a171bb6 [aws][docs] Update max session duration in sts_assume_role documentation(#41765)
Update to reflect assume role updated durations as of March 2018. 
https://aws.amazon.com/blogs/security/enable-federated-api-access-to-your-aws-resources-for-up-to-12-hours-using-iam-roles/

+label: docsite_pr
6 years ago
Mark Phillips 355b56ef00 [docs] Change 'tag' to 'tags' in aws_ec2 inventory examples (#41438) 6 years ago
Martin Krizek 2f60baa5e0 file: clarify attributes usage in docs (#41780) 6 years ago
Paul b21673b321 Update zabbix_screen.py limit screen columns (#41487)
* Update zabbix_screen.py limit screen columns

Add option graphs_in_row that allows to limit the count of columns on zabbix screen. When graphs_in_row columns is filled, begins to draw next row. If there is many hosts with many graphs each, draws all graphs for one host in an column each below each other

* fix remove whitespaces before and after brackets

Fixing ansible-test sanity --test pep8 errors
moved

* fix documentation parsing error

Fixing error: missing documentation (or could not parse documentation): expected string or buffer
6 years ago
Loïc b61b113fb9 new provider: ownca (#35840) 6 years ago
Sloane Hertel c4a6bce69f ecs_service: make assign_public_ip option a boolean (#41759) 6 years ago
Toshio Kuratomi 3ea936312a Remove an unnecessary import from the ansiballz wrapper (#41747) 6 years ago
Jordan Borean 11bd3fd318 win_updates fix when win_updates is run with async (#41756) 6 years ago
Toshio Kuratomi 8bd245a6a2 Fix file state=touch not returning diff information
Fixes #41755
6 years ago
Tim Rupp 58d857f235
Marks select modules as stableinterface (#41741)
this is being required by customers so that they may adopt ansible
and F5's work in ansible.
6 years ago
Adam Miller 80940a6b1c ensure copy action plugin returns an invocation in result (#41426)
* ensure copy action plugin returns an invocation in result

Fixes #18232

Previously the action plugin for copy, which runs operations on the
control host to orchestrate executing both local actions on the
control host and remote actions on the remote host, is not returning
invocation dict in the result dict, this happens here where the
return from _copy_file() is None

When force is True, the _execute_module() method is called, which
returns the dict containing the invocation key. This patch ensures
there is always an invocation key.

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix conditional, handle content no_log

Signed-off-by: Adam Miller <admiller@redhat.com>
6 years ago
Evgeni Golov e601caf873 lineinfile: add regex as an alias for regexp (#20454)
the param is called regexp, but a lot of people spell it regex
add an alias to help them
6 years ago
Sumit Jaiswal c989b62eef
To fix eos_vrf failure when transport method is eapi (#41470)
* resolve bug 40930

* resolve bug 40930

* to fix review comments

* to fix review comments

* reverting the changes based on review
6 years ago
Brian Coca 05a49d6eb6
handle groups correctly when they are 'null' (#41698)
* handle groups correctly when they are 'null'

 - even if defined as mapping but having no keys, objects shoudl still be processed correctly
 - also add ansilbe_verbosity to vars not to display in ansible-inventory

fixes #41692
6 years ago
Deepak Agrawal e91cee1a31
net_put module: add default mode to copy binary files (#41476)
* add default mode to copy binary files

* sanity fix

* add version for new options
6 years ago
Martin Krizek 2e68811c34 apt: fix apt-mark on debian6 (#41530) 6 years ago
Kevin Breit 543a7469b7 New module - meraki_switchport (#41634)
* Initial commit for meraki_switchport module
- Query or modify swichport configurations
- Further optimizations are available
- Integration tests will require manual editing of file for others

* Remove blank lines
6 years ago
Kevin Breit b8c39a0875 New module - meraki_config_template (#41633)
* Implement configuration template management
- Queries or removes templates
- Can bind or unbind templates to networks
- Module is idempotent only for binding and unbinding
- Meraki does not allow template creation via API
- Integration test is tedious b/c previous bullet point
- Fixed bug in construct_path() so it won't set self.function

* PEP8 changes

* Re-enable some integration tests, use variables, and fix broken code
6 years ago
Kevin Breit 618c3c508f New module - meraki_vlan (#41632)
* Initial commit of meraki_vlan module
- Create, delete, modify, and query VLANs within a network
- Support for all allowed objects in the VLAN data structure
- Meraki defaults networks to have VLANs disabled and there is no
way to use the API to enable VLAN support. It must be enabled
manually.

* Fix formatting error in documentation

* Formatting changes and added documentation

* PEP8 fix
6 years ago
Kevin Breit 7c888b86ba New module - meraki_device (#41631)
* Initial commit for meraki_device module
- Allow claiming, removal, updating, and querying of devices
- Integration tests are included
- Integration tests are not complete because physical gear is required
- Integration tests also require Meraki subscriptions

* Added support for serial number query without network

* Added support for net_id and net_name

* Changes recommended by ansible-test for PEP8 and documentation

* Remove duplicate state in example

* Fix typo
6 years ago
Kevin Breit 564fe87b29 Improve support for org_id in module (#41519)
- Faster performance since it reduces number of API calls
- Also simplified some of the execution
6 years ago
Kevin Breit 62bad5d592 Remove notes since it's already specified in the doc fragment (#41614) 6 years ago
Kevin Breit cccaf951fa Improved support for parameter testing and checks for org_id (#41517) 6 years ago
Kevin Breit 4a0b8f5123 Added support for passing org_id instead of org_name (#41518)
- Faster execution if passed instead of org_name
- Updated documentation
- Added additional integration tests
6 years ago
Kevin Breit 5ee0c0af18 Meraki_snmp - Add examples for SNMP documentation (#41424)
* Add examples for SNMP documentation

* Removed whitespace for PEP8
6 years ago
Kevin Breit 7058f11e1d Removed redundant documentation (#41422)
- Removed response documentation on keys which are standard across
modules.
6 years ago
Kevin Breit 9c4e5a2b30 Add proper response documentation (#41370)
- Added response documentation for organizations
- Additional information is likely to be added later
6 years ago
Abhijeet Kasurde 671babd9aa openssl_csr: Update example (#41677)
Update example of Subject Alternative Name with dynamic list.

Fixes: #33676

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Abhijeet Kasurde b5c18ea2bd
VMware: Add timeout in wait_for_task (#39596)
* VMware: Add timeout in wait_for_task
* Added exponential backoff algorithm
* code review comments

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Ryan Brown 84612577ba [aws] Remove unused return in ec2_vpc_dhcp_option_facts module (#41709) 6 years ago
Ryan Brown 531cdddeed [aws] Remove unused return in ec2_vpc_igw_facts module (#41708) 6 years ago
Ryan Brown a01a17c772 [aws] Remove extra variable definition in ec2_vpc_nacl module (#41707) 6 years ago
Ryan Brown 22f1b71be0 [aws] Remove unused variable in ec2_asg module (#41706) 6 years ago
Brian Coca 89f169127b added missing raise 6 years ago
Abhijeet Kasurde 174d969714 Correct defaults in lxc and lxd connection plugin
remote_addr value defaults to inventory_hostname, current defaults
seems to be copy-paste error.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Ryan Brown 956fe7362d [aws] Fix unused return value in ec2_vpc_vgw_facts module (#41697) 6 years ago
Sloane Hertel 1268ce4d4f [ecs_service] fix assign_public_ip network configuration to module parameter rather than fixed string (#41689)
Fix parameter name

Use suboptions

document suboptions

Add a test to assert assign_public_ip is configurable
6 years ago
Abhijeet Kasurde 37293dec3d Raise Exception in virtualbox inventory plugin
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Ryan Brown 67d6e8177e [aws] remove unused variable in iam_user module (#41695) 6 years ago
Ryan Brown 1118e441e9 [aws] lambda_policy: Remove spurious definition of `policy` variable (#41693) 6 years ago
Ryan Brown fd8cc775a7 [aws] Simplify conditional in iam_cert module (#41691) 6 years ago
Lindsay Hill 0713925f3d Fixed SLX-OS docstring inconsistency (#41662) 6 years ago
David Moreau Simard 89a9fb79da Add RETURN docs for the pip module (#39907)
The pip module returns some things. Let's document them.
6 years ago
Ryan S. Brown 52acec3455 [aws] Remove double-defined variable from iam_policy module 6 years ago
Jacob 617093efa7 Add upgrade ('latest') support to pkgng module (#41623)
* Add upgrade ('latest') support to pkgng module

* fixup for bad yaml

* fixup for bcoca review:
- add `version_added:` to description
- change examples to use `name:` and remove comments
- DRY out install_packages()
- clean up state conditional check in modules.params

* fixup to remove extra whitespace

* fixup to handle custom pkgsite when checking for updates

* fixup to remove misleading `version_added:`
6 years ago
Ryan S. Brown a5ec29ed49 Fix exception message in AWS lambda module 6 years ago
Adam Miller 6a620a1ed9 add notes to service_facts about accessing fact data (#41608)
* add notes to service_facts about accessing fact data

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove unquoted :

Signed-off-by: Adam Miller <admiller@redhat.com>
6 years ago
Nilashish Chakraborty 837c216587
Fix vyos_vlan aggregate issue & added tests (#41638)
* Fix vyos_vlan aggregate issue & Added tests

* Fix #2 for vyos_vlan aggregate issue
6 years ago
Ryan Brown 7dcaef8115
Fix aws_config_aggregator argument count error (#41686) 6 years ago
Deepakkothandan 5a72eef0a3 [ecs_service] fix assign_public ip for network configuration (#41685)
* fix assign_public ip for ecs_service

* used module.botocore_at_least instead of distutils
6 years ago
Kristian Østergaard Martensen d8fc027db5 [docs] Include "_facts" in module examples section (#41680)
The example says module name: "cloudwatchlogs_log_group"
where it should say: "cloudwatchlogs_log_group_facts"

+label: docsite_pr
6 years ago
Tim Rupp 6c654b6947
Fixes the default assignment of values (#41672)
Fixes: #41640

The defaults should be inherited from the parent during initial
creation. This patch fixes that.
6 years ago
Jason Tedor f71ad4e315 Enable to use greedy checks for outdated casks (#40799)
* Enable to use greedy checks for outdated casks

When using brew cask outdated to check if an installed cask is outdated
or not, brew cask will skip casks that have auto_updates set to true or
version: latest. This means that Ansible tasks using the homebrew_cask
module to upgrade packages installed by brew cask will miss upgrading
such packages. However such packages can still be managed by brew cask
so we need to be able detect such packages. This can be done with the
--greedy flag passed to brew cask outdated as this will also include
such packages that are outdated. This commit adds a greedy parameter to
the homebrew_cask module to enable upgrading such packages using Ansible
tasks with the homebrew_cask module. The default behavior preserves the
same behavior as today. Example usage would be:

- homebrew_cask:
  name: 1password
  state: upgraded
  update_homebrew: yes
  greedy: yes

* Fix test issues

* Add extra comma to match style
6 years ago
Jonathan Davila a79b6ec8a2
Update my own author email in comments block
my ansible/redhat email is not valid, replacing it with something that is.
6 years ago
Andrew Gaffney 729e7471d6 Fix name of action plugin in error message (#41665) 6 years ago
Pilou 3e6c76fc2e Scaleway inventory plugin: small improvements (#41642)
* scaleway inventory: token is mandatory

* scaleway inventory: mention exception in error

* scaleway inventory: remove print statement

* scaleway inventory: options don't need to be attr

* scaleway inventory: remove unused attr
6 years ago
Matt Martz ee221859cd
Load role vars and defaults before parsing tasks (#40982)
* Load role vars and defaults before parsing tasks. Fixes #40163

* Add porting guide note

* Wording clarifications

* typo

* grammar fixes
6 years ago
James Cassell 23fbe0ce8e update play_context for reset_connection (#40866)
steps taken from lib/ansible/executor/task_executor.py

fixes: https://github.com/ansible/ansible/issues/27520
6 years ago
Justin 6bd7d71cc1 Fix vmware host config for all vmware OptionTypes (#41343)
* Fix vmware host config for all vmware OptionTypes

Setting some options and option types failed with invalid value errors being return from vmware, this resolves all known ways that issue can occur.

* Add logic for integer inputs as string

For example - "UserVars.ESXiShellInteractiveTimeOut": "20"

Fixes #40180
Fixes #41212
6 years ago
Markos Chandras 1737b7be3e facts: suse: Fix major version detection for SUSE (#41416)
When parsing the distribution files such as /etc/os-release, we extract
the full distribution version but not the major version. As such, the
ansible_distribution_major_version ends up being 'NA' whereas the
ansible_distribution_version contains the full version.

Before this patch we get this on openSUSE Leap 15

ansible -o localhost -m setup -a filter=ansible_distribution_major_version
localhost | SUCCESS => {"ansible_facts": {"ansible_distribution_major_version": "NA"}, "changed": false}

After this patch we get this

ansible -o localhost -m setup -a filter=ansible_distribution_major_version
localhost | SUCCESS => {"ansible_facts": {"ansible_distribution_major_version": "15"}, "changed": false}

This also fixes the Tumbleweed distribution test to report a proper
major version and also adds a test for openSUSE Leap 15.0 to avoid
potential future regressions.

Fixes: #41410
6 years ago
Jon Dufresne bf304832ff Prefer readthedocs.io instead of readthedocs.org for doc links (#41537)
Read the Docs moved hosting to readthedocs.io instead of
readthedocs.org. Fix all links in the project.

For additional details, see:

https://blog.readthedocs.com/securing-subdomains/

> Starting today, Read the Docs will start hosting projects from
> subdomains on the domain readthedocs.io, instead of on
> readthedocs.org. This change addresses some security concerns around
> site cookies while hosting user generated data on the same domain as
> our dashboard.
6 years ago
Sloane Hertel 8047d97ffc
read scaleway option after the options have been set (#41259) 6 years ago
Abhijeet Kasurde fb7fdc53ec
Fix typo in group_by module (#41627)
Fixes: #31600

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
saichint 119e6d680b fix nxos_linkagg issue (#41550)
* fix nxos_linkagg issue

* fix shippable
6 years ago
Kevin Breit 674dd3b10d Add docstrings to meraki module utility methods
PR #41369

Co-authored-by: Kevin Breit <kevin.breit@kevinbreit.net>
6 years ago
Tim Rupp 16466f3171
Fixes usage of popen in bigip iapplx package (#41612)
This functionality is superceeded by the run_command method in the
ansible module class.
6 years ago
Toshio Kuratomi 5c614a59a6 Temporarily revert c119d54
There were bugs in this that needed to be resolved.  No time to get the
fix reviewed sufficiently for 2.6.0.

We'll get this into 2.7.0 and try to get this into 2.6.1 as well.

Will need the work done in https://github.com/ansible/ansible/pull/36218
when it does get merged.
6 years ago
Sam Doran 6fa2d9ac6f Update user module docs (#41572)
* Clarify append and groups behavior
* Document return values
6 years ago
Sharp Hall 3935cce394 docker: Allow publishing of ports with the same number but different protocol (#38412)
* Don't deduplicate docker container ports with different protocols

* Test _parse_exposed_ports
6 years ago
Abhijeet Kasurde f21307da91 Add more info related to galaxy sub commands (#41085)
Fixes: #17469

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
schp 63f2ad8776 sort the port list properly (.sort() returns None) 6 years ago
Ivica Kolenkaš 0691c9c099 setting LANG, LC_ALL and LC_NUMERIC to C (#41544)
* This forces the fact gathering commands to use C locale, preventing
weird locale issues such as different separator etc
6 years ago