Commit Graph

8916 Commits (87839953db4b8bea31574d1881b1db979841808c)
 

Author SHA1 Message Date
Shawn Siefkas 528f9a1d0b Check mode fix for ec2_group module (#2184)
The default VPC egress rules was being left in the egress rules for
purging in check mode.  This ensures that the module returns the correct
change state during check mode.
8 years ago
Michael Scherer 21c9f0defc Do not hardcode default ssh key size for RSA (#4074)
By default, ssh-keygen will pick a suitable default for ssh keys
for all type of keys. By hardocing the number of bits to the
RSA default, we make life harder for people picking Elliptic
Curve keys, so this commit make ssh-keygen use its own default
unless specificed otherwise by the playbook
8 years ago
Peter Sprygada 033c02152d Merge pull request #4301 from ansible/gundalow-patch-1
State runnng v running
8 years ago
peter.jang caaa8e282e fix for rsync protocol (#4211) 8 years ago
John R Barker 280522914c State runnng v running
Fix typo
8 years ago
Matt Clay fb780b550d Enable FreeBSD tests on Shippable. (#4296) 8 years ago
Rick Mendes 8287002f14 Fixes #4227: just changing messaging 8 years ago
Rick Mendes 72655fe4c8 Fix #3549, failure to reference `module` in `ec2_eip` module 8 years ago
David Chwalisz afff84321d file module: add clarification on state=absent re files that do not exist. 8 years ago
Ryan Brown cb2a47753a Merge pull request #4292 from julienvey/patch-1
Fix typo in docker_image_facts module
8 years ago
Christian Schwarz 635c37cec6 system/service.py: fix false-positive service enablement on FreeBSD. (#4283)
sysrc(8) does not exit with non-zero status when encountering a
permission error.

By using service(8) `service <name> enabled`, we now check the actual
semantics expressed through calling sysrc(8), i.e. we check if the
service enablement worked from the rc(8) system's perspective.

Note that in case service(8) detects the wrong value is still set,
we still output the sysrc(8) output in the fail_json() call:
the user can derive the exact reason of failure from sysrc(8) output.
8 years ago
Ryan Brown 81c663ff71 Merge pull request #4288 from rickmendes/rm-me
please remove me as maintainer
8 years ago
Lyle Mantooth 50abfd5e27 Remove file extension from policy names (#3805)
Fixes #3804.

Prevents `__file__` from contributing ".", which is an illegal character in ELB policy names.
8 years ago
Julien Vey 0bf24f2ae1 Fix Typo in docker_image_facts module 8 years ago
Monty Taylor d38c24d0ed
Merge pull request #3407 from yfried-redhat/idempotent_os_floating_ip 8 years ago
Monty Taylor 0e8ce4ad52
Rename a confusing variable
I had to read the two lines in question twice. That might just make me
dumb, but if I'm dumb, someone else might be too.
8 years ago
Rick Mendes 203b332cdb please remove me as maintainer 8 years ago
Rick Mendes 9cf83ab764 Fixes #4227 8 years ago
Jasmine Hegman a3bae3e6ce Update docs to indicate ec2_asg state defaults to present (#4046)
* Update docs to indicate ec2_asg state defaults to present

Hopefully fixes Issue #4016

* Forgot to flip required to false
8 years ago
Ryan Brown 52e39b545e Merge pull request #4267 from shaunbrady/ec2_group_respect_vpc
Make `ec2_group` group_name property VPC-aware
8 years ago
Matt Clay b3f363a46f Enable Windows tests on Shippable. (#4278) 8 years ago
Shaun Brady de29bafc1e Make ec2_elb_lb respect VPCs when resolving groups
AWS security groups are unique by name only by VPC (Restated, the VPC
and group name form a unique key).

When attaching security groups to an ELB, the ec2_elb_lb module would
erroneously find security groups of the same name in other VPCs thus
causing an error stating as such.

To eliminate the error, we check that we are attaching subnets (implying
that we are in a VPC), grab the vpc_id of the 0th subnet, and filtering
the list of security groups on this VPC.  In other cases, no such filter
is applied (filters=None).
8 years ago
Shaun Brady 8fa56c16ee Remove trailing white space 8 years ago
Shaun Brady 890bba6a0e Make group_name resolution VPC aware
EC2 Security Group names are unique given a VPC.  When a group_name
value is specified in a rule, if the group_name does not exist in the
provided vpc_id it should create the group as per the documentation.

The groups dictionary uses group_names as keys, so it is possible to
find a group in another VPC with the name that is desired.  This causes
an error as the security group being acted on, and the security group
referenced in the rule are in two different VPCs.

To prevent this issue, we check to see if vpc_id is defined and if so
check that VPCs match, else we treat the group as new.
8 years ago
Rob Phoenix aedf21b285 various typo corrections to ios network modules 8 years ago
John Baublitz 2de9fe0e67 Doc update 8 years ago
John Baublitz 4d9b872c3e Fix exception handling to be compatible with Python 3 8 years ago
John Baublitz b8569ae38b Additional error handling for corner cases like deleting networks with active subnetworks 8 years ago
John Baublitz a7702c1f67 Documentation 8 years ago
John Baublitz 1ea678e4ac Logic to allow subnet creation 8 years ago
John Baublitz afe17834ce Add error handling for specifying 'mode' with insufficiently recent libcloud 8 years ago
John Baublitz 4b5a459fc1 Changes to allow 'auto' mode which does not allow IP address specification 8 years ago
John Baublitz d8147f6226 Support for newer networking modes in GCE 8 years ago
Ryan Brown 24db4de245 Merge pull request #4156 from supertom/ansible-2111-fix
Support updating GCE firewall rules when attributes change

Fixes #2111
8 years ago
Ryan Brown d288ef2abc Merge pull request #4163 from kaikousa/improve-ec2_lc-documentation
Improve `ec2_lc` documentation on security_groups option
8 years ago
Ryan Brown a960f01bf3 Merge pull request #4234 from chrisweaver/patch-1
Enforce `bool` type for dup_ok option on AWS `iam_cert` module
8 years ago
Ryan Brown 95c67dc72a Merge pull request #4231 from phy1729/cfn-iam-capabilities
Support CAPABILITY_NAMED_IAM in AWS CloudFormation module
8 years ago
Ryan Brown 92a17c61f4 Merge pull request #4190 from jbaublitz/gce_suspend_node
Add states for stopping and starting GCE ☁️ instances
8 years ago
Ryan Brown 1e6d93cc52 Merge pull request #4203 from MichaelBaydoun/iam_policy_fix
Stop iam_policy from always reporting `changed` status
8 years ago
Brian Coca d64060ace0 updated docs to reflect new feature 8 years ago
yfried-redhat 6b20645b40 Make os_floating_ip module idempotent
Current module fails when tries to assign floating-ips to server that
already have them and either fails or reports "changed=True" when no
ip was added

Removing floating-ip doesn't require address

Server name/id is enough to remove a floating ip.
8 years ago
Ryan 810b40aee9 fix typo in azure_rm_storageaccount (#4236) 8 years ago
Brian Coca 53b4bd06f5 deprecated accelerate 8 years ago
Brian Coca 1c55fa9bda deprecated accelerate 8 years ago
chrisweaver 8879931f0c Enforce boolean type for dup_ok
Stop "choices" from being interpreted as strings.
8 years ago
Toshio Kuratomi b3c606047d Remove git and synchronize modules from list of commands we want users to use the module for instead. (#4233) 8 years ago
Matthew Martin 34d48eb89b Add CAPABILITY_NAMED_IAM to cloudformation capabilities
While from the documentation[1] one would assume that replacing
CAPABILITY_IAM with CAPABILITY_NAMED_IAM; this as empirically been shown
to not be the case.

1: "If you have IAM resources, you can specify either capability. If you
have IAM resources with custom names, you must specify
CAPABILITY_NAMED_IAM."
http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html
8 years ago
Michael Baydoun 07383c40d7
fixes issues where iam_policy incorrected reported changed 8 years ago
Andrei Lukovenko 3945794704 Bug: repeatable invocation with state=present leads to (#3052)
[localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"'Domain' object has no attribute 'id'"}

How to reproduce:

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

Problem: DigitalOcean API changed API
(https://developers.digitalocean.com/documentation/v2/#list-all-domain-records)
8 years ago
Peter Sprygada 3d65c82d7c Merge pull request #4196 from privateip/ios_config
adds update_config argument to ios_config
8 years ago