5 Commits (870abd736603fd1946fd6562d1b00143a1619bbe)

Author	SHA1	Message	Date
Matt Clay	37b013aca3	Enable additional pylint rules and resolve issues found. (#47221) ... * Resolve unneeded-not. * Resolve global-at-module-level. * Resolve useless-import-alias. * Resolve bad-whitespace. * Resolve global-variable-not-assigned. * Resolve logging-not-lazy. * Resolve comparison-with-itself.	6 years ago
Monty Taylor	0f893027c4	Add a module_utils OpenStack Cloud constructor (#20974) ... Start using this to construct shade OpenStack Cloud objects in a consistent manner. This will let us centralize things like dealing with password arguments and whatnot. It also allows us to introduce the ability to pass a fully formed config dict directly to the module. Migrate all OpenStack modules to use openstack_cloud_from_module. Have it return the shade library since it's responsible for importing shade and shade is needed for the exceptions. Only pull specific OpenStack arguments for the constructor Rather than passing **module.params to the shade constructor, pull out only the values that make sense. This should prevent the issues with module parameters stepping on shade parameters. Replace module.params.pop with module.params.get We don't need to pop these anymore since the shade constructor is now using opt-in values. Using real urls is ungood. Use example.com domains. Also, get rid of the antiquated port numbers.	7 years ago
Dag Wieers	4efec414e7	test/: PEP8 compliancy (#24803) ... * test/: PEP8 compliancy - Make PEP8 compliant * Python3 chokes on casting int to bytes (#24952) But if we tell the formatter that the var is a number, it works	8 years ago
Toshio Kuratomi	6bad4e57bd	Migrate most uses of if type() to if isinstance() ... Also convert those checks to use abcs instead of dict and list. Make a sentinel class for strategies to report when they've reache the end	8 years ago
Matt Clay	5628e260f2	Relocate module unit tests. (#18812) ... * Relocate module unit tests. * Fix classification of unit test changes.	8 years ago