Commit Graph

9549 Commits (857e1d374bb09a59f09f3edb8500baa9a5c12d6a)
 

Author SHA1 Message Date
Toshio Kuratomi ca0e78d12a Fix mount default options -- should be defaults, not default 8 years ago
John R Barker 752c80f8b7 deprecated _template network modules: Rename in modules-core (#5072) 8 years ago
Jiri Tyr 7808f42aff Ultimate fix of the mount module for Linux (#5055) 8 years ago
John R Barker 6b5d30ff11 typo in module name (#5062) 8 years ago
Kevin Carter 9b2ee881d9 apt: fix cache time handling (#1517)
This change is in response to issue #1497 where the apt module would not properly updating the apt cache in some situations and never returned a state change on cache update when the module was used without or without an item to be installed or upgraded.

The change simply allows the apt module to update the cache when update_cache option is used without or without a set cache_valid_time. 
If cache_valid_time is set and the on disk mtime for apt cache is ">" the provided amount of seconds, which now has a default of 0, the apt cache will be updated. Additionally if no upgrade, package, or deb is installed or changed but the apt cache is updated the module will return a changed state which will help users to know that the state of the environment has changed due to a task operation, even if it was only an apt cache update.

fixes #1497

Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
8 years ago
Peter Sprygada f3a2fb3dae fixes exception raised due to KeyError (#5068)
The vyos_config module would error when looking for a key called `updates`
in module.params.  There is no such key.  This fixes the problem.
8 years ago
Peter Sprygada 340ff31075 catches exception if conditional cannot be parsed (#5067)
If the conditional cannot be parsed, the module will now catch the exception
and return a well formed failed message.

fixes #5060
8 years ago
Peter Sprygada a1c3ce0ad1 fixes error when 'delete ...' config command is specified but doesn't exist (#5064)
The junos_config module will generate an exception if a 'delete ...' config
command is attempted to be loaded into a device configuration.  This change
will first check to see if the delete command is valid and filter it out
of the change set if it is not valid.

fixes #5040
8 years ago
Nathaniel Case 9a0add286f Network module code cleanup (#5061)
* Fix imports in junos_template

* Python 3 compatibility in eos_command

* Python 3 compatibility for ios_command

* Clean up issues with ios_facts

* Python 3 compatibility for ios_facts

* Import shuffle in ios_template

* Python 3 compatibility for iosxr_command

* Clean up iosxr_facts.py

* Python 3 compatibility for iosxr_facts

* Python 3 compatibility for junos_command

* Python 3 compatibility for ops_command

* Cleanup issues with ops_facts

* Python 3 compatibility for ops_facts

* Cleanup issues with ops_template

* Python 3 compatibility for vyos_command

* Cleanup issues with vyos_facts

* Python 3 compatibility for vyos_facts
8 years ago
Nathaniel Case cb29cbf6bc Fix imports in junos_template (#5059) 8 years ago
David Shrewsbury 7994115bbc Fix os_network's create_network() call for older shade versions (#5058)
A value for the project_id parameter to shade's create_network()
call was always being sent, even if no value for 'project' was
supplied. This was breaking folks with older versions of shade
(< 1.6).

Fixes PR https://github.com/ansible/ansible-modules-core/issues/3567
8 years ago
Matt Clay 0a7ebef14e Detect tar type (bsd, gnu) and only use gnu tar. (#4352)
* Detect tar type (bsd, gnu) and only use gnu tar.

* Revert return code checking for TgzArchive.
8 years ago
Nathaniel Case bdab56efa8 eos_facts cleanup (#5057)
* dict.iteritems does not exist in Python 3

Now just dict.items
six.iteritems handles the change

* Addresses point 1

Unsure if this is a good idea or not.

* Addresses point 2

This shouldn't have any particular change, just marks load_comments as abstract

* Remove unused import

Addresses point 3

* Clarify invalid subset error message

Addresses point 4
8 years ago
Chris Houseknecht c03697c81e Merge pull request #4961 from shaung/iss4504
Fix #4504 Respect timeout option when starting/stopping/restarting co…
8 years ago
Chris Houseknecht 5431d2d632 Merge pull request #5049 from chouseknecht/devel
Put requested devices in correct format to enable config comparison. …
8 years ago
Chris Houseknecht 84020b39ee Put requested devices in correct format to enable config comparison. Fixes #5000. 8 years ago
Peter Sprygada 87f47a44c9 fixes exception being raised when show configuration command issued (#5047)
The junos_command expects commands to be returned as xml by default but
`show configuration [options]` will return text not xml.  This fix
will set the output format for any command that starts with `show
configuration` to text

fixes #4628
8 years ago
Chris Houseknecht e0aede1266 Merge pull request #4825 from adityamarella/devel
Docker module: add support for OomScoreAdj
8 years ago
Peter Sprygada 57350f84cd fixes return passing output from command through jxmlease in junos_command (#5044)
The return string from the commands was not being passed through the
jxmlease library and therefore being returned as a string instead of a
json data structure.  This also adds back the missing xml key in the
return that includes the raw xml string.

fixes #5001
8 years ago
Denis Tiago b2c6d39bec fix health instances count when we have more than one lb in asg 8 years ago
Jiri Tyr 25585937fb Fixing bind mount on Linux (#1942) (#4439)
* Fixing bind mount on Linux

* Fixing broken implementation
8 years ago
Andrew Gaffney 622ae9c67e Match existing INI file entry with leading whitespace (fixes #4997) (#4998) 8 years ago
Senthil Kumar Ganesan cf243860ff Update minimum required version and ssh rate limit (#4995) 8 years ago
Matt Clay e8ed51bce4 Revert "Set PRIVILEGED=true for Linux integration tests. (#4993)"
This reverts commit fb779bf30c.
8 years ago
Matt Clay fb779bf30c Set PRIVILEGED=true for Linux integration tests. (#4993)
This should allow test_mount tests to run on Shippable.
8 years ago
Matt Clay 74120442f2 Fix handling of ansible-doc errors. (#4992) 8 years ago
Toshio Kuratomi edf361a5d4 Fix #3153 again (#4989) 8 years ago
Peter Sprygada 13c7288aea fixes exception raised when nxos_facts uses nxapi transport (#4988)
This fixes a condition where an exception is raised when collecting `interface`
facts and the transport is set to nxapi in the nxos_nxapi module.

fixes ansible/ansible#17691
8 years ago
Toshio Kuratomi d843204575 Working subset of mount fixes (#4987)
* Fixing bind mount on Linux

* The latest update from jtyr doesn't pass integration tests.

Manually select the changes that are necessary to fix the bug with
unmounting
8 years ago
Peter Sprygada 1dd2b849dc fixes default value in docstring for http (#4985)
The docstring incorrectly stated the default value for http is yes when
indeed its no.  This fixes the docstring
8 years ago
Peter Sprygada a923689182 fixes bug where setting state=absent in nxos_nxapi is not idempotent (#4984)
When setting state=absent the nxos_nxapi module would always try to remove
the configuration regardless of the current state of the device.  This will
fix that problem.

This also updates the docstring to correctly reflect https as default=no

fixes #4955
depends on ansible/ansible#17728
8 years ago
John R Barker a829ca29ee Force is not a 2.2 feature
9b5e6bbfa1 incorrectly chopped some text around
8 years ago
Matt Clay 8d3119dfe5 Add shellcheck to sanity checks. (#4976)
Also disable deprecation warnings during module validation.
8 years ago
Trond Hindenes ab1ac22187 win_feature_docs_update (#4421) 8 years ago
Timothy Appnel b995358185 Fixes grammatical error in assert module example (#4972) 8 years ago
Ryan S. Brown 0f505378c3 Accept JSON type as the content of policy_json parameter on `iam_policy` module 8 years ago
Søren Kröger cb9fc47cbc Added single_transaction and quick to db_dump (#3687)
It was missing before, ...
8 years ago
JesseEmond 1f741b69f4 Unarchive stop passing file mode to tar command (#4179)
Fixes #4063.

Tar does not use this parameter on extraction (-x) or diff (-d)(the
only two cases where it is passed in unarchive). It only uses it on
creation:
https://www.gnu.org/software/tar/manual/html_section/tar_33.html

Providing `unarchive` with a file mode of `0755` (octal) makes it pass
the argument `--mode 493` (493 = 0755 in decimal) to `tar`, which then
fails while verifying it (because it contains an invalid octal char
'9'). Not passing the parameter to tar solves the issue.
8 years ago
Marius Gedminas c354c974e7 postgresql_db: fix inverted 'changed' logic when state=absent (#4934)
Fixes #4933.
8 years ago
shaung 4e9e546ef0 Fix #4504 Respect timeout option when starting/stopping/restarting containers. 8 years ago
David Shrewsbury 4bd2a409e6 Correct reuse_fips param to reuse_ips (#4939)
This new parameter was incorrectly named. Fixing to match the expected
name in the shade library.
8 years ago
Toshio Kuratomi b4f1d0d0c2 Fix pip freeze workaround with virtualenv (#4951) 8 years ago
Matt Clay 3486395970 Remove script previously used by Travis. 8 years ago
Toshio Kuratomi 5b1994cb42 pip list isn't available on pip less than 1.3 so make a fallback (#4947) 8 years ago
Chris Houseknecht 16c9597ca7 Merge pull request #4943 from chouseknecht/devel
Improve error handling in docker_service module
8 years ago
Timothy Appnel b87bf7c12d Adds docs for msg param in assert modules plus some other clean up (#4926) 8 years ago
Peter Sprygada 3a2cfadb31 fixes junos_config to be idempotent when confirming a commit (#4946)
The junos_config module would always return true when confirming a commit
This changes the module to now check first making the feature idempontent
8 years ago
René Moser 19be0da3b0 iam_cert: remove choice list for dup_ok type bool (#4940)
See 8879931f0c
8 years ago
Toshio Kuratomi 70d4ff8e38 Fix parsing of pip output 8 years ago
Toopy 6fbd72db82 Fix git get_diff TypeError when fetch (#4881) 8 years ago