Commit Graph

311 Commits (857e1d374bb09a59f09f3edb8500baa9a5c12d6a)

Author SHA1 Message Date
Søren Kröger cb9fc47cbc Added single_transaction and quick to db_dump (#3687)
It was missing before, ...
8 years ago
Marius Gedminas c354c974e7 postgresql_db: fix inverted 'changed' logic when state=absent (#4934)
Fixes #4933.
8 years ago
Tobias Wolf 34201d6bc4 Fix database table quoting in privileges_unpack() (#3858)
In Ansible 2.x this module gives `changed = True` for all privileges
that are specified including a table with

    priv: "database.table:GRANT"

Mysql returns escaped names in the format

    `database`.`tables`:GRANT

However in PR #1358, which was intended to support dotted database names
(a crazy idea to begin with), the quotes for the table name were left
out, leading to `curr_priv != new_priv`.

This means that the idempotency comparison between new_priv and
curr_priv is always 'changed'.

This PR re-introduces quoting to the table part of the priv.
8 years ago
Jean Prat 86366eca68 if user is empty, it is not converted to tuple when using host_all (#3038) 8 years ago
Michael Scherer 2e7cd6e02a Port postgresql module to python3 (#4579)
Iteritems is no longer a dict method in Python3, replace it with
the six wrapper.
8 years ago
Michael Scherer c091a3e9ac Fix mysql_user for python3 (#4576)
dict no longer have a iteritems method, it was replaced
by items. So we need to use six.

    Traceback (most recent call last):
      File \"/tmp/ansible_hjd7d65c/ansible_module_mysql_user.py\", line 587, in <module>
        main()
      File \"/tmp/ansible_hjd7d65c/ansible_module_mysql_user.py\", line 571, in main
        changed = user_add(cursor, user, host, host_all, password, encrypted, priv, module.check_mode)
      File \"/tmp/ansible_hjd7d65c/ansible_module_mysql_user.py\", line 239, in user_add
        for db_table, priv in new_priv.iteritems():
    AttributeError: 'dict' object has no attribute 'iteritems'
8 years ago
René Moser a216ef210b mysql_db: use new exception handling, fixes build (#4373) 8 years ago
Saurabh Sharma fcee7d08b3 error handling for importing non-existent db. Fixes ##2068 (#3617)
* error handling for importing non-existent db

* creating db on import state and suitable message on deleting db

* handling all possible cases when db exists/not-exists
8 years ago
Jiri Tyr 4cb16a0f66 Removing double definition in postgresql_user module (#3714)
This commit is removing double definition of variables in the
grant_privileges function of the postgresql_user module.
9 years ago
Michael Scherer 20342860ad Convert all databases modules to python3 and 2.4 syntax (#3688) 9 years ago
Rene Moser 051744f7b5 mysql_user: fix unresolved reference
L282, module is used but not passed into function. Replaced check_mode reference and used module instead since check_mode is also in module.
9 years ago
Rene Moser 9765a30179 mysql_variables: fix inconsistent params, fixes ubuntu 16.04 support
In the mysql_user module, login_host is defined as "localhost". Setting this to localhost also fixes Ubuntu 16.04 support.

To make it more consistent in the future, the params in all mysql modules should move to module utils. I'll take care.

Also fixed a few other things along.
9 years ago
Jeroen Geusebroek 766671f1e1 Allow an empty password when adding a new MySQL user. (#3445) 9 years ago
jjshoe ea199ecac0 Give encoding examples (#3436) 9 years ago
hyperized 48fa3a5243 Set --quick to True by default and make it selectable (#3418)
As indicated by @jmainguy in eb1cb94380 (commitcomment-17077470), this will allow the user to set the option quick, which is True by default (as it was before).

This is in reference to: https://github.com/ansible/ansible-modules-core/pull/3402
9 years ago
hyperized eb1cb94380 Add single_transaction and quick options to MySQL DB module (#3402) 9 years ago
Michael Scherer 738e62e449 Mark path as type='path', do not leak login_password by error (#3396) 9 years ago
Michael Scherer a2c2a67170 Update the type of some arguments in mysql_db module (#3285)
login_password should not be logged, so mark it as 'no_log'
the others arguments are path to file, and so should be type='path',
which permit to remove the line handling '~' and shell variables.
9 years ago
Tom Paine c790519048 Update mysql_db.py
* Update mysql_db.py

Resubmission of https://github.com/ansible/ansible-modules-core/pull/2961 in single commit.

* Update mysql_db.py
9 years ago
René Moser b8d0f058f4 Merge pull request #2889 from towolf/add_check_mode_to_mysql_db
Add supports_check_mode=True to mysql_db module
9 years ago
Brian Coca e26e3bc201 Merge pull request #3112 from Jmainguy/mysql_user_binlog
added sql_log_bin setting to disable binary logging as option
9 years ago
Matt Clay 518803c4d7 Add optional connect timeout to mysql* modules. 9 years ago
Kenny Gryp d68c6c3de0 added sql_log_bin setting to disable binary logging as option 9 years ago
Matt Martz c7845456a6 Various simple linting type cleanups on modules 9 years ago
Toshio Kuratomi 8d126bd877 password needs to be type str.
In 1.9 this was the default.  In 2.0.0 and 2.0.1 this doesn't get set.
2.1.0 will fix the default but we should fix this now.
9 years ago
Toshio Kuratomi 93d02189f6 Remove duplicate documentation fields 9 years ago
Tobias Wolf 3d606dd2b4 Add supports_check_mode=True to mysql_db module
The most important cases are state=present and state=absent.

Future work: import and dump could be simulated and hence checked.
9 years ago
Lee H 8e326e10ff - fix check_mode test to avoid errors
- correct test mode check to ensure it returns and doesnt apply changes
  (via jmainguy)
9 years ago
Brian Coca 0ef69d19eb Merge pull request #2764 from Jmainguy/mysql_user_ansi
add ansi support
9 years ago
Brian Coca 30559b71dd Merge pull request #2170 from mvdriel/fix-add-user-with-require-ssl
Fix add user with require ssl
9 years ago
Brian Coca 516aed0837 Merge pull request #2774 from koichirok/mysql_user-check_mode
Add check_mode support to mysql_user.
9 years ago
Brian Coca dcb7169946 Merge pull request #2513 from joshrendek/patch-1
Fix quote on grants of more than one word
9 years ago
KIKUCHI Koichiro 76905bc345 Add check_mode support to mysql_user. 9 years ago
Mark van Driel 9da92bfba0 Fixed "invalid privileges string: set expected at most 1 arguments, got 2" 9 years ago
Jonathan Mainguy aebbcd6955 add ansi support 9 years ago
Jonathan Mainguy 92ec54c9b3 Fix bad merge 9 years ago
Toshio Kuratomi 9366dfb63e mariadb isn't always the last elemen of the version string 9 years ago
Toshio Kuratomi b4a3fdd493 Fix mysqldump usage of config_file 9 years ago
Toshio Kuratomi 16a3bdaa7d Account for mariadb versioning 9 years ago
Jonathan Mainguy 69d56c4d21 Unify all 3 mysql modules.
Use same connection method, use config_file, and add ssl support
9 years ago
Lee H f3b2180e42 - add version_added as requested to host_all 9 years ago
Lee H 85a19c68bd - remove user_anonymous as the same thing can be accomplished by user='', but leave
in the examples for removing anonymous users
9 years ago
Lee H 9dd6cad224 - add example showing removal of anonymous user accounts 9 years ago
Lee H b5d7becc29 Merge branch 'devel' into mysql_anon_user
Conflicts:
	database/mysql/mysql_user.py
9 years ago
Jonathan Mainguy 8e812164a4 Add Jmainguy as author, fix hash check 9 years ago
Derek Smith aba519868f updated examples
added mysql 5.7 user password modification support with backwards compatibility

resolved mysql server version check and differences in user authentication management

explicitly state support for mysql_native_password type and no others. fixed some failing logic and updated samples

updated comment to actually match logic.

simplified conditionals and a little refactor
9 years ago
trevoro c007cd7f9a adding password_hash support to mysql_user module
fixing user_add arguments error

fixing user_mod arguments error
9 years ago
Brian Coca 0b5555b62c Merge pull request #2365 from Jmainguy/mysql_docfix
Update documentation to reflect need for mysql client
9 years ago
Mark Theunissen 5599bfb07d Remove Mark Theunissen as maintainer 9 years ago
Mark van Driel 0890aab41b Fixes require ssl in combination with other privileges
Fixes require ssl in combination with grant option

Refactoring: code cleanup to make it easier to understand

Code rewritten inspired by @willthames

Added WITH GRANT OPTION as exception; when only REQUIRESSL and/or GRANT are specified we have to add USAGE
9 years ago