Commit Graph

498 Commits (8362ddd107958eb245ea08e6d41ca5835636e5da)

Author SHA1 Message Date
Peter Sprygada d668d53112 checks connected property to validate connection in Server (#20695)
fixes #20693
8 years ago
Peter Sprygada 6673673042 more logging and exception handling in ansible-connection (#20619)
adds more logging to handle display being called from plugins.  Also
rearranges some of the exception handling to better catch exceptions and
log to local syslog
8 years ago
Peter Sprygada 312328e22c adds more logging to ansible-connection (#20298)
* Server() instance will now add the entire traceback to syslog if it fail
  during init
8 years ago
Peter Sprygada 3f949358c7 adds some more logging to ansible-connection (#20205) 8 years ago
TaoBeier 6ec0369c26 fix indent (#20071) 8 years ago
Peter Sprygada 6fe9a5e40c functional updates to ansible-connection (#18574)
* sends the serialized play_context into an already established connection
* hooks the alarm_handler() method in the connection plugin if it exists
* added configuration options for connect interval and retries
* adds syslog logging to Server() instance

This update will send the updated play_context back into an already
established connection in case privilege escalation / descalation activities
need to be performed.  This change will also hook the alarm_handler() method
in the connection instance (if available) and call it in case of a
sigalarm raised.

This update adds two new configuration options

* PERSISTENT_CONNECT_INTERVAL - time to wait in between connection attempts
* PERSISTENT_CONNECT_RETRIES - max number of retries
8 years ago
James Cammarata 336f8d7233 Removing q debugging cruft from ansible-connection 8 years ago
James Cammarata 85064807af Removing test script for ansible-connection 8 years ago
James Cammarata 26ec2ecfce Adding a persistent connection utility 8 years ago
Brian Coca 18d3e0533f always log unexpected exceptions 8 years ago
Toshio Kuratomi bf29961947 Fixes to the controller text model (#17527)
* Fixes to the controller text model

* Change command line args to text type
* Make display replace undecodable bytes with replacement chars.  This
  is only a problem on pyhton3 where surrogates can enter into the msg
  but sys.stdout doesn't know how to handle them.
* Remove a deprecated playbook syntax in unicode.yml

* Fix up run_cmd to change its parameters to byte string at appropriate times.
8 years ago
Toshio Kuratomi 4ed88512e4 Move uses of to_bytes, to_text, to_native to use the module_utils version (#17423)
We couldn't copy to_unicode, to_bytes, to_str into module_utils because
of licensing.  So once created it we had two sets of functions that did
the same things but had different implementations.  To remedy that, this
change removes the ansible.utils.unicode versions of those functions.
8 years ago
James Cammarata 37f721f315 Remove debug lock 8 years ago
Michael Scherer f0023610e8 Fix bin/ansible to not make a double traceback on python3 (#15972) 9 years ago
Toshio Kuratomi dcc5dfdf81 Controller-side module caching.
This makes our recursive, ast.parse performance measures as fast as
pre-ziploader baseline.

Since this unittest isn't testing that the returned module data is
correct we don't need to worry about os.rename not having any module
data.  Should devise a separate test for the module and caching code
9 years ago
Brian Coca 0eb2844cc6 moved display's debug lock to cli as global 9 years ago
Brian Coca e74ab3ecdd draft 1st release of ansible-console
porting @dominis 's ansible-shell tool from 1.9 and integrating it into ansible
added verbosity control
made more resilitent to several errors
added highlight color, to configurable colors
more resilient on exception and interruptions
prompt coloring, goes red and changes to # when using become = true and root
become setting is now explicit and not a toggle
9 years ago
Toshio Kuratomi f4d68b8860 Transform tracebacks into unicode before printing
Fixes #14042
9 years ago
James Cammarata 120b9a7ac6 Changing the way workers are forked 9 years ago
Toshio Kuratomi 318bfbb207 Migrate cli and dependencies to use global display 9 years ago
Brian Coca 10fd717a44 narrow the scope of import error and make sure non - aliases to ansible get their own error 9 years ago
Brian Coca d0a22a7b45 made cli code more flexible to add new command line programs w/o need for updating bin/ansible 9 years ago
Brian Coca 56a2412dc2 now correctly traps unimplemented symlinks as subprograms 9 years ago
Toshio Kuratomi 7c10c16251 Revert "capture some install issues and give out a slightly nicer error"
This reverts commit e6b1dc45e1.

This is not ready yet and it's causing failures in some environments
(travis)
9 years ago
Brian Coca e6b1dc45e1 capture some install issues and give out a slightly nicer error 9 years ago
Toshio Kuratomi f34b55ac2b Add python3-compat boilerplate to all .py files in lib/ansible 9 years ago
James Cammarata de792ba3c2 Improve handling of unicode errors
Fixes #12669
9 years ago
Brian Coca a5e6845c8b Revert "Allow exceptions to pass through the program"
breaks handling constants.py errors gracefully

This reverts commit 59f96d713e.
9 years ago
Will Thames 59f96d713e Allow exceptions to pass through the program
This is useful when using `ipython --pdb -- $(which ansible-playbook)
...` for debugging.

Also show traceback when `ANSIBLE_DEBUG` is on
9 years ago
Brian Coca e49575ff56 added wrap_text to 'last resort' as it fails if there is an error in callbacks 9 years ago
James Cammarata 469aa0c26a Don't wrap text on most errors 9 years ago
James Cammarata 6d50a261c5 Allow full exception tracebacks to be displayed with increased verbosity 10 years ago
Marc Abramowitz 314bae2a9e Don't wrap text for AnsibleParserError
This allows not messing up the wonderful error reporting that is
carefully created. Instead of:

    $ ansible-playbook foo.yml
     [ERROR]: ERROR! 'foo' is not a valid attribute for a Task  The error appears
    to have been in '/Users/marca/dev/git-repos/ansible/foo.yml': line 4, column 7,
    but may be elsewhere in the file depending on the exact syntax problem.  The
    offending line appears to be:    tasks:     - name: do something       ^ here

we get:

    $ ansible-playbook foo.yml
    ERROR! 'foo' is not a valid attribute for a Task

    The error appears to have been in '/Users/marca/dev/git-repos/ansible/foo.yml': line 4, column 7, but may
    be elsewhere in the file depending on the exact syntax problem.

    The offending line appears to be:

      tasks:
        - name: do something
          ^ here

which is much nicer.
10 years ago
Brian Coca f42b6237d9 now has display of last resort
moved all display/color/err to use display.error
now also capture generic exceptions if they happen (never should!)
10 years ago
Brian Coca 6a75125f32 now traps exceptions on display instantiation 10 years ago
Brian Coca fdeca37257 switched to argv[0] from __file__ as it is what we actually wanted 10 years ago
Brian Coca b85ce38834 slight changes to error handling to align with v1 10 years ago
James Cammarata ce3ef7f4c1 Making the switch to v2 10 years ago
Jesse Rusak 652cd6cd5e Fix --force-handlers, and allow it in plays and ansible.cfg
The --force-handlers command line argument was not correctly running
handlers on hosts which had tasks that later failed. This corrects that,
and also allows you to specify force_handlers in ansible.cfg or in a
play.
10 years ago
James Cammarata 317728f649 Allow ansible-galaxy to install symlinks 10 years ago
Steve Gargan 4ce791fe84 avoid path issues by determining the path of ansible-pull and using its path to run ansible and ansible-playbook 10 years ago
Brian Coca 1fd0a78b0e fix issue with ask pass signature 10 years ago
Brian Coca 5f6db0e164 preliminary privlege escalation unification + pbrun
- become constants inherit existing sudo/su ones
- become command line options, marked sudo/su as deprecated and moved sudo/su passwords to runas group
- changed method signatures as privlege escalation is collapsed to become
- added tests for su and become, diabled su for lack of support in local.py
- updated playbook,play and task objects to become
- added become to runner
- added whoami test for become/sudo/su
- added home override dir for plugins
- removed useless method from ask pass
- forced become pass to always be string also uses to_bytes
- fixed fakerunner for tests
- corrected reference in synchronize action plugin
- added pfexec (needs testing)
- removed unused sudo/su in runner init
- removed deprecated info
- updated pe tests to allow to run under sudo and not need root
- normalized become options into a funciton to avoid duplication and inconsistencies
- pushed suppored list to connection classs property
- updated all connection plugins to latest 'become' pe

- includes fixes from feedback (including typos)
- added draft docs
- stub of become_exe, leaving for future v2 fixes
10 years ago
Brian Coca 8267bb2ae1 added list-tags option and also show tags in list-tasks option 10 years ago
Brian Coca 4805fa6b0b fix ansible-doc listing with new docstring
fixes #10295
10 years ago
Brian Coca 9f83af51b7 Merge pull request #9129 from lotia/devel
Clean up template comment text in ansible-galaxy
10 years ago
Brian Coca c81d981164 Merge pull request #10183 from bcoca/tag_control
adds complex tag management
10 years ago
Brian Coca 1e818f9c50 ansible-doc now shows return value docs 10 years ago
Brian Coca 65c08d1364 added tests
refactored task selection into method
list-tasks now uses common method of task selection
always is now skippable if specified in --skip-tags
10 years ago
Matt Martz 68358e31fb Allow ansible (ad-hoc) to support --extra-vars also 10 years ago
Monty Taylor 38e81083cd Add issue_tracker_url to the galaxy template
There is an optional issue_tracker_url setting that can be set in
meta/main.yml:galaxy_info. Include it in the generated template
commented out so that it can be filled out if desired.
10 years ago
Brian Coca 76a5dd7f62 Merge pull request #10189 from boxofrad/devel
Ignore errors from `shutil.rmtree` when removing temporary directory
10 years ago
Brian Coca f384e0d8d3 Merge pull request #10174 from dago/solaris
Use termios instead of stty for compatibility
10 years ago
Daniel Upton 78fb13657a Ignore errors from `shutil.rmtree` when removing temporary directory 10 years ago
Dagobert Michelsen 84718156e3 Use termios instead of stty for compatibility 10 years ago
Toshio Kuratomi 5b279c1c15 Fix for v1 handling of unicode extra-vars 10 years ago
Max Riveiro 9e8dae7498
Fix #6346. Add key_file and accept_hostkey to ansible-pull
Signed-off-by: Max Riveiro <kavu13@gmail.com>
10 years ago
Brian Coca 540d13cf52 Merge pull request #9404 from mmoya/configure-retry-files
Configure retry file usage and location
10 years ago
Sören Tempel 773849d421 Only write actual errors to stderr 10 years ago
rpe-github 3e7bb0c081 ignore VERSION file in ansible-doc 10 years ago
Toshio Kuratomi 2e0472e03b Allow ansible-playbook to determine if an invalid limit is specified 10 years ago
Jacopo 8dcffaf56f Converted empty inventory error to warning 10 years ago
Jacopo e1f2cb1d37 Removed early check for empty inventory 10 years ago
Toshio Kuratomi f998e65701 Merge pull request #9809 from mscherer/fix_9695
Make sure ansible-doc work when stdin is not a tty
10 years ago
Toshio Kuratomi fbadcfd44f Fix for not all platforms having optional libraries at the proper versions. 10 years ago
Brian Coca 88443d6dcf Merge pull request #7306 from abadger/feature/egg-info
Feature/egg info
10 years ago
Michael Scherer caefc20f16 Use --version to see if less can be executed
(less) 2> /dev/null would fail if stdin is /dev/null.
Sinceless --version do not read anything from stdin,
it is perfect for seeing if the software exist or not.

Also replace the whole os system detection by directly
using subprocess ( as we use it elsewhere, we already
depend on it ).
10 years ago
Michael Scherer f7ac012301 Do not assume that stdin is a tty
This can be used from another non interactive software, see #9695
for details.
10 years ago
Brian Coca 0ba2298fdd used del instead of pop, removed unused pprint import
Conflicts:
	lib/ansible/modules/core
	lib/ansible/modules/extras
10 years ago
Brian Coca 8250dba0f1 Merge pull request #9534 from mmicael1/devel
Add tags options [to ansible pull - ed]
10 years ago
Brian Coca 40caa11082 implemented info action for galaxy 10 years ago
mmicael1 a33dccfa61 Add tags options
Add -t OR --tags options to pass to ansible-playbook
10 years ago
Brian Coca 7a5e7db2df ansible doc now finds modules recursively
more intelligent about ignoring files that are clearly not modules
10 years ago
Brian Coca 0317e7b910 avoid modifying module var by just passing the substring to the append 10 years ago
Brian Coca 94a732fb1a fixed typo in comments 10 years ago
Brian Coca 0fb0548d0b removed no unused var that was not cleaned up properlly 10 years ago
Brian Coca e41bcc41d3 removed 'column display' options as there is no code handling this
function
10 years ago
Brian Coca 1b70ef6cba Several changes to ansible-doc
added display of deprecated to ansible-doc
now it does better job of using tty columns
fixed indication truncation of desc with trailing ...
removed extension from module list, also fixed matching exlusion
blacklist
10 years ago
Brian Coca b3b356480d added the ability to keep aliased and deprecated modules prefixed with
'_', they will be loaded after non prefixed modules are checked they can
be full modules or symlinks to existing ones (alias)

also updated ansible doc to ignore these, will eventually add selective
display
10 years ago
Ton Kersten 39bbe36fc7 Ignore compiled Python for documentation.
When running `ansible-doc --list` a lot of errors are
generated when `ansible-doc` tries to find documentation
strings in `.pyc` files.
10 years ago
Maykel Moya c15b47fb7b Configure retry file usage and location
Adds new settings for managing retry files:
* retry_files_enabled, defaults to True
* retry_files_save_path, defaults to ~/.ansible-retry

This change was adapted from PR #5515.
10 years ago
Pete Smith 0953322b23 Remove no-op string declaration 10 years ago
Toshio Kuratomi e91e30cd5e Fix unspecified role versions.
Fixes #9236
10 years ago
Ali Asad Lotia 9083643a7e Clean up template comment text in ansible-galaxy
Since support for non-galaxy templates is available in 1.8, the existing
comment in the default_meta_template requiring specified dependencies be
available via galaxy was no longer valid. That comment is now removed.
10 years ago
James Cammarata 889dfc4374 Merge pull request #8959 from willthames/galaxy_ssh_clone
Allow fairly common ssh repo clone path to work
10 years ago
James Cammarata b7a74e216f Merge pull request #8948 from sergevanginderachter/issue_8823
ansible-galaxy: exit with rc 1 if role doesn't exist/is not found
10 years ago
James Cammarata bc583dabbc Removing reference to ansible-pull in bin/ansible-vault 10 years ago
Toshio Kuratomi c6b26ff7c7 Remove duplicate call to remove tmp role file 10 years ago
Michael Scherer b9acaccc1d Do not remove local role file if given on the commandline
using this (for testing purpose) :
  $ ansible-galaxy install COPYING
  - error: the file downloaded was not a tar.gz
  - COPYING was NOT installed successfully.
  - you can use --ignore-errors to skip failed roles.

this result in COPYING being erased, which is surprising for the user.
This also prevent erasing requirements.yml if someone use the wrong flag.
10 years ago
Will Thames 537472f42c Make ansible-galaxy work as expected
This change fixes hg galaxy roles
Roles also get installed if roles path is missing, which
the tests currently require (fixes #8950)
10 years ago
Serge van Ginderachter 2474ce5819 Exit with rc 1 if role doesn't exist/is not found
fixes #8823
	modified:   bin/ansible-galaxy
10 years ago
James Cammarata aa46fcf096 Add error checking to ansible-galaxy to verify the roles_path is valid 10 years ago
James Cammarata c610783f90 Merge pull request #8911 from bbasleeper/devel
Adding a new 'load_callback_plugins' config option, defaults to False
10 years ago
James Cammarata 7b4df6e98e Fixing ansible-galaxy bug introduced in 399fe322 10 years ago
Bruno BAILLUET 16108e4a99 Adding a new 'load_callback_plugins' config option, defaults to False
This option, when set to True, allows "ansible" command to load callback plugins
10 years ago
James Cammarata f14dba8b2f Don't re-add galaxy deps if they've already been added for install
Fixes #8890
10 years ago
James Cammarata 9adde1eab0 Fix instance comparison for deps in bin/ansible-galaxy
Fixes #8884
10 years ago
James Cammarata 4698f85eac Merge pull request #8789 from retr0h/retr0h/add-role-path-to-role-file
Can override each role's install path
10 years ago
John Dewey 44b0ee5322 Can override each role's install path
Defaults to the system wide `roles-path` when `path` is not specified in the
provided `role-file`.  An example installing nginx to a relative path specified
by the `role-file`.

    - src: https://github.com/bennojoy/nginx
      path: vagrant/roles/
10 years ago
Matt Martz 206c201d87 The correct option is password_file. Fixes #8752 10 years ago