Toshio Kuratomi
9e0959d600
Fix for recursion traceback in copy with relative paths
...
This is a further fix for: https://github.com/ansible/ansible/issues/9092
when the relative path contains a subdirectory. Like:
ansible localhost -m copy -a 'src=/etc/group dest=foo/bar/'
10 years ago
Toshio Kuratomi
32e8595abf
Merge pull request #790 from rhlmhrtr/file_documentation
...
Fixed Documentation issue concerning file mode
10 years ago
Rahul Mehrotra
98f869f345
Fixed Documentation issue concerning file mode when specified using numberical value
10 years ago
Toshio Kuratomi
aa6c73f11b
When recursing subdirectories, honor the follow parameter for setting file attributes.
...
One half of the fix for
https://github.com/ansible/ansible-modules-core/issues/778
The other half is in basic.py
10 years ago
Brian Coca
f4dbcea30c
Merge pull request #295 from techtonik/patch-3
...
acl: Fix X support in ACL permissions
10 years ago
Toshio Kuratomi
99a8caf409
Prefer gtar to tar
...
Fixes #702
10 years ago
sysadmin75
80a5500a23
Fix #10059 - replace module does not obey follow=yes
10 years ago
Toshio Kuratomi
9f333afb6a
Standardize class names on Archive suffix.
...
This also removes the collision between the stdlib ZipFile class and the
module's ZipFile class
Fixes #681
10 years ago
Toshio Kuratomi
e3759bd0d3
Add detection of uid,gid,mode changes when deciding whether an archive
...
needs to be unarchived again.
10 years ago
Toshio Kuratomi
6159b5c423
Implement user,group,mode,selinux settings for unarchive.
...
This is a partial fix for #234 . Still have to figure out how to
make change reporting work as we can no longer rely on tar's --compare
option
10 years ago
Brian Coca
78cacd0c22
fix for allowing permissions on hard links and soft links + follow=yes
10 years ago
Toshio Kuratomi
022e5274e6
Merge pull request #460 from jbinto/file_allow_touch_hardlink
...
Files module: Allow touch on hardlinks
10 years ago
Brian Coca
6237dab4cf
fix for when state=directory, follow=yes and target is symlink to directory
10 years ago
Toshio Kuratomi
c5f7fc93b2
Merge pull request #514 from jbradberry/issue9546
...
Fix breakage in lineinfile check mode when target file does not exist.
10 years ago
Jeff Bradberry
28375aae7f
Fix breakage in lineinfile check mode when target file does not exist.
...
Similarly to https://github.com/ansible/ansible/issues/6182 , checking of the file attributes should be avoided in check mode when the file didn't originally exist.
Also, avoid creating parent directories in check mode.
Fixes https://github.com/ansible/ansible/issues/9546
10 years ago
sysadmin75
0fee1132ad
Fixes #9518 - "file state=directory" silently skips if it's currently a file
10 years ago
Brian Coca
242a1562c3
Merge pull request #36 from mscherer/fix_old_9092
...
Fix old ticket #9092 where a playbook can enter in recursion
10 years ago
Toshio Kuratomi
467ad65f73
Fix documentation formatting
10 years ago
Jesse Buchanan
2d5d7ff542
Files module: Allow touch on hardlinks
10 years ago
Piotr Gosławski
a5b1a599e2
update docs for insertbefore/insertafter
10 years ago
follower
5c38ea8374
Note that `rsync` must be installed on both local & remote machine
...
In particular, if `rsync` is not installed on the remote machine the following error message will be encountered:
"rsync error: remote command not found"
10 years ago
Brian Coca
4035d24313
Merge pull request #17 from cooniur/devel
...
Added support of returning owner's group name in stat module
10 years ago
Brian Coca
e04ac864a5
Merge pull request #10 from techtonik/patch-1
...
files.stat: Expose path in returned result
10 years ago
Piotr Gosławski
3c8b4bd4b9
Fix behavior when insert* doesn't match anything
...
If insertbefore/insertafter didn't match anything, lineinfile module was doing nothing, instead of adding the line at end of fille as it's supposed to.
10 years ago
Eric
87dd3afc91
Fix lineinfile documentation typo
10 years ago
Toshio Kuratomi
19b328c4df
Cannot readlink() on a hard link
10 years ago
Brian Coca
ee39fd8df0
Merge pull request #124 from jonhadfield/remove-unused-creates
...
Remove redundant check for creates argument.
10 years ago
Brian Coca
4bc1e46de2
Merge pull request #24 from sysadmind/devel
...
Added note to files/synchronize module about synchronizing two directori...
10 years ago
Jeff Geerling
b9471c9cd5
Add mention of fetch module to the copy module docs.
10 years ago
anatoly techtonik
4f2b99c1e0
acl: Fix X support in ACL permissions
...
If you try to set rwX permissions, ACL fails to set them at all.
Expected:
$ sudo setfacl -m 'group::rwX' www
...
drwxrwxr-x 2 root root 4096 Nov 10 17:09 www
With Ansible:
acl: name=/var/www permissions=rwX etype=group state=present
...
drwxrw-r-x 2 root root 4096 Nov 10 17:30 www
x for group is erased. =/
10 years ago
Toshio Kuratomi
6317d3a988
Move from md5 to sha1 to work on FIPS-140 enabled systems
10 years ago
Toshio Kuratomi
88b73afcbe
Use original_basename to set the dest path even if src is not set
10 years ago
Ted Timmons
fd68b77d37
fix spelling
10 years ago
Jon Hadfield
9e0565e58f
Remove redundant check for creates argument.
10 years ago
Tadej Janež
661b452fe3
Simplified condition in a stat module example testing if path is a directory.
10 years ago
James Cammarata
cb69744bce
Adding file doc fragment to those modules in files/ missing it
10 years ago
Michael DeHaan
1c2995d71f
Merge pull request #77 from major/suggest-selinux-enforcing
...
Updating SELinux example doc in lininefile module
10 years ago
Eric Hanchrow
cc0a38d268
Tweak docs to mention `replace`
10 years ago
Major Hayden
6d697780f9
Updating SELinux example doc in lininefile module
...
Encouraging users to use this Ansible module to enable SELinux seems
like a better idea. It also warms Dan Walsh's heart.
Signed-off-by: Major Hayden <major@mhtx.net>
10 years ago
Michael Scherer
9cbd4d0fad
Fix old ticket #9092 where a playbook can enter in recursion
...
This can be tested with this command :
ansible -c local -m copy -a 'src=/etc/group dest=foo/' all
This is a corner case of the algorithm used to find how we should
copy recursively a folder, and this commit detect it and avoid it.
Check https://github.com/ansible/ansible/issues/9092 for the story
10 years ago
Joe Adams
2206d4b1e0
Added note to files/synchronize module about synchronizing two directories on the same host
10 years ago
Tongliang Liu
e26cbb6ace
Added support of returning owner's group name in stat module
10 years ago
anatoly techtonik
7f9305b24e
files.stat: Expose path in returned result
...
This is needed to apply subsequent operation on tested path
10 years ago
Petros Moisiadis
f7c498d059
synchronize: use a single -F instead of -FF
...
This small change corrects behavior when one uses an .rsync-filter file to exclude some paths from both being transferred and being deleted, so that these excluded paths can be handled separately with different tasks (e.g. in order to deploy the excluded paths independently from the rest paths and notify handlers appropriately). The problem with the double -FF option is that it excludes the .rsync-filter file from being transferred to the receiver. However, deletions are done on the side of the receiver, so it is absolutely necessary the .rsync-filter file to be transferred to the receiver, so that the receiver knows what files to delete and what not to delete.
10 years ago
Michael DeHaan
385a037cd6
package files
10 years ago
Michael DeHaan
c8e1a2077e
file extensions!
10 years ago
Michael DeHaan
417309a626
Restructuring.
10 years ago
Michael DeHaan
73123b69fa
Move modules into subdirectory.
10 years ago
James Cammarata
dea00c767b
Merge branch 'dmage-devel' into devel
10 years ago
James Cammarata
bb8bac490a
Merge branch 'devel' of https://github.com/dmage/ansible into dmage-devel
10 years ago
Michael Scherer
d15931f15a
Make file module work on python 2.4, fix #9080
...
Python 2.4 do not support "except ... as ..." construct, so
revert back to the older syntax.
10 years ago
James Cammarata
d98d76aeae
Adding "follow" param for file/copy options
...
Also modifies the template action plugin to use this new param
when executing the file/copy modules for templating so that links
are preserved correctly.
Fixes #8998
10 years ago
Toshio Kuratomi
17665d962b
Do not keep a new file if we fail to set its attributes.
10 years ago
James Cammarata
ab5e8201f4
Fix quoting issues in lineinfile for individual single-quotes
...
Fixes #8806
10 years ago
Oleg Bulatov
583cfa45e5
Fix #7711
...
Fix relative symlinks creation in file module
Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
10 years ago
James Cammarata
311c10c8e5
Docs updates to add examples for symbolic modes
...
Also fixes missing doc fragments missing in template and assemble
10 years ago
Brian Coca
8f3bb4ff20
now acl expands tildes
10 years ago
Michael DeHaan
ef10c2dd9b
Merge pull request #8441 from willthames/unarchive_dest_fix
...
Unarchive should work when parent directory is not writable
10 years ago
James Cammarata
005ca0e5ec
Merge branch 'relative-path-fix' of https://github.com/major/ansible into major-relative-path-fix
10 years ago
Major Hayden
97d6807ec5
File module cannot create relative paths
...
When trying to create a directory relative to the current working
directory, a directory is created at the root of the filesystem
instead. This patch ensures that directories specified with relative
paths will be created in the current working directory. Fully
qualified paths aren't affected
Signed-off-by: Major Hayden <major@mhtx.net>
10 years ago
James Cammarata
0b35433654
Fix check mode issues with copy module
...
Fixes #8639
10 years ago
James Cammarata
989b14de80
Add option to disable ControlPath to ssh options during rsync
...
Fixes #8473
10 years ago
James Cammarata
6d4b429488
Update docs for copy directory_mode param per #8572
10 years ago
Michael DeHaan
ed0751984c
Copy recursion works when source is a parameter, there is no parameter 'recurse' here.
10 years ago
James Cammarata
3f052ead3a
Make sure we only use unquote on quoted lines in lineinfile when needed
10 years ago
James Cammarata
6c9371ea90
Unquote lines that were quoted for safety during eval in lineinfile
...
Fixes #8535
10 years ago
Piffey Parlance
c987dbcb67
Issue 8502: Fixed bug where failed when permissions weren't specified.
10 years ago
Michael DeHaan
60ce2d3853
Fix documentation builds.
10 years ago
Michael DeHaan
185d5a6221
Merge branch 'spelling' of git://github.com/cgar/ansible into devel
...
Conflicts:
docsite/rst/guide_rax.rst
plugins/callbacks/mail.py
10 years ago
Michael DeHaan
0591d3dfbf
Merge pull request #7312 from bcoca/unarchive_docs
...
reworded copy option docs
10 years ago
Will Thames
de16785b8c
Unarchive should work when parent directory is not writable
...
Correct unarchive so that the checks for writeability are
sensible.
Added a test for when parent directory is not writable
10 years ago
Michael DeHaan
f0ae6204e4
Merge pull request #8455 from nicocesar/version_check
...
if python >=2.7 use the option allow_no_value=True for ini_file.
10 years ago
Michael DeHaan
f228e0bff4
Some stray doc tweaks with file modules.
10 years ago
Michael DeHaan
d78e16ff36
Move doc fragments back into file module.
10 years ago
Nico Cesar
31b34906d0
if python >=2.7 use the option allow_no_value=True for ini_file.
10 years ago
Michael DeHaan
04568cd767
Revert ""allow_no_value=True" for ini_file module so /etc/my.cnf can be read without a problem"
...
This reverts commit cbdc9f1153
.
Code needs to make allowances for particular python versions and try/except
around this block.
10 years ago
Michael DeHaan
c05a5eba58
Add version_added attribute for regexp parameter.
10 years ago
Nico Cesar
eeabda4831
"allow_no_value=True" for ini_file module so /etc/my.cnf can be read without a problem
10 years ago
RomanDolejsi
7cd6d6fb89
file: prevent replace failure when overwriting empty directory with hard/link (force=yes)
10 years ago
Michael DeHaan
03c46f016a
Update unarchive example.
10 years ago
Michael DeHaan
0697bbd6dd
Merge pull request #8200 from geetotes/devel
...
[Docs] Added another example to demonstrate unarchive module working entirely on a remote machine
10 years ago
Michael DeHaan
0221727050
Merge pull request #7968 from bcoca/acl_fix_compare
...
acl module: now compares permissions correctly
10 years ago
Lee Gillentine
7cdeddb740
Pushing up correct example :(
10 years ago
anatoly techtonik
fdc355d376
acl: Remove obscurity in `state` description
10 years ago
Lee Gillentine
1b742ca567
Adding another example to demonstrate unarchive working entirely on a remote machine
10 years ago
James Cammarata
de3133682e
Merge pull request #8126 from dingus9/patch-1
...
Update lineinfile validate help
10 years ago
Michael DeHaan
1b48465106
Slight typo fix.
10 years ago
Nick Shobe
e553e24d0a
Update lineinfile
10 years ago
Henry Finucane
9fd91bec5d
Make 'compress' optional
10 years ago
Andreas Fleig
3c4dbd61fc
ini_file: replace lambda with named function
...
Fixes #6876
10 years ago
Brian Coca
030ac743a4
now compares permissions correctly
11 years ago
James Cammarata
68295b05b4
Merge branch 'fix_lineinfile_newlines' into devel
11 years ago
James Cammarata
4adf2c4dfd
Merge branch 'issue_5679_lineinfile' into fix_lineinfile_newlines
11 years ago
Norman J. Harman Jr
0f4aa34da2
lineinfile supports symlinks.
11 years ago
trbs
6567e40b6d
In check mode if a symlink does not exist there is no need to check the ownership properties (which causes an exception)
11 years ago
James Cammarata
abe3655cec
Double check whether the parent directory really exists using stat()
...
Fixes #7760
11 years ago
James Cammarata
bdf84b4e73
Merge branch 'unarchive-fix-7777-simple' of https://github.com/toddmowen/ansible into toddmowen-unarchive-fix-7777-simple
11 years ago
James Cammarata
2ac27fbbea
Use file documentation fragement for the copy module
11 years ago
Todd Owen
dc7e1fe21e
unarchive: do not assume tar supports -C
...
Fixes #7777
(But don't rewrite the tar invocation in is_unarchived(), since a
tar that supports "--diff" certainly supports "-C" as well).
11 years ago
Todd Owen
2b9402dc5c
unarchive: improve failure detection and reporting
...
Related to #7777
11 years ago
James Cammarata
0c028ad881
Merge branch 'fix-lineinfile-eof-newline' of https://github.com/ahtik/ansible into ahtik-fix-lineinfile-eof-newline
11 years ago
Aleksey Khudyakov
a1d76ca8d1
Escape backslash in assemble module docs
11 years ago
James Cammarata
8d9da7e89f
Merge pull request #7377 from mikhailguru/devel
...
Fixed handling of paths containing whitespaces in the synchronize module
11 years ago
Ahti Kitsik
6341cc23fb
Bugfix to lineinfile to properly handle files with no newline at EOF when using insertafter=EOF.
...
Looks like #6881 is also affected by this bug.
Currently when using lineinfile insertafter=EOF for a file that has no newline then the added line is not prefixed with a newline.
As a concrete example, ubuntu distro default /etc/ssh/sshd_config has no newline so lineinfile module cannot be used to add a new line to the end of the file.
11 years ago
James Cammarata
c276dec487
Fix issue with symlink path detection
...
Fixes #7627
Fixes #7664
11 years ago
James Cammarata
090fd0a224
Fix linking issue to directories in file module
...
The os.path.isdir() returns True for symlinks that point to directories,
so we also need to check to make sure it's not a symlink too.
Fixes #7657
11 years ago
Brian Coca
ffb87adbc2
Correctly examine path for relative links in file module
...
Fixes #7515
Fixes #7537
11 years ago
Kit Westneat
aab77b46d8
Fixed documentation for etype parameter on acl module.
...
The etype parameter just had a copy of the default parameter documentation.
Changed it to reflect what it really is for.
11 years ago
Brian Coca
ac14a8d6ad
unified calls to fs function vs duplicate functions for file and
...
directory
11 years ago
James Cammarata
5ec0297c04
Fixing absolute path calculation for file module when linking
...
Fixes #7403
11 years ago
telsacolton
ee60f8f710
Make file hardlink error message reasonble
...
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
11 years ago
telsacolton
133cbee473
Give reasonable error when symlink fails
...
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
11 years ago
James Cammarata
8c7aafd5ae
Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms
11 years ago
Mikhail Emelchenkov
cadb57f446
Fixed incorrect handling of paths contaiin whitespaces
11 years ago
James Cammarata
7faf766305
Merge branch 'devel' of https://github.com/jjshoe/ansible into jjshoe-devel
11 years ago
James Cammarata
261fe0ea96
Merge pull request #7013 from orgoj/replace-patch-changed
...
module replace - report changed only if contents is changed
11 years ago
Brian Coca
6cad8620d5
reworded copy option docs to be clearer
11 years ago
James Cammarata
5ce5ba5e58
Refuse to convert a non-empty directory into a link with the file module
...
Also adds an integration test for the above.
Fixes #7254
11 years ago
someda
5bb888af4b
fix #7244 recursive copy fails when setting directory attributes
...
- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module
11 years ago
Michael DeHaan
f57f9c950f
Merge pull request #7119 from jjshoe/patch-4
...
Finish reverting a broken commit in #5679
11 years ago
James Cammarata
b53bf7c8b1
Minor tweak to rsync_path construction in synchronize module
...
Fixes #7182
11 years ago
Carlos E. Garcia
4dcaa9d9fb
multiple spelling error changes
11 years ago
Skyler Leigh Amador
6eb8759ec5
Remove --timeout option to rsync from synchronize defaults
...
The current 10-second default timeout for rsync seems to be behind issue #6809 .
As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
11 years ago
Joel Schuweiler
aed596088b
Finish reverting #b73cddc
11 years ago
jjshoe
6f0808b23b
Ensure the validation string has %s in it
11 years ago
Brian Coca
1e3860c47b
now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Erika Heidi
40e7c6eddc
Possible docs error: 'path' instead of 'src'
...
I came to this example today (line 50), and when I tried it, I got an error:
`msg: src and dest are required for creating links`
So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
11 years ago
Michael Heca
6618c1e8b5
module replace - report changed only if contents is changed
11 years ago
James Cammarata
39356bd83b
Get the bin path for commands in the unarchive module
...
Fixes #6927
11 years ago
James Tanner
0f82a2b53c
Addresses #6702 Remove version_added from description string
11 years ago
James Tanner
f2c9c2c141
Addresses #6702 set version_added for rsync_opts
11 years ago
jctanner
7a6267690e
Merge pull request #6702 from jjshoe/devel
...
Allow you to pass in arbitrary rsync options
11 years ago
James Tanner
fec4c797d9
Fixes #6929 remote file module doc fragments from copy and template
11 years ago
James Tanner
199992adb6
Fixes #6894 create docs fragment for files
11 years ago
James Cammarata
8f325afe38
Fixing newline escapes in lineinfile
...
Fixes #5679
11 years ago
James Cammarata
7a03cc69e1
Revert "Fix #5679 again after recent changes in core"
...
This reverts commit 2bfaacd170
.
Fixes #6821
11 years ago
Richard C Isaacson
465b97be7e
assemble module: fix insertion of newlines when not needed.
...
This builds on GH-6359 and changes the logic so that a newline is only inserted between fragments if the previous fragment does not end with a newline.
11 years ago
Peter Gehres
53c1d25c70
Fix for #6353 adding a newline between assembled files
11 years ago
Michael DeHaan
63a1330263
Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
...
Application to other cloud providers would make very good sense.
11 years ago
James Tanner
7b72004eb4
Merge #5903 from rhaido/ansible
...
Update files documentation for usage of force=True and hardlinks
11 years ago
cgtx
bb3fed67aa
backreferences should be double escaped
11 years ago
Michael DeHaan
a8b345ad38
Repairs for documentation build.
11 years ago
Michael DeHaan
f596ee8850
Slight docs tweak, split lines according to code standards
11 years ago
Andrea.Mandolo
2a66f356b1
correct documentation comment and version_added in "synchronize" module
11 years ago
Andrea.Mandolo
7cd21a47ef
Add STDOUT lines in response of "synchronize" module
11 years ago
Andrea.Mandolo
33b440ac9f
Add "checksum" option support to 'synchronize' module
11 years ago
Michael DeHaan
d1975c906f
Merge branch 'update_docs_validate_cmd_not_passed_via_shell' of git://github.com/rwehner/ansible into devel
...
Conflicts:
library/files/template
11 years ago
Michael DeHaan
38c3332b8a
Merge pull request #6597 from tarka/handle-uncreated-symlink-tmpfile
...
Handle missing symlink tempfile
11 years ago
jjshoe
a5794f5d8c
Allow you to pass in arbitrary rsync options. I also added help for it, and what version it was added in.
11 years ago
Jeff Geerling
177bf3eb20
Fixed template validation docs and example.
11 years ago