Brian Coca
e1461ef792
Merge pull request #15200 from wimnat/feature/handle_lists_in_snake_dict_creation
...
Handle lists during dict recursion
9 years ago
René Moser
c0618794a2
Merge pull request #15213 from resmo/fix/cloudstack-api-secret-arg
...
cloudstack: fix bug, api_secret always None
9 years ago
Matt Clay
83e53cbb91
Add to_bytes to file paths for accelerate plugin.
9 years ago
James Cammarata
a8dbd3dee9
Pass the variable manager into load_list_of_blocks for include files
...
Fixes #15194
9 years ago
Brian Coca
4b3257c4fe
Merge pull request #15208 from bcoca/constants_pathlist
...
centralize path list handling
9 years ago
Brian Coca
5dfc013e18
Merge pull request #14971 from bcoca/clear_facts
...
meta: clear_facts
9 years ago
Brian Coca
5022fe9adc
Merge pull request #15209 from temal-/devel
...
Add '--skip-tags' to ansible-pull
9 years ago
Rene Moser
65e61e340a
cloudstack: fix bug, api_secret always None
...
In case if api args are used, api_secret is None in every cloudstack module.
9 years ago
Nathaniel Case
e4e913b331
Override params from environment variables, if set.
...
Fix a typo while I'm in the area.
Handle having None set in module.params more intelligently
9 years ago
James Cammarata
eab4ce19f3
Making the return parsing in ActionBase generic for reuse
...
Now also correctly parses the return value for the _low_level_execute_command
9 years ago
James Cammarata
4fc0aadd84
Only combine vars in include_vars if both are mappings
...
Fixes #15184
9 years ago
Brian Coca
c09e085480
Merge pull request #14735 from jsok/open_url-netrc
...
Lookup netrc for credentials in open_url
9 years ago
Malte Krupa
3c954e6572
Add '--skip-tags' to ansible-pull
9 years ago
Brian Coca
92d154f4ef
centralize path list handling
...
move it to constants and avoid duplicating code or misinforming
developers on the nature of the data
9 years ago
Brian Coca
3f6166d2bf
always return rc
9 years ago
Rob White
a46de20772
Handle lists during dict recursion
9 years ago
Peter Sprygada
fa6464e807
feature to localize prompt search logic for ios shared module
...
Prompt search logic is now localized to the ios shared module instead
of using the common regexps in the shell module. This resolves a number
of problems with ios modules functioning properly
9 years ago
James Cammarata
2be1726350
Don't remove _raw_params from static include args
9 years ago
nitzmahone
05af5c88ea
fix Mac chown/chmod -R issue, add error checks
...
The changes to chown/chmod were broken on Mac (-R was being appended to the end of the command- OSX requires it before the file list).
A number of base action remote setup commands were also blindly proceeding without checking for success. Added error raises for unrecoverable failure cases.
9 years ago
James Cammarata
f2713f764c
Take previous jinja2 blocks into account in splitter when we see quotes
...
Previously, split_args() was not taking print/block/comment depth into account
when splitting things, meaning that if there was a quote character inside an
un-quoted variable (ie. {{ foo | some_filter(' ') }}), it was incorrectly
splitting on the quotes instead of continuing to append to the previous param.
Fixes #13630
9 years ago
Brian Coca
04610106a3
Merge pull request #15173 from mattclay/issue6072
...
Support remote_user in jail connection plugin.
9 years ago
Brian Coca
e9a4526251
allow bypassing executable setting
...
if you set executable to an empty string this avoids passing one to the command constructor
fixes #14813
9 years ago
Rob White
a5b05922ed
Some helper functions to work with boto3
9 years ago
Brian Coca
c303ed24b5
Merge pull request #15159 from sigio/filter-ip4-hex
...
Add ip4_hex filter to convert ip-address to hex notation
9 years ago
Brian Coca
b77bba8f9f
Merge pull request #15175 from wimnat/feature/camel_case_fixing
...
Add function to convert CamelCased key names to snake_names
9 years ago
Brian Coca
363384f517
Merge pull request #15174 from mattclay/conn-msg-host
...
Fix inconsistent/missing host names in messages.
9 years ago
David Wittman
5036d1742c
Fix boolean choices in module docs fragments
...
A few of the docs fragments have the available choices for some params
defined as "BOOLEANS". Because choices accepts a list, it treats
"BOOLEANS" as an iterable and then generates a list composed of each
letter.
Instead, define the available choices as a list of `['yes', 'no']`,
as is common in most other modules.
9 years ago
Toshio Kuratomi
0fffb6c60c
Merge pull request #15163 from ansible/synchronize-connection-vs-play_context
...
Use _connection instead of _play_context for information about the connection
9 years ago
Brian Coca
c6c3fd79c2
Merge pull request #15168 from bcoca/script_exists_fix
...
Script exists fix
9 years ago
Rob White
ef8c1124d0
Add function to convert CamelCased key names to snake_names
9 years ago
James Cammarata
eff89d6290
Merge pull request #15140 from berlic/args-splitter-exception-context
...
Show error context in args splitter exception
9 years ago
Matt Clay
5fdc29e00f
Fix inconsistent/missing host names in messages.
9 years ago
Matt Clay
b60062bdf9
Support remote_user in jail connection plugin.
...
Resolves #6072 .
9 years ago
Brian Coca
28d20dbe53
moved 'path exists' function to shell
...
now it will work with powershell/winrm
9 years ago
Toshio Kuratomi
0cabd133ba
have to always run dwim() on the path to get the full absolute path.
...
Fixes #14944
9 years ago
Toshio Kuratomi
e2f5762232
Use _connection instead of _play_context for information about the connection
...
If we're not delegating then we change _connection into a local
connection midway through the file but we don't change
_play_context.connection (no need to alter that). When we later check
it in process_remote() we need to know the actual connection, not the
connection that we thought we were going to use at the start of run().
So we have to use _connection.transport in process_remote(). The rest
of the places could use either one (because we have not yet changed to
a local connection) but we go ahead and switch those to
_connection.transport as well to avoid confusion in the future.
Fixes https://github.com/ansible/ansible-modules-core/issues/3136
9 years ago
James Cammarata
f4eb9aac24
Fix --start-at-task which was broken by the setup task revamp
...
Fixes #15010
9 years ago
Toshio Kuratomi
2adf8f7ec9
Update submodule refs
9 years ago
Mark Janssen -- Sig-I/O Automatisering
b1015d897d
Re-add accidentaly removed comment
9 years ago
Mark Janssen -- Sig-I/O Automatisering
73766e0816
Add ip4_hex filter to convert ip-address to hex notation
9 years ago
Matt Davis
afc82f6beb
Merge pull request #14930 from mholiv/enable_dollar_as_first_char_in_folder_and_userName
...
Modified files to use single quotes rather than double for file path.…
9 years ago
Toshio Kuratomi
3221be4340
Reverse boilerplate order because from __future__ must be the first code in the file
9 years ago
Brian Coca
1c4cfee415
Merge pull request #15046 from bcoca/script_raw
...
removes python requirement to script
9 years ago
nitzmahone
4241106ad2
fix breakage from new recursive=True arg to chmod
9 years ago
Toshio Kuratomi
80e7fbff75
Add python3 compat boilerplate
9 years ago
Toshio Kuratomi
17e8500202
Don't process the same host multiple times
...
Fixes #14259
9 years ago
Brian Coca
1ebc2fda71
removes python requirement to script
...
mistakenly added when checksum was made to use stat module
fixed assertion in test
9 years ago
Brian Coca
6768f34b31
Merge pull request #15062 from gechr/gc-subset-superset-filters
...
Add `issubset` and `issuperset` tests
9 years ago
Thomas Steinbach
870160b8ed
fixed some breaks after merging ansible/devel
9 years ago
Thomas Steinbach
cd2c140f69
forwarded docker_extra_args to latest upstream/origin/devel
9 years ago
Toshio Kuratomi
228ad3ca39
Should be errors=strict since we don't want to end up matching hosts like '???'
9 years ago
Toshio Kuratomi
13b295f1ee
Fix using non-ascii for inventory hostname patterns with the CLI.
9 years ago
James Cammarata
2c20579a06
Add options to make includes 'static'
...
* Can be configured in the ansible.cfg for tasks/handlers individually
* If an included filename contains no vars or loops, it will be expanded
in-place as if it were marked as static
9 years ago
Toshio Kuratomi
f323eb858e
nv_por is needed later in the file
...
Fixes #14654
9 years ago
Toshio Kuratomi
c4a5cf174b
Merge pull request #15009 from bcoca/py3_compat_fixes
...
Py3 compat fixes
9 years ago
James Cammarata
f427955640
Make default var lookup for tasks follow the dep chain
...
Related to #14296 (@jjshoe's follow-up example on that issue)
9 years ago
Konstantin Suvorov
1c922135a0
show error context in args splitter exception
9 years ago
Brian Coca
5b11494437
python3 compatiblity
...
remove use of basestring
deal with configparser
9 years ago
Toshio Kuratomi
52e9209491
Don't create world-readable module and tempfiles without explicit user permission
9 years ago
Brian Coca
fdb56e4bad
avoid bad path entries
9 years ago
Toshio Kuratomi
728bb7d85e
Update submodule refs
9 years ago
Toshio Kuratomi
917da92e2b
Get rid of extra trailing space in log messages
9 years ago
Matthew Gamble
7b06ec79e3
Add documentation for squash_actions configuration setting
9 years ago
Matthew Gamble
197e590d7c
Small comment improvement in AnsibleModule class
9 years ago
Abhijit Menon-Sen
1b242ffb89
Merge pull request #15111 from xiaket/devel
...
complete the docstring. Fixed #14794
9 years ago
夏恺(Xia Kai)
f9a9e5e1b9
complete the docstring. Fixed #14794
...
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
9 years ago
Peter Sprygada
5bb876b0e2
fixes issue with getting value with . (dot) in key in netcfg
...
This commit addresses a problem when attempting to retrieve a value from
the result that includes a dict key using . (dot).
9 years ago
Brian Coca
b4b44b2708
Merge pull request #15086 from robinro/patch-2
...
remove double read of "path" (/etc/SuSE-release) in facts.py
9 years ago
Brian Coca
43f70d66a5
Merge pull request #15088 from robinro/patch-3
...
break after parsing SuSE-release in facts.py
9 years ago
Joel
23a74eb125
Sort plugins by basename to support ordering callbacks
9 years ago
Toshio Kuratomi
06d77996da
Update submodule refs
9 years ago
Robin Roth
2c28dcc5cb
break after parsing SuSE-release in facts.py
...
All sections that lead to succesful parsing of the version break afterwards, for SuSE-release this break was missing, potentiall causing #14837
9 years ago
Robin Roth
fea5500605
remove double read of "path"
...
path is already read in line 444, don't reread the file here, but use the existing content
9 years ago
Toshio Kuratomi
3511abb9d9
Merge pull request #15055 from ansible/ansible_sudo_pass-should-override-cli
...
Fix ansible_sudo_pass inventory variable so that it overrides setting of sudo password from the command line
9 years ago
Toshio Kuratomi
f39a1da360
Merge pull request #15074 from ansible/pluginloader-cleanups
...
Cleanup some minor issues in PuginLoader:
9 years ago
George Christou
02ad029840
Add `issubset` and `issuperset` tests
9 years ago
Toshio Kuratomi
ed9e164b80
Fix ansible_sudo_pass inventory variable so that it overrides setting of sudo password from the command line
9 years ago
Toshio Kuratomi
7ce130212f
Cleanup some minor issues in PluginLoader:
...
* class_only was a keyword arg of get() and all() that was mistakenly
passed on to Plugins. Be sure to strip it from the keyword args
before instantiating Plugins. (Reworked API probably should either
not instantiate Plugins or take the args for the Plugin as a separate
list and a dict.)
* Checking required base_classes was only done in get() and only if
class_only was False (ie: that Plugin was instantiated). This meant
that different plugins could be found depending on whether the call
was to .get() or to all() and whether it was for classes or instances.
Fixed so that required base_classes are always checked.
9 years ago
Brian Coca
3ae9a272e0
Merge pull request #14977 from towolf/hide_ok_items_in_actionable
...
For `actionable` cb plugin also hide ok for itemized results
9 years ago
James Cammarata
ae21d98955
Properly use check_raw when using parse_kv in cli/ code
...
Fixes ansible-modules-core#3070
9 years ago
Toshio Kuratomi
407f8f934e
Merge pull request #14976 from xiaket/devel
...
use __mro__ for plugin loading when we search for its base class.
9 years ago
Tobias Wolf
4938b98e4e
For `actionable` cb plugin also hide ok for itemized results
...
The purpose of the `actionable` callback plugin is to hide uninteresting
results.
Also hide the ok results when the task was itemized.
9 years ago
夏恺(Xia Kai)
38092dcc27
import the base class and check whether this obj has the required base class.
...
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
9 years ago
Toshio Kuratomi
9053d0468e
Merge pull request #15006 from ansible/local-pipelining
...
Add changes necessary for enabling pipelining for local connections
9 years ago
Will Thames
f438c074af
Remove need for unnecessary boto.ec2 import
...
Modules shouldn't need to import boto.ec2.
The check was to test if profile_name was supported by boto.
Two years after the introduction of the support, we will now
assume that if people are passing `profile`, they are using
a version of boto that supports it (this requirement is
already documented in the aws documentation fragment)
Also remove even older version check for `validate_certs`
Fixes #1901
9 years ago
James Cammarata
9d2fe2fb2c
Fixing role param precedence issues
...
* Make role param resolution follow the role dependency chain, rather
than using all roles within the play
* Also move params to be merged in after role vars in general, to match
our variable precedence rules
* Changes to the way var lookup is done in role helper methods for
get_vars(), get_inherited_vars(), and get_role_params() to make the
above possible without trampling on previously merged vars
Fixes #14472
Fixes #14475
9 years ago
Toshio Kuratomi
4a00999875
Update to latest git submodules
9 years ago
Toshio Kuratomi
b80c9b5032
Merge pull request #15049 from mattclay/paramiko-unicode
...
Add missing to_bytes for cmd.
9 years ago
Matt Clay
24c4384f0e
Add missing to_bytes for cmd.
9 years ago
James Cammarata
e4a5bcae3c
Merge pull request #14679 from dagwieers/merge_hash_v2
...
Avoid merging a dict and a AnsibleUnicode
9 years ago
Brian Coca
7a5ff16aee
Merge pull request #15042 from RNanney/RNanney-validate_certs
...
Update nxos.py
9 years ago
Toshio Kuratomi
f5654dced9
Merge pull request #15043 from mattclay/docker-user
...
Use docker exec -u only when supported.
9 years ago
Matt Clay
ea1a6c56b9
Use docker exec -u when needed and if supported.
...
If remote_user is given and cannot be set in docker, a warning will
be displayed unless the default container user matches remote_user.
9 years ago
RNanney
8bceff5136
Update nxos.py
9 years ago
James Cammarata
13f3cbaf3b
Renaming per-item and retry callbacks
9 years ago
Toshio Kuratomi
60c943997b
More doc updates regarding ansible_shell_executable
9 years ago
Toshio Kuratomi
8bdf0d4746
And another doc fix
9 years ago
Toshio Kuratomi
08394df8d0
Update submodule links for docs fixes
9 years ago
Abhijit Menon-Sen
efdac490ff
Merge pull request #14924 from mvgrimes/patch-1
...
Dynamically add ssl key to the mysql config hash iff needed
9 years ago
Brian Coca
d43fc631dd
mount facts now include network mounts (nfs)
9 years ago
Brian Coca
b809d23863
fixed typo
9 years ago
Abhijit Menon-Sen
e5460d6a6e
Merge pull request #15002 from camradal/devel
...
add find_host_portgroup_by_name function to vmware utils
9 years ago
Toshio Kuratomi
e25caebe7a
Cleanups to docs and rename of inv var
9 years ago
Toshio Kuratomi
8fc1c26c37
Merge pull request #14936 from bcoca/ansible_executable
...
add ansible_executable inventory var
9 years ago
Toshio Kuratomi
2ba4428424
Catch ValueError as well because of El Capitan provoking a bug in python2's subprocess
...
Fixes #14895
9 years ago
Abhijit Menon-Sen
a61a3e28da
Merge pull request #9776 from MiLk/fixes/git-repo-info-branch
...
ansible.utils._git_repo_info() now supports branch names with slashes
9 years ago
Brian Coca
db61e9be0c
add ansible_executable inventory var
...
also handle the overrides appropriately
also new executable to set shell type
9 years ago
Thomas Steinbach
14dfad730e
use just 'remote_user' as user for the docker connection
9 years ago
Thomas Steinbach
4ac49ed4a8
use remote_user or become_user in docker connection
9 years ago
Brian Coca
5d9b552317
Merge pull request #15024 from bcoca/delegation_vars_fix
...
ensure we use delegated vars on delegation
9 years ago
Toshio Kuratomi
ab693579a9
Clarify the document about the order of matryoshka shells
...
(nesting shells)
9 years ago
James Cammarata
1ee6d489ab
Make sure tuples returned by _get_item() are handled correctly in formatting
...
Fixes #14800
9 years ago
Brian Coca
292be944c6
ensure we use delegated vars on delegation
...
this prevents falling back to connection vars from the inventory_hostname
when matching connection var is not in delegated host.
9 years ago
René Moser
0a457230ab
Merge pull request #14982 from Linuturk/GalaxyInitWhitespaceFix
...
Remove trailing whitespace from the galaxy init Jinja2 template. Defa…
9 years ago
Toshio Kuratomi
2dd6bae9e1
Merge pull request #15003 from ansible/jail-enable-pipelining
...
Enable pipelining for jail connection plugin
9 years ago
Brian Coca
bc60f52db5
avoid exceptiosn when not being called by CLI
9 years ago
Toshio Kuratomi
e80cd8bcaf
Merge pull request #14908 from mattclay/mysql-connect-timeout
...
Document mysql connect_timeout and update tests.
9 years ago
James Cammarata
0e68c6d6fe
Cleaning up use of literal_eval in basic.py AnsibleModule.safe_eval
9 years ago
Matt Clay
6a1f97ad42
Add docs for mysql* modules connect_timeout.
9 years ago
Brian Coca
5ae9955aad
Merge pull request #15011 from dagwieers/fix-unreachable-color
...
Fix the color when unreachable in default cb plugin
9 years ago
Brian Coca
0cb804f0c2
fix lsb fact gathering
...
was erroring out when rc !=0 also fixed redundant paths
fixes #14965
9 years ago
Brian Coca
d7d47bcd75
Merge pull request #14989 from nifoc/patch-fetch_url
...
Check return value of get_distribution()
9 years ago
Dag Wieers
ed457ad53b
Fix the color when unreachable in default cb plugin
...
The dedicated color for unreachable errors was not being used in the default cb plugin.
This corrects the color.
9 years ago
qqo
a7f89cac63
fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found
9 years ago
qqo
85e843baee
Revert "fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found"
...
This reverts commit d1e0719e4c
.
9 years ago
qqo
d1e0719e4c
fix TypeError: coercing to Unicode: need string or buffer, AnsibleParserError found
9 years ago
Brian Coca
61f05c2e8d
strip keys recursively
9 years ago
Toshio Kuratomi
7346e3098a
Update extras submodule ref
9 years ago
Toshio Kuratomi
1346c209b0
Add changes necessary for enabling pipelining for local connections
9 years ago
Toshio Kuratomi
a8acd7f93e
Enable pipelining for jail connection plugin
9 years ago
Alexey Kalinin
9763e76f6f
add find_host_portgroup_by_name function to vmware utils
9 years ago
Toshio Kuratomi
de306eb5da
Small cleanup to use class attribute directly instead of property for transport names
9 years ago
Toshio Kuratomi
fee73100c4
Move BUFSIZE to __init__ since it's common to many connection plugins
9 years ago
Toshio Kuratomi
0ca4be6fb5
Update submodule refs for docs fixes
9 years ago
Toshio Kuratomi
ec419446b7
Update submodule refs
9 years ago
Daniel Kempkens
696b68f07a
Check return value of get_distribution()
...
On none-Linux systems `get_distribution()` returns `None`, which fails in `fetch_url`, because the return value of `get_distribution()` is not checked before calling `lower()` on the result.
9 years ago
Toshio Kuratomi
fe278202f2
Fix saving of tracebacks on module failure
9 years ago
Justin Phelps
d604c8c3a6
Remove trailing whitespace from the galaxy init Jinja2 template. Default a description.
9 years ago
Toshio Kuratomi
86080fbaa9
Update submodule refs
9 years ago
Toshio Kuratomi
66328e5200
Merge pull request #14967 from ansible/facts-subset-and-cleanup
...
Facts subset and cleanup
9 years ago
夏恺(Xia Kai)
cd6d865e27
use __mro__ for plugin loading when we search for its base class.
...
This would relax the constraint a little bit, allowing subclassing existing plugins.
Signed-off-by: 夏恺(Xia Kai) <xiaket@gmail.com>
9 years ago
Brian Coca
09699d0cd0
meta: clear_facts
...
draft implementation
9 years ago
Brian Coca
f3b9449e07
don't raise exceptoins on bad hosts files
...
fixes #14969
9 years ago
Peter Sprygada
ace0c9c5c2
fixes ansible-modules-code#3250
...
Sets the default value for transport to 'cli'
9 years ago
Peter Sprygada
c039ac524d
updates to nxos shared module
...
This commit address a number of minor updates the nxos shared module
* connect() is now lazy loaded
* parse inner output messages when errored
* code syntax cleanup
9 years ago
Toshio Kuratomi
512825455e
Make ohai and facter work via module_utils Fact classes rather than in the setup module
9 years ago
Toshio Kuratomi
5a1e35224b
Make changes proposed during review of restrict fact gathering feature:
...
* Make documentation examples into code blocks
* Make code to call the subsets more general.
* Made min subset always execute (cannot disable it).
* Use a passed in modules parameter rather than global modules. This is needed for ziploader
* Remove unneeded __init__()
* Remove uneeded multiple inheritance from a base class
* gather_facts is now a list type
9 years ago
Toshio Kuratomi
d665911bab
Allow FieldAttribute lists and sets to be set from a comma separated string
9 years ago
Yannig Perré
88772b6003
Add a way to restrict gathered facts in Ansible:
...
- Using gather_subset options
- By ignoring ohai/chef or facter/puppet facts
9 years ago
Brian Coca
2984ffdfac
now item callback honors display_skipped_hosts
...
fixes #14956
9 years ago