Commit Graph

2327 Commits (7e557663c26b96feb54afea7b8aa74eaaa1535e7)

Author SHA1 Message Date
Paul Durivage 8cf071f697 Hostvars support for su 11 years ago
Paul Durivage dec9131735 Ensure playbook support for su params 11 years ago
Paul Durivage d21281ff43 Resolve rebase conflicts 11 years ago
Paul Durivage ab6ee1a282 Enable su support in paramkio; disable su support in fireball, local, accelerate, chroot, jail, funcd connection plugins 11 years ago
Paul Durivage 4088243deb Proposing fix for Issue #4324; adding support for su in connection plugins ssh, ssh_alt
Fixes for ssh_alt support, adding in references to in_data where appropriate
11 years ago
Michael Scherer 5c5c8fd7ce Make synchronize module work better with local transport, fix #5668 11 years ago
Rutger Spiertz dec6345fe6 PlayBook: better error message
When a PlayBook has missing arguments the error message now shows which ones are missing.
11 years ago
James Tanner 559e89036b Fixes #5631 Return a unique list of hosts when joining groups 11 years ago
James Cammarata 02ce5af6df Added ANSIBLE_SSH_PIPELINING option to enable/disable pipelining support
Pipelining will be disabled by default, since it requires users remove
the 'requiretty' option from the servers sudoers configuration.
11 years ago
James Cammarata 233aae5861 Reverting paramiko_ssh/alt changes from yesterday 11 years ago
Matt Martz d46037d64c Do not log the rax api_key argument in module invocation 11 years ago
James Cammarata 36e6709771 Don't use pipelining when ANSIBLE_KEEP_REMOTE_FILES is enabled 11 years ago
James Cammarata df13b19fe1 Moving {ssh,paramiko}_alt connection types to be the defaults
The previous implementations will be kept for now as _old
11 years ago
James Cammarata c27db84e41 Adding paramiko_alt - pipelining support for paramiko connections 11 years ago
jctanner 91c5c9da08 Merge pull request #5465 from deonbredenhann/false_mandatory_variable
Treat a False mandatory variable as defined.
11 years ago
jctanner 59d99c17b3 Merge pull request #5337 from bob-smith/bugfixFQDNParsing
Fix inventory parsing so that FQDN can be parsed without throwing ssh port error
11 years ago
jctanner a6bc63512e Merge pull request #5308 from zecrazytux/fix/hash_merge_dynamic_inventory
Let merge hash_bahaviour work with dynamic inventory
11 years ago
jctanner 671b0454c6 Merge pull request #4987 from jpmens/lookup-csvfile
New lookup plugin csvreader
11 years ago
willthames 31f5ecea60 Allow float as an argument type in AnsibleModule 11 years ago
Rob Smith c15cffabdd This fixes bugs added as a part of 8665b0638a
1. if accept_hostkey is false, no matter if the host key is known or not, it will fail.

2. We don't check for the host key in /etc/ssh/ssh_known_hosts

This fixes both of those issues.
11 years ago
James Tanner 3719f3f496 Do not fetch or add keys for http based git urls 11 years ago
James Tanner eeee1e1c5a Set accept_hostkey to False by default in the git module and fail
early if the key is unknown
11 years ago
James Tanner 8665b0638a Add an "accept_hostkey" parameter to the git module to help automatically
accept hostkeys for git repos and prevent task hangs when the key is unknown
11 years ago
James Tanner 09e0d052ca Ensure sys.stdout has an istty method 11 years ago
James Tanner d7c8cf6ca7 Fixes #4958 Truncate printed stdout if it contains non-printable characters 11 years ago
jay e1f5b801cf fixed bug causing symlinks to fail in the host_vars, group_vars etc directories 11 years ago
James Tanner 78ec7c736f Fixes #3973 Second Revision of live ansible-pull output 11 years ago
Luca Berruti ae543eecab Simplified p.poll handling 11 years ago
James Tanner c408bcea31 Update sshpass hostkey error message 11 years ago
James Tanner 0b64408f5a Fixes #5531 Give the user a better error message when sshpass does not know the remote hostkey 11 years ago
jeromew 69febcefde remove useless create/delete remote tmp dir roundtrip in copy module 11 years ago
Serge van Ginderachter 836fb4143c path_dwim: fix when basedir not set 11 years ago
jeromew c9b01febb3 Make sure 'tmp' is in the remote tmp dirname to ensure correct cleanup 11 years ago
jctanner 21b4212ff5 Merge pull request #5517 from lichesser/fix_set_depreciation_warning
Fixes #5513. set is built-in since 2.4 and deprecated since 2.6
11 years ago
jctanner 83dec044ab Merge pull request #5504 from smoothify/synchronize-sudo
Synchronize Module: Improved sudo override behaviour.
11 years ago
jctanner 9a69b1b0ec Merge pull request #5311 from willthames/ec2_refactor
ec2 modules: Move more responsibility to common EC2 module
11 years ago
James Tanner d6b78e9dd6 Fixes #5238 Improve error messaging about unquoted variable references in playbooks 11 years ago
James Tanner ab51bd23a2 Fixes #5196 return a unique list of hostnames for a single host pattern 11 years ago
smoothify 93a55e8dff Don't override sudo if transport is set to local.
https://github.com/ansible/ansible/pull/5251
11 years ago
Michael DeHaan c039e276a2 Fact gathering on a second play against the same hosts should not be implicitly off since this is an undocumented beheavior and potentially
rather unwanted when a play could change a fact.

gather_facts: True/False can still be explicitly used per play.

Reverts 564a212b3c
11 years ago
Michael DeHaan 87258f6d42 Resolve merge commit 11 years ago
Michael DeHaan 1c632af2c9 Merge pull request #5468 from jeromew/ansible_ssh_alt
fix issue #5372 on ssh_alt: accept -K option for a user with NOPASSWD
11 years ago
Michael DeHaan a3d90e8a87 Merge pull request #5498 from j2sol/exit_setup_early
Return early from setup step when possible
11 years ago
Michael DeHaan 227e8e31c9 Merge branch 'use_comps' of git://github.com/j2sol/ansible into devel 11 years ago
Michael DeHaan 10350d1639 Update various copyrights. Not complete, but sufficient. 11 years ago
Jesse Keating 23720ff19d Use list comprehensions for efficiency
For loops can be inefficient, particularly when doing a dot command with
them. https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Loops and
https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Avoiding_dots...

This patch makes use of list comprehensions to be as efficient as
possible while still retaining order. Efficiency was lost a bit when
switching away from sets() but this gains some of it back.
11 years ago
Jesse Keating 35328ed503 Return early from setup step when possible
The _list_available_hosts call can be lengthy, and in the case where
gather_facts is disabled the call is pointless. So re-arrange the logic
to return early from _do_setup_step when gather_facts is false.
11 years ago
Michael DeHaan c41a23a35a Complete removal/refactoring of conditional deprecations. 11 years ago
Michael DeHaan 8e5b7d3095 Remove code underlying when_* and only_if, which are deprecated features slated for removal in the 1.5 release. 11 years ago
Michael DeHaan 28b9fd4e30 We have had only_if, when_foo, etc, deprecated for a while and said they would be removed in 1.5. Now they are, with friendly error messages still.
Users of these features should use "when:" as documented at docs.ansible.com.

Similarly, include + with_items has been removed.  The solution is to loop
inside the task files, see with_nested / with_together, etc.
11 years ago
James Tanner 21fdb2bbc7 Fixes #5200 Handle template contents with unicode strings better 11 years ago
James Tanner fc473b3246 Fixes #5146 Handle missing stdin when running under celery with rabbitmq or redis 11 years ago
Michael DeHaan de2ffc1276 Don't need to document these guys. 11 years ago
James Tanner cb2214d6f8 Fixes #4935 Synchronize module: set destination to an fqdn if connection is not local, and abide by ansible_remote_user 11 years ago
jctanner 99560e3902 Merge pull request #5047 from sergevanginderachter/synch_template_ansiblesshhost
synchronize: allow ansible_ssh_host to be templated
11 years ago
jeromew b2cd4a62de fix issue #5372 on ssh_alt: accept -K option even for a user with NOPASSWD 11 years ago
Deon Bredenhann c85aac8b17 Treat a False mandatory variable as defined. 11 years ago
Deon Bredenhann 4f1f13b100 Remove trailing space 11 years ago
Levi Gross dc6a26123b
Fixed syntax error and removed unused imports 11 years ago
Michael DeHaan 643690ffec Remove depedency of lookup plugin on setting in ansible.cfg 11 years ago
Michael DeHaan 5b3c796641 Update constants.py
Lookup plugins for optional web services do not warrant advertising in ansible.cfg.
11 years ago
Stephen Fromm 833e1f6e2a Make sure action plugin copy cleans up tmp dir
The copy action plugin creates its own tmp dir for each file that it
copies to the target machine.  However, it does not clean up the
original tmp path it was given when run() is called.  This cleans up the
tmp path before it begins looping on source files.
11 years ago
James Tanner 993e0f057e Allow for no role dependencies in role metadata 11 years ago
James Tanner 1ef9930b80 Addresses #5341 Expand home directories when searching for roles in ansible-playbook 11 years ago
James Tanner 5d022182fe Fixes #5341 Use constants.py to set the roles directory 11 years ago
John Barker 4bf9f714d0 Fix inventory parsing so that FQDN can be parsed without throwing ssh
port parsing errors
Fixes problesm introduced by 948d019fef
Adds testcases to defend
11 years ago
jctanner ea8cd62b19 Merge pull request #5259 from mvo5/bugfix/improve-error-on-invalid-vars-file
improve error on invalid vars file (if its a list instead of a dict)
11 years ago
jeromew e4a3f49fa2 ssh_alt - only trigger 'fatal' when returncode == 255 (interpreted as 'could no connect') 11 years ago
willthames 12005a1cd0 Move more responsibility to common EC2 module
Moved `AWS_REGIONS` into `ec2` module
Created `ec2_connect` method in `ec2` module
Updated modules able to use `ec2_connect` and `AWS_REGIONS`
11 years ago
jctanner cd3144af5d Merge pull request #5178 from cavassin/devel
Prevents UnicodeEncodeError
11 years ago
James Tanner f3a4705a9c Revert "Merge pull request #4874 from leth/editable_install"
This reverts commit 15b89b45e1, reversing
changes made to 3d836a1ab7.
11 years ago
jctanner 15b89b45e1 Merge pull request #4874 from leth/editable_install
Fix setup.py to work with 'pip install -e .'
11 years ago
Sébastien Bocahu c8d5846ab9 Let merge hash_bahaviour work with dynamic inventory 11 years ago
jctanner 3d836a1ab7 Merge pull request #5247 from jeromew/ansible_ssh_alt
ssh_alt.py / decrease # of ssh roundtrips
11 years ago
jeromew 5c965a75f0 ssh_alt.py / decrease # of ssh roundtrips 11 years ago
jctanner 1679d83637 Merge pull request #5131 from janeznemanic/devel
Fix for issue #4730 - stacktrace when deferenencing a non-existent group
11 years ago
jctanner 301a1189dd Merge pull request #5122 from willthames/openlog_str
Make first argument to syslog.openlog be a string
11 years ago
Ferenc Grecu 56642f9b04 Remove unused parameter from _get_config 11 years ago
Michael Vogt bef5ee2c3b improve error on invalid vars file (if its a list instead of a dict) 11 years ago
Jesse Keating 8cef210aea Make sure ssh pipes are empty before moving on
Resolves issue #5082

Code as it was would hit a scenario where one of the FDs was not ready for
reading the first time through -- but p.poll() would show the process as
complete. This would cause ansible to continue on, while leaving some content
left in a pipe.

The other scenario -- the one that causes the unclosed quote, is if we go
through select.select() and we do get stdout in the ready for reading -- we
read from it (9000 bytes), but that's not all that is there. Again we'd get to
the p.poll() check and it would be indeed not none, but we would have left some
of stdout on the FD and thus the json blob would be malformed.

Tested with and without full ssh debugging.
Tested with and without ControlPersist
Tested with and without ControlPersist sockets already created
11 years ago
Michael DeHaan 929f8a5c93 Had to revert commits due to async. 11 years ago
Michael DeHaan 74e4ccb59b Revert "ssh_alt.py / decrease # of ssh roundtrips"
This reverts commit 7f8863f96d.
11 years ago
jeromew 7f8863f96d ssh_alt.py / decrease # of ssh roundtrips 11 years ago
jeromew db182ba498 copy ssh.py to ssh_alt.py 11 years ago
Steve Smith 5b81f88c8f Cast the retrieved `retries` var to an int before incrementing as it may be in string form.
For example, the following method of calculating the value will result in a type error:

    appstatus_waitfor: 4  # Minutes
    appstatus_delay: 5 # seconds
    appstatus_retries: "{{ mins * 60 / delay }}"
11 years ago
Wanderlei Antonio Cavassin 6ba93817a9 Avoid UnicodeDecodeError exception when passing module args 11 years ago
James Tanner bf78d8cf73 Addresses #5090 setup module was using path.is_file instead of path.isfile 11 years ago
cavassin 10f5af82f9 Prevent UnicodeEncodeError
Prevents UnicodeEncodeError: 'ascii' codec can't encode character, while printing shell commands output
11 years ago
jctanner 7aa35d64c2 Merge pull request #5091 from EspadaV8/5089_assemble_fix
#5089 hack-fix assemble module
11 years ago
Michael DeHaan 801ca96a8b Merge pull request #5152 from sivel/too-many-ps
The word skipped only has 2 p's not 3
11 years ago
Matt Martz 5f0f3566a6 Skipped only has 2 p's not 3 11 years ago
Matt Martz 8873c3675b Ensure we are looking for the right import to determine if the module_style is new. Fixes #5148 11 years ago
jctanner 2670529671 Merge pull request #5090 from dragon3/hostname_support_amazon_linux
hostname module: add support for Amazon Linux
11 years ago
James Tanner d227614529 Fixes #5109 synchronize module ssh port
Added a parameter for dest_port and also check ansible_ssh_port inventory variable.
11 years ago
jctanner 93159cb9cd Merge pull request #4996 from sivel/rax-module-utils
Implement ansible.module_utils.rax
11 years ago
Janez Nemanic 8752ae6909 Fix for issue #4730 - stacktrace when deferenencing a non-existent group 11 years ago
Will Thames 76aca4d547 Make first argument to syslog.openlog be a string
syslog.openlog expects its first argument to be a string.
Without this change running under ipython fails.
11 years ago
James Cammarata 9101c2af98 Fix traceback in template error detection code
Fixes #5081
11 years ago
Andrew Smith eed32ea70c dest_contents isn’t always defined, so don’t pass it around
I think this is also a bit of a hack since it should probably be set
before being used, I’m just not sure what it should be set to.
11 years ago
Andrew Smith e2d03173d2 The file module doesn’t have it’s module_args reset
I believe that this should be reset in the same way that the copy module
does
11 years ago