Commit Graph

343 Commits (7e1361d0e02b8e3af6d4c83fbff3aaa3a912f805)

Author SHA1 Message Date
Michael DeHaan a6aeb12c8c Merge pull request #4560 from tronner/issue4461
Fix illegal set operation in FreeBSD section of user module.
11 years ago
Michael DeHaan bc6d454b5e Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
to be reused between modules.  See library/system/service and library/system/ping for initial examples.  Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
11 years ago
James Tanner f27e2fd285 Fixes #4448 reloaded services should be started if not running 11 years ago
James Cammarata a220d7c18c Merge branch 'fix_autorized_keys' of https://github.com/mscherer/ansible into mscherer-fix_autorized_keys 11 years ago
James Cammarata 8fc62a1fb0 Fixing up authorized_keys to accept comments with spaces 11 years ago
Michael Scherer d53abc2d5e make sure that options are quoted, as people can add a shell
script there with a comma that would produce invalid configuration
upon being wrote again
11 years ago
Michael Scherer 2ad3a46e13 sort the option_key to have a constant predictable line 11 years ago
Michael Scherer 7afaeea131 adding a single comma at the end of the options list confuse the module
it start to duplicate line, because this create
a empty option in the list, and so the module add a new line along the previous
one. See

>>> ' a,b, '.strip().split(',')
['a', 'b', '']
11 years ago
Scott Sturdivant 037dcbb4da If the output of rcvar isn't a key=value pair, ignore it. 11 years ago
Eugene Archibald 6599feac47 Fixed (broken) tab to (correct) spaces for indentation 11 years ago
Michael DeHaan ce8b0944a9 Misc pep8 fixes 11 years ago
Michael DeHaan c981999975 Merge pull request #4592 from mscherer/fix_4586
setup module, replace ':' by '_' in interface name, fix #4586
11 years ago
Eugene Archibald 70c78eade0 Added ['date_time']['tz_offset'] using %z to get the time offset rather than time zone. 11 years ago
Michael Scherer 4fb753997f fix logic in module host to add aliases even if none exist already, fix #4563
self._has_aliases is used to know if a alias already exist, but
the test we want is to know if we need to add a new alias, which
is stored in self.aliases
11 years ago
Michael Scherer fa0d869ddd setup module, replace ':' by '_' in interface name, fix #4586 11 years ago
James Tanner 54781bdfe1 Fixes #4554 Enumerate user homedir if not passed as an argument 11 years ago
Thomas Ronner 3b45cb366f Fix illegal set operation in FreeBSD section of user module. 11 years ago
jctanner 6dedb68bde Merge pull request #4517 from adfinis-sygroup/devel
Remove keys regardless of the options
11 years ago
James Tanner 798dba436a Fixes #4350 Create homedirectory if create=yes and directory is missing 11 years ago
Hiroaki Nakamura 744b758633 Add support for Fedora, OpenSUSE and ArchLinux.
Tested under Fedora 19 and OpenSUSE 12.3. Not tested on ArchLinux.
11 years ago
Hiroaki Nakamura 7bd59c4b23 Do not use shortcut conditional operator which is not supported in Python 2.4. 11 years ago
James Cammarata 57cec2a88b Handle ssh key files that may only have a type/key specified
If a specified key did not have a comment, it would be ignored as
an invalid key.

Fixes #4513
11 years ago
Stefan Heinemann 576f5813a2 Set the options of an authorized key comma separated
According to the sshd man page, no spaces are permitted between the
options of an authorized ssh key
11 years ago
Stefan Heinemann 948713db5e Don't mind the options of a key when removing it
This allows to remove a key without knowing the options in the
authorized_key file
11 years ago
Michael DeHaan 377b3f4b6f Merge branch 'devel' of git://github.com/shirou/ansible into devel 11 years ago
Keith Buck 5397f90f0c Improve the formatting and content for the sysctl module's description. 11 years ago
James Cammarata 2753a40d5a Adding 'unique' option to authorized_key module and cleanup
A small refactoring of the authorized_key module to accomodate these
changes, plus fixing some things like not rewriting the file on every
new key. These changes bring the original feature for ssh options in-
line with the comments in #3798

Fixes #3785
11 years ago
David Minor 0828d3a316 Add ssh key options parameter to authorized_key module 11 years ago
James Tanner 74833f730b Fixes #4312 for older versions of usermod which do not have --append 11 years ago
Michael DeHaan beae21dd40 Remove examples of module antipattern of setting the choices array for boolean types. 11 years ago
Boris Kaul 82a89b79d6 Add support for Rich Rules in firewalld module 11 years ago
Boris Kaul 3e85f39ba7 Fix timeout bug in firewalld module 11 years ago
James Tanner 4ce2a5f8df Second attempt at preventing ipv6 route enumeration on EL4 machines 11 years ago
James Tanner bee6b544f5 Revert "Do not enumerate ipv6 routes in CentOS 4"
This reverts commit 5186c408f7.
11 years ago
James Tanner 879d20cac3 Do not enumerate ipv6 routes in CentOS 4 11 years ago
Michael DeHaan d1b9ca4427 Add documentation about how passwords are generated. 11 years ago
James Cammarata 85cd7f7500 Better detection/categorization of ipv4 secondaries/virtual IPs
Fixes #3916
Fixes #3478
11 years ago
Michael DeHaan 9771032885 Merge pull request #4389 from MattTheRat/devel
addresses #4371 - adds -m to usermod commands
11 years ago
Matt Warren f40a1e0eae addresses https://github.com/ansible/ansible/issues/4371 - adding -m to home directory modification 11 years ago
Michael DeHaan c405a61505 Merge pull request #4336 from orkaa/devel
Fixes service update-rc.d functionality on debian
11 years ago
Martijn Lina 3d16b75096 replace dashes in rc.conf keys (which are based on freebsd rc.d filenames) to underscores 11 years ago
Skylar Saveland db378d4515 fixes 4365 - Mac with cisco vpn client, GenericBsdIfconfigNetwork get_default_interfaces fails with index out of range 11 years ago
Adam Miller 8b5bb43958 fixed firewalld get_service_enabled 11 years ago
Nace Oroz 1f39663a97 Fixes service update-rc.d functionality on debian 11 years ago
cdigiovanni 6720d0cf70 Added support to disable and enable upstart jobs 11 years ago
Brian Harring 487aa9a1ec Enforce umask for cron module, so cron_file generated files are 0644.
Certain cron implementations get cranky if files in cron.* are group
writable.
11 years ago
Nils Pascal Illenseer e1ff809d1a Add option 'lz4' for compression 11 years ago
Cristobal Rosa 0cbb97bddc Added an space between code and comments in order to follow the coding standars 11 years ago
Cristobal Rosa 0b10e1d019 Added a new check to check whether an network interface is in promiscuous mode 11 years ago
James Cammarata 38487ea464 Merge pull request #4222 from lessmian/devel
Module lvol fails when decimal point is a colon
11 years ago
James Cammarata a774f686f7 Merge branch 'obsd-fix-release' of https://github.com/johanwiren/ansible into johanwiren-obsd-fix-release 11 years ago
James Cammarata 6dbb1ff878 Fixing up some open_iscsi docs and CHANGELOG update 11 years ago
James Cammarata d920cbc25f Merge branch 'open_iscsi_bis' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-open_iscsi_bis 11 years ago
Tomasz Lesniewski 0eb92ac852 Module lvol fails when decimal point is a colon 11 years ago
Rene Moser 9f969cd3ec host: minor doc style improvements 11 years ago
Tomasz Lesniewski 75ca71bf2c Module lvol fails when decimal point is a colon 11 years ago
Michael DeHaan eca73d3c82 Merge pull request #4220 from dagwieers/setup-dmidecode-fix
Fix for commented dmidecode output
11 years ago
Dag Wieers b4cdd15843 Fix for commented dmidecode output
This patch fixes the problem that on some system dmidecode prints out warning information as commented text. For example:

    [user@system ~]# dmidecode -s system-manufacturer
    # SMBIOS implementations newer than version 2.6 are not
    # fully supported by this version of dmidecode.
    HP

So we remove all commented lines from the output.
11 years ago
Rene Moser 497b742935 host: added another example 11 years ago
James Cammarata 28592ed64f Minor pep8 cleanup 11 years ago
James Cammarata d4ba1f9ded Fixing some bugs found during testing in the host module 11 years ago
James Cammarata 339f17d560 Merge branch 'feature/host' of https://github.com/resmo/ansible into resmo-feature/host 11 years ago
James Cammarata 104535ac48 Merge branch 'devel' of https://github.com/drybjed/ansible into drybjed-devel 11 years ago
James Cammarata 65180fa530 Added version_added string to new modprobe module and CHANGELOG update 11 years ago
James Cammarata 04683f554b Merge branch 'modprobe-module' of https://github.com/stygstra/ansible into stygstra-modprobe-module 11 years ago
James Cammarata aadf8175c6 Modified env fact gathering to use the native python method
Also updated CHANGELOG for this feature
11 years ago
James Cammarata d16a382935 Merge branch 'env_facts' of https://github.com/bcoca/ansible into bcoca-env_facts 11 years ago
Maciej Delmanowski 669b345937 Made re.search string shorter 11 years ago
Maciej Delmanowski fa879a63a1 Add Linux Container identification 11 years ago
Johan Wirén 9120303446 Fixed setup module to no longer break on OpenBSD release versions. 11 years ago
James Cammarata 6eec6f776e More housekeeping
* Modified version_added strings in recent modules
* Added firewalld inclusion to the CHANGELOG
11 years ago
James Cammarata 6b5b004232 Moving firewalld module from net_infra to system 11 years ago
René Moser d2d6b20d99 host: code cleanup 11 years ago
James Cammarata 3511687dad Minor tweak to service changed logic from the previous commit 11 years ago
James Cammarata 8bdb95a014 Merge branch 'service-enable-fix' of https://github.com/gottwald/ansible into gottwald-service-enable-fix 11 years ago
Petr Svoboda f82d3f7fa9 Fix traceback in service module when svc_cmd is None (2nd fix)
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

This extends fix from e2f20db534 also
for state=restarted.

Fixes issue #3533
11 years ago
René Moser 9f5d8f8482 host: updated version_added 11 years ago
Rene Moser 318c956a22 added module host
Add or remove entries in /etc/hosts using tasks:
- host: ip=127.0.0.1 hostname=localhost aliases=foobar.com,localhost.foobar.com
- host: ip=127.0.0.1 hostname=localhost state=present
- host: ip=192.168.1.1 state=absent
- host: hostname=localhost state=absent
- host: ip=::1 hostname=localhost aliases=ip6-localhost,ip6-loopback
11 years ago
David Stygstra 86d4331e3b Add Python 2.4 support to modprobe module 11 years ago
David Stygstra d6a5e05a21 Module to manage kernel modules 11 years ago
James Cammarata 7a52ad498d Merge branch 'issue_3417_systemd_stuff' into devel 11 years ago
James Cammarata 3d09c6441e Merge branch 'archlinux-fact' of https://github.com/Schnouki/ansible into Schnouki-archlinux-fact 11 years ago
r-p-e df746b4fb7 Add some more OpenBSD facts
added:
 * ansible_distribution
 * ansible_distribution_release
 * ansible_distribution_version
11 years ago
Ingo Gottwald 08af5f833f Bugfix service module: Only change service state when needed 11 years ago
Thomas Jost 725dd43fca Add Archlinux "distribution" fact 11 years ago
James Cammarata 0449470f21 Allow service module to manage services not ending in .service
Fixes #3417
11 years ago
James Cammarata 3e7511609e Slight refactorization of the sysctl module
* Added in support for freebsd-style sysctl commands
* Replaced some functionality that was provided by module_common
* Simplified some logic in a couple of places (ie, not checking
  a split with len() but instead limiting the split to 1)

Fixes #3380
11 years ago
James Cammarata 8d6e302cf8 Compare exploded values in the sysctl module to avoid whitespace errors
Fixes #3931
11 years ago
James Cammarata 5fe192e5e7 Fixes to the service module for Ubuntu 12.04 (LTS)
Fixes #3615
Fixes #3572
11 years ago
James Cammarata 5e8918cb2c Check for systemd ownership of a service even if an init.d script exists
Also slight modification to the error message in the earlier commit that
modified the update-rc.d detection portion of the code

Fixes #3474
11 years ago
James Cammarata ef02c6107a Minor fix to account for template service names in systemctl 11 years ago
James Cammarata f22ffab259 Fix for update-rc.d based systems that also have systemd installed
By default, the service module had assumed that if the system had the
update-rc.d binary, the service was either managed via upstart or standard
sysV init-style scripts. This patch adds a check for systemctl ahead
of the other methods when update-rc.d is detected, and also simplifies
the logic around the detection of systemctl-managed services
11 years ago
James Laska 5dc830c279 The required package for selinux is libselinux-python 11 years ago
Brian Coca 849d7b282b Added collection of user's env
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
James Cammarata 21ae255fb3 Merge branch 'aix_wpar_facts' of https://github.com/mplonka/ansible into mplonka-aix_wpar_facts 11 years ago
James Cammarata 17f683aad7 Added 'reloaded' state to list of states checked for bounced services
Fixes #3556
11 years ago
Serge van Ginderachter 129fa6689f Introduce open-iscsi module to manage targets on the initiator. 11 years ago
Raul Melo b0ffba472f Fix issue 3908. There was some ilegal operations over the sets 11 years ago
James Cammarata b4306920ce Fix for the cron module on FreeBSD
Apparently crontab on freebsd does not like the file path coming before
the "-u username" portion of the command to install the crontab
11 years ago
Hiroaki Nakamura 2bef08705f Fix a bug in DebianStrategy.get_permanent_hostname(). Use strip, not split! 11 years ago
Hiroaki Nakamura bf21ba1521 Rewrite with "try ... finally" instead of "with" statement to support Python 2.4. 11 years ago
Hiroaki Nakamura 860cf75fdc Remove extra sysloggings. 11 years ago
Hiroaki Nakamura 14fde81ad5 Raise an error on unsupported platform/distributions. 11 years ago
Hiroaki Nakamura 557c25a794 Add a hostname module, which sets system's hostname. 11 years ago
Marcin Płonka 4a43bb3b00 Skipping facts not available on AIX WPARs 11 years ago
shirou 26e6ac4340 supports nested values of ohai. 11 years ago
Michael DeHaan 003c86e250 Merge branch 'fix_service_with_initscript' of git://github.com/psvo/ansible into devel 11 years ago
Andy Wilson 85e34cc107 docfix: grammar in docstring for sysctl module 11 years ago
Petr Svoboda 48b064b55b Fix traceback in service module when svc_cmd is None
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

Fixes issue #3533
11 years ago
Michael Scherer bb9d0a9493 Add urpmi as a package manager for mandriva-based distribution 11 years ago
James Cammarata 494030aa6c Removing skipped=True so the task is just marked as not-changed 11 years ago
James Cammarata f3384374b9 Set result to skipped when vol group is missing and lv state=absent
Fixes issue #3714 - lvol module state=absent fails (with error) if
the volume group doesn't exist
11 years ago
rishid fea38f44ac Verify groups string is not empty before trying add user to groups 11 years ago
Brian Coca e8e8779dfa fixed bug from prev update
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 2c06418f6d whitespace updates on new lines
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca fe57037f84 now uses get_bin_path for lvg executables
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 5b80299231 Make exceptions handling python 2.4 compatible. 11 years ago
Michael DeHaan ecf074865f Continue on mount errors, don't fail the setup module. 11 years ago
Brian Coca 220fe24d39 use global to fail as its not in self
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 3f4c6affa3 Update CHANGELOG 11 years ago
Michael DeHaan 9ebde16e3a Merge branch 'iss_cron' of git://github.com/dirtyharrycallahan/ansible into dh_cron 11 years ago
Michael DeHaan 4281f773bb Merge pull request #3602 from bcoca/fine_tune_stat_exception
narrowed down exception
11 years ago
Michael DeHaan 517c318989 Merge pull request #3470 from langemeijer/devel
Only append non_unique parameter if a uid is provided as well to user module
11 years ago
Brian Coca 7132f7e792 narrowed down exception we ignore and fail if any other unexpected one
crops up.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Florian Tham 865a663d05 fix fatal error when removing logical volumes 11 years ago
Antti Rasinen f9e9286b2c Make zfs set_property accept values with embedded spaces
Converting the argument list to a string with ' '.join causes
the shell interpreter to misparse spaces in property values.
Since the zfs command does not need shell anywhere, using
a list instead of a string works just as well with run_command. 

Fixes #3545.
11 years ago
Antti Rasinen 8bfe9f6942 Fix zfs property parsing
Current property parser breaks when values contain spaces. Since
zfs get -H returns tab separated lines,  it is better to explicitly
split on tabs than on whitespace.
11 years ago
trbs 98b284159f fix missing json module for issue #3363 print JSON error as string instead 11 years ago
Brian Coca dd1ffce0a0 now won't throw exception if we don't have permission to stat a mtab
entry on linux (weird chromebook issue)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan b22428d87e Merge pull request #3426 from trbs/services_sleep_option
sleep option for service module which adds a pauze between stopping and ...
11 years ago
Michael DeHaan 7dfafc6ec4 Merge pull request #3496 from johanwiren/bsd-ipv6-facts
Fix for populating default_ipv6 on BSD systems
12 years ago
Michael DeHaan 38ac6c9abd Merge pull request #3497 from johanwiren/bsd-gateway
Updated setup module to collect gateway fact for BSD systems
12 years ago
Michael DeHaan 03605484f8 Merge pull request #3388 from bcoca/fixed_user_create_doc
updated module docs to reflect 'correct' on_create vs on_creation
12 years ago
Johan Wirén 3e765f7775 Updated GenericBsdIfconfigNetwork to collect gateway 12 years ago
Johan Wirén a03125e0cf Fix for populating default_ipv6 on BSD systems 12 years ago
Joshua Lund d75f73fffe Added a new with_file example to the authorized_key documentation 12 years ago
Patrick Callahan f37becb94a Bug fixes and enhancements.
Bugs:
(1) no longer allow empty jobs
(2) strip the header added by crontab package used in openSuSE and SuSE
(3) try not to leak temp files when things go wrong
(4) issue returning job names under certain conditions

Enhancements:
(1) Allow all special times not just reboot.
(2) Fail earlier by performing more input validation
(3) Add feature to allow removing cron file under /etc/cron.d

ToDo:
(1) Validate times (minute, hour, ...)
(2) Strip white space from fields such as name and job such that name=foo equals name=' foo'.
(3) More testing
12 years ago
Brian Coca e0e50b5936 fixed check mode
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Casper Langemeijer 8727f0ce11 Only append non_unique parameter if a uid is provided as well 12 years ago
Aaron Brady 34617476d0 Make the CPU facts Hyperthreading aware 12 years ago
trbs 0d8da6eeb0 sleep option for service module which adds a pauze between stopping and starting a service using state=restarted. This helps for bad scripts that exist immediatly after signaling a process to stop. 12 years ago
Antti Rasinen c2a4645349 Fix service enable on FreeBSD
Some services have a knob (i.e. rc.conf setting) whose name
differs from that of the script. For example, lockd process
is controlled with a script called lockd, but the rc.conf
value is rpc_lockd_enable.

Fixes issue #3382.
12 years ago
Brian Coca b494d6d2ae updated module docs to reflect 'correct' on_create vs on_creation
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan 8d23df3576 Merge pull request #3315 from madduck/fix-service-updatercd-changed
Let update-rc.d set changed flag properly
12 years ago
Michael DeHaan da0e718698 Styling: semicolon 12 years ago
Michael DeHaan 936ad65726 Styling: blank lines 12 years ago
Serge van Ginderachter fc01f88228 add more support for different size formats 12 years ago
martin f. krafft 3b7b061b07 Expand usage of Python 2.6 if statement
Syntax like "'foo' if bar else 'baz'" is not supported by all Python
versions targetted by Ansible. Hence we break it up.

Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
martin f. krafft 22b30b9281 Let update-rc.d set changed flag properly
When update-rc.d is used to enable/disable service, the changed flag was
always true (see #2189). This commit fixes that.

Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
Michael DeHaan 997bf64f3f Fix up some module docs formatting errors. 12 years ago