Commit Graph

16352 Commits (7b64126c9d83f7201453c128c69f9fcdac082cdb)
 

Author SHA1 Message Date
Borys Borysenko 6b396cdab7 fix code block quoting and boldface for modules name 9 years ago
Chris Church 904b8ca27b Update win_msi tests to specify msi url and paths via variables. 9 years ago
Chris Church 0300294f6e Add tests for creates parameter to win_msi module. 9 years ago
gptech 1c6be7b9ba Replace 'degug' with 'debug'
Tiny typo fix.
9 years ago
Brian Coca 97b99e4517 Merge pull request #12361 from Ch00k/os_docs_typo
Fix a tiny typo
9 years ago
Andriy Yurchuk af213241ab Fix typo 9 years ago
Brian Coca e7807c4f2d Merge pull request #12339 from emonty/feature/openstack-no-log
Add no-log parameter to common openstack args
9 years ago
Brian Coca e342e1df29 Merge pull request #12360 from Yannig/devel_fix_ini_doc
Fix ansible v2 documentation for ini lookup plugin
9 years ago
yannig.perre@gmail.com 54eb08eb0d Fix ansible v2 documentation for ini lookup plugin (property => properties). 9 years ago
James Cammarata 4f30db8ca5 Check if path is /dev/null when checking if a file is in fact a file 9 years ago
Chris Church 260b9f648c Fix fetch action plugin to not fail if file is missing and fail_if_missing=False (the default). Add tests to test_fetch role to verify it works as expected. 9 years ago
James Cammarata 36b5858f51 Fix unit tests for change related to local_action 9 years ago
James Cammarata feee4613cd Merge pull request #12357 from apollo13/become_fix
Fixed #12356 -- Restored ansible 1.9.x become behavior.
9 years ago
James Cammarata 49ca0eb797 Track local_action internally to prevent it from being overridden
Fixes #12053
9 years ago
Florian Apolloner 8182eb3787 Fixed #12356 -- Restored ansible 1.9.x become behavior. 9 years ago
Brian Coca d8b671ca76 Merge pull request #12348 from bborysenko/docsite/playbooks_intro
docsite - playbooks_intro - minor tweaks
9 years ago
Brian Coca 0f5133b657 Merge pull request #12336 from halberom/doc_fix_filters
docsite - playbooks_filters - minor tweaks
9 years ago
Borys Borysenko 4064063794 use boldface for modules name 9 years ago
Borys Borysenko f5cfb5577e fix code block quoting 9 years ago
Marius Gedminas 9877a5c415 Python 3: two more instances of 'basestring'
Fixes two failing tests on Python 3.4.
9 years ago
Monty Taylor 3bdd6793ca Add no-log parameter to common openstack args
These bad boys can contain secret data, so should be marked no-log.
9 years ago
Gerard Lynch e5211a9b18 playbooks_filters - minor fixes 9 years ago
James Cammarata f0efe1ecb0 Merge pull request #12334 from geerlingguy/changelog-fixes
Clean up Ansible 2.0 release notes in CHANGELOG.md.
9 years ago
James Cammarata aa762bb432 Don't split args out unless we're parsing module args using the new style
Fixes #12331
9 years ago
James Cammarata 1cb4e0be1c Fix bug in implicit block squashing where block is not reassigned
Fixes #12333
9 years ago
James Cammarata 7deb8bbd1c Reworking how includes within handlers are run
Fixes #12238
9 years ago
James Cammarata c9860000da Uncommenting sample line in include.yml to help debug issues 9 years ago
Jeff Geerling 0857e29e77 Clean up Ansible 2.0 release notes in CHANGELOG.md. 9 years ago
Brian Coca 03758151e4 Merge pull request #12330 from cchurch/revert_find_plugin_changes
Revert "Fix order of loading of modules."
9 years ago
Brian Coca 9d4d7bd74d fixed porting bugs in profile_tasks to v2 9 years ago
Chrrrles Paul ba7734b78b Merge pull request #12165 from amenonsen/address-parsing
Hi @amenonsen - thanks for fixing up the hunting down the unicode bug and expanding test_addresses.  The code looks good, merging!-- Be systematic about parsing and validating hostnames and addresses
9 years ago
James Cammarata 4156bcedf5 Fix typo in 049a48f 9 years ago
Chris Church ed3a9795d4 Revert "Fix order of loading of modules."
This reverts commit 4b895f04e3.
9 years ago
James Cammarata 1243686b90 Submodule update 9 years ago
James Cammarata 6cf99cf614 Merge pull request #12328 from amenonsen/noneguard
Test state.tasks_child_state before dereferencing
9 years ago
Abhijit Menon-Sen 049a48f3d3 Test state.tasks_child_state before dereferencing
I hit a traceback in the FAILED_TASKS case, but it seemed prudent to add
guards in the other similar branches.
9 years ago
James Cammarata df89f03627 Fixing precedence order for new nonpersistent vars (set_fact/register)
These used to go in vars_cache, so merging them in after that as they
are "live" variables and the user would most likely want to see these
above anything else.
9 years ago
Abhijit Menon-Sen 88a20e7a20 Fix broken integration test with unicode hostnames
1. The test did "name: '{{hostnames}}.{{item}}'" inside a with_sequence
   loop, which didn't do what was intended: it expanded hostnames into
   an array, appended ".1", and set name to the resulting string. This
   can be converted to a simple with_items loop.

2. Some of the entries in hostnames contained punctuation characters,
   which I see no reason to support in inventory hostnames anyway.

3. Once the add_host failures are fixed, the playbook later fails when
   the unicode hostnames are interpolated into debug output in ssh.py
   due to an encoding error. This is only one of the many places that
   may fail when using unicode inventory hostnames; we work around it
   by providing an ansible_ssh_host setting.
9 years ago
Abhijit Menon-Sen 7479ab47e0 Be stricter about parsing hostname labels
Labels must start with an alphanumeric character, may contain
alphanumeric characters or hyphens, but must not end with a hyphen.
We enforce those rules, but allow underscores wherever hyphens are
accepted, and allow alphanumeric ranges anywhere.

We relax the definition of "alphanumeric" to include Unicode characters
even though such inventory hostnames cannot be used in practice unless
an ansible_ssh_host is set for each of them.

We still don't enforce length restrictions—the fact that we have to
accept ranges makes it more complex, and it doesn't seem especially
worthwhile.
9 years ago
Abhijit Menon-Sen 065bb52109 Be systematic about parsing and validating hostnames and addresses
This adds a parse_address(pattern) utility function that returns
(host,port), and uses it wherever where we accept IPv4 and IPv6
addresses and hostnames (or host patterns): the inventory parser
the the add_host action plugin.

It also introduces a more extensive set of unit tests that supersedes
the old add_host unit tests (which didn't actually test add_host, but
only the parsing function).
9 years ago
James Cammarata 49803509b4 Make sure include paths are templated before dwim in case they're absolute
Fixes #12327
9 years ago
James Cammarata 4cdd9b2a82 Merge pull request #12318 from mgedmin/py3k
Python 3: make ansible.template.safe_eval() work
9 years ago
Brian Coca 52f587cac3 Merge pull request #12325 from quinot/topic/wrong_interp_test
Test for Python must be against basename of interpreter
9 years ago
James Cammarata c2115c3715 Re-adding part of 926f127 which was actually fixing #12277 9 years ago
James Cammarata 083aef65ad Revert "set_fact should put facts in the fact_cache, not vars_cache"
This reverts commit 926f127245.
9 years ago
Thomas Quinot 0bc9223826 Test for Python must be against basename of interpreter
Followup on issue #12076
9 years ago
James Cammarata 441a8af671 Merge pull request #12267 from h-hirokawa/add_replacer_jsonargs
Add the new module replacer <<INCLUDE_ANSIBLE_MODULE_JSON_ARGS>>.
9 years ago
Marius Gedminas f91b28ef23 Fix safe_eval() of set literals
There was code to support set literals (on Python 2.7 and newer), but it
was buggy: SAFE_NODES.union() doesn't modify SAFE_NODES in place,
instead it returns a new set object that is then silently discarded.

I added a unit test and fixed the code.  I also changed the version
check to use sys.version_tuple instead of a string comparison, for
consistency with the subsequent Python 3.4 version check that I added in
the previous commit.
9 years ago
Marius Gedminas 2b73002044 Python 3: make ansible.template.safe_eval() work
Two things changed in Python 3.4:

- 'basestring' is no longer defined, so use six.string_types

- True/False are now special AST node types (NamedConstant) rather than
  just names

(Good thing we had tests, or I wouldn't have noticed the 2nd thing!)

I found only one place where safe_eval() is called inside the ansible
codebase: in lib/template/__init__.py.  The call to safe_eval(result,
...) is protected by result.startswith('...'), which means result cannot
possibly be a byte string on Python 3 (or startswith() would raise, so
six.string_types (which excludes byte strings on Python 3) is fine here.
9 years ago
James Cammarata 0c5bbe3c32 Use the original (un-templated) args for include params
Fixes #12314
9 years ago