Commit Graph

3079 Commits (7a86083850b1fddd696fc429dd990399da42c242)

Author SHA1 Message Date
Alan Fairless 7a86083850 Fix postgresql_user to understand PG namespaces
Previously postgresql_user quoted user supplied identifers to create
grant statements that look like this:

    GRANT SELECT on "tablename" to "user";

Which only works if the tablename is not in a namespace.  If you supply
a namespaced tabelname like "report.revenue" then it creates this
incorrect statement:

    GRANT SELECT on "report.revenue" to "user";

Which will not find the "revenue" table in the "report" namespace, but
will rather look for a table named "report.revenue" in the current
(default public) namespace.  The correct form is:

    GRANT SELECT on "report"."revenue" to "user";

This approach could have the unfortunate effect that code that
previously relied on the other behavior to grant privileges on tables
with periods in their names may now break.  PostgreSQL users
typically shouldn't name tables as such, and users can still access the
old behavior and use tablenames with periods in the if they must by
supplying their own quoting.
11 years ago
Michael DeHaan e0cd4a45c6 Merge pull request #5489 from daghoidahl/devel
Use "brew list <name>" instead of grepping the output of "brew list". Fix for #5488
11 years ago
Paul Beattie e96377685e Fixed typo in example documentation 11 years ago
James Tanner 191be7b951 Resolves issues with newer versions of pip not having a --use-mirrors paramater for the install command 11 years ago
Dag Høidahl 279098bd03 Use "brew list <name>" instead of grepping the output of "brew list".
Some brew packages are not listed with their package name, e.g. libjpeg.
11 years ago
jctanner 89abc35e59 Merge pull request #5167 from jaspernbrouwer/devel
service_module: Fixed false positive on initctl as enable_cmd
11 years ago
Michael DeHaan 2f811c40d7 Basic docsite formatting fixups 11 years ago
James Tanner 86719ce77f Fixes #5040 setup module: do not add primary interface info to the secondary interface data 11 years ago
Michael DeHaan 99616d0c80 Pass scrub_data by default, see response from DO here: https://www.digitalocean.com/blog 11 years ago
Michael DeHaan d4cd1fba8b add a note about raw/endraw 11 years ago
Jim Kleckner edca1d69cf Fix documentation example for the fail module
The example for the fail module doesn't work:
  http://www.ansibleworks.com/docs/modules.html#fail

The current text shows:
    - fail: msg="The system may not be provisioned according to the CMDB status."
      when: "{{ cmdb_status }} != 'to-be-staged'"

The "when" documentation indicates that the argument is already a Jinja2
expression:
  http://www.ansibleworks.com/docs/playbooks_conditionals.html#the-when-statement

Thus, the following is
      when: cmdb_status != "to-be-staged"

is preferred even though the following could work but generates a
deprecation warning:
      when: {{cmdb_status != "to-be-staged"}}
11 years ago
Mikhail Sobolev 8733b5da8b fix short/full description for elasticache 11 years ago
Michael DeHaan cfcdc3403e Use task names in examples. 11 years ago
Michael DeHaan 4765032fcb Merge branch 'devel' of git://github.com/beefsalad/ansible into devel 11 years ago
Michael DeHaan 1260225fc9 Merge pull request #5427 from bcoca/template_docs2
added more usefull example for jinja2 overrides
11 years ago
beefsalad 5b2fda6fa6 added descriptions for yum options
Updated main description to state that the yum module will handle package groups.  Added descriptions for each example, as it is unclear to (some) users that @Name implies a group install.
11 years ago
Brian Coca 488ef22f5e added more usefull example for jinja2 overrides (this one is actually
used)

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Maykel Moya 0711447d3a Missing "is" in file module description 11 years ago
Michael DeHaan e8d9f58949 Merge pull request #5419 from stoned/shell-module-doc-fix
shell module: document removes option and sync with command module doc
11 years ago
Michael DeHaan 0bdf615612 User report of DO not taking underscores so tweaking docs 11 years ago
Michael DeHaan aa8beadec3 Fix a documentation item. 11 years ago
Stoned Elipot b85743e228 shell module: document removes option and sync with command module doc 11 years ago
Jasper N. Brouwer a52ca73167 Swapped conditions of the changed if statements 11 years ago
Peter Salvatore 12cb1afdc8 fix typo in synchronize module 11 years ago
Michael DeHaan 3f81c3c416 Merge pull request #5162 from JensRantil/fix-corrupt-module-outputs
More don't catch `SystemExit`
11 years ago
willthames 46a5f8c656 Make state=present the default for ec2_tag
Using `ec2_tag` module without the state argument
currently results in:
```
failed: [127.0.0.1] => {"failed": true, "parsed": false}
```
This fix makes `state=present` the default
11 years ago
jctanner d3f94fe606 Merge pull request #5303 from mohangk/rds_postgres
Adds postgres support for Ansible RDS module
11 years ago
jctanner 320d41149a Merge pull request #5289 from rstrox/devel
rax: import novaclient.exceptions for cs.images.find
11 years ago
jctanner 4209b8a953 Merge pull request #5203 from sivel/irc-rfc-loops
Improve IRC module. Fixes #5186
11 years ago
jctanner 93c15a41dc Merge pull request #5274 from veeti/easy_install_chdir
Fix permission error when using easy_install through sudo
11 years ago
jctanner 53a3671df4 Merge pull request #5160 from JensRantil/fix-issue-5159
Fixes #5159 `file` module: Don't catch `SystemExit`
11 years ago
jctanner 7182486fd2 Merge pull request #5099 from tartansandal/postgresql_db_check_mode
postgres_db CHECKMODE changed status
11 years ago
Troy C 038d030404 catch exposed cs.exceptions instead of novaclient 11 years ago
Mohan Krishnan 1dd2510e76 Adds postgres support for Ansible RDS module 11 years ago
Troy C 3007a8af7e import novaclient.exceptions for cs.images.find
cs.images.find(human_id= throws novaclient.exceptions.NotFound,
resulting in the try/except block with
image = cs.images.find(name=image)  being skipped. catching
novaclient.exception.NotFound allows images to be specified with the
human readable name.

Example:
  tasks:
    - name: Server build request
      local_action:
        module: rax
        region: DFW
        image: Ubuntu 12.04 LTS (Precise Pangolin)

Also, the import is placed after try: import pyrax, because pyrax
imports novaclient and should fail if novaclient is missing.
11 years ago
Jens Rantil 1b6019f6e0 module(file): Fail instead of exit on exception 11 years ago
Jens Rantil f4aa808b8d module(file): state what went wrong on exception 11 years ago
jctanner 91f903eabe Merge pull request #4886 from sergeyhush/devel
fix when the system does not have lsb_release script, but has /etc/lsb_release file
11 years ago
James Tanner f55270e746 Set version_added for new_instance_name in cloud/rds module 11 years ago
jctanner b9cb49e638 Merge pull request #4872 from timurbatyrshin/4869-old-python-apt-fix
#4869 compatibility with older versions of apt
11 years ago
jctanner 66cad764d2 Merge pull request #5028 from retr0h/correct-nova-api-auth-check
Nova doesn't attempt to auth on obj instantiation
11 years ago
jctanner 53c5b1d934 Merge pull request #4949 from eest/openbsd_pkg-rework-name-parsing
openbsd_pkg: rework package name parsing.
11 years ago
jctanner dc41912158 Merge pull request #5213 from dalevizo/devel
Add get_dmi_facts in setup for FreeBSD systems using dmidecode
11 years ago
jctanner 6051ee0df5 Merge pull request #5052 from bpennypacker/promote_rename
cloud/rds module: added promote command & updated modify command to allow for renaming of database instances.
11 years ago
James Tanner 35cd043e25 Addresses #5276 update documentation for ec2_ami no_reboot parameter 11 years ago
evan82 01e8390a8f Fix ec2_ami no_reboot setting (currently it will not reboot instances to create the AMI)
Line 276: no_reboot = dict(default=True, type="bool"),

This should really default to False (When AMIs are created the machine will reboot before copying the disk).

"When enabled, Amazon EC2 does not shut down the instance before creating the image. When this option is used, file system integrity on the created image cannot be guaranteed."
11 years ago
jctanner 1688a7c776 Merge pull request #5231 from jeffnappi/patch-1
Corrected documentation in ec2_ami module - no_reboot defaults to yes
11 years ago
Veeti Paananen fa90f31cc8 Fix permission error when using easy_install through sudo
Same as b2542bff72.
11 years ago
Jim Dalton aa329b4b48 Make sure initial_state is initialized 11 years ago
Jim Dalton ac1e84d976 Account for instances that have not yet been registered. Fixes #5076 11 years ago