Commit Graph

32471 Commits (791a0292034028015e5a85fc050c392bf3a6677c)
 

Author SHA1 Message Date
Matt Clay a31f4c178a Fix pep8/pylint tests when deleting files. (#28410)
* Fix pep8/pylint tests when deleting files.
* Improve static analysis in PyCharm.
* Use success instead of skipped for explain.
7 years ago
Konstantin Shalygin 343da35381 mail: Fix auth over starttls. (#24089) 7 years ago
Peter Sprygada 03b888052b fixes bugs in network filter for parsing ip address (#28404)
also adds parse_cli and parse_cli_textfsm to changelog
7 years ago
Gaige B Paulsen 54c50cc983 netconfig module updated to pay attention to .ssh/config (#23876) 7 years ago
Sloane Hertel b9762b52af s3_sync was setting HAS_BOTO3 by the existence of botocore alone. Fixes #28023 (#28339)
* s3_sync was setting HAS_BOTO3 by the existence of botocore alone. Fixed to import from module_utils.ec2 to ensure boto3 + botocore are present.

Also documented module requirements.

* Remove unused import
7 years ago
Matt Clay f8d6c71d09 Remove deleted files from legacy-files.txt. 7 years ago
Bobby Watson 8e8a7c869a Changed string check to verify that EOS device is not in config mode. (#28332)
Changed string check to verify that EOS device is not in config mode. This was required in order to work with Arista 7500 series modular switches.
Resolves #2830
7 years ago
Chris Alfonso bd56e6c9ce Removing deprecated openswitch modules (#28397) 7 years ago
Adrian Likins 2941e86671 Fix plugin_formatter.py -l / MODULES=none make webdocs
Fix the get_module_info check against the limit_to_modules
list so building a subset/none of the module docs works again.
7 years ago
Doug Gorley 5e6984a34c Added support to GCE module for image families and external projects. (#26711)
* Added support to GCE module for image families and external projects.

* Added image_family and external_projects to gce_pd.

* Added version_added for new options.
7 years ago
Nathaniel Case db5d799122 Fix nxos_pim idempotence (#28348) 7 years ago
welchwilmerck af40d04247 bring comments and docs up-to-date for invoking hacking/test-module (#20940)
inside test-module, rundebug also needs to know interpreters
7 years ago
TaoBeier be6c4908a2 executor stats and task_executor pep8 error (#23651) 7 years ago
Abhijeet Kasurde 6fd579b9f5 Refactor DigitalOcean modules
Fix adds refactoring of DigitalOcean modules by adding
common functionality to module_utils.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Sam Doran f35975f114 PEP8 fixes 7 years ago
Peter Hoffmann 6c9cb05cfd Use tenant in UserPassCredentials if set.
If you have multiple Tenants you need to set the tenant in https://github.com/Azure/msrestazure-for-python/blob/master/msrestazure/azure_active_directory.py otherwise the azure_rm.py call will fail.
7 years ago
Achraf Cherti e45d5b7e8e Compatibility of gce.py (Google Cloud Ansible inventory) with Python 3 (#26032)
* Compatibility of gce.py (inventory) with Python 3

* Revert './secrets.py' file check (will import 'secrets' from PYTHONPATH)

Instead of checking if secrets.py exists in the current directory, this
commit will make gce import 'secrets' from one of PYTHONPATH's paths.

There are 2 possibilities:
1. secrets.py will be used if secrets.GCE_PARAMS and
secrets.GCE_KEYWORD_PARAMS are declared.

2. secrets.py will be ignored if secrets.GCE_PARAMS and
secrets.GCE_KEYWORD_PARAMS aren't declared. This could happen in Python
>=3.6 where a module named 'secrets' could be imported if a custom
secrets.py doesn't exist in PYTHONPATH.
Check out https://www.python.org/dev/peps/pep-0506/ and
https://docs.python.org/3/library/secrets.html for more information.
7 years ago
Ganesh Nalawade 9ab9945cf3 iosxr modules aggregate check and other minor refactor (#28360)
*  iosxr aggregate validation
*  vyos_user, junos_user minor changes
*  Aggregated documentation
7 years ago
Ganesh Nalawade ceef4f97ed Use merge operation for load configuration in junos modules (#28369)
*  Change load configuration operation from replace to merge
7 years ago
Toshio Kuratomi bc66faa328 Add more tests for copy/file/template with harlinks 7 years ago
Andrew Erickson 2b14fdbce3 add test for template, file, and copy with hardlinks 7 years ago
Mehran Kholdi ecfa7f696d Enforce `state='file'` in `copy` module
This was causing wrong behaviour when `prev_state` was `hard`-link,
since the `file` module tried to apply the same `state` on the new
file, causing unexpected errors.

Particularly, both `overlay` and `devicemapper` storage drivers in
docker use hardlinks to share files between layers. This causes
most ansible playbooks to fail when working with files from layers
below.
7 years ago
Dag Wieers 78dfbed2a5 openbsd_pkg: Fix when failed, PEP8-compliant (#26018)
This PR includes:
- PEP8 compliancy
- A fix to ensure the module fails when it failed for a package
- Various cosmetic changes to documentation
- Make `state: present` the default (and not required)
7 years ago
Sam Doran 9fe898add6 Make options match others in the file 7 years ago
Kurt Bomya 05fd51f77d Added "choices" true/false for user_install 7 years ago
Julien Stroheker 0b29162b97 Azure Availability Set module (azure_rm_availabilityset) (#28353)
* Adding the module and int. tests

* upgrading metadata to 1.1
7 years ago
Sergio Millan 400085aa5b return EXCL_STATE when color property is not in the response 7 years ago
Artem Loginov 6e8eb7612a Fixed issue with legacy jenkins instances 7 years ago
Filipe Azevedo 6868c892ed Fixes https://github.com/ansible/ansible-modules-extras/issues/2462 (#21891) 7 years ago
Adrian Likins 01c0b2f714 Handle errors in jmespath in json_query better (#22109)
* Handle errors in jmespath in json_query better

Catch any exceptions raised from jmespath and raise
an AnsibleFilterError instead.

Avoid a traceback.

Fixes #20379

* pep8
7 years ago
Ricardo Carrillo Cruz d3ecf3efb7 Remove user auth tests (#28364)
They are breaking CI, as they are SSHing with a non IP address.
Removing for now, we can think of other strategies for this later.
7 years ago
Sam Doran 8e18a2d6ee Update maintainers for mount.py (#28362) 7 years ago
Lukas Beumer eebc0cea6e [cloud][gcp] Add region and versioning parameter to gc_storage (#27802) 7 years ago
John Bond 722579356d correct handeling of execute option (#23814) 7 years ago
Nihlaeth e5ff8e3407 Don't remove comment from public key, and improve error message for duplicate keys (github_key) (#22282)
* improve error message for duplicate public keys

* don't consider self when searching for duplicates

* don't strip comment from key
7 years ago
Antony Messerli e0d0446183 Updates lldp module example to use ifname instead of ifalias (#23064) 7 years ago
Anthony Arnaud 3da1036baa zfs bad volume block size #23090 (#23092) 7 years ago
Elachance 7b8b444602 Fix logic in os_nova_host_aggregate module (#23191)
* Fix logic in os_nova_host_aggregate module

Fix logic around adding availability zone to metadata and comparing existing host list to parameter host list. 

Previously, when no availability zone was defined, an empty availability zone was being appended to metadata. This was causing 'empty named availability zone' errors when running the module against an already existing host aggregate with no availability zone. This was fixed by only appending availability zone to metadata if it is not an empty parameter.

Also added set() casting when comparing existing and new host lists. Previously, if existing host list was not in the same order as the host list in the .yml parameter file the module would consider this a change even if the two lists had the same entries.

* Update os_nova_host_aggregate.py
7 years ago
Michael Leer ce2c14757d the use of --puppet has been deprecated (#23356) 7 years ago
Sloane Hertel 25a9ababcc ec2.py: filter by client-token if id is specified (#26114)
fixes #26021
7 years ago
Sloane Hertel 1300680d30 [cloud] Cast port to an integer in elb_application_lb listener spec (#28341) 7 years ago
Matt Clay 8e0b5800b7 Miscellaneous ansible-test fixes. (#28355)
* Include .github in test targets. Fix BOTMETA.yml.
* Include bin in compile tests.
* Exclude links from test targets.
* Include bin in pep8 and pylint tests.
* Fix pep8 and pylint issues in bin dir.
7 years ago
Dag Wieers e801187899 Bugfix and assorted fixes (#28352)
These are updates from aci-ansible.
7 years ago
disappear89 d4cedbee20 nmcli: Changed parameter ordering in create_connection_bond (#23571)
nmcli: Changed parameter ordering in create_connection_bond
7 years ago
Jun Guo 655667527d [docker] Fix ignore_image option not work issue. (#19039)
Currently the ignore_image option can be set, but can not work as it is
descripted in document. The reason is the code will check the difference
of configurations between current container and target image, and it
will mark the `different` to `True` when the image is different even we
set `ignore_image=true`, that will cause the container being re-create.
7 years ago
Simon Dodsley e7b0849886 Fix incorrect bool check in Pure Storage modules (#28007) 7 years ago
jctanner f4e93ccc1a Fix the authors in pure storage modules so the bot can ping the right users. (#28347) 7 years ago
David Moreau-Simard e9d6d37589 Update release status for 2.3 to 2.3.2 7 years ago
Matt Clay 66fa46fdda Update ansible-test change classification. (#28345) 7 years ago
jctanner 83ac480241 Correct the formatting for azure_rm's maintainers (#28346) 7 years ago