Commit Graph

24069 Commits (77f5472a53546cfc38bf9520ee36229f67d49069)
 

Author SHA1 Message Date
Lucas Costa Beyeler 6aeea1fe7e Fix #4202: Can't unarchive remote files (#4244)
When you try to remote unarchive files with the option copy=no the code always fail, as evidenced in issue #4202. That happens because the conditional to check "if remote_src=no or copy=yes" will always be true since the default value of them is remote_src=no and copy=yes.
My modification is only to change the condition from or to and, that way only if both the vars stay with the default value will be true, otherwise you can unarchive remote files.
8 years ago
Brian Coca 16ccde49ad remove X bit 8 years ago
jctanner 634b1024d6 git: save changed submodules in check and non-check mode (#4392) 8 years ago
Dag Wieers 4ee9cc4b3f Add diff mode support to git module (#3364)
* Add diffmode support to git module

This patch adds missing diffmode support to the git module.

* Remodel get_diff() and calls to it

As proposed by @abadger

* Ensure we fetch the required object before performing a diff

Also we handle the return code ourselves, so don't leave this up to run_command().
8 years ago
Indrajit Raychaudhuri fb255b3607 Improve hostname module to support systemd in more generic way (#4382)
Now that there is general purpose `Fact` helper to detect if systemd
is active, we would be able to rely on that to apply SystemdStrategy.

Detecting presence of systemd at runtime would be more reliable than
distribution version based heuristics. (e.g., Debian, Ubuntu allows
user to change the default init system, Gentoo allows switching as
well, and so on).
8 years ago
Brian Coca ab3a87cc1a improved logic when dealing with init scripts 8 years ago
Brian Coca 3c89a21e0c fixes corner case for systemd services
when both unit file and sysv init script exist
Thanks to @olfway for fix.

fixes #3764
8 years ago
Dag Wieers fe273a4e09 Improve the documentation (#4385)
Improvements to make it more clear that pure compressed files (.gz, .bz2 and .xz) files are not supported.

This improves on #3241.
8 years ago
Sam Doran 4c6cfb9eec Improve regexp for matching file permissions (#4306)
A capital "S" appears when the the setuid or setgid bit are set but have no effect. Likewise, a capital "T" appears when the sticky bit is set but it has no effect.
8 years ago
Roman 7b547e3e0b get_url headers param values parsing (#4245) 8 years ago
Evan 7b66bdc1c4 pip: Fix uninitialized variable during check_mode (#4379)
During check_mode (`--check`), the variable change could be
used uninitialized, yielding this error:

`UnboundLocalError: local variable 'changed' referenced before assignment`

This changeset simply initializes it to False.
8 years ago
Evan Kaufman 3a44d60fbc Fixes #3791 cron always returning changed state for multiline jobs (#4285)
Strip only newlines and carriage returns. Instead of stripping ALL whitespace, which may have unintended side effects
8 years ago
BradLook 766413e79d Allow cron to target remote user (#4270) 8 years ago
René Moser 03022875c4 mysql_db: use new exception handling, fixes build (#4373) 8 years ago
Jan Malte Gerth 9549883e78 reuse already split output for filtering (#4310)
there is no need to call out.split('\n') multiple times (line 275 and 277)
8 years ago
Brian Coca 81e87cefd7 unsafe writes! (#4314)
* unsafe writes!

* moved unsafe_write docs and args to file common

* added unsafe_writes option handling
8 years ago
Saurabh Sharma a5695c8b24 error handling for importing non-existent db. Fixes ##2068 (#3617)
* error handling for importing non-existent db

* creating db on import state and suitable message on deleting db

* handling all possible cases when db exists/not-exists
8 years ago
Toshio Kuratomi c5052f9b01 Be explicit about specifying the ssh port if it was user specified (#4302)
Previously, if the port specified by the user or inventory was 22, then
the ssh client port would be used instead.

Fixes #3895
8 years ago
Zoltán Müllner ac561772ea Revert "Reset all locale environment variables before running svn commands" (#4358)
* Revert "Reset all locale environment variables before running svn commands"

This reverts commit 99456fbc98.

* Reset locale environment variables before running svn commands
8 years ago
Michael Scherer cd3c454917 Add a example with a non service unit (#4355)
Since the documentation focus mostly on service
units, a explicit example may help people realizing
it can be used for socket and timer too.
8 years ago
Alvaro Aleman d9c28454ae Make ios_command example working 8 years ago
muxator 16db1d54d1 typo in the documentation of the "state" parameter (#4353) 8 years ago
John R Barker 1357e7e83a ios & iosxr Documentation improvements (#4321) 8 years ago
Chris Houseknecht 2514ec5056 Add buildargs parameter to support Dockerfile ARG directive. (#4349)
* Add buildargs parameter to support Dockerfile ARG directive.

* Fix doc_strings. Doc string for load_path was completely missing.
8 years ago
chouseknecht f6b126d412 Default repository tag value to tag parameter value or 'latest'. 8 years ago
chouseknecht 3dab1785ba Always returns changed when state present and name includes :tag. 8 years ago
Chris Houseknecht 1cf9d3e68e Add *build* to state parameter choices. Updated deprecation message. Will be deprecated in release 2.3. Removed (#4342)
mention of *tagged* state in the force parameter doc strings. There is no *tagged* state.
8 years ago
John Barker ecc7e445b5 vyos: Docs fixes 8 years ago
John Barker d76a4e71c2 openswitch: Docs fixes 8 years ago
John Barker 3f8f67e359 NXOS Docs update 8 years ago
chouseknecht 2ea29fee3f Fix image tag operation. Allows repository in form of repo:tag. If no tag value, defaults to 'latest'. 8 years ago
John Barker d4200b0389 junos: Docs update 8 years ago
Nathaniel Case 36ba105b91 Fix ios_config broken logic 8 years ago
John Barker 6ad7d6b3cd Cumulus - consistent docs formatting 8 years ago
Nathaniel Case 6857cea9e6 Quick fix to nxos_command and minify imports 8 years ago
chouseknecht 0c4da5d3a0 Added implementation of ignore_image, which prevents recreation of containers on image change. 8 years ago
chouseknecht 5992c21c9c Fix #3670 host IP defaults to 0.0.0.0 ignoriing bridge Host IP option. 8 years ago
chouseknecht a6bfeea1c4 Improved documentation for returned actions. 8 years ago
chouseknecht cd7b34547d When build true call docker-compose build, and add nocache option. 8 years ago
chouseknecht df09b4f668 Set version_added 8 years ago
chouseknecht 1670d9b030 Add pull option to pull images prior to evaluating service state. 8 years ago
Kevin Kirsche db03ebdfb9 Fix typo in "ssantaize" typo
ssantaize to santaize
8 years ago
John Barker 2b82389705 General EOS documentation improvements
Typos, formatting, choices.
8 years ago
Shawn Siefkas e9bf046c26 Check mode fixes for ec2_vpc_net module (#2179)
* Check mode fixes for ec2_vpc_net module

Returns VPC object information

Detects state change for VPC, DHCP options, and tags in check mode

* Early exit on VPC creation in check mode
8 years ago
Shawn Siefkas 0b95051039 Fix #2526 (#2527)
Fail on unhandled exception in ec2_asg rather than raise
8 years ago
Shawn Siefkas 66f1f6d537 Check mode fix for ec2_group module (#2184)
The default VPC egress rules was being left in the egress rules for
purging in check mode.  This ensures that the module returns the correct
change state during check mode.
8 years ago
Michael Scherer 3c2110215c Do not hardcode default ssh key size for RSA (#4074)
By default, ssh-keygen will pick a suitable default for ssh keys
for all type of keys. By hardocing the number of bits to the
RSA default, we make life harder for people picking Elliptic
Curve keys, so this commit make ssh-keygen use its own default
unless specificed otherwise by the playbook
8 years ago
peter.jang b06f3bbb22 fix for rsync protocol (#4211) 8 years ago
John R Barker aa6a7d5789 State runnng v running
Fix typo
8 years ago
Matt Clay c2270a37ff Enable FreeBSD tests on Shippable. (#4296) 8 years ago