Commit Graph

122 Commits (75039845dbdf15530cb94a963233d4e263ce4c74)

Author SHA1 Message Date
Stijn Tintel 9d0fc0fd67 Only revoke GRANT OPTION when user actually has it
When revoking privileges from a user, the GRANT OPTION is always
revoked, even if the user doesn't have it. If the user exists, this
doesn't give an error, but if the user doesn't exist, it does:

mysql> GRANT ALL ON test.* TO 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE ALL ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
ERROR 1141 (42000): There is no such grant defined for user 'test' on
host 'localhost'

Additionally, in MySQL 5.6 this breaks replication because of
http://bugs.mysql.com/bug.php?id=68892.

Rather than revoking the GRANT OPTION and catching the error, check if
the user actually has it and only revoke it when he does.
12 years ago
Xabier Larrakoetxea 8c25f98c43 Changed action keyword to command 12 years ago
Michael DeHaan 10b967374d Add version_added information to module parameter. 12 years ago
Michael DeHaan 34315c63ca Merge pull request #3396 from adq/mysql
Check if mysql allows login as root/nopassword before trying supplied credentials.
12 years ago
Xabier Larrakoetxea 4560e8fc7c Added redis config module (slave and flush) 12 years ago
Jan-Piet Mens c4189dfd3c mysql_db small fix to docs 12 years ago
James Martin 93d5d76468 Fixed #3433. Using get_bin_path, removed uneeded imports, "module" is inlined, misc other style improvements. 12 years ago
Andrew de Quincey 4cb48f0dcc Check if mysql allows login as root/nopassword before trying supplied credentials. 12 years ago
Jan-Piet Mens 30d641094b Docs: consistently format playbook EXAMPLES 12 years ago
Michael DeHaan 3e1e163ec3 Merge pull request #3172 from gw0/fix-mongodb2.2-compat
Fix `mongodb_user` compatibility with MongoDB 2.2 (used in Debian 7).
12 years ago
Michael DeHaan 294230d529 Merge pull request #3177 from stintel/mysql56-compat
Fix MySQL 5.6 compatibility
12 years ago
Jan-Piet Mens 5c69918d53 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
12 years ago
Stijn Tintel 767c208e6c Fix MySQL 5.6 compatibility
In MySQL 5.6, the root account created by default during MySQL
installation has the PROXY ... WITH GRANT OPTION privilege for ''@'',
that is, for all users.

The mysql_user module tries to revoke this privilege, but this fails:
_mysql_exceptions.ProgrammingError: (1064, "You have an error in your
SQL syntax; check the manual that corresponds to your MySQL server
version for the right syntax to use near '''@'' FROM 'root'@'localhost''
at line 1")

Quick fix: don't revoke privilege if user is root and the privilege to
revoke contains PROXY.
12 years ago
gw0 [http://gw.tnode.com/] 47c8396598 Fix `mongodb_user` compatibility with MongoDB 2.2 (used in Debian 7). 12 years ago
Michael DeHaan caa07e7fab pep8 fixes 12 years ago
Michael DeHaan 16c7c50e8f Docs standardization 12 years ago
Michael DeHaan e5d911fbce Docs standardization 12 years ago
James Martin 1aec4c0e74 Now can specify amount of time to wait_for_handoffs or ring ready instead of booleans. 12 years ago
James Martin 633724dc8c Timeouts implemented for riak stats operation. Removed failback mode
for fetching riak stats.
12 years ago
James Martin cf304b43b0 Fixed docs. Fixed fallback status method. Fixed "changed" message with cluster commit. 12 years ago
Bernhard Weitzhofer 119f33ed34 postgresql_privs: fix wrong codec specification
Use psycopg2's mapping from PostgreSQL encoding names to Python codec names.
12 years ago
Michael DeHaan 391fb98ee2 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago