Commit Graph

486 Commits (73246a49dc090b4c411e8b504781f26e4bc55097)

Author SHA1 Message Date
James Cammarata 08fca488f3 Use the no-user-groups option (-N) for useradd in the user module
If no group was specified, but a group by the same name as the user
exists, an error was raised in the situation where USERGROUPS_ENAB is
enabled in /etc/login.defs (which is the case for almost every major
linux distro). In this case, the user will be put in group 100 (which
is usually the "users" group on those same distros). This is currently
only done in the base class, as the issue may not exist on other
platforms like AIX or the BSDs.

Fixes #6210
11 years ago
Dustin C. Hatch d2dc260e98 filesystem: Ignore blkid cache
Sometimes, `blkid` will incorrectly return no information about a block
device, even if it exists and has a valid filesystem. This causes the
*filesystem* module to fail if *force=no*. Instructing `blkid` to use
`/dev/null` as a cache file will force it to rescan the block device on
each run, making results more consistent.

Signed-off-by: Dustin C. Hatch <admiralnemo@gmail.com>
11 years ago
Chris Church 09b076e39c Fix setup module to gather facts from PowerPC Macs. 11 years ago
James Cammarata 8aec47af89 Merge branch 'usermod_fix' of https://github.com/tknguyen79/ansible into tknguyen79-usermod_fix
Conflicts:
	library/system/user
11 years ago
Stefan J. Betz b335eb2412 Require force for LVM shrink and remove operations in lvol. Fixes #5774
Conflicts:
	library/system/lvol
11 years ago
Richard C Isaacson eb2762bc5b If you try to resize a lvol to the current size return a changed=False and don't fail.
This addresses GH-5165 and adds the ability to check if a lvol exists.

The tests for this don't fit nicely into the current integration tests so they are below.

```
---

- name: remove any existing lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: remove any existing lv=two of vg=main
  lvol: lv=two vg=main state=absent

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  ignore_errors: true
  register: lvol_result0

- name: Assert that we will get a "No size given."
  assert:
    that:
      - "'No size given.' in lvol_result0.msg"

- name: create lv=one of vg=main sized 30g
  lvol: lv=one size=30g vg=main state=present
  register: lvol_result1

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result1.changed == True"

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  register: lvol_result2

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result2.changed == False"

- name: remove lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: create lv=two of vg=main sized 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result3

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result3.changed == True"

- name: reduce lv=two of vg=main to 15G
  lvol: lv=two size=15G vg=main state=present
  register: lvol_result4

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result4.changed == True"

- name: increase lv=two of vg=main to 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result5

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result5.changed == True"

- name: create lv=two of vg=main sized 30G when already exists at 30G
  lvol: lv=two size=30g vg=main state=present
  register: lvol_result6

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result6.changed == False"

- name: remove lv=two of vg=main
  lvol: lv=two vg=main state=absent
```
11 years ago
Matt Jeffery 6cfa724472 Normalise the module name when comparing against the module names in /proc/modules. 11 years ago
C. Morgan Hamill c29f2fb888 Add 'vgoptions' parameter to lvg module.
Allows specifying extra flags to pass to `vgcreate`.
11 years ago
Nils Pascal Illenseer 7f40790fc1 Fix zfs create command for properties with spaces
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
11 years ago
Richard C Isaacson cb8c462880 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 11 years ago
Peter Gehres a9bf607013 Adding better failure output for chkconfig failures rather than
just saying that the service name is unknown
11 years ago
Sean Chittenden c892f51002 Fix broken behavior when removing all auxiliary groups from a user
(e.g. 'groups=' in the user module).
11 years ago
Brian Coca 01a1482f1a hopefully last batch of fixes
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
11 years ago
Brian Coca 4b0c2d839e made changes as per feedback:
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
11 years ago
Brian Coca c11fbd54e1 fixed main() issue created in prev fix, now values are empty string if they were None
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Brian Coca 8a6a2aba75 changes names to name in example 11 years ago
Brian Coca ddb191f208 fixes as per feedback 11 years ago
Tom Dymond c9e7541e60 Reworked PR to avoid repeating the command 11 years ago
jctanner 4901af0ef6 Merge pull request #5554 from ttarabul/devel
Use /etc/rc.conf.local for sevice configuration on FreeBSD
11 years ago
Tom Dymond 16edbd3181 Add option to enable the sysctl -e option 11 years ago
kustodian 405dee2398 Updated authorized_key module documentation regarding manage_dir
Added a warning in the documentation about manage_dir when selecting an alternate directory for authorized_keys
11 years ago
Aaron Lindsay 931f8e4c5b Add move_home option to user module 11 years ago
Richard C Isaacson cc20868bfb Tested implementation adding action option for (add, delete, unique). 11 years ago
Richard C Isaacson 855154226e Rough cut implementation based on @resmo's comments. 11 years ago
Richard C Isaacson 4e4ba1f695 Rough cut implementation based on @resmo's comments. 11 years ago
Richard C Isaacson c677056dfe Change to dynamically pick up the command from the PATH. 11 years ago
Richard C Isaacson 9dc98d9b66 Formating and syntax fixes that were pointed out during code review. 11 years ago
Richard C Isaacson eb9831cf62 Added user option. 11 years ago
Richard C Isaacson 7e1361d0e0 First commit of the at module being very basic. 11 years ago
Brian Coca fee79e6501 be permissive with BSD with service enabled upper/lower/mixed cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Jakub Jirutka 1dc5ee00b6 sysctl: parse bool value as 0/1 and refactor a little bit 11 years ago
Thoai Nguyen 220b0f87d9 reorder usermod options 11 years ago
jctanner f14f6ebd44 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2
Correctly compare values returned by 'sysctl -e -n'
11 years ago
Augustus Kling de19375d1b Fix error reporting in case locale-gen fails on non-Ubuntu systems. 11 years ago
Augustus Kling eabc9cd775 Merge remote-tracking branch 'upstream/devel' into locale 11 years ago
Augustus Kling 00ee613446 Handle install/uninstall of locales for Ubuntu, too. 11 years ago
Simon Zimmermann be69ca4ead correctly compare the values, better func name 11 years ago
Simon Zimmermann 45728d739c Correctly compare values as returned from 'sysctl -e -n' 11 years ago
Simon Zimmermann 624c563e43 fix str format error due to missing '%' in sysctl module 11 years ago
James Tanner f3b86abc30 Fixes #5661 Handle null values for sysctl parameters 11 years ago
Michael DeHaan 49b0db9819 Merge pull request #5658 from rishid/devel
Add support for Scientific Linux for hostname module
11 years ago
jctanner 921ae2134b Merge pull request #5655 from scottgilbert/devel
Allow keystring passed to authorized_key to contain blank lines and comments
11 years ago
James Tanner 03aba39b59 Fixes #5656 quote values with multiple columns before calling
the sysctl command. Calling sysctl should also not be true by default
11 years ago
rishid 4ef5b60f3d Add support for Scientific Linux for hostname module
hostname module was lacking support for Scientific Linux, this commit adds it.
11 years ago
Scott Gilbert df72690e6c Allow keystring passed to authorized_key to contain blank lines and comments 11 years ago
James Tanner a9c5aa8f78 Remove unused variable from authorized_key 11 years ago
James Tanner 30f7b2d298 Fixes #5486 Keep authorized key options in tact and ordered 11 years ago
James Tanner 272c3634cd sysctl module: append newline character to lines in the file 11 years ago
Michael DeHaan cb6f7748d5 All modules should be using /usr/bin/python in the shebang as ansible_python_interpreter processes this (see FAQ).
Fixing for standardization purposes.
11 years ago
jctanner da9cd8e018 Merge pull request #5490 from rgbj/devel
user module/OpenBSD: using login_class always makes status 'changed'
11 years ago
jctanner 9779206142 Merge pull request #5426 from lichesser/debian_release_4565
setup module: Partial fix for #4565, reporting Debian release version. Works only for Debian 7 and later
11 years ago
James Tanner 1b712ec48d sysctl module: fail if reloading the file did not succeed 11 years ago
James Tanner f0b842b28b Fixes #5469 Refactor sysctl module into object oriented code,
and add a sysctl_set parameter to manage the values in /proc
11 years ago
Tyler 5ce664b499 keep /usr/local/etc/rc.conf for backwards compatibility 11 years ago
Tyler c073438d40 Use /etc/rc.conf.local for sevice configuration on FreeBSD
/etc/rc.conf.local is the preferred location for system-specific
startup configuration, and /usr/local/etc/rc.conf generally isn’t used.

see:
http://www.freebsd.org/doc/handbook/configtuning-core-configuration.html
11 years ago
Joshua Lund e0a720b8b2 Improved the documentation for password generation 11 years ago
James Tanner 154a99529c Fixes #5353 create etc/hostname file in debian if it does not exist 11 years ago
Michael DeHaan 0fdcb8ea69 Merge pull request #5528 from dverhelst/devel
Adding support for detecting RHEV Hypervisor in ansible_virtualization_type
11 years ago
Paul Beattie 31f81c3a1b Fixed typo in example documentation 11 years ago
rgbj fa5a448983 On OpenBSD, make user module status 'changed' only if necessary when using 'login_class' parameter 11 years ago
jctanner 6f16ea6d49 Merge pull request #5167 from jaspernbrouwer/devel
service_module: Fixed false positive on initctl as enable_cmd
11 years ago
James Tanner e2c7aeca4c Fixes #5040 setup module: do not add primary interface info to the secondary interface data 11 years ago
lichesser bab510f0c5 Partial fix for #4565. Works only for Debian 7 and later 11 years ago
Michael DeHaan 05c755f2dc Fix a documentation item. 11 years ago
Augustus Kling c850c0a76b Basic handling of locales. 11 years ago
Brian Coca 45872dfee7 making pylint happier
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca ebba754ee6 corrected my grammar (again Mikhail)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 72eba69175 did some minor refactoring on docs and fixed spelling mistakes (thanks
Mikhail)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Jasper N. Brouwer 9dab01c5e2 Swapped conditions of the changed if statements 11 years ago
Brian Coca ce72f27787 corrected indentation and now handles non existing previous key (not
just changed existing)

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 3587053119 and it was supposed to be a dict
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 564bd29eeb fixed typo for showing diff
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 0c2ec0d9d1 debconf package
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
jctanner 76c3055986 Merge pull request #4886 from sergeyhush/devel
fix when the system does not have lsb_release script, but has /etc/lsb_release file
11 years ago
jctanner 0a2fd6f088 Merge pull request #5213 from dalevizo/devel
Add get_dmi_facts in setup for FreeBSD systems using dmidecode
11 years ago
Dimos Alevizos 8cda18ec51 Minor changes to simplify code 11 years ago
David Hummel e329b23365 Fix issue #5214: hostname persistence on RedHat/CentOS 11 years ago
Dimos Alevizos 34ff7e00a9 Add get_dmi_facts in setup for FreeBSD systems using dmidecode 11 years ago
jeromew 5413ee9431 user module: force= and remove= should not be mutually exclusive 11 years ago
jctanner 5040665cd0 Merge pull request #5075 from gservat/patch-1
Added support for parsing in the SLES patch level correctly
11 years ago
gservat 38ec5b0058 This change is meant to replace distribution_release, not version! 11 years ago
gservat a8c9e2afd1 Oops... fixed an error 11 years ago
Alfons Zitterbacke f37a217a33 added AIX network facts 11 years ago
Alfons Zitterbacke f556151c56 added AIX network facts 11 years ago
James Tanner 3bb1a263cf Fixes #5169 Evaluate check_mode in the user module SunOS class 11 years ago
Jasper N. Brouwer 677f95294e Fixed false positive on initctl as enable_cmd
Also on update-rc.d
In service module
11 years ago
jctanner 5fb01db898 Merge pull request #5090 from dragon3/hostname_support_amazon_linux
hostname module: add support for Amazon Linux
11 years ago
jctanner 4125713b6e Merge pull request #5107 from maetthu/devel
authorized_key module: rewrite options to dict parser, fixes #5032
11 years ago
jctanner cd5c817a36 Merge pull request #5063 from samh/devel
Fixed hostname module for RHEL6 Workstation
11 years ago
James Tanner 4f9aadcc07 Addresses #5023 Fix import comments 11 years ago
James Tanner 38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago
James Tanner 0242f10781 Fixes #4796 handle unicodedecode errors from dmidecode output 11 years ago
Michael DeHaan 4704dfefb0 Merge pull request #5046 from JensRantil/improve-mount-doc
mention that the mount module will remove mount directories
11 years ago
Matthias Blaser 1e1def3fbd rewrite options to dict parser, fixes #5032 11 years ago
Michael DeHaan 4c35b7f380 There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
11 years ago
Michael DeHaan 9e4d71203d No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 11 years ago
dragon3 b5eb3c41e3 hostname module: add support for Amazon Linux 11 years ago
gservat 3b6e9a07f6 Added support for parsing in the SLES patch level correctly
On SLES, the setup module was returning the architecture as the distribution version (i.e. platform.dist() didn't quite return the right thing). This change checks for /etc/SuSE-release and grabs the second column in the third line as distribution_version.
11 years ago
Sam Hartsfield a8a6771b0e Fixed hostname module for RHEL6 Workstation 11 years ago
James Tanner fa4b30819a Fix comment yaml escaping in authorized_key module 11 years ago
James Tanner 999b04f7fa Save comment hashes in sshkeys 11 years ago
James Tanner 7de788f346 Cleanup debug statements 11 years ago
James Tanner d0c2b37688 Fixes #5032 escape and safely split key options in authorized_keys module 11 years ago
James Tanner 486d248401 Fixes #5010 Add user to all defined supplementary groups 11 years ago
Jens Rantil 79a3ed2654 Improved documentation of `mount` module
Mentioning the fact that mount point directories are created and
removed.
11 years ago
James Tanner 407d6041b3 Fixes #5021 safely split hostkeys with quotes 11 years ago
James Tanner 6ca17b90d0 Fix pep8 error in hostname module 11 years ago
Michael DeHaan 147210ddcf Merge pull request #4868 from hnakamur/rhel5_hostname_fix
hostname module fix for RHEL5
11 years ago
Michael DeHaan db9176f77d Remove the 'host' module for now because the alias handling involves a bit too much automagic. Proposal is to come up with a spec
of how it should work and accept to spec, using the existing patch (cherry-picked) as a baseline.
11 years ago
Michael DeHaan 08996d78d6 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
11 years ago
Michael DeHaan 55a48aacc3 Changelog updates and a few module renames. vpc -> ec2_vpc, githooks -> github_hooks, blacklist -> kernel_blacklist. These are all new in 1.4 so safe to change. 11 years ago
Sergey Sudakovich 8ecd617df8 compatible with python 2.4 11 years ago
jctanner ab54bce2f6 Merge pull request #4910 from matze/add-system-blacklist-module
Add system module to blacklist kernel modules
11 years ago
Rene Moser b1f27ca902 host: fix bug, alias was not removed 11 years ago
Rene Moser 25f527a32d host: removed unused self_has_aliases 11 years ago
Rene Moser ee9dc73a63 host: skip lines beginning with new line 11 years ago
Rene Moser 502d9f43e5 host: fix changed is not available on fail 11 years ago
Matthias Vogelgesang 6ce4635952 Add system module to blacklist kernel module 11 years ago
nextus 6d701cb517 Don't allow cron module to delete cron_file without name parameter assignment 11 years ago
nextus f0ea92cc75 Fix: absent state removing whole cron.d file instead of specific job 11 years ago
James Tanner 73d36f84b1 Merge pull request #4282 from cristobalrosa/ansible
Add a fact for checking if interface is in promiscuous mode.
11 years ago
Sergey Sudakovich ae9fd2172e fix when the system does not have lsb_release script, but has /etc/lsb_release file 11 years ago
James Tanner 36c4f05891 Add more error detail to the service module for FreeBSD 11 years ago
jctanner fc51fb8853 Merge pull request #4304 from ferringb/fixes/cron-permissions
Enforce umask for cron module, so cron_file generated files are 0644.
11 years ago
Hiroaki Nakamura cc17a0ac7d Apply the same change as https://github.com/hnakamur/ansible-playbooks/pull/2 11 years ago
James Tanner 44014d6800 Set the correct version added for the hostname module 11 years ago
jctanner 9083258fa7 Merge pull request #3940 from hnakamur/hostname_module
Add a hostname module, which sets system's hostname.
11 years ago
James Tanner e62cbba1fc Address #4573 Check interface keys and return gracefully on solaris zones 11 years ago
Jim Richardson 71bf839121 return True/False from remove_job_file()
revised fix for https://github.com/ansible/ansible/issues/4795
11 years ago
Jim Richardson dd313b1b8f fix for https://github.com/ansible/ansible/issues/4795
Incorrect changed result in cron module.
Report changed=False if no cron is removed:wq
11 years ago
Hiroaki Nakamura 7aa728a32f Fix for RHEL6. 11 years ago
Michael DeHaan 99a8213be1 Merge pull request #4754 from mscherer/fix_4648
Fix 4648, cron module is not working on solaris
11 years ago
Michael DeHaan 0e7069d7c1 Undo an inadvertant revert from template changes so we still allow pythonic imports in module land. 11 years ago
Michael Scherer 2a3ee8dbf4 make cron module work on solaris
Cron on solaris do not take the same
set of option than vixie cron on linux, and
among the biggest difference, root cannot set
the crontab of a user directly from a file. Thus the
use of su to run the crontab command. Fix issue #4648
11 years ago
Michael Scherer 5547cc9c29 remove unused function 11 years ago
Scott Dunlop be6e2c9097 add "zle" as a supported ZFS compression type
ZFS supports "zle" compression, which compresses runs of null bytes efficiently.
11 years ago
James Tanner 8036e6ee23 Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754 11 years ago
jctanner 63b1c47881 Merge pull request #4715 from mscherer/fix_4702
Fix #4702, make setup work on windows
11 years ago
Michael Scherer 2865a1b074 Fix #4702, make setup work on windows 11 years ago
James Cammarata 4c80cf411c Fixing authorized_keys module to make the key part detection better
Fixes #4677
Fixes #4657
Fixes #4599
11 years ago
Christian Berendt 8672ce9769 changing permissions of modules to 0644 11 years ago
Michael DeHaan 8bcd697816 Merge pull request #4424 from localvoid/firewalld-rich_rules
Add support for Rich Rules in firewalld module
11 years ago
Michael DeHaan dcc1beab37 Merge pull request #4600 from earchibald/devel
Added ['date_time']['tz_offset'] using %z to get the time offset rather ...
11 years ago
Michael DeHaan a6aeb12c8c Merge pull request #4560 from tronner/issue4461
Fix illegal set operation in FreeBSD section of user module.
11 years ago
Michael DeHaan bc6d454b5e Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
to be reused between modules.  See library/system/service and library/system/ping for initial examples.  Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
11 years ago
James Tanner f27e2fd285 Fixes #4448 reloaded services should be started if not running 11 years ago
James Cammarata a220d7c18c Merge branch 'fix_autorized_keys' of https://github.com/mscherer/ansible into mscherer-fix_autorized_keys 11 years ago
James Cammarata 8fc62a1fb0 Fixing up authorized_keys to accept comments with spaces 11 years ago
Michael Scherer d53abc2d5e make sure that options are quoted, as people can add a shell
script there with a comma that would produce invalid configuration
upon being wrote again
11 years ago
Michael Scherer 2ad3a46e13 sort the option_key to have a constant predictable line 11 years ago