Commit Graph

25736 Commits (7188ae4fe16e16152d38195291ec844299469824)
 

Author SHA1 Message Date
Dreamcat4 7188ae4fe1 fix: The names of firewall profiles are different on win10 & win2008r2
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
8 years ago
Dreamcat4 f64e438150 fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch.
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
8 years ago
Dreamcat4 b9dd3568f3 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()'
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
8 years ago
Ramon de la Fuente 1d09eaf6d0 updated the examples to the new Slack API 8 years ago
Ramon de la Fuente 918012a42f module guidelines compliency 8 years ago
Stefan Berggren aeb1090542 Add attachments support to slack module. 8 years ago
Kevin b43329b6a0 Remove `homebrew-` prefix when checking if repo has already been tapped
See: https://github.com/Homebrew/homebrew/blob/master/Library/Homebrew/cmd/tap.rb

Example:

```
$ brew tap neovim/homebrew-neovim
$ brew tap
neovim/neovim
...
```
8 years ago
Luis Rodriguez adedc7ef3f Fix bug #1067 8 years ago
Brian Coca 1426c3ba02 added missing GPL licences fixes #508 8 years ago
Michael Perzel f84dc8fd5d Improve example wide_ip variable 8 years ago
Michael Perzel 9c8891740c Wrap main() in conditional 8 years ago
Michael Perzel 21425f36ef Update bigip_api method to use variable name server 8 years ago
Michael Perzel 6681a5b386 Style updates 8 years ago
Michael Perzel ca0d4aad52 Module for managing F5 wide ip 8 years ago
Toby Fleming 3293fe7231 Homebrew: Allow colons, direct check for outdated formula 8 years ago
Indrajit Raychaudhuri e115f62a2d homebrew: Also add 'formula' as alias for 'name' and reformat 8 years ago
Indrajit Raychaudhuri c397dfe9ed homebrew: Improve 'argument_spec' handling
- Remove choice list for boolean values in argument_spec and make it
  more consistent with core modules
- Add 'package' alias and support for list type for 'name' parameter
- Added self as maintainer
8 years ago
jhawkesworth@users.noreply.github.com 17d1c8916d Document module limitations to resolve https://github.com/ansible/ansible-modules-extras/issues/908 8 years ago
Matt Martz 803d9695e0 sys.exit removal for system/capabilities.py 8 years ago
Matt Martz a87cf4967e sys.exit removal for notification/mail.py 8 years ago
Matt Martz e99a202ac5 sys.exit removal for cloud/google/gce_img.py and cloud/google/gce_tag.py 8 years ago
Matt Martz 7cb0d86c27 sys.exit removal for cloud/misc/ovirt.py 8 years ago
Matt Martz 950c951e06 sys.exit removal for cloud/xenserver_facts.py 8 years ago
James Cammarata 766ad0ace2 Updating version for 2.0.0-0.3.beta1 release 8 years ago
Matt Martz 9c4fae7e3f Fix open_iscsi EXAMPLES section 8 years ago
Matt Martz e2872a984a Switch from old style replacer code to new style for ansible.module_utils.basic 8 years ago
Matt Martz 793f0e0fd1 Fix interpreter line in a few vmware modules 8 years ago
Rick Mendes 7bb6a5aa90 added missing license 8 years ago
Charles Paul 0acfd95747 allow floating point input for size vale 8 years ago
Brian Coca 4134b7a04d doc formatting fixes 8 years ago
Toshio Kuratomi 7ccd6a4de0 Change documented requirement from dnf to python-dnf as dnf could be taken to mean the command line tool.
Fixes #1032
8 years ago
nitzmahone bf59d1cc1e win_updates rewrite for 2.0
uses scheduled job to run under a local token (required for WU client)
supports check mode
no external PS module deps
8 years ago
Brian Coca ae84177514 switched to use module loggigng 8 years ago
Brian Coca a04972c79b changed use_sudo to system_lib (kept alias) and expanded description to explain how it works 8 years ago
Milad Soufastai c3c9f46ba4 Updating Description to provide better explanation of what the use_sudo flag does 8 years ago
Milad Soufastai 07a4ab2fc5 Adding the --sudo flag for CPANM use since the sudo: yes on the task doesn't work 8 years ago
Trond Hindenes 86be6b1dba added module author 8 years ago
Trond Hindenes 6890cc81be fixes #984 8 years ago
Matt Martz 503948203f znode requires a minimum of python2.6 8 years ago
Michael J. Schultz 6b6aeefa7b sns: remove BabyJSON 8 years ago
Toshio Kuratomi dc788cf045 Make the znode module a valid ansible module 8 years ago
Toshio Kuratomi 07af4c3627 Fix doc build 8 years ago
Rene Moser a134a71187 cloudstack: implement common argument spec handling 8 years ago
Alan Loi 6e4c78d165 Docfixes - add version_added and missing default values. 8 years ago
Alan Loi a14420dcf0 Fix sqs_queue module to check that boto library is installed and AWS region & credentials are provided. 8 years ago
Alan Loi e8e1e41e08 Updated documentation for sqs_queue - state option is not required. 8 years ago
Alan Loi 6022f5abc7 Rename module to sqs_queue.py to differentiate from other potential modules e.g. reading/writing messages. 8 years ago
Alan Loi e018a12572 Add .py file extension to sqs module. 8 years ago
Alan Loi 1cb506c556 Add new amazon sqs module. 8 years ago
whiter 2294e5708e Documentation examples fix 8 years ago