Commit Graph

63 Commits (70a3891b1e1efe5e823ea4231ad3aa2bda8eeae5)

Author SHA1 Message Date
Matt Martz d112599fd5 Set version_added to 2.1 for autoremove. Fixes #3200 9 years ago
Matt Davis 7d2fd4e944 Merge pull request #2926 from mattclay/apt-unsafe
Split shell command to avoid use_unsafe_shell.
9 years ago
Brian Coca 38d6c1cd36 expanded info on fail on check + missing apt-python
it now explains that apt module will auto install
9 years ago
Matt Clay d33e033eba Do not install python-apt in check mode. 9 years ago
Toshio Kuratomi 1df8ebf0c3 use new method of setting locale and other environment variables
The old method left settings in the environment.  The new method takes
care of clearing them after use.  In this module, the old method was
also setting the environment too late to affect all the command line
tools which lead to a bug.

Fixes https://github.com/ansible/ansible/issues/14264
9 years ago
Charles Paul d7a0a3b7e3 adding autoremove to apt 9 years ago
Matt Clay e56d668ade Split shell command to avoid use_unsafe_shell.
This mirrors a nearly identical change made to apt_repository.py.

Also removes the use of apt-get --force-yes as it can be dangerous
and should not be necessary (apt_repository.py does not use it).

Repeating the explanation from the apt_respository change below:

Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to thoroughly inspect for a security audit.

In this case, the '&&' can be replaced by doing 2 calls to run_command.
9 years ago
Arata Notsu 14950824c3 apt: export env vars before run dpkg
Without this change, some trouble may occur when "deb" parameter
is used as env vars controlling dpkg are not set. For example,
installing a package that requires user input will never end since
DEBIAN_FRONTEND=noninteractive is not set.

So export env vars in APT_ENV_VARS before run dpkg, like in cases
using apt-get/aptitude.
9 years ago
Charles Ferguson fca36415d6 Update the documentation of the 'apt' action for the 'name'.
The package name has two aliases, 'package' and 'pkg'. Add them to the
documentation.
9 years ago
Toshio Kuratomi 5cacef8617 Fixes for bcoca's review of #1916 9 years ago
Harlan Lieberman-Berg a53cf5434b Give include_recommends a useless default to make the parser happy. 9 years ago
Harlan Lieberman-Berg 06a4efa1cf Add missing brace. 9 years ago
Harlan Lieberman-Berg a234e9b7b2 Change install_recommended in apt to a trinary.
Conditions are now "yes", "no", and "default", with the latter falling
back to the OS default.
9 years ago
Harlan Lieberman-Berg baafcfc091 Change behavior of apt.py around installing recommended packages.
Closes #1189.

This will cause the settings in Ansible to override the system settings.
That will have no effect except on systems that have an out-of-Ansible
configuration that disables automatic installation of recommended
packages.  Previously, ansible would use the OS default whenever
install_recommends wasn't part of the playbook.  This change will cause
the Ansible default configuration setting of installing recommended
packages to override the configuration files set on the OS for things
installed through ansible, even when there is no install_recommends
specified in the playbook.  Because the OS default matches the Ansible
default, this shouldn't have wide impact.
9 years ago
Patrick Galbraith 2a93f21821 Fix to issue 12912. Supply 'force' to install of python-apt. 9 years ago
Marius Gedminas eb17b6a36c apt: check for "0 upgraded" to be at the beginning of the line
Fixes #1678.
9 years ago
Brian Coca 5913f5e5e1 deal with more failures when apt module fails to instantiate pkg
fixes #1499
9 years ago
Brian Coca 93754b903f updated upgrade to a more sensible default as the previous was prone to confusion
fixes #1667
9 years ago
Matt Martz 9eb4219f79 Replaced tabbed indentation with spaces for apt module 10 years ago
Greg DeKoenigsberg 2a5f0bde87 Proper author info for all remaining modules 10 years ago
Brian Coca 6d088169ef Merge pull request #1348 from devjatkin/issue_1230
fix apt to handle virtual packages correctly
10 years ago
Brian Coca 0d41af23c2 Merge pull request #909 from bcoca/apt_return_cacheinfo
added updated cache time to apt, also started documenting return values
10 years ago
Semyon Deviatkin adf34a6ccd Fix issue #1230
When virtual package providing only one package, look up status of target package
10 years ago
Toshio Kuratomi 7540cbb845 Explain why the apt module does not do implicit regex matches on package name since this is different than the apt-get command line tool.
Fixes #1258
10 years ago
bugchecker 496f9ca180 prevent using undefined variable 10 years ago
Tim Rupp dba0023940 Add missing import of apt.debfile
In cases when the python-apt package is not installed, ansible will
attempt to install it. After this attempt, it tries to import the
needed apt modules, but forgets to import the apt.debfile module.

The result is that playbooks that use the dpkg argument on a machine
that does not initially have the python-apt package available will
fail with the following error

AttributeError: 'module' object has no attribute 'debfile'

This patch adds the appropriate import to the apt module to ensure
that necessary libraries are available in cases when the dpkg argument
is being used on a system that does not initially have the python-apt
package installed
10 years ago
Brian Coca 19ec770680 added updated cache time to apt, also started documenting return values 10 years ago
Brian Coca 2fcc93e5b3 Merge pull request #785 from bcoca/apt_deb_missing
now module fails gracefully instead of stacktrace
10 years ago
Brian Coca 818767b1d4 Merge pull request #53 from hfinucane/apt-dpkg-force
dpkg does not take a --force-yes option
10 years ago
Brian Coca 611e8b59d6 now module fails gracefully instead of stacktrace when trying to install missing deb file 10 years ago
Conrado Buhrer bd208da8ea fixed: namespace clash #710 10 years ago
Conrado Buhrer a5114bfa39 fixed: erroneous logic 10 years ago
Conrado Buhrer 3155656eef fixed: missing check for upgrade flag 10 years ago
Conrado Buhrer ef3f486f6e fixed: removed build-deb from required_one_of 10 years ago
Conrado Buhrer 711005fe9b changed: state=build-dep; refactored into install() 10 years ago
Conrado Buhrer d257e2be8c added: build-dep to apt module #349
Original code provided by @nathanhruby
10 years ago
Brian Coca e2dcb5fc9b now captures cache fetch failures 10 years ago
fabios 9ed842e2d0 mark as upgradable and let apt-get install deal with it 10 years ago
fabios b747d9411a improve fail message and use itertools chain 10 years ago
fabios d19f7c7026 older python-apt compatibility 10 years ago
fabios 6fce4a9c3d handle list of list for python-apt < 0.7.9 compatibility 10 years ago
Toshio Kuratomi 170457413d Cleanup the old apt compatibility changes 10 years ago
fabios a08165ca2e use low-level apt_pkg.Package 10 years ago
FabioBatSilva 55b85ddc46 fix compatibility issues with python-apt < 0.7.9 10 years ago
Toshio Kuratomi 195e7c5a13 Merge commit '383ecdb' into devel 10 years ago
Toshio Kuratomi 383ecdb50b Correct variable name 10 years ago
Henry Finucane ce02d59651 If force=true, ignore python-apt's advice
This lets you downgrade packages, for instance.
10 years ago
Henry Finucane 4558ed6925 dpkg does not take a --force-yes option 10 years ago
Toshio Kuratomi fb4854ebcb Fix retrieval of package version in apt module 10 years ago
Toshio Kuratomi c389cd671f Documentation update for apt version wildcards from bryanlarsen 10 years ago