Commit Graph

165 Commits (70a3891b1e1efe5e823ea4231ad3aa2bda8eeae5)

Author SHA1 Message Date
toshihisa 530643a216 One more bug yum non English locales
d7fac82f97
9 years ago
Matt Martz d112599fd5 Set version_added to 2.1 for autoremove. Fixes #3200 9 years ago
Matt Davis 7d2fd4e944 Merge pull request #2926 from mattclay/apt-unsafe
Split shell command to avoid use_unsafe_shell.
9 years ago
Tobias Wolf c5be97ca5c Add diff support to apt_repository module
The returned list of diffs aims to simulate how a file system diff would
look before and after writing the sources list files.

![screenshot](http://i.imgur.com/dH6QXtY.png)

n.b. Ternary conditional  is due to failing integration test for
python 2.4
9 years ago
Brian Coca 2a03fc2b99 Merge pull request #2997 from callipeo/issue/2996
Add support for both keyserver and keyring in apt_key
9 years ago
Brian Coca 38d6c1cd36 expanded info on fail on check + missing apt-python
it now explains that apt module will auto install
9 years ago
Matt Clay d33e033eba Do not install python-apt in check mode. 9 years ago
callipeo 27df98b6fb Add support for both keyserver and keyring in apt_key
Fixes Issue #2996
9 years ago
Toshio Kuratomi 1df8ebf0c3 use new method of setting locale and other environment variables
The old method left settings in the environment.  The new method takes
care of clearing them after use.  In this module, the old method was
also setting the environment too late to affect all the command line
tools which lead to a bug.

Fixes https://github.com/ansible/ansible/issues/14264
9 years ago
Charles Paul d7a0a3b7e3 adding autoremove to apt 9 years ago
Toshio Kuratomi 63fda10853 Merge pull request #1458 from Tahvok/patch-1
Explain that state=present should be used with yum and url
9 years ago
Toshio Kuratomi a5667e51ad Merge pull request #2660 from mscherer/fix_rhn_register
Do not use a shell construct for rhnreg_ks
9 years ago
Matt Clay e56d668ade Split shell command to avoid use_unsafe_shell.
This mirrors a nearly identical change made to apt_repository.py.

Also removes the use of apt-get --force-yes as it can be dangerous
and should not be necessary (apt_repository.py does not use it).

Repeating the explanation from the apt_respository change below:

Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to thoroughly inspect for a security audit.

In this case, the '&&' can be replaced by doing 2 calls to run_command.
9 years ago
Matt Clay 7a82f2c86d Show error if python-apt is absent in check mode.
Previously this would fail with an exception which
did not clearly explain the reason for the failure.
9 years ago
Michael Scherer c01cc5f6e4 Do not use a shell construct for rhnreg_ks
Since there is no shell escape of the password parameter, a password with
a single quote (or even worst, a single quote and a pipe) could have
unattended consequences. Also, the less we use use_unsafe_shell=True, the
better.
9 years ago
Brian Coca 9e5737d776 Merge pull request #2661 from mscherer/remove_unsafe_shell_apt_repos
Split a shell snippet in 2 to avoid using use_unsafe_shell=True
9 years ago
Toshio Kuratomi d7fac82f97 Fix for yum's use of rpm with non English locales
Depends upon https://github.com/ansible/ansible/pull/14025

Fixes https://github.com/ansible/ansible/issues/13996
Fixes https://github.com/ansible/ansible/issues/13975
9 years ago
Brian Coca 61379184d4 Merge pull request #2794 from evverx/fix-apt-key-del-long-id
apt-key: convert ids to the 'short' format
9 years ago
Matt Davis 51056bac9d Merge pull request #2696 from mattclay/apt-repository-filename
Added filename option to apt_repository module.
9 years ago
Evgeny Vereshchagin d441cb176c apt-key: convert ids to the 'short' format
Fixes:
$ ansible all -m apt_key -a 'state=present id=7A82B743B9B8E46F12C733FA4759FA960E27C0A6 keyserver=hkp://keyserver.ubuntu.com:80' --sudo
127.0.0.1 | SUCCESS => {
    "changed": true
}

$ ansible all -m apt_key -a 'state=absent id=7A82B743B9B8E46F12C733FA4759FA960E27C0A6' --sudo
127.0.0.1 | SUCCESS => {
    "changed": false
}

$ apt-key export 7A82B743B9B8E46F12C733FA4759FA960E27C0A6
-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1
...

See https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1481871
9 years ago
Brian Coca 2fbfc0740f corrected version added 9 years ago
Brian Coca dc517ecea6 Merge pull request #2457 from axelspringer/rhn_register-sslcacert-systemorgid
rhn_register: add sslcacert and systemorgid options
9 years ago
Arata Notsu 14950824c3 apt: export env vars before run dpkg
Without this change, some trouble may occur when "deb" parameter
is used as env vars controlling dpkg are not set. For example,
installing a package that requires user input will never end since
DEBIAN_FRONTEND=noninteractive is not set.

So export env vars in APT_ENV_VARS before run dpkg, like in cases
using apt-get/aptitude.
9 years ago
Barnaby Court d4c5360380 add no_log to the password parameter 9 years ago
Martin Matuska d3740505ac rhn_register: add sslcacert and systemorgid options 9 years ago
Matt Clay 9f622015f1 Added filename option to apt_repository module. 9 years ago
Chrrrles Paul 3c685d7468 Merge pull request #2680 from ansible/yum-use-rpm
Use rpm instead of repoquery for is_installed()
9 years ago
Toshio Kuratomi 0125770d8d Use rpm instead of repoquery for is_installed()
* This keeps us from hitting bugs in repoquery/yum plugins in certain
  instances (#2559).

* The previous is also a small performance boost

* Also in is_installed(), when using the yum API, return if we detect
  a package name has been installed.  We don't need to also check
  virtual provides in that case.  This is another small performance
  boost.

* Sort the list of packages returned by the list parameter.
9 years ago
Brian Coca 74609ce42c Merge pull request #2636 from vmindru/yum_fix_typo
fix typo s/defaults/default
9 years ago
Michael Scherer 8c5e8f0425 Split a shell snippet in 2 to avoid using use_unsafe_shell=True
Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to toroughly inspect for a security audit.

In this case, the '&&' can be replaced by doing 2 calls to run_command.
9 years ago
Daniel Kimsey a54d1fe09c Fix yum module failing to initalize yum plugins 9 years ago
Veaceslav Mindru 0d5380258e fix typo s/defaults/default 9 years ago
Veaceslav Mindru dc697bf533 adding validate_certs for YUM. #2582 9 years ago
Charles Ferguson fca36415d6 Update the documentation of the 'apt' action for the 'name'.
The package name has two aliases, 'package' and 'pkg'. Add them to the
documentation.
9 years ago
Charles Ferguson 490038b0e4 Update documentation of the 'pkg' and 'state' parameters in yum.
The yum module allows the 'name' parameter to be given as 'pkg', in
a similar way to some of the other package managers. This change
documents this alias.

The module's 'state' parameter has two other aliases, in line with
the 'apt' action; the 'state' parameter can take 'installed' as an
alias for 'present', and 'removed' as an alias for 'absent'. These
aliases are documented.
9 years ago
Toshio Kuratomi 5cacef8617 Fixes for bcoca's review of #1916 9 years ago
Harlan Lieberman-Berg a53cf5434b Give include_recommends a useless default to make the parser happy. 9 years ago
Harlan Lieberman-Berg 06a4efa1cf Add missing brace. 9 years ago
Harlan Lieberman-Berg a234e9b7b2 Change install_recommended in apt to a trinary.
Conditions are now "yes", "no", and "default", with the latter falling
back to the OS default.
9 years ago
Harlan Lieberman-Berg baafcfc091 Change behavior of apt.py around installing recommended packages.
Closes #1189.

This will cause the settings in Ansible to override the system settings.
That will have no effect except on systems that have an out-of-Ansible
configuration that disables automatic installation of recommended
packages.  Previously, ansible would use the OS default whenever
install_recommends wasn't part of the playbook.  This change will cause
the Ansible default configuration setting of installing recommended
packages to override the configuration files set on the OS for things
installed through ansible, even when there is no install_recommends
specified in the playbook.  Because the OS default matches the Ansible
default, this shouldn't have wide impact.
9 years ago
Toshio Kuratomi eeaeeb5a1f Correct typo in yum module docs 9 years ago
Patrick Galbraith 2a93f21821 Fix to issue 12912. Supply 'force' to install of python-apt. 9 years ago
Toshio Kuratomi 06f301b05b Note the difference between yum package groups and environment groups.
Fixes https://github.com/ansible/ansible/issues/12873
9 years ago
Toshio Kuratomi 01dcee98d2 Fix for state=latest with wildcard or virtual provide package names 9 years ago
Brian Coca f6bbd2ac5b removed syslog in favor of common module logging functions 9 years ago
Greg DeKoenigsberg 0813c5fb40 Change author field for os_redhat_subscription.py 9 years ago
Marius Gedminas eb17b6a36c apt: check for "0 upgraded" to be at the beginning of the line
Fixes #1678.
9 years ago
Toshio Kuratomi b29276df34 Merge pull request #1204 from detiber/test_rhsm
bugfixes for redhat_subscription
9 years ago
Toshio Kuratomi 4721d6d8b5 Fix for the case where plugins aren't loaded on old RHEL systems 9 years ago
Toshio Kuratomi c228739f2d Merge pull request #1946 from ansible/pr/1657
Update check-mode results to be a dictionary (finishes pr 1657)
9 years ago