Commit Graph

28 Commits (6f8a29dc3d464515a51e4ee5618f3a0d816c5986)

Author SHA1 Message Date
James Cammarata c8376e296f Tweaking change to documentation language for cron name param 10 years ago
James Cammarata 509761249c Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel 10 years ago
Matt Parker 6086c505fe Update cron documenation
The "name" parameter seems to be rather important as the identifying feature of a cron job.  This is an update to the documentation to further emphasize this.
10 years ago
Matt Parker 5accd15ba6 Name appears to be a required parameter
As far as I can tell, `name` is a required parameter.  The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear.  Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too.  However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
10 years ago
Markus Amalthea Magnuson a58709ac1d Use correct parameter name in error message.
The parameter is called `cron_file` but the error message uses `file` which is confusing.
11 years ago
James Cammarata 6ad83bb5ce Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel 11 years ago
Adam Chainz 6b10cf756a Fix grammar and value errors in cron documentation 11 years ago
James Tanner 0025273fca Fixes syntax error in cron module caused by #6870 11 years ago
MorrisA ac72d44219 Modified Cron to add AIX Crontab support, changed according to suggestions
from mpdehaan and redone entirely.
11 years ago
Michael DeHaan 3d8997d219 Name is not required, update docs. 11 years ago
Joshua Lund 74962a0e35 Update cron module documentation. The 'name' parameter is required. 11 years ago
Tim G 32d48d75e9 Bugfix, fix crontab commands on HP-UX 11 years ago
Michael DeHaan 29138b1872 More shell updates 11 years ago
James Tanner 38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago
nextus 6d701cb517 Don't allow cron module to delete cron_file without name parameter assignment 11 years ago
nextus f0ea92cc75 Fix: absent state removing whole cron.d file instead of specific job 11 years ago
jctanner fc51fb8853 Merge pull request #4304 from ferringb/fixes/cron-permissions
Enforce umask for cron module, so cron_file generated files are 0644.
11 years ago
Jim Richardson 71bf839121 return True/False from remove_job_file()
revised fix for https://github.com/ansible/ansible/issues/4795
11 years ago
Jim Richardson dd313b1b8f fix for https://github.com/ansible/ansible/issues/4795
Incorrect changed result in cron module.
Report changed=False if no cron is removed:wq
11 years ago
Michael Scherer 2a3ee8dbf4 make cron module work on solaris
Cron on solaris do not take the same
set of option than vixie cron on linux, and
among the biggest difference, root cannot set
the crontab of a user directly from a file. Thus the
use of su to run the crontab command. Fix issue #4648
11 years ago
Michael Scherer 5547cc9c29 remove unused function 11 years ago
Brian Harring 487aa9a1ec Enforce umask for cron module, so cron_file generated files are 0644.
Certain cron implementations get cranky if files in cron.* are group
writable.
11 years ago
James Cammarata b4306920ce Fix for the cron module on FreeBSD
Apparently crontab on freebsd does not like the file path coming before
the "-u username" portion of the command to install the crontab
11 years ago
Michael DeHaan 5b80299231 Make exceptions handling python 2.4 compatible. 11 years ago
Michael DeHaan 3f4c6affa3 Update CHANGELOG 11 years ago
Patrick Callahan f37becb94a Bug fixes and enhancements.
Bugs:
(1) no longer allow empty jobs
(2) strip the header added by crontab package used in openSuSE and SuSE
(3) try not to leak temp files when things go wrong
(4) issue returning job names under certain conditions

Enhancements:
(1) Allow all special times not just reboot.
(2) Fail earlier by performing more input validation
(3) Add feature to allow removing cron file under /etc/cron.d

ToDo:
(1) Validate times (minute, hour, ...)
(2) Strip white space from fields such as name and job such that name=foo equals name=' foo'.
(3) More testing
12 years ago
Jan-Piet Mens 3404a0fc16 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
12 years ago
Michael DeHaan cd97a4cb14 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago