Commit Graph

6173 Commits (6c73aa7ad68d3ba00a81f4ec89aefae869912f45)

Author SHA1 Message Date
James Cammarata 15135f3c16 Make sure we're using the original host when processing include results
Also fixes a bug where we were passing an incorrect number of parameters to
_do_handler_run() when processing an include file in a handler task/block.

Fixes #13560
9 years ago
James Cammarata 857456ea5f Fixing template integration test for python 2.6 versions
No longer immediately fallback to to_json if simplejson is not installed
9 years ago
Toshio Kuratomi fd4ad2c8f2 Update submodule ref to fix a bug in mysql_user with mariadb 9 years ago
James Cammarata 8716bf8021 All variables in complex args again
Also updates the CHANGELOG to note the slight change, where bare variables
in args are no longer allowed to be bare variables

Fixes #13518
9 years ago
James Cammarata 76b4b9ed2c Merge pull request #13501 from chouseknecht/galaxy-2.0-update
Galaxy 2.0 update
9 years ago
nitzmahone baece499df fix plugin loading for Windows modules
force plugin loader to only consider .py files, since that's the only place docs can live ATM...
9 years ago
Toshio Kuratomi 9724117bbb Update submodule refs for mysql refactor 9 years ago
Toshio Kuratomi 1116bc6ca6 Merge pull request #13191 from Jmainguy/mysql
Add shared connection code for mysql modules
9 years ago
Jonathan Mainguy 34e88e48a5 Add shared connection code for mysql modules 9 years ago
James Cammarata 6a252a3f77 Preserve the cumulative path for checking includes which have parents
Otherwise, each relative include path is checked on its own, rather
than in relation to the (possibly relative) path of its parent, meaning
includes multiple level deep may fail to find the correct (or any) file.

Fixes #13472
9 years ago
Toshio Kuratomi 0095d04af9 Update submodule refs 9 years ago
Toshio Kuratomi 7d519127fe Merge pull request #13573 from ansible/ssl-context-with-proxy
Fix a few problems with url handling.
9 years ago
Toshio Kuratomi 33863eb653 Conditionally create the CustomHTTPSConnection class only if we have the required baseclasses.
Fixes #11918
9 years ago
Toshio Kuratomi 72a0654b81 Fixes for proxy on RHEL5 9 years ago
Toshio Kuratomi 73ead4fbba First attempt to fix https certificate errors through a proxy with python-2.7.9+
Fixes #12549
9 years ago
Brian Coca 97275110d7 Merge pull request #13533 from bcoca/debug_fixes
debug now validates its params
9 years ago
James Cammarata fcc9258b74 Use the original host rather than the serialized one when processing results
Fixes #13526
Fixes #13564
Fixes #13566
9 years ago
Toshio Kuratomi d203438a2c Merge pull request #13554 from Yannig/devel_fix_python3_tests
Use six lib to import urlparse properly.
9 years ago
Brian Coca be5488cb60 clean debug output to match prev versions 9 years ago
Brian Coca a0842781a6 renamed ssh.py shared module file to clarify 9 years ago
Yannig Perré be4d1f9ee3 Fix a part of python 3 tests (make tests-py3, see https://github.com/ansible/ansible/issues/13553 for more details). 9 years ago
Peter Sprygada 27cd7668c1 the ssh shared module will try to use keys if the password is not supplied
The current ssh shared module forces only password based authentication.  This
change will allow the ssh module to use keys if a password is not provided.
9 years ago
Toshio Kuratomi 8d16638fec Fix for template module not creating a file that was not present when force=false 9 years ago
Michael Scherer a7ac98262d Make module_utils.known_hosts.get_fqdn work on ipv6 9 years ago
Toshio Kuratomi c9eb41109f Update submodule refs 9 years ago
James Cammarata 80d23d639c Use an octal representation that works from 2.4->3+ for known_hosts 9 years ago
James Cammarata 6312e38133 Fixing up some non-py3 things for unit tests 9 years ago
Brian Coca 2a37f11738 Merge pull request #13542 from h0nIg/devel_default_ask
ansible vault, ask pass: use default settings from ansible.cfg
9 years ago
Hans-Joachim Kliemeck f5f9b2fd35 use default settings from ansible.cfg 9 years ago
James Cammarata f8ff63f8c8 A few tweaks to improve new forking code 9 years ago
Brian Coca 175c2d6510 Merge pull request #13502 from robinro/patch-3
use shallow clones by default in ansible-pull
9 years ago
Toshio Kuratomi 2bc3683d41 Restore comment about for-else since it is an uncommon idiom 9 years ago
chouseknecht 06dde0d332 Fixed documentation typos and bits that needed clarification. Fixed missing spaces in VALID_ACTIONS. 9 years ago
chouseknecht 342dee0023 Define and handle ignore_certs correctly. Preserve search term order. Tweak to Galaxy docsite. 9 years ago
chouseknecht bc73920090 Updated ansible-galaxy man page. Removed -b option for import. 9 years ago
chouseknecht d8e6bc98a2 Fix overloaded options. Show an error when no action given. Don't show a helpful list of commands and descriptions. 9 years ago
Robin Roth 1bd8d97093 fix whitespace 9 years ago
Robin Roth 1b2ebe8def make shallow clone the default for ansibel-pull 9 years ago
Brian Coca d73562902b debug now validates its params
simplified var handling
made default message the same as in pre 2.0
fixes #13532
9 years ago
Brian Coca f3bedbae29 simplified skippy
thanks agaffney!
9 years ago
Brian Coca 99e46440bd changed shell delimiters for csh
fixes #13459
9 years ago
Brian Coca 8e445c551a removed unused imports in galaxy/cli 9 years ago
James Cammarata 120b9a7ac6 Changing the way workers are forked 9 years ago
Brian Coca ae988ed753 avoid set to unique hosts to preserver order
swiched to using a list comp and set to still unique but keep expected order
fixes #13522
9 years ago
Brian Coca de71171fc2 removed merge conflict 9 years ago
James Cammarata 7f7e730dea Don't mark hosts failed if they've moved to a rescue portion of a block
Fixes #13521
9 years ago
Brian Coca d9e510b192 narrow down exception catching in block builds
this was obscuring other errors and should have always been narrow scope
9 years ago
Chrrrles Paul e56efa49c4 Merge pull request #13509 from chrrrles/vca_default_host
fix default host for non vcd service types
9 years ago
Abhijit Menon-Sen 37c4e9aee3 Clean up debug logging around _low_level_execute_command
We were logging the command to be executed many times, which made debug
logs very hard to read. Now we do it only once.

Also makes the logged ssh command line cut-and-paste-able (the lack of
which has confused a number of people by now; the problem being that we
pass the command as a single argument to execve(), so it doesn't need an
extra level of quoting as it does when you try to run it by hand).
9 years ago
Charles Paul a6a58d6947 fix default host for non vcd service types 9 years ago
Toshio Kuratomi bd9582d072 Update submodule refs 9 years ago
Toshio Kuratomi 1dda8158ff become_pass needs to be bytes when it is passed to ssh.
Fixes #13240
9 years ago
Charles Paul 6680cc7052 allow custom callbacks with adhoc cli for scripting
missing import of CallbackBase
9 years ago
Robin Roth c20c1a6d49 add depth option to ansible-pull
Allows shallow checkouts in ansible-pull by adding `--depth 1` (or higher number)
9 years ago
James Cammarata 2b36343451 Missed one place we were appending the incorrectly escaped item to raw params 9 years ago
Toshio Kuratomi 62cbc03af6 Revert "Remove the funcd connection plugin"
This reverts commit c0d79cf7e1.

We may still port the funcd connection plugin, just not in time for
2.0.0
9 years ago
James Cammarata 30b6dd8bcd Merge pull request #13495 from Yannig/devel_debug_null_error
Do not fail when variable is not correct in debug action.
9 years ago
Yannig Perré 18ac12aee6 Do not fail when variable is not correct in debug action.
See https://github.com/ansible/ansible/issues/13484 for more information.
9 years ago
Toshio Kuratomi c0d79cf7e1 Remove the funcd connection plugin 9 years ago
Brian Coca 64864829c4 changed deprecation to removal warning 9 years ago
Toshio Kuratomi 61dc4a7e67 Update module refs 9 years ago
James Cammarata 14e19c239d Make on_file_diff callback item-aware 9 years ago
Brian Coca 04d74fd680 reenabled --tree for ansible adhoc command
previous fix to avoid callbacks now conflicted with tree optoin
which is implemented as a callback in 2.0
9 years ago
Brian Coca 7936a4687e adhoc avoids callbacks by default as it did before
Previous emptying of whitelist only affected callbacks that were
constructed for need whitelist. This now works for all callbacks.
9 years ago
Brian Coca ae2447df91 attribute defaults that are containers are a copy
This is simpler way to prevent persistent containers across instances
of classes that use field attributes
9 years ago
Brian Coca 2bfb13bfb3 removed unused 'pattern' from ansible.cfg
also moved the config param to a 'deprecated' list in constants.py
added TODO for producing a deprecation warning for such vars
9 years ago
Brian Coca 2820b4c243 removed default from hosts to make it requried
prevents writing a play w/o a hosts entry which would default to
all/empty
9 years ago
Brian Coca c64298de02 Revert "avoid persistent containers in attribute defaults"
This reverts commit 87969868d4.
found better way to do it
9 years ago
James Cammarata 332a008273 Merge pull request #13489 from chouseknecht/galaxy-2.0
Galaxy 2.0
9 years ago
chouseknecht 4f84769a17 Galaxy 2.0 9 years ago
Brian Coca 87969868d4 avoid persistent containers in attribute defaults
moved from the field attribute declaration and created a placeholder
which then is resolved in the field attribute class.

this is to avoid unwanted persistent of the defaults across objects which introduces
stealth bugs when multiple objects of the same kind are used in succession while
not overriding the default values.
9 years ago
Brian Coca 0719eb3e2d clarified warning from tree callback 9 years ago
Brian Coca d82d65ee7b keep string type filters as strings
now we don't try to convert types if using a filter that outputs a specifically formated string
made list of filters configurable
9 years ago
James Cammarata 1799de8528 Preserve original token when appending to _raw_params in parse_kv
Fixes #13311
9 years ago
Brian Coca 795fac917e fixed typo in tree callback, added default dir
this would allow it to work with playbooks also
9 years ago
James Cammarata 398f6bbb89 Fix typo from 5ae850c 9 years ago
James Cammarata de690445bc Make fact delegating configurable, defaulting to 1.x behavior 9 years ago
Brian Coca 7ffd578a9d Revert "Fix always_run support in the action plugin for template when copying"
This reverts commit 9c4eae5253.
9 years ago
Brian Coca d4ccb0be59 have always_run override check mode for a task
Fixes #13418
9 years ago
James Cammarata 9c4eae5253 Fix always_run support in the action plugin for template when copying
Fixes #13418
9 years ago
David L Ballenger cdc3c88018 Merge remote-tracking branch 'ansible/devel' into issue_13438 9 years ago
Peter Sprygada 2d5b4b1799 Merge pull request #13273 from privateip/nxapi
adds new device argument to nxapi command arguments
9 years ago
David L Ballenger 970d7cadb7 Add ssh_host support for MacOSX El Capitan.
OS X El Capitan moved the /etc/ssh_* files into /etc/ssh/. This fix
adds a distribution version check for Darwin to set the keydir
appropriately on El Capitan and later.
9 years ago
Brian Coca 9ae1dede03 adhoc does not load plugins by default
reimplemented feature from 1.x which kept additional callbacks from
poluting adhoc unless specifically asked for through configuration.
9 years ago
Brian Coca 17b334d4a5 Merge pull request #13450 from privateip/feature_ios_shared_module
bugfix for ios.py shared module argument creation
9 years ago
James Cammarata 540cbe0f64 Merge pull request #13445 from n-st/tasks-string-repr
More meaningful string representation for meta tasks (like 'noop' and 'flush_handlers')
9 years ago
James Cammarata 2884ff3932 Merge pull request #13455 from Yannig/devel_fix_debug_var_when_content_same_as_name
Fix issue when var name is the same as content.
9 years ago
Yannig Perré 2c8eee956f Fix issue when var name is the same as content.
See https://github.com/ansible/ansible/issues/13453 for more details.
9 years ago
Toshio Kuratomi 4d637e5780 Use self.args when we parse arguments that way the arguments can be constructed manually 9 years ago
Toshio Kuratomi a8e015cc22 Add representers so we can output yaml for all the types we read in from yaml 9 years ago
Peter Sprygada 41773630ed adds new device argument to nxapi command arguments
The device argument allows a dict of nxapi parameters to be passed to
the module to simplify passing the nxapi parameters
9 years ago
Brian Coca 8607aa527d Merge pull request #13446 from lberruti/no_target_syslog
Make no_target_syslog consistent.
9 years ago
Brian Coca 955710267c only set become defaults at last possible moment
tasks were overriding commandline with their defaults, not with the
explicit setting, removed the setting of defaults from task init and
pushed down to play context at last possible moment.
fixes #13362
9 years ago
Luca Berruti 8ea45e8608 Make no_target_syslog consistent.
no_target_syslog = False --> do log on target
9 years ago
Brian Coca f89f906f87 simplified get_hosts code to have 1 retrun point 9 years ago
Nils Steinger a1f6d17e37 More meaningful string representation for meta tasks (like 'noop' and 'flush_handlers') 9 years ago
Nils Steinger 0129fb0a44 Remove duplicates from host list *before* caching it
Ansible previously added hosts to the host list multiple times for commands
like `ansible -i 'localhost,' -c local -m ping 'localhost,localhost'
--list-hosts`.
8d5f36a fixed the obvious error, but still added the un-deduplicated list to a
cache, so all future invocations of get_hosts() would retrieve a
non-deduplicated list.
This caused problems down the line: For some reason, Ansible only ever
schedules "flush_handlers" tasks (instead of scheduling any actual tasks from
the playbook) for hosts that are contained in the host lists multiple times.
This probably happens because the host states are stored in a dictionary
indexed by the hostnames, so duplicate hostname would cause the state to be
overwritten by subsequent invocations of … something.
9 years ago
Toshio Kuratomi c8fd599e14 Merge pull request #13373 from no2a/boolean
BOOLEAN should contain boolean literals
9 years ago
Toshio Kuratomi 0434644d12 Transform exceptions into ansible messages via to_unicode instead of str to avoid tracebacks.
Fixes #13385
9 years ago
James Cammarata 84507aedd4 Adding a uuid field so we can track host equality across serialization too 9 years ago
James Cammarata 750adbaa27 Changing up how host (in)equality is checked
Fixes #13397
9 years ago
Toshio Kuratomi e385c91fa5 Update submodule refs# 9 years ago
Brian Coca d5446f9804 fixed ansible-pull broken options
* sudo was not working, now it supports full become
* now default checkout dir works, not only when specifying
* paths for checkout dir get expanded
* fixed limit options for playbook
* added verbose and debug info
9 years ago
Brian Coca e1c62fb5af reverted to previous pull checkout dir behaviour
This fixes bugs with not finding plays when not specifying checkout dir
Also makes it backwards compatible
9 years ago
Brian Coca 8d5f36a6c2 return unique list of hosts 9 years ago
Brian Coca a1f516824e corrected playbook path, reformated options help
the last just to make the help consistent and readable
9 years ago
Brian Coca 26520442bd Now and/or shell expressions depend on shell plugin
This should fix issues with fish shell users as && and || are
not valid syntax, fish uses actual 'and' and 'or' programs.
Also updated to allow for fish backticks pushed quotes to subshell,
fish seems to handle spaces w/o them.
Lastly, removed encompassing subshell () for fish compatibility.
fixes #13199
9 years ago
James Cammarata f467f1770f Properly compare object references for Hosts when adding new ones
Fixes #13397
9 years ago
James Cammarata 4426b7f6e0 fix sorting of groups for host vars
Fixes #13371
9 years ago
Brian Coca 7d073bdd17 Merge pull request #13345 from amenonsen/extract
Add an 'extract' filter
9 years ago
Peter Sprygada 29f5c5db71 bugfix for ios.py shared module argument creation
This patch fixes a bug in module_utils/ios.py where the the wrong shared
module arguments are being generated.  This bug prevented the shared module
from operating correctly.  This patch should be generally applied.
9 years ago
James Cammarata 5f83a6aeda Properly default remote_user for delegated-to hosts
Fixes #13323
9 years ago
Toshio Kuratomi e201a255d1 Revert "Make sudo+requiretty and ANSIBLE_PIPELINING work together"
This reverts commit f488de8599.

Reverting for now due to hard to pin down bugs: #13410  #13411
9 years ago
Toshio Kuratomi 9b81c35d06 Don't compare or merge str with unicode
Fixes #13387
9 years ago
James Cammarata a183972477 Don't use play vars in HostVars
Fixes #13398
9 years ago
James Cammarata 8ff67e0494 Default msg param to AnsibleError to avoid serialization problems 9 years ago
James Cammarata 5f1f2acfea Merge pull request #13405 from sivel/v2-playbook-on-start
Get v2_playbook_on_start working
9 years ago
Matt Martz 384b2e0234 Get v2_playbook_on_start working
* Move self._tqm.load_callbacks() earlier to ensure that v2_on_playbook_start can fire
* Pass the playbook instance to v2_on_playbook_start
* Add a _file_name instance attribute to the playbook
9 years ago
Brian Coca 7708661270 Merge pull request #13402 from amenonsen/expandpath
Use CLI.expand_tilde also for the vault --output file
9 years ago
Brian Coca 94d2958e1f Merge pull request #13403 from amenonsen/module-lang
Make module_lang default to whatever LANG is set to on the control node
9 years ago
Abhijit Menon-Sen 0d16d16ab8 Make module_lang default to whatever LANG is set to on the control node 9 years ago
Abhijit Menon-Sen fac7626230 Use CLI.expand_tilde also for the vault --output file 9 years ago
Matt Martz ce54a59cdc Catch additional assertion errors for load_list_of_blocks 9 years ago
Brian Coca 53cd802251 better error on invalid task lists 9 years ago
James Cammarata f7dc5a9515 Minor tweak and comment addition to 974a0ce3 9 years ago
James Cammarata f1d53a87e5 Merge pull request #13394 from Christoph-D/issue-13370
Fix #13370
9 years ago
Abhijit Menon-Sen 8cf1815867 Add an 'extract' filter
At its most basic, this is nothing more than an array or hash lookup,
but when used in conjunction with map, it is very useful. For example,
while constructing an "ssh-keyscan …" command to update known_hosts on
all hosts in a group, one can get a list of IP addresses with:

    groups['x']|map('extract', hostvars, 'ec2_ip_address')|list

This returns hostvars[a].ec2_ip_address, hostvars[b].ec2_ip_address, and
so on. You can even specify an array of keys for a recursive lookup, and
mix string and integer keys depending on what you're looking up:

    ['localhost']|map('extract', hostvars, ['vars','group_names',0])|first
        == hostvars['localhost']['vars']['group_names'][0]
            == 'ungrouped'

Includes documentation and tests.
9 years ago
Abhijit Menon-Sen 22381be253 Bump version in devel now that stable-2.0 has been branched 9 years ago
Christoph Dittmann 267199fdd5 Update debug messages and comments
The comment was taken literally from lib/plugins/strategy/linear.py and
makes no sense in free.py where we have no noop tasks.

Also update the debug messages.
9 years ago
Christoph Dittmann c6e400fbea Fix issue #13370
all_blocks is referenced after the loop over included_files, so it needs
to be initialized before this loop, not inside.
9 years ago
Christoph Dittmann 9a6ae1d62a Let PlayIterator.add_tasks accept empty task lists
PlayIterator.add_tasks raised an error when trying to add an empty task
list.  This was the root cause of ansible issue #13370.
9 years ago
Brian Coca b92cb93539 unconditionally set vars on init to avoid issues with var precedence 9 years ago
Peter Sprygada 2491afc8b6 fixes a syntax issue with module_utils/eapi.py
This patch fixes an issue with the common args dict in the eapi shared
module.  This patch is required for the eapi shared module to be properly
imported and is therefore should be applied to all instances.
9 years ago
Brian Coca 8c630406c9 Merge pull request #13357 from privateip/feature_ssh_shared_module
initial add of ssh shared module.
9 years ago
Brian Coca 923b5467e3 Merge pull request #13354 from privateip/feature_eapi
adds device common argument to shared module
9 years ago
Brian Coca 574d7be8d5 Merge pull request #13358 from privateip/feature_ios_shared_module
Feature ios shared module
9 years ago
Peter Sprygada 93cd7a2a5f adds module create function for eapi.py shared module
This commit changes the way modules create an instance of AnsibleModule to
now use a common function, eapi_module.  This function will now automatically
append the common argument spec to the module argument_spec.  Module
arguments can override common module arguments
9 years ago
Peter Sprygada 8638e0ccf8 initial add of the ios shared module
This adds shared module support for building modules that connect to Cisco
IOS devices.  It builds on the module_utils/ssh.py shared module.
9 years ago
Brian Coca 3e01516783 fixed signature for init on callbacks
also removed passing display to base class which already handles this
9 years ago
nitzmahone c94509f273 allow shell plugin to affect remote module filename
Fix for 13368, added get_remote_filename to shell plugins, powershell version appends .ps1 if necessary, base shell plugin no-ops
9 years ago
Abhijit Menon-Sen f488de8599 Make sudo+requiretty and ANSIBLE_PIPELINING work together
Pipelining is a *significant* performance benefit, because each task can
be completed with a single SSH connection (vs. one ssh connection at the
start to mkdir, plus one sftp and one ssh per task).

Pipelining is disabled by default in Ansible because it conflicts with
the use of sudo if 'Defaults requiretty' is set in /etc/sudoers (as it
is on Red Hat) and su (which always requires a tty).

We can (and already do) make sudo/su happy by using "ssh -t" to allocate
a tty, but then the python interpreter goes into interactive mode and is
unhappy with module source being written to its stdin, per the following
comment from connections/ssh.py:

        # we can only use tty when we are not pipelining the modules.
        # piping data into /usr/bin/python inside a tty automatically
        # invokes the python interactive-mode but the modules are not
        # compatible with the interactive-mode ("unexpected indent"
        # mainly because of empty lines)

Instead of the (current) drastic solution of turning off pipelining when
we use a tty, we can instead use a tty but suppress the behaviour of the
Python interpreter to switch to interactive mode. The easiest way to do
this is to make its stdin *not* be a tty, e.g. with cat|python.

This works, but there's a problem: ssh will ignore -t if its input isn't
really a tty. So we could open a pseudo-tty and use that as ssh's stdin,
but if we then write Python source into it, it's all echoed back to us
(because we're a tty). So we have to use -tt to force tty allocation; in
that case, however, ssh puts the tty into "raw" mode (~ICANON), so there
is no good way for the process on the other end to detect EOF on stdin.
So if we do:

    echo -e "print('hello world')\n"|ssh -tt someho.st "cat|python"

…it hangs forever, because cat keeps on reading input even after we've
closed our pipe into ssh's stdin. We can get around this by writing a
special __EOF__ marker after writing in_data, and doing this:

    echo -e "print('hello world')\n__EOF__\n"|ssh -tt someho.st "sed -ne '/__EOF__/q' -e p|python"

This works fine, but in fact I use a clever python one-liner by mgedmin
to achieve the same effect without depending on sed (at the expense of a
much longer command line, alas; Python really isn't one-liner-friendly).

We also enable pipelining by default as a consequence.
9 years ago
Toshio Kuratomi 50553bc2ba _connect no longer takes a port argument 9 years ago
Brian Coca f1fcab4610 ignore password flags in become conflict check
since all the --ask pass options end up triggering the same code
and are functionally equivalent, ignore them when it comes to checking
privilege escalation conflicts. This allows using -K when --become-method=su
and so on.
9 years ago
Brian Coca a6f6a80caa avoid inheritance issues with default=dict declaration at class level
this should avoid the issue of subsequent plays not prompting for a var
prompted for in a previous play.
9 years ago
Toshio Kuratomi 30094912eb boto is expecting that we pass it unicode strings.
The secret_key parameter especially can contain non-ascii characters and
will throw an error if such a string is passed as a byte str.

Potential fix for #13303
9 years ago
Arata Notsu 6d6d4f0c8e BOOLEAN should contain boolean literals
It is natural that an argument_spec with choises=BOOLEAN accepts
boolean literal (True, False) though the current implementation
allows only string or int.
9 years ago
Toshio Kuratomi ba4e571029 Update submodule refs to go along with the StandardError change in ec2 moudles 9 years ago
Toshio Kuratomi 19d5759771 raise AnsibleAWSError instead of StandardError.
* StandardError doesn't exist in python3
* because it is the root of builtin expections, we can't catch it
  separate from the builtin exceptions
* It doesn't tell us anything about the error being thrown as it's too
  generic
9 years ago
James Cammarata dc0fae1af7 Also make sure remote_user is defaulted correctly for delegated hosts
Fixes #13323
9 years ago
Toshio Kuratomi e2ddc2f6ab Call the function :-)
Fixes #13330
9 years ago
James Cammarata cc36eedf76 Ensure port is (re)set for delegated-to hosts
Fixes #13265
9 years ago
Brian Coca b5f2c3def2 fixed typo 9 years ago
Brian Coca eefb4931dd allow for bad stdout return from make temp dir command
fixes #13359
9 years ago
Brian Coca 005b17afec corrected become_methods class variable in winrm
This should now correctly react when using become with winrm
fixes #13331
9 years ago
James Cammarata 80db6bacc4 Make sure run_once tasks properly set variables for all active hosts
Fixes #13267
9 years ago
James Cammarata fbc9553bd4 Use text_type instead of unicode 9 years ago
James Cammarata c6a30f7000 Make sure the uuid in vars is string 9 years ago
James Cammarata f926e81782 Re-implement lookup wantlist
Fixes #13285
9 years ago
James Cammarata dfa576b037 Merge pull request #13307 from Yannig/devel_fix_big_include_vars
Fix for https://github.com/ansible/ansible/issues/13221
9 years ago
Peter Sprygada c087160652 initial add of ssh shared module.
This ssh shared module is used for building modules that require an
interactive shell environment such as those required for connecting
to network devices
9 years ago
James Cammarata 6671d78f95 Tweak location of stats callback execution and properly relocate stats output code 9 years ago
James Cammarata ea23159be4 Merge pull request #13348 from emonty/bug/iterate-on-none
Put in trap for args being None
9 years ago
Monty Taylor d20e67d708 Put in trap for args being None
_normalize_old_style_args can return None. If it does, the loop
"for args in args" blows up.
9 years ago
James Cammarata 800811a15f Trigger on_stats just once, not once for each play
Fixes #13271
9 years ago
James Cammarata a7f7f8bd29 Merge pull request #13297 from amenonsen/ssh-escalation
Explicitly accept become_success in awaiting_prompt state
9 years ago
James Cammarata 5b6162a166 Re-adding role_name/role_uuid variables 9 years ago
James Cammarata 8d9835c40b Merge pull request #13342 from Yannig/devel_fix_bomb_shell
Devel fix bomb shell
9 years ago
Yannig Perré 5227c6bb52 Do not copy variable_manager each time. Instead, keep host and local variable_manager sync.
Fix https://github.com/ansible/ansible/issues/13221
9 years ago
Yannig Perré 2fc7c8b460 More restrictive test against variable name to allow setting variable starting with _. 9 years ago
Brian Coca fa358d9d61 avoids prompting for vars during syntax check
fixes #13319
9 years ago
Yannig Perré 2c54fb1339 Switch parameters validation after parsing in order to be more consistent between old and new style. 9 years ago
Abhijit Menon-Sen f20e2630b0 Explicitly accept become_success in awaiting_prompt state
If we request escalation with a password, we start in expecting_prompt
state. If the escalation then succeeds without the password, i.e., the
become_success response arrives, we must explicitly move into the next
state (awaiting_escalation, which immediately goes into ready_to_send),
so that we no longer try to apply the timeout.

Otherwise, we would leak the success notification and eventually
timeout. But if the module response did arrive before the timeout
expired, the "process has already exited" test would do the right
thing by accident (which is why it didn't fail more often).

Fixes #13289
9 years ago
Toshio Kuratomi 1b743436b9 Do not double transform to unicode 9 years ago
Chrrrles Paul 157230c3e8 Merge pull request #13257 from chrrrles/utf8
fixing error with using non-ascii values for ask-sudo-password
9 years ago
Charles Paul 1e5a205389 fixing errors with utf-8 values
removing utf-8 stanza

changing cast to binary_type instead

using to_unicode
9 years ago
Brian Coca 71fe49ee3a Merge pull request #13247 from bcoca/fetch_fixes
fixes to fetch action module
9 years ago
Brian Coca 7244b5ae49 added missing : 9 years ago
Brian Coca 0ec60ac09b added missing events to base class 9 years ago
James Cammarata 70de8bc96f Fix ssh state issues by simply assuming it's never connected 9 years ago
James Cammarata 65747285a4 Properly check for prompting state when re-using ssh connection
Fixes #13278
9 years ago
James Cammarata 96fcfe45d0 Merge pull request #13264 from Yannig/devel_debug_var_list_or_dict
Allow debug var parameter to accept a list or dict.
9 years ago
Yannig Perré 5fa49a9ad8 Use to_unicode instead of str() 9 years ago
James Cammarata 679488fdb5 Merge pull request #13239 from sysreq0/devel
We should give pipes.quote() a string every time
9 years ago
James Cammarata 53e86f3130 Merge pull request #13261 from cchurch/with_items_reuse_connection
Modify task executor to reuse connections inside a loop.
9 years ago
James Cammarata e06b107d2d Template (and include vars) PlaybookInclude paths
Fixes #13249
9 years ago
Chris Church 272778f732 Modify task executor to reuse connection inside a loop. Fix WinRM connection to set _connected properly and display when remote shell is opened/closed. Add integration test using raw + with_items. 9 years ago
Toshio Kuratomi adf2d53fa2 Update submodule refs 9 years ago
Yannig Perré 0480b44f50 Allow debug var parameter to accept a list or dict. Fix https://github.com/ansible/ansible/issues/13252 9 years ago
Brian Coca 478c6c756a marked spot that should send per item reulsts 9 years ago
Brian Coca fb96748d7c fixes to fetch action module
* now only runs remote checksum when needed (fixes #12290)
 * unified return points to simplify program flow
9 years ago
Toshio Kuratomi 2631a8e6e4 Update extras to fix docs build 9 years ago
Toshio Kuratomi 8fd15ae2a3 Merge pull request #13217 from ansible/more-strict-plugin-lookup
Fix non-module plugins picking up files that did not end in .py.
9 years ago
Toshio Kuratomi 77c83fd520 Commit submodule refs to the devel HEAD 9 years ago
Toshio Kuratomi 664c7980a2 Update submodule refs 9 years ago
Sebastien Couture 087dbc1ed5 We should give pipes.quote() a string every time 9 years ago
Toshio Kuratomi 591c81e95f Docker cp sets file ownership to root:root so we can't use it.
Fixes #13219
9 years ago
Toshio Kuratomi d75e707af5 Simplify code a little 9 years ago
Toshio Kuratomi 72558f7ecd Merge pull request #13074 from joernheissler/patch-13073
Use ansible_host in synchronize module
9 years ago
Toshio Kuratomi c86120cea6 Fix non-module plugins picking up files that did not end in .py.
This was caused by accessing the cache using the passed in mod_type
rather than the suffix that we calculate with knowledge of whether this
is a module or non-module plugin.
9 years ago
James Cammarata c97c101bd3 Merge pull request #13209 from nitzmahone/winrm_put_file
fast winrm put_file without size restrictions
9 years ago
James Cammarata 8a0d2e0ef2 Submodule pointer update 9 years ago
James Cammarata 91500f8f5f Fix include param precedence in variable manager 9 years ago
James Cammarata 78e4f176e6 Return skipped/failed async results directly
Fixes #13205
9 years ago
James Cammarata 3b16ad973c Merge pull request #13201 from ma82/patch-1
Fix DataLoader's docstring
9 years ago
Marius Gedminas 66347c9449 Fix NameError when using loops
vars_copy disappeared in 3d1255d190.

Fixes #13213.
9 years ago
nitzmahone db83c0e7cd winrm error handling tweaks 9 years ago
James Cammarata 3d1255d190 Don't update job vars too early when getting loop items in TaskExecutor
Fixes #13113
9 years ago
Brian Coca f8ed99e5e4 Revert "success should not include skipped"
This reverts commit 300ee227a2.
9 years ago
nitzmahone 549163170f fast winrm put_file without size restrictions 9 years ago
Matteo Acerbi 0127d32652 Fix DataLoader's docstring
DataLoader.__init__ doesn't take an argument named vault_password
9 years ago
James Cammarata 9b9fb51d9d Template the final_environment value in _compute_environment_string()
Fixes #13123
9 years ago
Toshio Kuratomi 782aa9a7fd Update submodule refs 9 years ago
James Cammarata 180159b01d Adding vars back in and trying to add a little more speed by avoiding copies 9 years ago
James Cammarata 25807f5404 Don't modify things we've put on the queue
Fixes #12937
9 years ago
Brian Coca d35f615af8 added more debug info for command results 9 years ago
Brian Coca aa55db69fe Merge pull request #12687 from nitzmahone/pywinrm_arg_passthru
Force SSL transport for pywinrm updates, get host+group vars
9 years ago
James Cammarata f10d2c57c8 Restoring templating of hostvars returned by __getitem__ 9 years ago
James Cammarata 9f31c073fe Fixing a few bugs in the HostVars performance areas
* Also refresh inventory in the HostVars manager process when things
  are changed via add_host/group_by
* Raise j2undefined rather than return it
9 years ago
James Cammarata 984729016e Fix tag filtering on included files and add more debugging
Previously, we were filtering the task list on tags for each host
that was including the file, based on the idea that the variables
had to include the host information. However, the top level task
filtering is play-context only, which should also apply to the
included tasks. Tags cannot and should not be based on hostvars.
9 years ago
James Cammarata 5cbeab5a3c Performance improvements for HostVars and some bugfixes 9 years ago
Dann Bohn 7f2cae5405 add REPLACER_SELINUX back into module_common 9 years ago
Brian Coca 355fa4797a Merge pull request #13186 from nitzmahone/add_host_cache_fix
fix for dynamic (add_host) hosts not available in hostvars
9 years ago
Brian Coca 6a2559be02 Merge pull request #13184 from nitzmahone/hostvars_undefined_fix
hostvars should return j2 undefined as instance, not type
9 years ago
Toshio Kuratomi fc7e2912f2 zone connection plugin bugfixes and pipelining and sudo become methods enabled!
Thanks to peinheber for helping test and debug this!
9 years ago
nitzmahone 349e072a74 fix for dynamic (add_host) hosts not available in hostvars
Looks like there are two pattern caches that need to be cleared for this to work- added the second one.
Added integration tests for add_host to prevent future regressions.
9 years ago
nitzmahone 3bb1f7a561 hostvars should return j2 undefined as instance, not type
Looks like someone forgot to create an instance of undefined here- we were returning the undefined type object, which broke all the undefined checks.

Added an integration test around add_host that will catch this (separate PR to follow)
9 years ago
Brian Coca db27541a0e Merge pull request #13053 from Etherdaemon/fix_13010_boto3_aws_profile
Fixes #13010 by updating boto3 methods
9 years ago
Brian Coca 89646d4253 no need to be executable 9 years ago
Jonathan Davila 1b76a9cef2 Patch to remove dependency on boto when only using boto3
Updated with explicit check for HAS_BOTO3
9 years ago
Brian Coca 2083a2dffa Merge pull request #13174 from sebi-hgdata/sebi/consul_kv_issue
Consul kv lookup super invocation fix
9 years ago
Brian Coca 83f7942dcf removed print entries, corrected display calls to match latest devel 9 years ago
Brian Coca 78be81b96d Merge pull request #12510 from jcftang/devel
Initial add of logentries callback plugin
9 years ago
Brian Coca f1db99caa7 updated with latest changes to default 9 years ago
Brian Coca eeedaf2cbc fixed var name typo 9 years ago
Brian Coca e174247734 evaluate includes for skipped tags
cannot evaluate for include tags as underlying tasks might have them, but skips override so this should be a performance boost
9 years ago
Sebi Calbaza 1f052d5ce6 fixed super invocation 9 years ago
Brian Coca 300ee227a2 success should not include skipped
fixes #13161
9 years ago
Jimmy Tang 19ba54c9fd Don't be fatal on import errors so plays don't fail if plugin doesn't have required dependencies 9 years ago
Jimmy Tang 125370ab48 Run when whitelisted 9 years ago
Jimmy Tang 5f2f5e2b59 Add boilerplate and fix initialisation to match what 2.0 expects 9 years ago
Jimmy Tang c02ceb8f12 Remove threading and queues. Added license information and cleaned up callback. 9 years ago
Jimmy Tang 85277c8aae Initial add of logentries callback plugin
This callback plugin will generate json objects to be sent to the
logentries service for auditing/debugging purposes.

To use:

Add this to your ansible.cfg file in the defaults block

    [defaults]
    callback_plugins = ./callback_plugins
    callback_stdout = logentries
    callback_whitelist = logentries

Copy the callback plugin into the callback_plugings directory

Either set the environment variables

    export LOGENTRIES_API=data.logentries.com
    export LOGENTRIES_PORT=10000
    export LOGENTRIES_ANSIBLE_TOKEN=dd21fc88-f00a-43ff-b977-e3a4233c53af

Or create a logentries.ini config file that sites next to the plugin with the following contents

    [logentries]
    api = data.logentries.com
    port = 10000
    tls_port = 20000
    use_tls = no
    token = dd21fc88-f00a-43ff-b977-e3a4233c53af
9 years ago
James Cammarata 07b588f6c0 Version bump for new beta 2.0.0-0.5.beta3 9 years ago
James Cammarata 2b25b7974c Remove unnecessary sleep from result process 9 years ago
Brian Coca 634e10e5b8 Merge pull request #13156 from amenonsen/broken-timeout
If ssh died, it's an error, not a timeout
9 years ago
Abhijit Menon-Sen 26ea9c4351 If ssh died, it's an error, not a timeout 9 years ago
David M. Lee 5bd096208c Increase the escalation prompt timeout
It was set to match the SSH connect timeout. Unfortunately, they would
race when ssh fails to connect, and the connect timeout usually failed.
This led to some misleading error messages.

Fixes #12916
9 years ago
James Cammarata 31b1abf580 Merge pull request #13146 from nitzmahone/gce_error_messaging
fix gce module error reporting
9 years ago
nitzmahone 4163655099 fix gce module error reporting
Error reporting was broken for GCE modules- pprint didn't work with exceptions, so you'd always get "Unexpected response: {}" instead of the real error.
9 years ago
Toshio Kuratomi 958fb29b78 Merge pull request #12881 from Scypho/devel
fix for issue #11885 - allowing json in lookup template calls
9 years ago
James Cammarata 13750f68ee Reduce spinning while waiting on queues 9 years ago
Daniel Menet 0918416b83 substitute tilde and env vars before storing C.CACHE_PLUGIN_CONNECTION as instance attribute 9 years ago
Toshio Kuratomi 7fd8b86a10 Fix documentation build problems 9 years ago
Toshio Kuratomi d38ac6a394 Update submodule ref for another new module 9 years ago
Toshio Kuratomi 7807e99bca A bunch of shipit's merged 9 years ago
Toshio Kuratomi 8aa2cbd647 Fix traceback because we're using display from another object that no
longer has it.
9 years ago
James Cammarata b2b0fa8d13 Changed do/until failed color
Fixes #13130
9 years ago
James Cammarata 94c20c9ac6 Cleanup failed/changed logic in TaskExecutor
Fixes #12980
9 years ago
Toshio Kuratomi 62979efa14 Finish up plugin porting to global display
Also remove display = display which does nothing
9 years ago
Toshio Kuratomi 2bd695ed42 Port cache plugins to global display 9 years ago
Toshio Kuratomi b05d0b8c9c Port lookup plugins to global display. 9 years ago
Toshio Kuratomi 4c7128da17 Port action plugins to global display 9 years ago
Toshio Kuratomi 186e034515 Move the rest of executor code to global display 9 years ago
Toshio Kuratomi 7ecfa072da Move the rest of the playbook code to use global display 9 years ago
Toshio Kuratomi aa4f213cb5 Move connection plugins to using global display 9 years ago
Toshio Kuratomi 318bfbb207 Migrate cli and dependencies to use global display 9 years ago
Brian Coca 1b7d3f2898 updated submodule refs 9 years ago
Brian Coca 99f45f2e19 pass task args without filtering, copy module needs to explcitly support
remote_src or it will remove the src file
9 years ago
Toshio Kuratomi c7b69127ec Remove dead code 9 years ago
Toshio Kuratomi e45ce871a7 Fix for traceback when neither name nor pkg are in the module params 9 years ago
Toshio Kuratomi 4737305837 Remove dead code as this was moved to another class 9 years ago
Brian Coca be22a670e5 addes deprecated information to ansible-doc display
fixes #13118
9 years ago
Brian Coca 1b349fdf34 Merge pull request #13112 from privateip/eapi
add initial support for Arista eAPI
9 years ago
James Cammarata 566144461f Remove internal use of display and use the top-level import 9 years ago
James Cammarata 0fc187893d Catch import warnings in a common location for both get() and all()
Potential solution for #12979
9 years ago
James Cammarata 9f0c2cfda5 Merge pull request #13114 from mgedmin/fix-plugin-loader
Check sys.modules before loading modules
9 years ago
Marius Gedminas 54eae4a793 Check sys.modules before loading modules
Code for a plugin is usually loaded by a PluginLoader(), and henceforth
available from self._module_cache, which prevents duplicate loading.
However there are situations (e.g. where one action plugin imports code
from another one) where the plugin module might be already imported (and
resident in sys.modules), but not present in the PluginLoader's
_module_cache, which causes imp.load_source() to effectively reload the
module, overwriting global class declarations and causing subtle latent
bugs.

Fixes #13110.
Fixes #12979.
9 years ago
James Cammarata a99f2fd52f Save delegated vars in result for use in callback methods
Fixes #13014
9 years ago
Peter Sprygada 2e98f7f429 add initial support for Arista eAPI
This commit adds the shared module support for Arisat EOS devices
running eAPI.  The shared module builds on top of module_utils/urls.py.
9 years ago
James Cammarata e56fd9e95d Make sure pattern cache components are converted to unicode 9 years ago
James Cammarata 0b999c602a Properly figure subset and restrictions into host cache pattern
Fixes #13111
9 years ago
James Cammarata d8fb5efa90 Merge pull request #13102 from Yannig/devel_cache_enhancement
New method template_no_cache for template object.
9 years ago
Yannig Perré 0c360d17cb New parameter for template method.
We do not compute hash when we know that the result does not need to be cached (like with_items loop).
It also result in a small speed improvement.
9 years ago
Etherdaemon 27398131cf Fixes #13010 by updating boto3 methods to update boto3_conn to check for profile_name and if detected, remove from params and set a new variable of profile which is passed into Session separately 9 years ago
James Cammarata 09994c18f3 Correct logic around determining environment variable existence
Fixes #13105
9 years ago
James Cammarata c753ae6e22 Fixing up host pattern caching to avoid bugs
* Always cache and return unique list objects, so that if the list
  is changed later it does not impact the cached results
* Take additional parameters and the type of the pattern into account
  when building the hash string
9 years ago
James Cammarata e8f83dcba3 Revert "Temporarily disable template caching"
This reverts commit 4d1757ce64.
9 years ago
James Cammarata 4d1757ce64 Temporarily disable template caching 9 years ago
Toshio Kuratomi 995db275f8 Update submodule refs 9 years ago
Toshio Kuratomi db5d3f03a9 Fix first_found not finding files in roles (only templates) 9 years ago
James Cammarata ccbcfcddfc Move where we add environment and make it conditional on not existing
Also displays a warning now, because users should not be using that variable
name as it causes a collision with the internal variable of the same name.
9 years ago
Brian Coca 37ae243587 made get_file_lines rely on get_file_content which deals with many error
conditions that the former did not.
9 years ago
ghislainbourgeois eb850d7e5b Fix get_dns_facts on inexistent resolv.conf 9 years ago
James Cammarata e36b4e2a13 Merge pull request #13072 from Yannig/devel_cache_optimization
Cache optimization
9 years ago
James Cammarata 76ae577519 Ensure environment is inherited properly (task->block/include->play) 9 years ago
James Cammarata 937584cd52 Ensure 'environment' is set in the magic variables
Fixes #13033
9 years ago
James Cammarata 7e04947599 Be more selective about what variables we cache during templating
Fixes #13087
9 years ago
Toshio Kuratomi 1a04f354f3 For with_first_found loops, set undefined variables to fall through rather than failing the task 9 years ago
Brian Coca 240acb1924 Merge pull request #13092 from privateip/nxapi
initial shared module support for nxapi
9 years ago
Peter Sprygada f88273eb87 changes the nxapi argument spec to require url_password 9 years ago