Gabe Mulley
84a57b7545
ensure non-root users can read arguments file when using sudo_user
...
Non-standard modules must read in the arguments file in order to access their arguments, however, when this file is transfered to the remote host it may only have the permissions 600. This means that using sudo and sudo_user will result in permission denied errors when attempting to read the arguments file.
This patch fixes #4438 by explicitly forcing the arguments file to be world readable before executing the module.
11 years ago
Brian Coca
bd9acedb57
fixed name colision between warnings dict and module
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Paul Sokolovsky
2e668f14f7
copy: Handle "no copy/propagate attrs only" for recursive mode well.
...
For this, add internal "original_basename" param to file module,
similar to copy module. (Param name is a bit misnormer now, should
be treated as "original basepath").
11 years ago
Paul Sokolovsky
ce88df3cf4
copy: Handle dest path variations for recursive mode.
11 years ago
Paul Sokolovsky
6cf3975e2e
copy: Set suitable default result for check mode.
11 years ago
Paul Sokolovsky
612b446856
copy: Don't modify input module_args in a recursive file handling loop.
11 years ago
Paul Sokolovsky
b3b4f9885f
copy: Implement recursive copying if src is a directory.
...
If src param to copy is a directory, all files under it are collected
and pushed one by one to target. Source dir path handled in a way
simalar to rsync: if it ends with slash, only inside contents of
directory are copied to destination, otherwise the dir itself is
copied (with all contents of course). Original idea and implementation
by https://github.com/ansible/ansible/pull/1809 . Rewritten to address
review comments and simplify/correct logic.
11 years ago
jctanner
69fa5954fd
Merge pull request #3932 from jocelynj/devel
...
Add option remote_user to task level, to specify the ssh login user
11 years ago
Michael DeHaan
e131de4de0
Added "debug: var=variableName" capability.
11 years ago
egghead
ca7e2d283c
Adding os realpath filter.
...
This is particularly useful when wanting to get the absolute path of filepaths found by the 'fileglob' filter.
This also lets you provide absolute paths to roles, which search for files in different areas unless absolutely pathed.
11 years ago
Michael DeHaan
c90a82fd52
Handle possible scenario where conditional might be an integer (whoa!) down the error path. Super rare but fixes #4483 .
11 years ago
Michael DeHaan
9ea54fcaaf
Fixes a dev branch glitch where a conditional could be applied to multiple tasks. Also improves the errors on parsing bad conditionals to make them less confusing to users.
11 years ago
Thomas Omans
632232259a
Adding config flag role_path for common/global roles
...
Using ANSIBLE_ROLE_PATH environment variable or role_path in ansible.cfg
can configure paths where roles will be searched for
extra paths will only be used as a backup once regular locations are exhausted
11 years ago
Michael DeHaan
43df00550d
Merge pull request #3827 from mscherer/disable_callbacks
...
add a way for callback to disable itself
11 years ago
Michael DeHaan
1b2d4c328c
Cache patterns a bit higher up to make things a little more efficient. See #4469 .
11 years ago
Michael DeHaan
d168c709d5
Fix an issue where the ordering of an include statement is processed ahead of the conditional in the included statement,
...
which required a redundant check to see if a variable was defined rather than short circuiting.
Fixes #4469
11 years ago
Michael DeHaan
add45d2ca9
Fixup legacy var detector.
11 years ago
Michael DeHaan
709ffda3d1
Tweak only_if deprecation detector.
11 years ago
Michael DeHaan
a45494a896
Add warnings feature.
11 years ago
Michael DeHaan
9637f620d7
Deprecation warnings of several flavors, nice and purple and can be disabled
...
in ansible.cfg.
11 years ago
Michael DeHaan
a017a69bb3
Have the parser explain another type of YAML gotcha to reduce the need for users to ask how to resolve it.
11 years ago
Michael DeHaan
861f076df5
Tweak the syntax-detector-warning-suggester-message (SDWSM) a little.
11 years ago
Michael DeHaan
41aaad69aa
Make add_host clear the inventory pattern cache, add some more aliases. Fixes #4442 .
11 years ago
jctanner
65ef6a62dc
Merge pull request #4425 from jeromew/ansible_sudo_user_with_items
...
Template sudo_user via with_items
11 years ago
James Cammarata
d73a5da9e5
Merge pull request #4453 from pschwartz/fix_cfg_load_order_to_match_docs
...
GH-4452 Corrected config load order to match docs
11 years ago
Philip Schwartz
65c8c691f7
GH-4452 Corrected config load order to match docs with
...
cwd > ~ > /etc
Signed-off-by: Philip Schwartz <philip.schwartz@rackspace.com>
11 years ago
Matt Martz
61525a97df
Add regex (search, match, regex) jinja2 filters. Fixes #3725
11 years ago
Serge van Ginderachter
c4d20094b4
make changed filter understand results lists
11 years ago
Serge van Ginderachter
e5d45311f9
Implement a |changed filter plugin
11 years ago
Serge van Ginderachter
c2e5f783da
Add caching to pattern enumeration
...
Inventory._hosts_in_unenumerated_pattern()
Was TODO: cache this logic so if called a second time the result is not
recalculated
11 years ago
jeromew
dec364ae80
Template sudo_user via with_items
11 years ago
Michael DeHaan
3f968ff46a
Check one more skipped scenario in with_subelements.
11 years ago
James Cammarata
9124ebb4f1
Clear out complex_args before running async_status
...
When using complex args with an async task, the subsequent runs of
async_status would inherit them, causing a module error (invalid params).
Fixes #3150
11 years ago
Michael DeHaan
2078518735
Allow subelements to work right with skipped results.
11 years ago
Jeremy Price
9da5043f18
Adding path_prefix to run_command so that one can pass in a path to the run environment if you nees something in a non-default path.
11 years ago
James Cammarata
948d019fef
Detect IPv6 addresses in INI inventory
...
Prevents parts of the IPv6 address from being interpreted as a port
(for example, :80).
Fixes #3888
11 years ago
Michael DeHaan
6febc97104
Add a warning about include + with_items so nobody uses it.
11 years ago
James Cammarata
98f6bc1f63
Apply tags to dependent roles correctly
...
Fixes #4339
11 years ago
Michael DeHaan
c69e19c6a6
Enhance references to logging functionality. Fixes #3431 .
11 years ago
Michael DeHaan
f081c68a65
Prevent duplicately loaded handlers from running more than once.
...
Fixes #3863
11 years ago
Michael DeHaan
5ed28efe45
Script module should return changed attribute so handlers always fire, unless "changed_when" is specified.
...
Fixes #4053
11 years ago
Michael DeHaan
a7adc8ef4d
Allow doing things like "groups.groupname" in with_nested.
...
Fixes #3858
11 years ago
Michael DeHaan
5e30cd999c
Make it possible to say:
...
tags: 42
And have the tag be a string, not an int, so --tags matches.
Fixes #4110
11 years ago
Michael DeHaan
8fc46a3a5a
Return inventory objects in the order they are presented. Additionally, fix host slicing such that it works on Python terms with
...
zero indexed lists and a non-inclusive final element.
11 years ago
Michael DeHaan
19386c43a7
Merge
11 years ago
James Cammarata
d10582225b
Merge branch 'issue_4215_fetch_expanduser' into devel
11 years ago
Andrey Shorin
35457b67f5
Pass host to runner_on_file_diff callback
11 years ago
Stoned Elipot
e7957b6d58
Fix group_by: do not group a host for which a condition is false
11 years ago
Michael DeHaan
44e391fd8b
Merge pull request #4255 from mcodd/legacy_vars_fix
...
Fix for legacy_playbook_variables (should fix issue #4254 )
11 years ago
Michael DeHaan
65178290e7
Merge branch 'devel' of git://github.com/nextus/ansible into devel
...
Conflicts:
lib/ansible/constants.py
11 years ago
Michael DeHaan
ea73151757
Add automatic advice when folks hit one of two common but minor YAML gotchas, so they can be more easily correct them on their own.
11 years ago
Michael DeHaan
4987c73bb6
Proper check for raw as module options versus raw being in the string.
11 years ago
James Tanner
52aea868df
Allow for updating host vars in add_host
11 years ago
James Cammarata
d21714a37f
Fix for network byte order issues in accelerate
11 years ago
James Cammarata
912e3a7b0b
Merge branch 'accelerate_improvements' into devel
...
Conflicts:
library/utilities/accelerate
11 years ago
James Cammarata
fa80a17aa3
Make recv_data less greedy so it doesn't eat other packets
11 years ago
James Cammarata
8923a5b0d9
Drop default config value for accelerate timeout to 30 seconds
11 years ago
James Cammarata
12f6957596
Cleaning up some vvvv log messages in accelerate
11 years ago
James Cammarata
8c17711247
Removing accelerate_timeout as a playbook option
...
This will remain in ansible.cfg only.
11 years ago
James Cammarata
d317103371
Added in an accelerate connection timeout setting
11 years ago
James Cammarata
59a5ce23d9
Adding an accelerate_timeout parameter for plays
...
This setting makes the timeout for each play configurable, rather than
hard-coding it at 300 seconds (now the default if left unspecified)
Fixes #4162
11 years ago
James Cammarata
f9c87868ac
Added keepalive packets to accelerate mode
...
Commands will now be started up in a separate task from the main
handler thread, so that it can be monitored for completeness while
sending a keepalive packet back to the controller to avoid a socket
receive timeout.
11 years ago
James Cammarata
8a3f8b757b
Make sure yaml data loaded for role is valid before using it
...
Fixes #4322
11 years ago
James Cammarata
bff47df5ff
Fix issue with ast evaluation of strings
11 years ago
James Cammarata
5b205ae8bd
Merge branch 'fixes/subprocess' of https://github.com/ferringb/ansible into ferringb-fixes/subprocess
11 years ago
James Cammarata
d89ce6ac61
Merge branch 'patch-1' of https://github.com/ustun/ansible into ustun-patch-1
11 years ago
James Cammarata
12a21d94b7
Merge branch 'allow_types_in_ini' of https://github.com/bcoca/ansible into bcoca-allow_types_in_ini
11 years ago
jctanner
32a1dd422c
Merge pull request #4269 from jphalip/issue-4256
...
In the script action: Get around a Python bug.
11 years ago
James Cammarata
7aad576f5f
Minor change to add a space around role name/task delimiter
11 years ago
James Cammarata
1cc1e7058b
Merge branch 'role_report_fix1' of https://github.com/bennojoy/ansible into bennojoy-role_report_fix1
11 years ago
James Cammarata
8ed343cc36
Merge branch 'jsmartin-hide_skipped_hosts' into devel
11 years ago
James Cammarata
6cd8aacc81
Merge branch 'hide_skipped_hosts' of https://github.com/jsmartin/ansible into jsmartin-hide_skipped_hosts
11 years ago
James Cammarata
52a42bf607
Add more verbose debugging options for accelerate
11 years ago
Michael DeHaan
ac0a7d965a
Merge pull request #4306 from sivel/3563-glob
...
Add fileglob Jinja2 filter. Fixes #3563
11 years ago
Matt Martz
535ce97067
Add fileglob Jinja2 filter. Fixes #3563
11 years ago
Brian Harring
d0ad6c581b
For defaults that are integers, enforce it for config supplied values.
...
If a user supplies a string in the config (rather than an int), the code
should fix that- or blow up immediately- rather than allowing that value to
work it's way down and break w/in the connection object; when that happens,
the actual error is opaque and requires pdb.set_trace() to run down.
11 years ago
Brian Harring
2174230315
USE subprocess.Popen API correctly.
...
When collecting stdout/stderr *and* feeding data into a Popen instance,
communicate() must be used to avoid a known deadlocking scenario
when data sizes cross PIPE_BUF (which can be as small as 512, although should
be much larger in practice on linux).
11 years ago
Ustun Ozgur
977b31249a
Update cache check in find_plugin
...
I am not familiar with the internals, but this line looked suspicious.
11 years ago
Julien Phalip
44aeea7afc
In the script action: Get around a bug in that's been fixed in Python 2.7 but not Python 2.6.
...
See: http://bugs.python.org/issue6988
Fixes #4256 .
11 years ago
James Cammarata
039d4c95d9
Merge pull request #4221 from ashorin/unicode-md5
...
Prevent UnicodeEncodeError: 'ascii' codec can't encode characters in pos...
11 years ago
Brian Coca
771435deb4
now ini vars are typed
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
James Martin
d5f20e6b21
Optionally display Skipping [host] messages.
11 years ago
bennojoy
482cb72128
role report fix
11 years ago
Matt Coddington
7f7116de3b
commit 9db4f7a
made a change that also needed to include this to retain correct legacy_playbook_variables behavior
11 years ago
Preston Marshall
3ee7b177e8
Allow storing input from user in a pause prompt
11 years ago
James Cammarata
1c97831288
Merge branch 'empty_inventory' of https://github.com/spil-jasper/ansible into spil-jasper-empty_inventory
11 years ago
James Cammarata
994dfb84fc
Minor pep8 cleanup and CHANGELOG update for do-until
11 years ago
James Cammarata
202c4f5294
Merge branch 'do_until_14' of https://github.com/bennojoy/ansible into bennojoy-do_until_14
11 years ago
James Cammarata
478c400817
Minor pep8 cleanup in the new jail connection plugin
11 years ago
James Cammarata
0e0595bdb2
Merge branch 'jail' of https://github.com/mscherer/ansible into mscherer-jail
11 years ago
bennojoy
70a9a797fa
Fix for accelerate when ansible_ssh_user is specified
11 years ago
Jasper Capel
d4dec5f577
Allow creating empty inventory
...
Instantiating the Inventory class with host_list=None now results in an
empty inventory instead of an error.
11 years ago
nextus
ca96d74572
#4227 in upstream repo
11 years ago
Andrey Shorin
fd101dd2d6
Encode to utf-8 only when needed
11 years ago
Andrey Shorin
21f5bc4242
Prevent UnicodeEncodeError: 'ascii' codec can't encode characters in position ...: ordinal not in range(128)
11 years ago
bennojoy
0e749611ac
doc update and add attempts
11 years ago
bennojoy
21529de82e
dountil feature commit 2
11 years ago
bennojoy
53e48b63a9
dountil feature commit 1
11 years ago
James Cammarata
2f39d37a97
Expand destination path in the fetch action
...
Fixes #4215
11 years ago
Michael DeHaan
319a0f9523
Merge pull request #4154 from mplonka/AIX_MD5
...
using AIX 'csum' command for generating MD5 checksums
11 years ago
Michael DeHaan
7f8126a6c9
Merge pull request #4168 from nigelm/md5_filter
...
Added md5 as a jinja filter - returns hex digest of input
11 years ago
Andrey Shorin
cb4b964070
Allow for dynamic accelerate_port: and port: in plays
11 years ago
James Cammarata
1f674c4a50
Merge branch 'fix_selinux_debian' of https://github.com/mscherer/ansible into mscherer-fix_selinux_debian
11 years ago
Alek Storm
3569a2ffee
Handle AnsibleUndefinedVariable's raised from lookup plugins like jinja2 UndefinedError's
11 years ago
James Cammarata
47b9cc6311
Merge branch 'meta-roles' of https://github.com/eggsby/ansible into eggsby-meta-roles
...
Conflicts:
lib/ansible/playbook/play.py
11 years ago
James Cammarata
27e8675277
Make the role_name in the task its own field for use in the callback
11 years ago
James Cammarata
98cfcec5e2
Correct role name detection
11 years ago
James Cammarata
8dcf386def
Don't set the role name on handlers as this breaks notifications
11 years ago
James Cammarata
a5ee6ff1e5
Display parent role name of tasks in the name line
...
Fixes #4076
11 years ago
James Cammarata
c840cbaad9
Merge branch 'fork_fixes' of https://github.com/akerl/ansible into akerl-fork_fixes
11 years ago
James Cammarata
69cfcf7ed0
Minor change to -vvvv mode to only show debugging info for ssh conns
...
Also added this feature to the CHANGELOG
11 years ago
James Cammarata
d5b96abd80
Added support for -vvvv to enable ssh connection debugging
...
This patch also checks specifically for a return code of 255, which
indicates an unknown SSH error of some kind. When that happens, ansible
will now recommend running with -vvvv (if not enabled) or show the
output from 'ssh -vvv' (when it is enabled)
11 years ago
Nigel Metheringham
f0cc2d6efe
Added md5 as a jinja filter - returns hex digest of input
11 years ago
Timothy Appnel
d8cd3d603e
Straightened out the logic for delegate handling in synchronize action module
11 years ago
Timothy Appnel
61e726fe82
Fix to local delegate_to override and proper sudo handling from @smoothify
11 years ago
Timothy Appnel
32ae6fdd43
Return of sychronize module code for take 3
11 years ago
Thomas Omans
91a4ba2248
allowing a roles to do be made out of dependencies alone
11 years ago
James Cammarata
503f062521
Merge branch 'ferringb-fixes/configurable-ControlPath' into devel
11 years ago
Michael DeHaan
20708e31b1
Merge pull request #4133 from skyl/DIST_MODULE_PATH
...
DEFAULT_MODULE_PATH in setup.py
11 years ago
Marcin Płonka
d0c78bdc83
using AIX 'csum' command for generating MD5 checksums
11 years ago
Brian Harring
5b1b831cc7
Make ssh's ControlPath configurable via ansible.cfg
...
This shouldn't generally be needed unless you're working in an environment
that uses rediculously long FQDNs; if the name is too long, you wind up
hitting unix domain socket filepath limits enforced by ssh.
11 years ago
Stephen Fromm
27b5c2e28c
Fix how module_common handles selevel (issue #4142 )
...
Two fixes:
* parameter name is selevel, not serange.
* Fix split on selinux context to limit to max of 4 since the selevel
may contain ':' characters. This was fixed in
selinux_default_context() and selinux_context().
11 years ago
Skylar Saveland
50bd14faa9
use DEFAULT_MODULE_PATH in setup.py so that there is a chance to override with ANSIBLE_LIBRARY env variable
11 years ago
Les Aker
98bf473cb2
fixes for PTY handling
11 years ago
James Cammarata
458f71b53c
Merge branch 'issue_4129_role_defaults_empty_yaml' into devel
...
Conflicts:
lib/ansible/playbook/play.py
11 years ago
James Cammarata
091a90ee8b
Allow includes to follow the standard format
...
Previously, includes had to receive variables via a special 'vars'
field. With this patch, the include syntax becomes a more natural
datastructure without special fields and is more akin to the way
role includes/dependencies work.
Tested with the following playbook:
---
- hosts: localhost
connection: local
tasks:
- { include: inc1.yml, a: 1 }
- include: inc2.yml
b: 2
- include: inc3.yml
with_items:
- x
- y
- z
Fixes #3481
11 years ago
Skylar Saveland
8dc31f3093
ANSIBLE_DIST_MODULE_PATH environment variable
11 years ago
James Cammarata
c5bb1394b9
Check to make sure default_vars in the datastructure isn't empty
...
Fixes #4129
11 years ago
James Cammarata
5b15010099
Merge branch 'issue_3312_role_links' into devel
11 years ago
James Cammarata
3b801dec72
Merge branch 'failed_when' of https://github.com/hnakamur/ansible into hnakamur-failed_when
11 years ago
James Cammarata
fcc18fa105
Merge branch 'subelements' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-subelements
11 years ago
James Cammarata
aac3090909
Merge branch 'play_remote_user' of https://github.com/bcoca/ansible into bcoca-play_remote_user
11 years ago
James Cammarata
3848e02959
Merge branch 'issue4022' of https://github.com/sfromm/ansible into sfromm-issue4022
...
Conflicts:
lib/ansible/runner/connection_plugins/accelerate.py
11 years ago
James Cammarata
d9cf1dfefb
Merge branch 'fetch' of https://github.com/bpennypacker/ansible into bpennypacker-fetch
11 years ago
James Cammarata
f4b3defcbf
Set sudo in accelerate commands correctly
...
Fixes #4111
11 years ago
Michael DeHaan
5c0dd958e5
Merge pull request #4028 from willthames/lineinfile_userdir
...
Expand tilde in paths in file module
11 years ago
Michael Scherer
5e1828a524
add jail module, based on lxc and chroot connexion plugin
11 years ago
Michael DeHaan
1f0eb32846
Update 1.4 specfile -- no need for node fireball package, release dates
11 years ago
James Cammarata
35d138a0d6
When checking conditionals, don't dereference when the variable contains dashes
...
Fixes #4104
11 years ago
James Cammarata
d0236f6ada
Check for link in path in utils.path_dwim_relative()
...
This allows an included path to be relative to a directory, if the
basedir of the original path is a symlink. In that case, the path
is normalized and the file is searched for in the normalized path.
Fixes #3312
11 years ago
Marcin Kałuża
6786773797
filter out qoutes since they cause random errors
11 years ago
Marcin Kałuża
aab445a28f
add 'chars' parameter to password plugin to allow custom character set
...
It accepts comma separated list of names that are
either string module attributes (ascii_letters,digits, etc)
or are used literally
To enter comma use two commas ',,' somewhere - preferably at the end
Qoutes and double qoutes are not supported
11 years ago
Hiroaki Nakamura
2357194b39
Add failed_when module variable.
...
Implementation note: Ternery operator trick for python prior to 2.5 is used.
(test and [when_true_value] or [when_false_value])[0]
http://stackoverflow.com/questions/394809/ternary-conditional-operator-in-python#comment1466794_394887
11 years ago
Serge van Ginderachter
4f9af7efad
subelements lookup plugin
11 years ago
James Cammarata
75a9357e5e
Fixing role variable precedence for top-level roles
...
Fixes #4026
Fixes #3989
11 years ago
James Cammarata
294451d002
Correctly handle variable issues when evaluating jinja2 when statements
...
Fixes #4025
11 years ago
James Cammarata
bcc2a4b513
Minor fix so the any_errors_fatal value is checked properly
11 years ago
James Cammarata
4025695c00
Merge branch 'devel' of https://github.com/kavink/ansible into kavink-devel
11 years ago
Brian Coca
d47c48e30a
Added remote_user to plays
...
Still compatible with user: but deprecating it so we can have
a matching remote_user: in tasks, cannot be user: because of the
module of the same name. #3932
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Kavin Kankeshwar
c24f6f438b
Avoid ugly formatting due to a long if statement
11 years ago
James Cammarata
6e9fa5019f
Reverting HostVars change from a mapping back to a dictionary
11 years ago
James Laska
546788a1b6
The required package for selinux is libselinux-python
11 years ago
James Cammarata
4e9dee6093
Use StringIO to feed md5 calculation to prevent unicode issues
...
Fixes #4014
11 years ago
James Cammarata
2a47f72139
Merge pull request #4049 from mscherer/fix_no_kerberos
...
Fix no kerberos
11 years ago
Michael Scherer
f489702973
Also add back gssapi-keyex
...
While this is not currently implemented in openssh as far as I know,
there is patch floating around on the web and this may land one day
upstream.
11 years ago
Keiichi Mori
17c39b94a3
support GSSAPIAuth back
...
GSSAPIAuthentication has not been supported
due to PreferredAuthentications trick ( 2bdba17a85
)
11 years ago
James Cammarata
ae9e38daf8
Change hostvars to a mutable mapping to more closely resemble a dict
...
Fixes #4030
11 years ago
James Cammarata
2cbf28385a
Move check for accelerate mode deeper to account for ansible_connection
...
Fixes #4045
11 years ago
James Cammarata
20b0dc4abd
Check for an empty executable passed into the accelerate plugin
...
This was breaking at least the script module, so it would seem best
to check for it and set it to the default executable value
11 years ago
James Cammarata
4bf506f683
Always run the accelerate module as the user specified in the play
...
Currently, the accelerate daemon will be run as the sudo_user if
specified, which is incorrect.
11 years ago
Scott Sturdivant
68bffb1233
Don't force accelerate connection for local actions.
11 years ago
James Cammarata
f6e1bdabea
Ensure ports are set correctly in accelerate module
11 years ago
willthames
fe70ed94e3
Expand tilde in paths in file module
11 years ago
guersam
64db327411
Fix: raise correct error in accelerate mode
11 years ago
kavink
a075ec9831
Bug fix for a crash, when any_errors_fatal is true
...
Reported by Rumen:
TASK: [fail FAIL] *************************************************************
skipping: [hostname.com]
failed: [hostname.com] => {"failed": true}
msg: Failed as requested from task
Traceback (most recent call last):
File "/usr/local/bin/ansible-playbook", line 268, in <module>
sys.exit(main(sys.argv[1:]))
File "/usr/local/bin/ansible-playbook", line 208, in main
pb.run()
File "/Library/Python/2.7/site-packages/ansible/playbook/__init__.py", line 262, in run
if not self._run_play(play):
File "/Library/Python/2.7/site-packages/ansible/playbook/__init__.py", line 580, in _run_play
if (hosts_count - len(host_list)) > int((play.max_fail_pct)/100.0 * hosts_count):
TypeError: object of type 'NoneType' has no len()
11 years ago
Stephen Fromm
d704b55860
Support using paramiko to set up accelerate connection
...
Adds original_transport attribute to Runner to track what the original
transport was before it is changed to 'accelerate'.
If using paramiko in original_transport, uses ParamikoConnection. If
not, falls back to SSHConnection like before.
11 years ago
James Cammarata
fff497a1ae
Make sure the accelerated port is set to a sane value
11 years ago
James Cammarata
cc21e5c90c
Adding hostvars to injected variables in accelerate ssh runner
...
Also some minor cleanup of some fb* variables and functions, which
were remnants of the old fireball2 name
Fixes #4021
11 years ago
James Cammarata
7b13b1e03e
Minor fix to dependency dupe patch
11 years ago
James Cammarata
16258edd7a
Merge branch 'devel-duplicates2' of https://github.com/smoothify/ansible into smoothify-devel-duplicates2
11 years ago
James Cammarata
a202adcae1
Merge branch 'doublecallback' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-doublecallback
11 years ago
smoothify
5337397abd
Second Attempt: Ensure duplicate roles are not loaded in the case of a missing meta/main.yml file.
11 years ago
James Cammarata
c0fecf87d1
Increase default socket timeout to 5 minutes
11 years ago
smoothify
0411ea2867
Ensure duplicate roles are not loaded in the case of a missing meta/main.yml file.
11 years ago
James Cammarata
2e49d2003d
Fix bug where accelerate keyword was not checked for boolean value
...
The play was just checking for the presence of the keyword in the
YAML datastructure, and not the value of the field, so doing something
like variable substitution was always causing the play to be accelerated
11 years ago
James Cammarata
2696135b3b
Display error during launch of accelerated daemon
...
* also minor tweak to the # of retries in the connection attempt
Fixes #4012
11 years ago
James Cammarata
7c1c9b3d10
Fix message in utils related to python-keyczar and fireball/acc mode
11 years ago
James Cammarata
53c2f4c1bb
Fix race condition on creating the temp directory for ControlPersist
...
Fixes #3943
11 years ago
James Cammarata
d05c61d1f0
Merge branch 'devel' into fireball2
...
Conflicts:
lib/ansible/playbook/__init__.py
lib/ansible/playbook/play.py
11 years ago
James Cammarata
50f54f6bda
Making variable names more descriptive for the default variables work
11 years ago
James Cammarata
02b7b79d7e
Re-adding capability of tasks to see a unique view of their own defaults
11 years ago
Stoned Elipot
6cbd94dfae
Avoid duplicates of the 'all' group when using inventory script.
...
Do not recreate an 'all' group when it is in the inventory script's
output, but use the one created upfront.
11 years ago
James Cammarata
266d2008d8
Reverting the role default variables change
...
Loading the default variables in _build_role_dependencies() lead to
a side-effect where those variables were over-riding inventory variables.
11 years ago
James Cammarata
47a89a57fa
Fixing bug in playbook use of default variables in roles
11 years ago
James Cammarata
e0df5b5888
A couple more tweaks to role default variables/dependencies
...
* Default variables are now fed directly into roles, just like the
other variables, so that roles see their unique values rather
than those set at the global level.
* Role dependency duplicates are now determined by checking the params used
when specifying them as dependencies rather than just on the name of the
role. For example, the following would be included twice without having
to specify "allow_duplicates: true":
dependencies:
- { role: foo, x: 1 }
- { role: foo, x: 2 }
11 years ago
James Cammarata
d69d5c294f
Renaming fireball2 as 'accelerate' and removing old references
11 years ago
James Cammarata
736c8b19d3
Added ability to limit role dependencies to just one inclusion
11 years ago
James Cammarata
6f6efa268b
Merge branch 'smoothify-defaults' into devel
11 years ago
James Cammarata
25e3eed519
Fixing a bug in variable precedence for roles and dependencies
11 years ago
James Cammarata
637d3070dc
Allow default variables to be overridden by inventory variables
11 years ago
James Cammarata
9806f89a04
Revert "Construct the multiprocessing manager only once."
...
This reverts commit 1d13ec2da3
.
11 years ago
James Cammarata
7d3ae9fc75
Fixing a few bugs related to fireball2
...
* ssh port not being picked up, always uses default of 22
* forgot to 'import time' in the fireball2 connection plugin
11 years ago
James Cammarata
f66683863e
Merge branch 'defaults' of https://github.com/smoothify/ansible into smoothify-defaults
11 years ago
James Cammarata
faf82bf841
Fix bug with fetch when using sudo: true
...
Fixes #3111
11 years ago
James Cammarata
af1dd7075f
Adding chunked file transfers to fireball2
11 years ago
James Cammarata
959138d00d
Added accelerate_port to plays, and made it configurable
11 years ago
James Cammarata
167f185092
Initial support for running gather_facts through fireball2
11 years ago
James Cammarata
b45342923c
Initial support for sudoable commands over fireball2
...
Caveats:
* requiretty must be disabled in the sudoers config
* asking for a password doesn't work yet, so any sudoers users must
be configured with NOPASSWD
* if not starting the daemon as root, the user running the daemon
must have sudoers entries to allow them to run the command as the
target sudo_user
11 years ago
James Cammarata
4b552457e7
Bail out correctly if socket.recv gets nothing (indicating a closed socket)
11 years ago
James Cammarata
86f01965cd
Fireball2 module will now launch in a proper tmp path
11 years ago