Commit Graph

275 Commits (6a5ad846569f831871c1babec9e6a5147868270c)

Author SHA1 Message Date
James Cammarata c276dec487 Fix issue with symlink path detection
Fixes #7627
Fixes #7664
10 years ago
James Cammarata 090fd0a224 Fix linking issue to directories in file module
The os.path.isdir() returns True for symlinks that point to directories,
so we also need to check to make sure it's not a symlink too.

Fixes #7657
10 years ago
Brian Coca ffb87adbc2 Correctly examine path for relative links in file module
Fixes #7515
Fixes #7537
10 years ago
Kit Westneat aab77b46d8 Fixed documentation for etype parameter on acl module.
The etype parameter just had a copy of the default parameter documentation.
Changed it to reflect what it really is for.
10 years ago
Brian Coca ac14a8d6ad unified calls to fs function vs duplicate functions for file and
directory
10 years ago
James Cammarata 5ec0297c04 Fixing absolute path calculation for file module when linking
Fixes #7403
10 years ago
telsacolton ee60f8f710 Make file hardlink error message reasonble
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
11 years ago
telsacolton 133cbee473 Give reasonable error when symlink fails
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
11 years ago
James Cammarata 8c7aafd5ae Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms 11 years ago
James Cammarata 7faf766305 Merge branch 'devel' of https://github.com/jjshoe/ansible into jjshoe-devel 11 years ago
James Cammarata 261fe0ea96 Merge pull request #7013 from orgoj/replace-patch-changed
module replace - report changed only if contents is changed
11 years ago
James Cammarata 5ce5ba5e58 Refuse to convert a non-empty directory into a link with the file module
Also adds an integration test for the above.

Fixes #7254
11 years ago
someda 5bb888af4b fix #7244 recursive copy fails when setting directory attributes
- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module
11 years ago
Michael DeHaan f57f9c950f Merge pull request #7119 from jjshoe/patch-4
Finish reverting a broken commit in #5679
11 years ago
James Cammarata b53bf7c8b1 Minor tweak to rsync_path construction in synchronize module
Fixes #7182
11 years ago
Skyler Leigh Amador 6eb8759ec5 Remove --timeout option to rsync from synchronize defaults
The current 10-second default timeout for rsync seems to be behind issue #6809.

As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
11 years ago
Joel Schuweiler aed596088b Finish reverting #b73cddc 11 years ago
jjshoe 6f0808b23b Ensure the validation string has %s in it 11 years ago
Brian Coca 1e3860c47b now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Erika Heidi 40e7c6eddc Possible docs error: 'path' instead of 'src'
I came to this example today (line 50), and when I tried it, I got an error:

`msg: src and dest are required for creating links`

So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
11 years ago
Michael Heca 6618c1e8b5 module replace - report changed only if contents is changed 11 years ago
James Cammarata 39356bd83b Get the bin path for commands in the unarchive module
Fixes #6927
11 years ago
James Tanner 0f82a2b53c Addresses #6702 Remove version_added from description string 11 years ago
James Tanner f2c9c2c141 Addresses #6702 set version_added for rsync_opts 11 years ago
jctanner 7a6267690e Merge pull request #6702 from jjshoe/devel
Allow you to pass in arbitrary rsync options
11 years ago
James Tanner fec4c797d9 Fixes #6929 remote file module doc fragments from copy and template 11 years ago
James Tanner 199992adb6 Fixes #6894 create docs fragment for files 11 years ago
James Cammarata 7a03cc69e1 Revert "Fix #5679 again after recent changes in core"
This reverts commit 2bfaacd170.

Fixes #6821
11 years ago
Richard C Isaacson 465b97be7e assemble module: fix insertion of newlines when not needed.
This builds on GH-6359 and changes the logic so that a newline is only inserted between fragments if the previous fragment does not end with a newline.
11 years ago
Peter Gehres 53c1d25c70 Fix for #6353 adding a newline between assembled files 11 years ago
Michael DeHaan 63a1330263 Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
Application to other cloud providers would make very good sense.
11 years ago
James Tanner 7b72004eb4 Merge #5903 from rhaido/ansible
Update files documentation for usage of force=True and hardlinks
11 years ago
cgtx bb3fed67aa backreferences should be double escaped 11 years ago
Michael DeHaan a8b345ad38 Repairs for documentation build. 11 years ago
Michael DeHaan f596ee8850 Slight docs tweak, split lines according to code standards 11 years ago
Andrea.Mandolo 2a66f356b1 correct documentation comment and version_added in "synchronize" module 11 years ago
Andrea.Mandolo 7cd21a47ef Add STDOUT lines in response of "synchronize" module 11 years ago
Andrea.Mandolo 33b440ac9f Add "checksum" option support to 'synchronize' module 11 years ago
Michael DeHaan d1975c906f Merge branch 'update_docs_validate_cmd_not_passed_via_shell' of git://github.com/rwehner/ansible into devel
Conflicts:
	library/files/template
11 years ago
Michael DeHaan 38c3332b8a Merge pull request #6597 from tarka/handle-uncreated-symlink-tmpfile
Handle missing symlink tempfile
11 years ago
jjshoe a5794f5d8c Allow you to pass in arbitrary rsync options. I also added help for it, and what version it was added in. 11 years ago
Jeff Geerling 177bf3eb20 Fixed template validation docs and example. 11 years ago
jjshoe e62b38c250 Show argument dependency
failed: [192.168.1.2] => {"cmd": "rsync --delay-updates -FF --compress --timeout=10 --delete-after --rsh 'ssh -i /home/jjshoe/.vagrant.d/insecure_private_key -o StrictHostKeyChecking=no' --rsync-path 'sudo rsync' --out-format='<<CHANGED>>%i %n%L' /tmp/app vagrant@192.168.1.2:/home/ubuntu/app", "failed": true, "item": "", "rc": 1}
msg: rsync: --delete does not work without --recursive (-r) or --dirs (-d).
rsync error: syntax or usage error (code 1) at main.c(1453) [client=3.0.9]
11 years ago
James Cammarata 68327fa172 Cleanup from merge of replace module and CHANGELOG update 11 years ago
James Cammarata 2c05e337cb Merge branch 'devel' of https://github.com/EvanK/ansible into EvanK-devel 11 years ago
James Cammarata d6a2befb0d Merge branch 'file_fixes_agg' of https://github.com/bcoca/ansible into bcoca-file_fixes_agg 11 years ago
Robert Wehner 406317371b Update 'validate=' parameter documentation to make clear that the command
passed via this paramter is not passed via shell and so all shell features
will not work.
11 years ago
James Tanner 7c263fcdad Fixes #6590 add set_remote_user parameter to synchronize
This allows usage of custom ssh configs for remote hosts where
the inventory user does not match the configured user.
11 years ago
Steve Smith 5b5af14921 Only unlink the symlink tempfile on error if it was created in the
previous operation.
11 years ago
Brian Coca a395eb3aba fixed issue with tmp file (path can include filename) and added missing
else which made it try to link x2
11 years ago