717 Commits (69deab1786aa0bcfd0347bb4c33a92eabd47170b)

Author	SHA1	Message	Date
Brian Coca	8c8be0e48c	Merge pull request #572 from jrobeson/rename-fedora-hostname-strategy ... [hostname] rename FedoraStratgy to SystemdStrategy	10 years ago
Toshio Kuratomi	2973bac72f	Clarify documented behaviour of user module's ssh_key_file parameter ... Fixes #9873	10 years ago
sysadmin75	aa99eade7e	ansible-modules-core #530 fix - Mount module does not accept spaces in mount point path	10 years ago
Johnny Robeson	50011f13d6	[hostname] rename FedoraStratgy to SystemdStrategy	10 years ago
Jeff Gonzalez	54214f83b5	Added ability to use url as key source	10 years ago
Peter Oliver	18c429d016	Fix appending to a user's group on Solaris ... Without this change, you get: AttributeError: 'set' object has no attribute 'extend' Tested on a Solaris 11.2 client with the included Python 2.6.8.	10 years ago
Toshio Kuratomi	443951ce82	Merge pull request #524 from zitterbacke/patch-1 ... re-enable AIX password setting	10 years ago
Toshio Kuratomi	67aeab9576	Merge pull request #512 from mscherer/fix_438 ... Revert commit cbc417c, as the code is broken, see #438	10 years ago
Jonathan Mainguy	541070be4c	Fixed hostname for rhel5 python 2.4.3	10 years ago
zitterbacke	2e88582165	re-enable AIX password setting ... the AIX class uses a unsafe shell for setting the user password (containing a pipe in the command). This patch adopts to the new behavior of module_utils/basic.py (since somewhere around 1.7). besides it changes the qoutes for the echo command from double to single, because password-hashes contain $-signs and one would not have this variables expanded.	10 years ago
Michael Scherer	39cd64ec17	Revert commit cbc417c, as the code is broken, see #438 ... LooseVersion expect a string, so filtering to return a int is incorrect. Thanks to Jeremy Brown for the analysis.	10 years ago
Toshio Kuratomi	e1f90635af	Don't traceback if a gid is specified instead of a group name ... Fixes https://github.com/ansible/ansible/issues/9796	10 years ago
Patrik Lundin	2acfbf016d	Handle string returned by 'default' correctly. ... We need to handle the string returned by 'default' in the same way we handle the string returned by 'status' since the resulting flags are compared later.	10 years ago
Brian Coca	ba139b145b	fixed hostname for gentoo	10 years ago
Brian Coca	aba9e5e4f9	vastly simplified systemd detection, made enable/disable errors clearer ... both of which allows us to remove 'service name detection' as if systemd is init we still use it to handle initscripts.	10 years ago
Brian Coca	df6d58614e	now actually adds usable name for systemd when service only has init ... script	10 years ago
Toshio Kuratomi	5af4463823	Gixes to doc formatting	10 years ago
Toshio Kuratomi	799a75580a	Update cron example for setting to run twice a day ... Fixes #415	10 years ago
Brian Coca	943f8fe7c9	Merge pull request #346 from bcoca/service_cleanup ... service cleanup	10 years ago
Jonathan Mainguy	a75bef5bc6	Fixes bind mounts ... Fixed tab's and spaces, or so I think I did Fixed tabs and spaces for real this time	10 years ago
Achilleas Pipinellis	a375ce33d3	Clarify supported init systems.	10 years ago
Pascal Borreli	32a00ec3a3	Fixed typo	10 years ago
Fabrice Bernhard	1ef8c26c0e	Typo in comments ... Credit goes to @kbsali @pborreli : you did not see that one? :-)	10 years ago
Brian Coca	29d211e7ab	service cleanup	10 years ago
Brian Coca	f49120598f	service now detects systemd is actually running, not just installed	10 years ago
Jonathan Mainguy	8b8008569f	fixes user module for rhel5 by using -n instead of -N, all other distros will still use -N	10 years ago
Robert Estelle	4dd099fe7a	Remove incorrect executable permissions.	10 years ago
Brian Coca	04680ce228	Merge pull request #286 from bcoca/hostname_24_compatible ... made hostname work with python 2.4	10 years ago
Patrik Lundin	eea4d06848	Fix typo: Replace "N0" with "NO".	10 years ago
Brian Coca	83669d7eda	switched to iterator as per comments	10 years ago
Martijn P. Rijkeboer	5257222f33	Fix whitespace around '=' in sysctl.conf.	10 years ago
Brian Coca	e4b6968901	made hostname work with python 2.4	10 years ago
David Fritzsche	c96a85fb70	Add working status detection for pf on FreeBSD ... The return code of "service pf onestatus" is usually zero on FreeBSD (tested with FreeBSD 10.0), even if pf is not running. So the service module always thinks that pf is running, even when it needs to be started.	10 years ago
Toshio Kuratomi	7f611468a8	Fix for systemd service scripts with newlines ... Fixes #127	10 years ago
Patrik Lundin	f9d9c1b6d7	Multiple fixes for OpenBSD rcctl handling. ... * Use the newly added 'default' argument to know if the default flags are set or not. * Handle that 'status' may either return flags or YES/NO. * Centralize flag handling logic. * Set action variable after check if we need to keep going. Big thanks to @ajacoutot for implementing the rcctl 'default' argument.	10 years ago
Patrik Lundin	e463400412	Simplify self.arguments logic. ... Strange logic pointed out by @jarmani, thanks!	10 years ago
Patrik Lundin	924cf20cf8	Depend more on rcctl if it is present. ... * Make the module support enable/disable of special services like pf via rcctl. Idea and method from @jarmani. * Make the module handle when the user supplied 'arguments' variable does not match the current flags in rc.conf.local. * Update description now that the code tries to use rcctl for everything if it is available.	10 years ago
Patrik Lundin	5f37624eb4	Tweak error checking for "enabled" code. ... Based on input from @jarmani: * A return value of 2 now means a service does not exist. Instead of trying to handle the different meanings of rc after running "status", just look at stderr to know if something failed. * Skip looking at stdout to make the code cleaner. Any errors should turn up on stderr.	10 years ago
Patrik Lundin	c6dd88c1d1	Fail if "rcctl status" writes to stderr.	10 years ago
Patrik Lundin	1a8cdb5e3e	Check rc and print error message if any. ... It is probably good to use stdout before printing a generic error message as well.	10 years ago
Patrik Lundin	c46e030100	Make "enabled" code aware of --check mode.	10 years ago
Jonathan Armani	1b97390765	Add enable / disable of services for OpenBSD if rcctl is present	10 years ago
billwanjohi	ff36edbb11	user: add expired state ... ported from https://github.com/ansible/ansible/pull/6303 It's very useful and routine to disable a *nix user. I implemented expired instead of locked because this prevents any use of the account, safer than just preventing password-based authentication. I have tests [1], but since none of the suite came along with the core modules, I'm unsure how to submit them. [1] https://github.com/billwanjohi/ansible/blob/add_locked_state/test/integration/roles/test_user/tasks/main.yml	10 years ago
kustodian	82af074382	Set selinux state to 'permissive' for state=disabled	10 years ago
Michael Scherer	37d9903169	Add hostname to generated user SSH key comment ... The default is not very useful to sort between different keys and user. Adding the hostname in the comment permit to later sort them if you start to reuse the key and set them in different servers. See https://github.com/ansible/ansible/pull/7420 for the rational.	10 years ago
Michael DeHaan	385a037cd6	package files	10 years ago
Michael DeHaan	c8e1a2077e	file extensions!	10 years ago
Michael DeHaan	417309a626	Restructuring.	10 years ago
Michael DeHaan	73123b69fa	Move modules into subdirectory.	10 years ago
Toshio Kuratomi	8b81062be0	The fix for gh-7284 causes problems for initscripts which have the ... standards compliant return codes but return a verbose error message via stdout. Limit the times when we invoke the heuristic to attempt to work around this.	10 years ago
Michael Scherer	c9a0a7ae4b	Fix #9704, correctly set changed as false when nothing is done	10 years ago
Toshio Kuratomi	7b100dd389	Be more specific in checking if a job restarted successfully. ... Fixes: #9056	10 years ago
Toshio Kuratomi	36083c3b90	Failure to enable a service now fails the task ... Fixes: 8855	10 years ago
Toshio Kuratomi	a50258d26a	remove debugging that was causing failure	10 years ago
Toshio Kuratomi	2e16bd3a44	Refactor the Linux service_enable() method ... * Fix check_mode for initctl systems Fixes #9009	10 years ago
Toshio Kuratomi	104401805b	Revert "Refactor the Linux service_enable() method" needs some debugging ... This reverts commit e294e31fd3.	10 years ago
Toshio Kuratomi	c362902f50	Refactor the Linux service_enable() method ... * Fix check_mode for initctl systems Fixes #9009	10 years ago
Toshio Kuratomi	a9928492f7	Make systemd vs rht detection more robust for centos ... Centos 6.x and below use an old RHT style of configuring hostname. CentOS 7.x and better use systemd. Instead of depending on the distribution string which seems to have changed over the course of 6.x we need to explicitly check the version. Fixes #8997	10 years ago
James Cammarata	7edcf21bdc	Move initscript rc check to later in service status check ... Fixes #7284	10 years ago
Michael DeHaan	5aa6ddef7f	Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules.	10 years ago
Patrik Lundin	0abf14ff19	service: use self.changed in service_enable_rcconf(). ... This sets the "changed" result of the module when a rc file is modified. Previously only --check mode would show that it was going to change.	10 years ago
James Cammarata	30d6713bf0	Add additional checks to detect upstart services ... Also adds checks for the upstart version, in order to test check support for manual vs. start on manual	10 years ago
Eri Bastos	6f8a29dc3d	Proposed fix for issue #7757	10 years ago
James Cammarata	c8376e296f	Tweaking change to documentation language for cron name param	10 years ago
James Cammarata	509761249c	Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel	10 years ago
James Cammarata	07e77c5bed	Merge pull request #8740 from mattparker/patch-1 ... Name appears to be a required parameter for cron module	10 years ago
James Cammarata	1f2727c607	Merge pull request #8729 from ercpe/openrc-hostname ... Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)	10 years ago
Matt Parker	6086c505fe	Update cron documenation ... The "name" parameter seems to be rather important as the identifying feature of a cron job. This is an update to the documentation to further emphasize this.	10 years ago
Matt Parker	5accd15ba6	Name appears to be a required parameter ... As far as I can tell, `name` is a required parameter. The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear. Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too. However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.	10 years ago
Johann Schmitz	7ef67e3f8b	Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)	10 years ago
Ding Deng	85c6434262	debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7).	10 years ago
Michael DeHaan	60ce2d3853	Fix documentation builds.	10 years ago
Michael DeHaan	f21d6c7980	Merge pull request #8002 from prune998/patch-2 ... added missing force flag on mkfs commandline	10 years ago
Michael DeHaan	185d5a6221	Merge branch 'spelling' of git://github.com/cgar/ansible into devel ... Conflicts: docsite/rst/guide_rax.rst plugins/callbacks/mail.py	10 years ago
Michael DeHaan	66ec9089bd	Update docs.	10 years ago
Michael DeHaan	f6f184b36d	Updating docs.	10 years ago
Brian Coca	aeeefd046f	bumped to 1.7	10 years ago
Brian Coca	5aa2ca762a	added control to fail or not on missing key ... made split 'smarter' but still overridable	10 years ago
Brian Coca	391f8ec600	added getent module to get system data as facts	10 years ago
Serge van Ginderachter	961d4b0d6c	execute the mount after path validation ... This avoids a stale situation where name/path contains some impossible path, but gets configured (faultly) in fstab, and the module only fails after that, when creating that path.	10 years ago
Jonathan Mainguy	650003dd5c	Fixes issue #8339 where Scientific Linux incorrectly tries to use FedoraStrategy of hostnamectl	10 years ago
Michael DeHaan	e978dcf7eb	Merge pull request #8283 from ps-jay/sys_mount_fstype_doc ... Add fstype arg to the mount examples	10 years ago
Michael DeHaan	bc01f2571e	Merge pull request #8311 from neersighted/wrap_distroversion ... Wrap get_distribution_version() in the hostname module	10 years ago
Michael DeHaan	2212b64fd9	Cleaning up explanation of mount module states.	10 years ago
Bjorn Neergaard	cbc417ca1b	Wrap get_distribution_version() in the hostname module ... We wrap get_distribution_version() with a new function, _get_distribution_version(), that returns `0` when the result is a string or `None`. This accounts for the case when get_distribution_version() returns a string, and we try to compare it to a float. We do this in the hostname module instead of the module snippets because other modules may want the real string version.module snippets because other modules may want the real string version.	10 years ago
Michael DeHaan	99ad691950	Merge branch 'ufw' of git://github.com/Trozz/ansible into devel	10 years ago
Michael DeHaan	caba7ac6a6	Merge pull request #7954 from alimony/patch-3 ... cron module: Use correct parameter name in error message.	10 years ago
James Cammarata	03f0d6bec8	Merge pull request #8308 from robinro/extend-hostname-distrolist ... Extended distributions list for hostname module	10 years ago
Robin Roth	7920f4eaf5	Fix extra newline at end of hostname for Fedora ... This fixes a bug introduced by 138b45e3. The hostname has an additional newline at the end which leads to the state always being 'changed: true' even if the hostname is unchanged.	10 years ago
Robin Roth	a26bc9c926	Extended distributions list for hostname module ... Implementations already present	10 years ago
Tom Lazar	d89adce760	FreeBSD 10 compatibility fix ... On FreeBSD the whitespace around the ``=`` triggers a (cryptic) ``no such file or directory`` error. removing the whitespace like above fixes this.	10 years ago
Philip Jay	bb7b290ed8	Add fstype arg to the mount examples ... Needed fstype in the examples, since fstype is a required argument for mount.	10 years ago
Berend de Boer	f46c4ee093	Default for fstab missing, causing KeyError: 'fstab'	10 years ago
James Cammarata	6879e4ff0a	Merge pull request #8223 from renard/create-fstab-if-not-exists ... Create fstab if not exists	10 years ago
Sébastien Gross	e0f7b3f39c	[mount] make sure fstab exists ... This is mainly to prevent from failing with no such file or directory during module execution.	10 years ago
Sébastien Gross	806052a9e5	[mount] Add documentation for fstab option	10 years ago
Hector Acosta	60edb6b04b	Add check_mode support to authorized_key. Fixes #7300 ... Signed-off-by: Hector Acosta <hector.acosta@gmail.com>	10 years ago
Yasser Nabi	8cc894bef2	Enable puppet facts ... Currently facter facts omit facts that a distributed via Puppet. This commit adds the `--puppet` option. In cases where puppet is not installed, the command sends a warning to STDERR *but* completes successfully. So should not cause any issues. The benefit is, filtering can be done based on facts set by Puppet.	10 years ago
Michael DeHaan	96fe275946	Merge pull request #8139 from peterkh/devel ... Fix "TypeError: group id must be integer" if groupid passed in for group key	10 years ago
Ruggero Marchei	ae95ebd075	fix LooseVersion exception with empty distribution_version	10 years ago
Peter Hall	ae67002c15	Fix "TypeError: group id must be integer" if groupid passed in for group ... key	10 years ago
Ruggero Marchei	8d01986617	fix issue #8102	10 years ago
Cristian Ciupitu	72d6e6d805	Remove useless code	11 years ago
Michael Leer	39b34b008c	add interfact documentation #7704	11 years ago
Prune	afb358af77	added missing force flag on mkfs commandline ... even if the option ```force=yes``` is used in the playbook, it is not reflected in the mkfs command line. As force option is dependent of the fs type, a "if-then-else" case have been added. Also, some FS types does not have a force option.	11 years ago
Markus Amalthea Magnuson	a58709ac1d	Use correct parameter name in error message. ... The parameter is called `cron_file` but the error message uses `file` which is confusing.	11 years ago
James Cammarata	936daf6f63	Updating the other classes in the group module to match #7249	11 years ago
James Cammarata	4ca9ebf084	Merge pull request #7249 from jfchevrette/implement-group-checking-if-state-present ... Allow group module to handle check_mode properly when group.state=present and group already exists	11 years ago
James Cammarata	236a2989cc	Merge branch 'lvg_dm_names' of https://github.com/ajsalminen/ansible into ajsalminen-lvg_dm_names	11 years ago
James Cammarata	ad4926e090	Update authors for modprobe module	11 years ago
James Cammarata	974693882e	Merge branch 'add_name' of https://github.com/stygstra/ansible into stygstra-add_name	11 years ago
James Cammarata	6ad83bb5ce	Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel	11 years ago
Michael DeHaan	4fbc2a83e0	Merge pull request #7861 from cchurch/devel ... Windows Remote Support	11 years ago
David Stygstra	cae41d0931	Added author and copyright lines to modules I contributed	11 years ago
Michael DeHaan	8b262d775b	Slight tweak to windows wording.	11 years ago
Matt Martz	cab68bc579	Mention that with windows target hosts, fact_path and filter are not currently supported	11 years ago
James Cammarata	2c22cf46cf	Merge branch '7763' of https://github.com/rmarchei/ansible into rmarchei-7763	11 years ago
James Cammarata	34405ea905	Merge branch 'lvg_fix' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-lvg_fix	11 years ago
Ilya Rusalowski	b1a31ebb84	Set default vg_options to empty string	11 years ago
Ruggero Marchei	f522425415	move get_distribution_version() to basic.py	11 years ago
Ruggero Marchei	bd69e9f265	use different strategy for RHEL >= 7. Fixes 7763	11 years ago
James Cammarata	d35d5ac9d1	Merge pull request #7741 from mgcrea/devel ... Add support for Linaro distribution in hostname module	11 years ago
James Cammarata	3e04d8c70c	Merge pull request #7737 from toddmowen/zfs-fix-7696 ... zfs: fix incompatibility - share.nfs vs sharenfs (issue #7696)	11 years ago
Olivier Louvignes	158d6276eb	Add support for Linaro distribution in hostname module	11 years ago
Todd Owen	34517b0836	zfs: work around incompatibility by renaming share.nfs to sharenfs ... Fixes #7696	11 years ago
rgbkrk	5591e8838d	Error checking and reporting on interface ufw rule	11 years ago
Ron Gomes	73246a49dc	Fix incorrect argument ordering in error message, which provokes a ... printf-related TypeError.	11 years ago
Yann Coleu	f378ed643c	Add primary group in the first user module doc example	11 years ago
Nicolas Brisac	ecda1455bf	open_iscsi module: support RC 21 when listing logged-in target	11 years ago
Brian Coca	5c87e97a45	now module searches for update-alternatives vs hardcoding it	11 years ago
James Cammarata	3a8ebd4325	Pull the link out of the alternatives output when not specified ... Fixes #7414	11 years ago
Adam Chainz	6b10cf756a	Fix grammar and value errors in cron documentation	11 years ago
Luca Berruti	eca36953c8	Make alternatives module python 5 compatible	11 years ago
Jean-Francois Chevrette	8756612599	this should return 0 to indicate a non-failure when check_mode is True	11 years ago
Antti Salminen	a6b482c500	Switch to mapper device name if pvs returns the wrong one.	11 years ago
Carlos E. Garcia	4dcaa9d9fb	multiple spelling error changes	11 years ago
Michael Scherer	4ed4bfff90	Do not fail if we try to generate a ssh key for a user without being root ... If we try to use the user module without being root, it fail on RHEL/Fedora because usermod --help cannot be run. The root cause is lack of permission due to EAL4+ certification, as seen in shadow-utils changelo. So if we cannot run it, assume there is no append. It doesn't matter much since we will not be able to run usermod at all with or without the option.	11 years ago
Chris Lamb	b123b648a0	Correct/update debconf examples - need to specify vtype. ... Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>	11 years ago
Michael Scherer	cf3365b99e	Add a better error message for service ... While migrating my playbook to a newer ansible version, I faced the error message "unknown init system, cannot enable service". It turned out to be caused by a wrong service name that was not expanded anymore. So by giving the name of the service that cannot be enabled and a more precise reason, i think people will be able to diagnose their issue more easily.	11 years ago
Hernandes B. de Sousa	780b5e0bbf	Add missing info for the append option ... Both 'default' and 'choices' options were missing at the documentation.	11 years ago
James Cammarata	0c96e2f33b	Check to make sure the firewalld client is connected before proceeding ... Fixes #6911	11 years ago
Jonathan Davila	a90aa46ed2	Added example demonstrating other functionality	11 years ago
James Tanner	0025273fca	Fixes syntax error in cron module caused by #6870	11 years ago
Eric Lake	58dccfbc29	Adding bold to service doc to call up state and enabled.	11 years ago
MorrisA	ac72d44219	Modified Cron to add AIX Crontab support, changed according to suggestions ... from mpdehaan and redone entirely.	11 years ago
Serge van Ginderachter	867702b26a	lvg module bugfix on vg_options patch ... When no vg_options are passed to the module, 'vg_options' still exists in the module.params dict with a value of None, so the default empty string in the get method is never used. None cannot be "splitted", which backtraced.	11 years ago
Michael DeHaan	3d8997d219	Name is not required, update docs.	11 years ago
Michael DeHaan	7258c15ce1	Merge pull request #6831 from aresch/patch-1 ... Fix _parse_value always returning 0 when not true, false or None.	11 years ago
Andrew Resch	32e5383bef	Fix _parse_value always returning 0 when not true, false or None.	11 years ago
Joshua Lund	74962a0e35	Update cron module documentation. The 'name' parameter is required.	11 years ago