618 Commits (691fbf623fd3466818c92685ec348928f6059f7a)

Author	SHA1	Message	Date
Toshio Kuratomi	a22909c226	Migrate basestring to a python3 compatible type (#17199)	8 years ago
Toshio Kuratomi	57701d7115	Give native strings to selinux library functions. (#17184) ... * Give native strings to selinux library functions. SELinux takes pathnames as native strings. That means we need to convert to bytes on python2 and convert to text on python3. Fixes #17155 * Read kitchen documentation, make module_utils params more like kitchen API * Remove none nonstring strategy and add strict * Raise TypeError on invalid nonstring strategy * Document to_native() * Make unittests for testing module_utils.text	8 years ago
Adrian Likins	a4785c2691	Fix docker connection plugin version tests and py2.6 compat (#16841) ... * Rm py2.7+ code in docker connection plugin The docker connection plugin was using subprocess.check_output which only exists in python 2.7 and later. Connection plugins need to support python2.6 so this replaces it with Popen/communicate() * Handle docker ver errors in docker connection Add unit tests for DockerConnection Fixes #16971	8 years ago
Toshio Kuratomi	d29a7c55fe	Enable some basic.py tests on python3 (#17167)	8 years ago
Adrian Likins	7d41f623dd	Move py34 mock_open compat to compat/test/mock (#17157) ... test/units/plugins/action/test_action.py had code for handling a bug in python 3.4's mock_open that causes errors when reading binary data. Moved to compat/tests/mock.py so other tests can use it by default.	8 years ago
Toshio Kuratomi	bd31cc096a	Fix facts.py for python3 (#17131) ... * Fix facts.py for python3 * Update facts unittest to account for filepaths being byte strings	8 years ago
Adrian Likins	7bd57acda4	Linux mount/fs (lsblk) facts fixes and tests. (#17036) ... Fixes #10779 Refactor some of the block device, mount point, and mtab/fstab facts collection for linux for better performance on systems with lots of block devices. Instead of invoking 'lsblk' for every entry in mtab, invoke it once, then map the results to mtab entries. Change the args used for invoking 'findmnt' since the previous combination of args conflicts, so this would always fail on some systems depending on version. Add test cases for facts Hardware()/Network()/Virtual() classes __new__ method and verify they create the proper subclass based on the platform.system() results. Split out all the 'invoke some command and grab it's output' bits related to linux mount paths into their own methods so it is easier to mock them in unit tests. Fix the DragonFly* classes that did not defined a 'platform' class attribute. This caused FreeBSD systems to potentially get the DragonFly* subclasses incorrectly. In practice it didnt matter much since the DragonFly* subclasses duplicated the FreeBSD ones. Actual DragonFly systems would end up with the generic Hardware() etc instead of the DragonFly* classes. Fix Hardware.__new__() on PY3, passing args to __new__ would cause "object() takes no parameters" errors. So check for PY3 and just call __new__ without the args See https://hg.python.org/cpython/file/44ed0cd3dc6d/Objects/typeobject.c#l2818 for some explaination.	8 years ago
Brian Coca	b1410fa278	fixed tests to accoutn for new parameter	8 years ago
James Cammarata	c669a381d1	Don't immediately return failed for any_errors_fatal tasks ... Instead of immediately returning a failed code (indicating a break in the play execution), we internally 'or' that failure code with the result (now an integer flag instead of a boolean) so that we can properly handle the rescue/always portions of blocks and still remember that the break condition was hit. Fixes #16937	8 years ago
James Cammarata	47acf55fa9	Cache tasks by uuid in PlayIterator for O(1) lookups ... Rather than repeatedly searching for tasks by uuid via iterating over all known blocks, cache the tasks when they are added to the PlayIterator so the lookup becomes a simple key check in a dict.	8 years ago
James Cammarata	e244895174	Avoid copying task parents in TaskExecutor ... As Block.copy() is potentially expensive, avoid copying the parent structure of tasks in TaskExecutor.	8 years ago
James Cammarata	06d4f4ad0e	Move tasks/blocks to a single parent model	8 years ago
James Cammarata	d2b3b2c03e	Performance improvements	8 years ago
James Cammarata	159aa26b36	FEATURE: adding variable serial batches ... This feature changes the scalar value of `serial:` to a list, which allows users to specify a list of values, so batches can be ramped up (commonly called "canary" setups): - hosts: all serial: [1, 5, 10, "100%"] tasks: ...	8 years ago
Brian Coca	e2f17f8d9b	set cwd to task's basedir (#16805) ... * switch cwd to basedir of task This restores previous behaviour in pre 2.0 and allows for 'local type' plugins and actions to have a more predictable relative path. fixes #14489 * removed FIXME since prev commit 'fixes' this * fix tests, now they need a loader (thanks jimi!)	8 years ago
s-hertel	93c5ec42cf	Test GalaxyCLI when no actions are provided ... Adds a new test for GalaxyCLI. Tests cases when: - no actions are provided - invalid actions are provided - each valid action is provided When parser() runs successfully the method returns True, creates a SortedOptParser instance, a Galaxy instance, and updates certain class data.	8 years ago
s-hertel	671f9c3d15	Merge pull request #16783 from s-hertel/test_display_galaxy_info_fix ... fixing a logic error in test_galaxy	8 years ago
s-hertel	3cb5747f54	fixing a logic error in test_galaxy	8 years ago
s-hertel	aae5e50299	Adding a test for GalaxyCLI. Tests exit_without_ignore method.	8 years ago
Christoph Dittmann	d55452d3ed	Adding unit tests for role variable precedence ... Originally from PR #16735	8 years ago
jctanner	238c6461f6	Add a function to check for killed processes in all strategies (#16684) ... * Add a function to check for killed processes so that if any threads are sigkilled or sigtermed, the entire playbook execution is aborted.	8 years ago
Toshio Kuratomi	c8a8f546d4	A little unittest refactoring (#16704) ... A little unittest refactoring * Add a class decorator to generate tests when using a unittest.TestCase base class * Add a TestCase subclass with setUp() and tearDown() that sets up module parameter parsing * Move test_safe_eval to use the class decorator and ModuleTestCase base class * Move testing of set_mode_if_different into its own file and separate some test methods out so we get better errors and more coverage in case of errors. * Naming convention for test cases doesn't need to duplicate information that's already in the file path.	8 years ago
James Cammarata	221520cbad	Fixing type in 293723f (mock_handler -> mock_handler_task)	8 years ago
James Cammarata	0ea2b2a6af	Fix unit test for base strategy in regards to handler changes	8 years ago
s-hertel	e84ab95733	Fixing bug in GalaxyCLI test; creates temp dir for role_path instead … (#16689) ... * Fixing bug in GalaxyCLI test; creates temp dir for role_path instead of installing to /etc/ansible/roles * Update test_galaxy.py	8 years ago
nitzmahone	de549ad675	update action unit test for powershell shebang behavior	8 years ago
s-hertel	9c925eeeab	Adding a test for GalaxyCLI and two methods on which it depends. Tes… (#16651) ... * Adding a test for GalaxyCLI and two methods on which it depends. Tests execute_info method. * Adding a test for GalaxyCLI and two methods on which it depends. Tests execute_remove method. * Update test_galaxy.py * Revising test for GalaxyCLI execute_remove. * Removing mocks	8 years ago
Robin Roth	1f04130c00	add more distribution version tests (#16563) ... * ubuntu 16.04 * solaris 10, 11 * fedora 22, 25 Thanks Peter Oliver for providing the test data	9 years ago
Matt Clay	292785ff2b	Parse async response in async action. (#16534) ... * Parse async response in async action. * Add async test for non-JSON data before module output. * Fix existing async unit test. Resolves #16156	9 years ago
jctanner	4ba60d00c8	Refactor the parameter splitting in ini lookup to handle more path formats (#16477) ... Refactor the parameter splitting in ini lookup to handle more path formats. Fixes #16468	9 years ago
James Cammarata	ca6ee4c789	FEATURE: handler listeners ... Fixes ansible/proposals#8	9 years ago
James Cammarata	8218591fec	Track notified handlers by object rather than simply their name ... Due to the fact that roles may be instantiated with different sets of params (multiple inclusions of the same role or via role dependencies), simply tracking notified handlers by name does not work. This patch changes the way we track handler notifications by using the handler object itself instead of just the name, allowing for multiple internal instances. Normally this would be bad, but we also modify the way we search for handlers by first looking at the notifying tasks dependency chain (ensuring that roles find their own handlers first) and then at the main list of handlers, using the first match it finds. This patch also modifies the way we setup the internal list of handlers, which should allow us to correctly identify if a notified handler exists more easily. Fixes #15084	9 years ago
Nate Coraor	706778ee7f	Fix distro detection for Solaris derivatives	9 years ago
jctanner	587d3c368b	Fix synchronize+vagrant dest assertions that were incorrect. (#16291) ... Addresses #16284	9 years ago
Dag Wieers	d91df20620	Fix unit tests for module_name commit #16087	9 years ago
Brian Coca	a529a60478	raw should not use default executable (#16085) ... also removed unused cruft in script	9 years ago
James Cammarata	fbec2d9692	Expand return code values returned by TQM and strategies ... This allows the PlaybookExecutor to receive more information regarding what happened internal to the TaskQueueManager and strategy, to determine things like whether or not the play iteration should stop. Fixes #15523	9 years ago
James Cammarata	61f132a609	Adding unit tests for playbook group/host vars	9 years ago
Toshio Kuratomi	5a3493be5f	Port urls.py to python3 and other byte vs text fixes (#16124) ... * Port urls.py to python3 Fixes (largely normalizing byte vs text strings) for python3 * Rework what we do with attributes that aren't set already. * Comments	9 years ago
Matt Clay	7a533406f9	Merge pull request #13145 from Mic92/devel ... lxc connection plugin	9 years ago
Saran Ahluwalia	fda927a14b	added failing test for testing if executable is not empty string	9 years ago
Toshio Kuratomi	f86df7c88b	Test that task.args are also set properly (#15950)	9 years ago
Adrian Likins	644f0fb190	Merge pull request #15178 from alikins/galaxy_info_output ... galaxy info displayed 'galaxy_info' section wrong [fix for #15177]	9 years ago
jctanner	c52cea8db3	Add a framework, fixtures and test for common synchronize scenarios. (#15983) ... * Add a framework, fixtures and test for common synchronize scenarios. Addresses #15905	9 years ago
jctanner	373b23cc24	Fix mock loader for osx /etc symlinks (#16074) ... Fix role based unit tests for osx via mock.patch	9 years ago
Adrian Likins	1468538414	galaxy info displayed 'galaxy_info' section wrong ... The output of 'ansible-galaxy info' was formatting the 'galaxy_info' key with one char per line. Previously, when building the output string, items in role_info that had a dict for value, the label for it's key ('galaxy_info' for ex) was being added to the text list in addition to being appended. Only the append is needed. Also added a unit test in test/units/cli/test_galaxy.py, but skip it on py3 until galaxy is py3 compatible. fixes #15177	9 years ago
jctanner	018d3c3118	Add a new vmware inventory script backed by pyvmomi (#15967) ... Add a new dynamic vmware inventory script backed by pyvmomi	9 years ago
Jörg Thalheim	88482234e6	lxc connection plugin	9 years ago
Brian Coca	329c62e914	docker was deprecated, test now reflects new name	9 years ago
Toshio Kuratomi	b41b6b2ec5	Update test off make_become for ssh pty race mitigation (#15931)	9 years ago
Robin Roth	85477fa215	Don't use 'from ansible.module_utils import foo' style here as it breaks (#15756) ... py.test"	9 years ago
Toshio Kuratomi	c1cc9f1f23	Merge pull request #15845 from abadger/ziploader-constants ... Ship constants to the modules via internal module params rather than a secondary dict	9 years ago
Toshio Kuratomi	186337db28	Ship constants to the modules via internal module params rather than a secondary dict.	9 years ago
Matt Davis	bc7405efc9	Merge pull request #15797 from robinro/patch-1 ... reduce async timeout in unittests	9 years ago
Matt Martz	196453b9b2	Merge pull request #13771 from sivel/binary-modules ... First pass at allowing binary modules	9 years ago
Matt Martz	0faddfa168	Move binary module detection into executor/module_common.py	9 years ago
Matt Martz	3466e73c50	Resolve test failures	9 years ago
Toshio Kuratomi	292f0ed0d6	If we can't squash for any reason, then simply do not optimize the items loop. ... Also add more squashing testcases Fixes #15649	9 years ago
Toshio Kuratomi	8a184381af	Strip junk after JSON return. (#15822) ... Fixes #15601	9 years ago
Toshio Kuratomi	c730af5dc2	Remove reload from arg related tests. Changes to how ziploader passes args mean we don't need reload anymore. (#15782)	9 years ago
Robin Roth	254cf9ea68	reduce async timeout ... reduce from 3 sec to 0.1 sec; the 3 sec sleep was about half of the total unittest time on my development machine...	9 years ago
Toshio Kuratomi	5c7ad654db	Add some more tests for item squashing	9 years ago
nitzmahone	133395db30	add jimi-c's unit test for squashed skip results, tweaked is_skipped() logic to pass	9 years ago
Robin Roth	1d6608e84f	Dist version fix for Red Hat and more tests (#15663) ... * add tests for centos6, rhel6 and rhel7 * gen_distribution_version_testcase with python2.6 * remove unused imports * fix redhat/vmware/... parsing * add centos7 test case	9 years ago
Toshio Kuratomi	487e6562ca	Fix ziploader for the cornercase of ansible invoking ansible. ... * Make ziploader's ansible and ansible.module_utils libraries into namespace packages. * Move __version__ and __author__ from ansible/__init__ to ansible/release.py. This is because namespace packages only load one __init__.py. If that is not the __init__.py with the author and version info then those won't be available. * In ziplaoder, move the version ito ANSIBLE_CONSTANTS. * Change PluginLoader to properly construct the path to the plugins even when namespace packages are present.	9 years ago
Toshio Kuratomi	d652b2edc0	Fix for unittests on python2.6 or less	9 years ago
Toshio Kuratomi	7e1fbe2e03	Some algorithmic unittests for the apt and docker modules	9 years ago
Tegan Snyder	bf0da4aa3c	add centrify dzdo escalation (#15219) ... add dzdo context, and test	9 years ago
Toshio Kuratomi	44e21f7062	Allow AnsibleModules to be instantiated more than once in a module ... Fix SELINUX monkeypatch in test_basic	9 years ago
Toshio Kuratomi	03126f7097	Fix cut and paste error of test code	9 years ago
Toshio Kuratomi	0a31c24938	Merge pull request #15419 from nitzmahone/module_debug_arg_override ... add _load_params debug overrides for module args/file passed on cmdline	9 years ago
James Cammarata	6eefc11c39	Make the loop variable (item by default) settable per task ... Required for include+with* tasks which may include files that also have tasks containing a with* loop. Fixes #12736	9 years ago
nitzmahone	5b336832af	add _load_params debug overrides for module args/file passed on cmdline ... Updated python module wrapper explode method to drop 'args' file next to module. Both execute() and excommunicate() debug methods now pass the module args via file to enable debuggers that are picky about stdin. Updated unit tests to use a context manager for masking/restoring default streams and argv.	9 years ago
Robin Roth	49cdc565c5	remove nose.tools use	9 years ago
Robin Roth	4088aa2b4c	get rid of assert_in	9 years ago
Robin Roth	692bf51fde	move gen_testcase to hacking/tests ... * also use json instead of pprint	9 years ago
Robin Roth	37188ea336	cleanup tests ... * use nose test generator * more comments * move facts import inside the skipped function, fix python3 warning	9 years ago
Robin Roth	2b104fe6ad	fix tests for SLES and CoreOS ... * include #15230	9 years ago
Robin Roth	3c883d8a6d	add testcases from refactor PR	9 years ago
Toshio Kuratomi	208ad36ce4	Merge pull request #15344 from abadger/ziploader ... Ziploader "recursive imports" and caching	9 years ago
Jonathon Klobucar	7bee994e1c	Fix for serial when percent amount is less than one host (#15396) ... Ansible when there was a percentage that was calculated to be less than 1.0 would run all hosts as the value for a rolling update. The error is due to the fact that Python will round a float that is under 1.0 to 0, which will trigger the case of 0 hosts. The 0 host case tells ansible to run all hosts. The fix will see if the percentage calculation after int conversion is 0 and will else to 1 host.	9 years ago
Toshio Kuratomi	75546678d9	Fix unittests	9 years ago
Toshio Kuratomi	dcc5dfdf81	Controller-side module caching. ... This makes our recursive, ast.parse performance measures as fast as pre-ziploader baseline. Since this unittest isn't testing that the returned module data is correct we don't need to worry about os.rename not having any module data. Should devise a separate test for the module and caching code	9 years ago
Strahinja Kustudić	eed6cf5dad	Adds 'ansible_check_mode' boolean magic variable ... * Makes it possible to pass any options variable to VariableManager by changing `load_options_vars(options)` in `lib/ansible/utils/vars.py`	9 years ago
Toshio Kuratomi	4b0aa1214c	Ziploader ... * Ziploader proof of concept (jimi-c) * Cleanups to proof of concept ziploader branch: * python3 compatible base64 encoding * zipfile compression (still need to enable toggling this off for systems without zlib support in python) * Allow non-wildcard imports (still need to make this recusrsive so that we can have module_utils code that imports other module_utils code.) * Better tracebacks: module filename is kept and module_utils directory is kept so that tracebacks show the real filenames that the errors appear in. * Make sure we import modules that are used into the module_utils files that they are used in. * Set ansible version in a more pythonic way for ziploader than we were doing in module replacer * Make it possible to set the module compression as an inventory var This may be necessary on systems where python has been compiled without zlib compression. * Refactoring of module_common code: * module replacer only replaces values that make sense for that type of file (example: don't attempt to replace python imports if we're in a powershell module). * Implement configurable shebang support for ziploader wrapper * Implement client-side constants (for SELINUX_SPECIAL_FS and SYSLOG) via environment variable. * Remove strip_comments param as we're never going to use it (ruins line numbering) * Don't repeat ourselves about detecting REPLACER * Add an easy way to debug * Port test-module to the ziploader-aware modify_module() * strip comments and blank lines from the wrapper so we send less over the wire. * Comments cleanup * Remember to output write the module line itself in powershell modules * for line in lines strips the newlines so we have to add them back in	9 years ago
jpic	4985411816	Test other use-cases for PluginLoader's config	9 years ago
jpic	da175d0a57	Bugfix: proper plugin configuration was reset ... Before this patch, if config was ['/some/path'] then it would enter the else block and config would be set to []. The regression this patch fixes was introduced by 700db154.	9 years ago
James Cammarata	5fdac707fd	New unit tests for #13630 fix	9 years ago
Toshio Kuratomi	52e9209491	Don't create world-readable module and tempfiles without explicit user permission	9 years ago
Toshio Kuratomi	d3583108ec	Fix log_invocation test on python2 with hash randomization	9 years ago
Matt Martz	ad30bad14f	Skip test_module_utils_basic__log_invocation until we can figure out the cause of the failure	9 years ago
Toshio Kuratomi	ed9e164b80	Fix ansible_sudo_pass inventory variable so that it overrides setting of sudo password from the command line	9 years ago
Brian Coca	db61e9be0c	add ansible_executable inventory var ... also handle the overrides appropriately also new executable to set shell type	9 years ago
James Cammarata	8eadc1d8eb	Adding more unit tests for AnsibleModule things in basic.py	9 years ago
James Cammarata	81788e627d	Adding unit tests for TaskResult	9 years ago
Toshio Kuratomi	2b8a0cdddc	Fix ssh connection unittests for python3.4	9 years ago
James Cammarata	9d61a6cba8	Fixing PlayIterator bugs ... * Unit tests exposed a problem where nested blocks did not correctly hit rescue/always portions of parent blocks * Cleaned up logic in PlayIterator * Unfortunately fixing the above exposed a potential problem in the block integration tests, where a failure in an "always" section may always lead to a failed state and the termination of execution beyond that point, so certain parts of the block integration test were disabled.	9 years ago
James Cammarata	f0d3284ead	Adding more unit tests for ssh connection plugin	9 years ago
James Cammarata	2f472fd4e9	Adding start of ssh connection unit tests	9 years ago
James Cammarata	299d93f6e9	Updating unit tests for PlayIterator ... This knowingly introduces a broken test, planning to fix that later.	9 years ago
James Cammarata	b853e932d1	Adding unit tests for symbolic mode conversion stuff in basic.py	9 years ago
James Cammarata	18240d350c	Adding a skip for the literal_eval test on py3	9 years ago
James Cammarata	0ea3a9d08d	Removing tabs from test_basic.py	9 years ago
James Cammarata	1de9357c2f	Attempt at cleaning up issues introduced by new basic.py unit tests	9 years ago
James Cammarata	e011f52557	Expanding unit tests for module_utils/basic.py	9 years ago
James Cammarata	c56e3aabfb	Clean up jsonify unit test with format to remove json lib differences	9 years ago
James Cammarata	7c049c3200	Fixing up jsonify and adding unit tests	9 years ago
James Cammarata	a9d25f455c	More unit tests for ActionBase	9 years ago
James Cammarata	e588437067	Adding some unicode params to the ActionBase module formatting test	9 years ago
Toshio Kuratomi	7cb29cdbec	Workaround py2.6's StringIO	9 years ago
Toshio Kuratomi	b70bf3b056	Use io.StringIO and io.BytesIO instead of StringIO.StringIO for compat with py3	9 years ago
Toshio Kuratomi	c29f51804b	Fix mixing of bytes and str in module replacer (caused traceback on python3)	9 years ago
James Cammarata	01d835700b	Cleaning up some py version problems with ActionBase unit tests	9 years ago
James Cammarata	3518a05db6	Starting to expand unit tests for ActionBase plugin class	9 years ago
James Cammarata	e02b98274b	issue callbacks per item and retry fails ... - now workers passes queue to task_executor so it can send back events per item and on retry attempt - updated result class to pass along events to strategy - base strategy updated to forward new events to callback - callbacks now remove 'items' on final result but process them directly when invoked per item - new callback method to deal with retry attempt messages (also now obeys nolog) - updated tests to match new signature of task_executor fixes #14558 fixes #14072	9 years ago
Brian Coca	6dc910c13a	shell + become fixes ... 1 less level of shell + quoting simplified become commands, less quote and shell	9 years ago
Toshio Kuratomi	0e410bbc8a	Squashing was occuring even though pkgs didn't have a template that would be affected by squash ... This broke other uses of looping (looping for delegate_to in the reported bug) Fixes #13980	9 years ago
Brian Coca	fad6eb1844	fixed unit test to match new output of become/su	9 years ago
Toshio Kuratomi	d97d28ecb0	Merge pull request #14025 from ansible/run_command-env-rework ... rework run_command's env setting to not change os.environ for the res…	9 years ago
Toshio Kuratomi	a68d90a71a	rework run_command's env setting to not change os.environ for the rest of the module. ... New param to run_command to modify the environment for just this invocation. Documentation and comment adjustments.	9 years ago
Brian Coca	c09c01a1f5	go back to defaulting wrapping commands in shell ... this was taken out in an effort to default to the user's shell but creates issues as this is not known ahead of time and its painful to set executable and shell_type for all servers, it should only be needed for those that restrict the user to specific shells and when /bin/sh is not available. raw and command may still bypass this by explicitly passing None. fixes #13882 still conditional	9 years ago
James Cammarata	b1223746cd	Relocate use of ERROR to display class, to avoid doubling up	9 years ago
Brian Coca	27f4730c29	correctly deals with non serializable type ... combine_vars shoudl really be data types, but some just get in in test, add dict to mock and avoid combine_vars using object	9 years ago
Toshio Kuratomi	1ed3a018eb	Revert "Fix make tests-py3 on devel. Fix for https://github.com/ansible/ansible/issues/13638." ... This reverts commit e70061334a. Going to do this in the connection plugins	9 years ago
James Cammarata	2d11cfab92	Squashed commit of the following: ... commit 24efa310b58c431b4d888a6315d1285da918f670 Author: James Cammarata <jimi@sngx.net> Date: Tue Dec 29 11:23:52 2015 -0500 Adding an additional test for copy exclusion Adds a negative test for the situation when an exclusion doesn't exist in the target to be copied. commit 643ba054877cf042177d65e6e2958178bdd2fe88 Merge: e6ee59f 66a8f7e Author: James Cammarata <jimi@sngx.net> Date: Tue Dec 29 10:59:18 2015 -0500 Merge branch 'speedup' of https://github.com/chrismeyersfsu/ansible into chrismeyersfsu-speedup commit 66a8f7e873 Author: Chris Meyers <chris.meyers.fsu@gmail.com> Date: Mon Dec 28 09:47:00 2015 -0500 better api and tests added * _copy_results = deepcopy for better performance * _copy_results_exclude to deepcopy but exclude certain fields. Pop fields that do not need to be deep copied. Re-assign popped fields after deep copy so we don't modify the original, to be copied, object. * _copy_results_exclude unit tests commit 93490960ff Author: Chris Meyers <chris.meyers.fsu@gmail.com> Date: Fri Dec 25 23:17:26 2015 -0600 remove uneeded deepcopy fields	9 years ago
Brian Coca	d89d7951e6	fixed tests to follow new invocation structure ... also added maxdiff setting to see issues clearly when they happen	9 years ago
Yannig Perré	b22d998d1d	Fix make tests-py3 on devel. Fix for https://github.com/ansible/ansible/issues/13638.	9 years ago
Brian Coca	75e94e0cba	allow for non standard hostnames ... * Changed parse_addresses to throw exceptions instead of passing None * Switched callers to trap and pass through the original values. * Added very verbose notice * Look at deprecating this and possibly validate at plugin instead fixes #13608	9 years ago
Brian Coca	e957335b0d	Merge pull request #13607 from mattclay/test-cache-typo ... Fixed import typo for memcache module in tests.	9 years ago
Toshio Kuratomi	e2d9f4e2f2	Fix unittests for return of invocation from fail_json and exit_json	9 years ago
Matt Clay	d2ad17e88f	Fixed import typo for memcache module in tests. ... The typo caused the test for the memcached cache plugin to be skipped even when the necessary memcache python module was installed.	9 years ago
James Cammarata	d7f2f606e1	Add has_hostkey to mock objects to fix broken unit tests	9 years ago
James Cammarata	6109f70397	Attempt at fixing strategy unit test failures on py2.6 and py3	9 years ago
Michael Scherer	a7ac98262d	Make module_utils.known_hosts.get_fqdn work on ipv6	9 years ago
Toshio Kuratomi	457f86f61a	Minor: Correct type pyhton => python	9 years ago
James Cammarata	35015aaa4a	Merge pull request #13529 from mscherer/add_tests_known_hosts ... Add tests for ansible.module_utils.known_hosts	9 years ago
James Cammarata	279c5a3596	Cleanup strategy tests broken by new forking strategy	9 years ago
Michael Scherer	3c4d2fc6f2	Add tests for ansible.module_utils.known_hosts	9 years ago
James Cammarata	750adbaa27	Changing up how host (in)equality is checked ... Fixes #13397	9 years ago
Toshio Kuratomi	cfeef81303	For now, skip tests of module_utils/basic functions that are failing on ... py3 (these are only run on the target hosts, not on the controller).	9 years ago
Toshio Kuratomi	e00012994e	Also some unicode tests for return_values()	9 years ago
Toshio Kuratomi	5fdfe6a0f2	Add some test data that has unicode values	9 years ago
James Cammarata	dc0fae1af7	Also make sure remote_user is defaulted correctly for delegated hosts ... Fixes #13323	9 years ago
James Cammarata	91500f8f5f	Fix include param precedence in variable manager	9 years ago
Brano Zarnovican	90f99f29ae	unittest cover for 'run_command' ... All os.*, subprocess.* is mocked to avoid side-effects. Tests are skipped in Py3, since 'run_command' is not Py3-ready, yet.	9 years ago
Toshio Kuratomi	318bfbb207	Migrate cli and dependencies to use global display	9 years ago
Toshio Kuratomi	aa034f4fcf	Add unit tests for issue #12976	9 years ago
Toshio Kuratomi	37052a983a	Fix unittest dailure with the new squash items code	9 years ago
Brian Coca	174de1161b	fixed removing -n in password sudo tests	9 years ago
Brian Coca	b2fc5142eb	moved sudo -S and -n into configurable flags as they might be absent in much older systems ... if password is supplied exsiting -n would get remove from flags	9 years ago
Toshio Kuratomi	4203850d1a	Break apart a looped dependency to show a warning when parsing playbooks ... Display a warning when a dict key is overwritten by pyyaml Fixes #12888	9 years ago
Brian Coca	f78c82b9ee	don't set user to current user ... also remove condition to bypass setting user if user matches current user this enables forcing user when set to the same user as current user and ignoring .ssh/config while keeping .ssh/config with current user if nothing is specified.	9 years ago
Toshio Kuratomi	ce2b18174e	Merge pull request #12878 from ansible/invocation-fix ... Invocation fix	9 years ago
Toshio Kuratomi	2e87c1f74e	Two fixes to action plugins ... * Fix the task_vars parameter to not default to a mutable type (dict) * Implement invocation in the base class's run() method have each action module call the run() method's implemention in the base class. * Return values from the action plugins' run() method takes the return value from the base class run() method into account so that invocation makes its way to the output. Fixes #12869	9 years ago
James Cammarata	86de1429e5	Cleaning up FIXMEs	9 years ago
Toshio Kuratomi	5a0e63af1e	Workaround seeming bug in python-2.6's sys.exit()	9 years ago
Toshio Kuratomi	6e5055e786	Update the use of no_log values to cover everything that heuristic_log_sanitize does. ... Fixes #12792	9 years ago
Toshio Kuratomi	c2d188baff	Hide values in json returns which were given in parameters marked no_log.	9 years ago
Brian Coca	6d87bd405d	Merge pull request #12765 from bcoca/lookup_inventory_hostname ... implemented inventory_hostname lookup in v2	9 years ago
Marius Gedminas	ec3ada1cda	Fix test on Python 3: vault code expects bytes ... (All tests now succeed on Python 3.5)	9 years ago
Marius Gedminas	5c70f932bd	Fix test on Python 3: vault code expects bytes ... (Third failing test out of four.)	9 years ago
Marius Gedminas	a1d95536f9	Fix test on Python 3: vault code expects bytes ... (Different test than the last commit.)	9 years ago
Marius Gedminas	f58f0c62e1	Fix test on Python 3: vault code expects bytes	9 years ago
Brian Coca	9b088a1e40	implemented inventory_hostname lookup in v2	9 years ago
Marius Gedminas	225fe85530	Skip test_module_utils_basic_ansible_module_creation on Python 3 ... This reverts commit 073f10a52a and instead disables the failing test. We're focusing on Python 3 support on the controller first; modules will come later.	9 years ago
James Cammarata	e6d3c6745f	Revert to using local file/dir tests in inventory instead of loader's ... Fixes #12719	9 years ago
Toshio Kuratomi	15d7f53846	AnsibleModules.log() fix for python3 ... Also add unittests for AnsibleModules.log() Fixes #12586	9 years ago
James Cammarata	0e1a5919c8	Adding unit tests for PlaybookExecutor _get_serialized_batches	9 years ago
Brian Coca	abf2e13955	Revert "Track local_action internally to prevent it from being overridden" ... This reverts commit 49ca0eb797.	9 years ago
James Cammarata	de792ba3c2	Improve handling of unicode errors ... Fixes #12669	9 years ago
Marius Gedminas	0371b14567	Fix test: selinux gets passed byte strings ... (I don't have a system with selinux to test if the module still wants byte strings even on Python 3.)	9 years ago
Marius Gedminas	500e7a1263	Fix test: _to_filesystem_str produces byte strings	9 years ago
Marius Gedminas	f7571cb37f	Python 3: there's no __builtin__ module ... This caused an ImportError in a test module and showed up as one test failure. Now the test module can get imported and many more tests fail (on Python 3). Such is life. ;-)	9 years ago
Brian Coca	ddafed4403	Merge pull request #12528 from bcoca/task_logging ... task logging revamp	9 years ago
James Cammarata	6339bf8a82	Merge branch 'tests' of https://github.com/amenonsen/ansible into amenonsen-tests	9 years ago
James Cammarata	dfa33d0f23	Tweak variable manager use in role includes to avoid test failures	9 years ago
Abhijit Menon-Sen	d100db837b	Add basic tests for expand_hostname_range	9 years ago
Abhijit Menon-Sen	838e71edb7	Add more exhaustive tests for various IPv6 address notations	9 years ago
Brian Coca	37a918438b	task logging revamp ... * allow global no_log setting, no need to set at play or task level, but can be overriden by them * allow turning off syslog only on task execution from target host (manage_syslog), overlaps with no_log functionality * created log function for task modules to use, now we can remove all syslog references, will use systemd journal if present * added debug flag to modules, so they can make it call new log function conditionally * added debug logging in module's run_command	9 years ago
James Cammarata	ccddda1ebc	Merge pull request #12502 from mgedmin/py3k ... Python 3: make test_variable_manager_precedence pass	9 years ago
James Cammarata	31d5f88a1d	Use the task loop to calculate multiple delegated hosts ... Due to the way we're now calculating delegate_to, if that value is based on a loop variable ('item') we need to calculate all of the possible delegated_to variables for that loop. Fixes #12499	9 years ago
Toshio Kuratomi	a1428d6bed	Remove tmp as a parameter to the connection plugins ... There doesn't appear to be anything that actually uses tmp_path in the connection plugins so we don't need to pass that in to exec_command. That change also means that we don't need to pass tmp_path around in many places in the action plugins any more. there may be more cleanup that can be done there as well (the action plugin's public run() method takes tmp as a keyword arg but that may not be necessary). As a sideeffect of this patch, some potential problems with chmod and the patch, assemble, copy, and template modules has been fixed (those modules called _remote_chmod() with the wrong order for their parameters. Removing the tmp parameter fixed them.)	9 years ago
Toshio Kuratomi	03127dcfae	remove the stdin return value from connection plugin exec_command() methods ... The value was useless -- unused by the callers and always hardcoded to the empty string.	9 years ago
Marius Gedminas	0624797375	Bugfix: if you define a custom __eq__, you must define a __hash__ too ... Also, on Python 3 the stock object.__hash__ raises an error ("unhashable type"), and we have code that uses Host instances as dict keys.	9 years ago
Marius Gedminas	a2bc6b4b26	Bugfix: if you define __eq__, you should define __ne__ too	9 years ago
Marius Gedminas	5d29a2eabd	Python 3: shlex.split() wants unicode ... On Python 2, shlex.split() raises if you pass it a unicode object with non-ASCII characters in it. The Ansible codebase copes by explicitly converting the string using to_bytes() before passing it to shlex.split(). On Python 3, shlex.split() raises ('bytes' object has no attribute 'read') if you pass a bytes object. Oops. This commit introduces a new wrapper function, shlex_split, that transparently performs the to_bytes/to_unicode conversions only on Python 2. Currently I've only converted one call site (the one that was causing a unit test to fail on Python 3). If this approach is deemed suitable, I'll convert them all.	9 years ago
Abhijit Menon-Sen	2fcdb37e7b	Support «hosts: groupname[1:]» notation (~= 'the rest of the group')	9 years ago
Abhijit Menon-Sen	21142f5723	Add some tests for split/apply_subscript	9 years ago
Abhijit Menon-Sen	2d420a9bb7	Allow hexadecimal ranges in IPv6 addresses, not only 0-9	9 years ago
James Cammarata	951128d7a6	Merge branch 'hostpatterns' of https://github.com/amenonsen/ansible into amenonsen-hostpatterns	9 years ago
Victor Salgado	01ae60d524	Add more tests for _split_pattern for when the input is a list	9 years ago
Abhijit Menon-Sen	abd006657b	Add test/units/inventory with a few _split_pattern tests ... There were no inventory-specific unit tests earlier, so we add a new directory for them with some initial low-level tests of _split_pattern with various valid and deprecated pattern strings.	9 years ago
Florian Apolloner	d9f873495e	Ported over #7158 to support SELinux context switches.	9 years ago
Florian Apolloner	8548690ca3	Added a test to ensure that sudo is only used if remote and become user difer.	9 years ago
Brian Coca	b6d6c2e4db	corrected all missing paths changes	9 years ago
James Cammarata	36b5858f51	Fix unit tests for change related to local_action	9 years ago
James Cammarata	49ca0eb797	Track local_action internally to prevent it from being overridden ... Fixes #12053	9 years ago
Abhijit Menon-Sen	7479ab47e0	Be stricter about parsing hostname labels ... Labels must start with an alphanumeric character, may contain alphanumeric characters or hyphens, but must not end with a hyphen. We enforce those rules, but allow underscores wherever hyphens are accepted, and allow alphanumeric ranges anywhere. We relax the definition of "alphanumeric" to include Unicode characters even though such inventory hostnames cannot be used in practice unless an ansible_ssh_host is set for each of them. We still don't enforce length restrictions—the fact that we have to accept ranges makes it more complex, and it doesn't seem especially worthwhile.	9 years ago
Abhijit Menon-Sen	065bb52109	Be systematic about parsing and validating hostnames and addresses ... This adds a parse_address(pattern) utility function that returns (host,port), and uses it wherever where we accept IPv4 and IPv6 addresses and hostnames (or host patterns): the inventory parser the the add_host action plugin. It also introduces a more extensive set of unit tests that supersedes the old add_host unit tests (which didn't actually test add_host, but only the parsing function).	9 years ago
Marius Gedminas	f91b28ef23	Fix safe_eval() of set literals ... There was code to support set literals (on Python 2.7 and newer), but it was buggy: SAFE_NODES.union() doesn't modify SAFE_NODES in place, instead it returns a new set object that is then silently discarded. I added a unit test and fixed the code. I also changed the version check to use sys.version_tuple instead of a string comparison, for consistency with the subsequent Python 3.4 version check that I added in the previous commit.	9 years ago
James Cammarata	444987cde6	Fix unit test for plugins after basedir/push_basedir removal	9 years ago
Toshio Kuratomi	e2c49b4ef4	Fix problem with "=" in the initial file path.	9 years ago
Toshio Kuratomi	3a50393cf7	Merge pull request #12269 from mgedmin/py3k ... Python 3: fix TypeError: unorderable types in test	9 years ago
Toshio Kuratomi	c1039de70c	Compatibility with six-1.3.0	9 years ago
James Cammarata	ac6f61ec7f	Properly handle group/host_var files with dots in them ... Fixes #12245	9 years ago
Marius Gedminas	c22f4ee697	Add a comment explaining why async = 1 in the test	9 years ago
Marius Gedminas	1a1c9203e2	Python 3: fix TypeError: unorderable types in test ... The full error was ====================================================================== ERROR: test_task_executor_execute (units.executor.test_task_executor.TestTaskExecutor) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/mg/src/ansible/test/units/executor/test_task_executor.py", line 252, in test_task_executor_execute mock_action.run.return_value = dict(ansible_facts=dict()) File "/home/mg/src/ansible/lib/ansible/executor/task_executor.py", line 317, in _execute if self._task.async > 0: TypeError: unorderable types: MagicMock() > int() ---------------------------------------------------------------------- Experiments show that Python 2 MagicMock() > 0 is true, so I'm setting the async property on mock_task to 1. (If I set it to 0, the test fails anyway.)	9 years ago
James Cammarata	ff9f5d7dc8	Starting to add additional unit tests for VariableManager ... Required some rewiring in inventory code to make sure we're using the DataLoader class for some data file operations, which makes mocking them much easier. Also identified two corner cases not currently handled by the code, related to inventory variable sources and which one "wins". Also noticed we weren't properly merging variables from multiple group/host_var file locations (inventory directory vs. playbook directory locations) so fixed as well.	9 years ago
Brian Coca	c17fbf2f12	simplify become testing and handling, we had drifted and were doulbe checking prompt, become and become_pass ... fixed tests to conform to new signature and now tests both with and w/o password now we are more explicit about self.prompt	9 years ago
Toshio Kuratomi	e218bf8da9	Do not escape backslashes when processing a template file. ... Fixes #12198 Fixes #12241	9 years ago
James Cammarata	b2cb3153f1	Fix unit tests for PlayIterator changes regarding fact gathering	9 years ago
Marius Gedminas	a32bf1ec18	Simplify FactCache.copy() ... Also fix the bug (missing from six import iteritems) I introduced in 823677b490.	9 years ago
Marius Gedminas	823677b490	Replace .iteritems() with six.iteritems() ... Replace .iteritems() with six.iteritems() everywhere except in module_utils (because there's no 'six' on the remote host). And except in lib/ansible/galaxy/data/metadata_template.j2, because I'm not sure six is available there.	9 years ago
Toshio Kuratomi	1b64702b9a	Fix templar unittests for change in preserve_trailing_newline parameter's default value	9 years ago
James Cammarata	45aac6a739	Adding unit tests for safe_eval	9 years ago
James Cammarata	843138e7d9	Merge pull request #12202 from mgedmin/py3k ... Use rich comparisons for Attribute and FieldAttribute	9 years ago
Toshio Kuratomi	9ecfc30f9a	* Mark all strings as unicode -- shouldn't matter for this dataset but ... ansible is passing unicode arond internally so we should test the same data. * Add a zero length test for _count_newlines and fix the zero newlines test to have no newlines.	9 years ago
Toshio Kuratomi	417bf1c805	Unittest the _count_trailing_newlines function	9 years ago
Brian Coca	a7231c2203	actually implemented flags correctly for all priv escalation methods	9 years ago
Brian Coca	14f061d5ea	fixed become tests	9 years ago
Marius Gedminas	33a374edde	Use rich comparisons for Attribute and FieldAttribute ... Because __cmp__ is not supported on Python 3.	9 years ago
Toshio Kuratomi	aeff960d02	Cleanup combine_vars ... * Dedupe combine_vars() code (removed from VariableManager) * Fix merge_hash algorithm to preserve the type * unittest combine_vars and merge_hash	9 years ago
Toshio Kuratomi	7f5080f64a	Fix backslash escaping inside of jinja2 expressions ... Fixes #11891	9 years ago
James Cammarata	ccaf47bd97	Fix unit tests broken by 057712c1	9 years ago
Marius Gedminas	709dbbc7db	Use 0oNNN octal syntax in test/	9 years ago
Abhijit Menon-Sen	4f3a98eff6	Update Vault tests to make sure AES decryption works ... Note that this test was broken in devel because it was really just duplicating the AES256 test because setting v.cipher_name to 'AES' no longer selected AES after it was de-write-whitelisted. Now that we've removed the VaultAES encryption code, we embed static output from an earlier version and test that we can decrypt it.	9 years ago
Abhijit Menon-Sen	b84053019a	Make the filename the first argument to rekey_file	9 years ago
Abhijit Menon-Sen	c4b2540ecc	Update tests for VaultEditor API changes	9 years ago
Toshio Kuratomi	56ae3a032f	Merge pull request #12075 from ansible/fix-vault-unicode ... Unicode and other fixes for vault	9 years ago
Toshio Kuratomi	a3fd4817ef	Unicode and other fixes for vault	9 years ago
Brian Coca	846f0b0510	changed no_log expected type to new value	9 years ago
Ryan Petrello	1886307845	Fix a parsing bug that prevents IPv6 addresses from being used with `add_host` ... Closes #8682	9 years ago
Brian Coca	69f380da3a	changed mod_args test to match connection	9 years ago
Brian Coca	ab355218a0	fixed test to new parser options	9 years ago
Brian Coca	ee21ebaffc	Merge pull request #11975 from mutemule/become_doas ... Add become support for OpenBSD doas	9 years ago
Damian Gerow	1c5611100e	Add become support for OpenBSD doas	9 years ago
Brian Coca	43bf9c86d8	fixed typo	9 years ago
Brian Coca	d38bb4152d	fixed test to match new exception class used	9 years ago
Brian Coca	2eb5333b50	fixed test to match new become output	9 years ago
Toshio Kuratomi	e8452c864e	Restore the relative path handling portion of #11865	9 years ago
Brian Coca	b9433650d1	Revert "Path of group_vars and host_vars were getting the basedir added twice." ... in view of simpler solution incomming from james This reverts commit bae7a02be5.	9 years ago
Toshio Kuratomi	bae7a02be5	Path of group_vars and host_vars were getting the basedir added twice. ... Fix inventory so this won't happen and fix DataLoader so that it will test relative paths relative to self._basedir Fixes #11789	9 years ago
James Cammarata	9891bcbcae	Fix unit tests broken by previous commit	9 years ago
James Cammarata	6b244ed61e	update unit tests for role templating changes	9 years ago
James Cammarata	42cfacf83b	Switch up the task/host overrides for PlayContext to use the compiled vars dict ... Fixes #11436	9 years ago
James Cammarata	8146a193eb	Fix strategy base unit tests after 88e1ef8	9 years ago
James Cammarata	993ce592b1	Update unit tests for flush_handlers fix	9 years ago
James Cammarata	66a8864ae9	Fix environment setting and inheritence ... Fixes #11401	9 years ago
James Cammarata	e64989beb4	Moving ConnectionInformation -> PlayContext ... Also making PlayContext a child class of the Playbook Base class, which gives it access to all of the FieldAttribute code to ensure field values are correctly typed after post_validation Fixes #11381	9 years ago
James Cammarata	fadd8f23f1	Fix broken strategy unit test from earlier change	9 years ago