Brian Coca
5d7cb981d3
made continue into a pass (there was no loop)
9 years ago
Brian Coca
cd0a1947c2
Merge pull request #1899 from austinhyde/fix-service-rcconf-newlines
...
Service module incorrectly handles lines not ending in a newline
9 years ago
Brian Coca
7a2687178e
avoid shlex exceptions in rc parsing (happens with multiline entries)
...
fixes #1898
9 years ago
Evgeny Vereshchagin
55e8863cb4
Fix service.enable on: Debian 8, Ubuntu 15.04
...
Workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751638
See https://github.com/systemd/systemd/issues/937
9 years ago
Austin Hyde
5c25057868
Always end rc.conf entries with a new line
9 years ago
James Cammarata
bc60c893f5
Prefer non-zero rc's over text analyis in service status checks
...
Fixes ansible/ansible#10441
9 years ago
KIKUCHI Koichiro
a3b9fb58bf
Fix service enabled check failure on FreeBSD
9 years ago
Brian Coca
03d4805074
Merge pull request #1279 from no2a/devel
...
Not use "is" to compare strings
9 years ago
Greg DeKoenigsberg
2a5f0bde87
Proper author info for all remaining modules
10 years ago
Brian Coca
9acc7c402f
Revert "added innitial daemon-reloaded support to service module"
...
This reverts commit 438d87d269
.
10 years ago
Brian Coca
438d87d269
added innitial daemon-reloaded support to service module
10 years ago
Patrik Lundin
fb41bdfc1e
service: Fix comments in OpenBsdService class.
...
No functional change.
10 years ago
Brian Coca
d02ef57815
minor doc fix
10 years ago
Brian Coca
0c9dd0e6a4
Merge pull request #751 from j2sol/service_must_exist
...
Add service option to avoid failure on missing service
10 years ago
Jonathan Mainguy
442b6a2067
fixes check mode for Ubuntu 14.04
10 years ago
Semyon Deviatkin
4e22a8039c
Fix unused variable systemd_enabled
...
Removed declared but unused variable systemd_enabled
10 years ago
Arata Notsu
fff29f049e
Not use "is" to compare strings
...
As "is" tests whether if operands are the same object rather than
they have the same value, potentially causes a wrong result.
10 years ago
James Cammarata
c4f6e63117
Fix bug in service where upstart services incorrectly use init scripts
...
Fixes #1170
10 years ago
Brian Coca
727c9131c8
Merge pull request #1138 from bcoca/service_fix
...
simplified bad if chain
10 years ago
Brian Coca
f1d72ea004
simplified bad if chain
...
hopefully fixes #1136
10 years ago
Brian Coca
61f664bc47
Merge pull request #251 from davidfritzsche/patch-1
...
Add working status detection for pf on FreeBSD
i'm going to merge this to give you a usable workaround, still I consider this a bug in the init script.
10 years ago
David Wittman
8d53ef2f60
[service] Fix bug with upstart detection
...
Upstart scripts are being incorrectly identified as SysV init scripts
due to a logic error in the `service` module.
Because upstart uses multiple commands (`/sbin/start`, `/sbin/stop`,
etc.) for managing service state, the codepath for upstart sets
`self.svc_cmd` to an empty string on line 451.
Empty strings are considered a non-truthy value in Python, so
conditionals which are checking the state of `self.svc_cmd` should
explicitly compare it to `None` to avoid overlooking the fact that
the service may be controlled by an upstart script.
10 years ago
Toshio Kuratomi
939ecd33d4
In service_enable, the default of changed is True so we have to set it
...
to False explicitly if it is False.
Fixes #875
10 years ago
Brian Coca
1bca815d37
Merge pull request #95 from Gamevy/use-insserv
...
Use insserv where available
10 years ago
Brian Coca
ed8154bdc7
Merge pull request #759 from jonhadfield/systemd_enabled_check
...
use is-enabled to check systemd service status.
10 years ago
Dagobert Michelsen
1f2ffb3900
Solaris SMF is already supported and should be mentioned in the docs,
10 years ago
Brian Coca
b82055f021
Merge pull request #648 from bcoca/service_fix_update-rc.d
...
simplified update-rc.d enable/disable handling,
10 years ago
Jon Hadfield
b20b29bd17
use is-enabled to check systemd service status.
10 years ago
Jesse Keating
cf0e8d62d2
Add service option to avoid failure on missing service
...
This adds a must_exist option to the service module, which gives callers the
ability to be tolerant to services that do not exist. This allows for
opportunistic manipulation of a list of services if they happen to exist on the
host. While failed_when could be used, it's difficult to track all the
different error strings that might come from various service tools regarding a
missing service.
10 years ago
Graham Hay
17c7d9c5d5
Use insserv where available
10 years ago
Jonathan Armani
645e0653a3
Merge branch 'devel' into openbsd_rcctl
10 years ago
Toshio Kuratomi
4f1f8e89c9
More information about distutils on Solaris in case we run into this again
10 years ago
Toshio Kuratomi
effdba95de
Merge pull request #639 from tgolly/devel
...
distutils is not available on some non-Linux OS's
10 years ago
Brian Coca
e957150f77
Merge pull request #189 from jarmani/openbsd_rcctl
...
Openbsd rcctl
10 years ago
Patrik Lundin
e8c328773a
Update OpenBSD rcctl handling to use new syntax.
...
See http://marc.info/?l=openbsd-cvs&m=142054488027109&w=2
10 years ago
Tim G
8f43a0a4fe
Load distutils on all platforms EXCEPT Solaris.
...
Solaris doesn't ship distutils with with the default Python package. This patch fixes "service" on Solaris since 30d6713
.
10 years ago
Brian Coca
9ac5ed2621
now allows for case in which someone removed the K* links and is trying
...
to reenable a service
10 years ago
Brian Coca
f4a709ad7c
simplified update-rc.d enable/disable handling, removed forced defaults
...
creation as that breaks local customizations
10 years ago
Tim G
68b5b7be72
distutils is not available on some non-Linux OS's
10 years ago
Patrik Lundin
2acfbf016d
Handle string returned by 'default' correctly.
...
We need to handle the string returned by 'default' in the same way we handle
the string returned by 'status' since the resulting flags are compared later.
10 years ago
Brian Coca
aba9e5e4f9
vastly simplified systemd detection, made enable/disable errors clearer
...
both of which allows us to remove 'service name detection' as if systemd
is init we still use it to handle initscripts.
10 years ago
Brian Coca
df6d58614e
now actually adds usable name for systemd when service only has init
...
script
10 years ago
Toshio Kuratomi
5af4463823
Gixes to doc formatting
10 years ago
Brian Coca
943f8fe7c9
Merge pull request #346 from bcoca/service_cleanup
...
service cleanup
10 years ago
Achilleas Pipinellis
a375ce33d3
Clarify supported init systems.
10 years ago
Brian Coca
29d211e7ab
service cleanup
10 years ago
Brian Coca
f49120598f
service now detects systemd is actually running, not just installed
10 years ago
Patrik Lundin
eea4d06848
Fix typo: Replace "N0" with "NO".
10 years ago
David Fritzsche
c96a85fb70
Add working status detection for pf on FreeBSD
...
The return code of "service pf onestatus" is usually zero on FreeBSD (tested with FreeBSD 10.0), even if pf is not running. So the service module always thinks that pf is running, even when it needs to be started.
10 years ago
Toshio Kuratomi
7f611468a8
Fix for systemd service scripts with newlines
...
Fixes #127
10 years ago