Commit Graph

582 Commits (67dadf3aa40f5c76cfb8f1440949dc094a824b4e)

Author SHA1 Message Date
Guruprasad ea6c2573e3 Fix typo in the copy module error message
Fix the typos in the error message shown on trying to use remote_src=yes for copying directories
9 years ago
Brian Coca b89f4c7cab cleaner error on recursive remote copy
TODO: add recursive copy support when remote_src=yes
probably need to make shared the logic in the action plugin.
9 years ago
Brian Coca 6a42e54e57 removed 'overquoting' of example
fixes #3029
9 years ago
Toshio Kuratomi 93d02189f6 Remove duplicate documentation fields 9 years ago
Tobias Wolf 99ba594f0a Add diff for both file contents and file attributes to lineinfile
Using the difflist feature added in ansible/ansible@c337293 we can add
two diffs to the `diff` dict returned as JSON: A `before` and `after` pair of
changed file contents and the diff of the file attributes.

n.b.: the difflist handling from the above commit is logically broken.
PR will follow.

Example output:

    TASK [change line and mode] ************************************************************
    changed: [localhost]
    --- before: /tmp/sshd_config (content)
    +++ after: /tmp/sshd_config (content)
    @@ -65,21 +65,21 @@
     X11DisplayOffset 10
     PrintMotd no
     PrintLastLog yes
     TCPKeepAlive yes
     #UseLogin no

     #MaxStartups 10:30:60
     #Banner /etc/issue.net

     # Allow client to pass locale environment variables
    -AcceptEnv LANG LC_*
    +AcceptEnv        LANG LC_* GF_ENV_*

     Subsystem sftp /usr/lib/openssh/sftp-server

     # Set this to 'yes' to enable PAM authentication, account processing,
     # and session processing. If this is enabled, PAM authentication will
     # be allowed through the ChallengeResponseAuthentication and
     # PasswordAuthentication.  Depending on your PAM configuration,
     # PAM authentication via ChallengeResponseAuthentication may bypass
     # the setting of "PermitRootLogin without-password".
     # If you just want the PAM account and session checks to run without

    --- before: /tmp/sshd_config (file attributes)
    +++ after: /tmp/sshd_config (file attributes)
    @@ -1,3 +1,3 @@
     {
    -    "mode": "0700"
    +    "mode": "0644"
     }
9 years ago
Toshio Kuratomi c8d5fdaf27 Merge pull request #2891 from ansible/synchronize-better-error-missing-rsync
Better error message when rsync nad ssh aren't present where synchronize is run
9 years ago
Toshio Kuratomi cb1fefdf92 Better error message when rsync nad ssh aren't present where synchronize is run
Fixes https://github.com/ansible/ansible/issues/9305
9 years ago
Brian Coca 3239691e9e Merge pull request #2870 from towolf/add_diff_to_synchronize
Add custom diff field to synchronize module
9 years ago
Tobias Wolf cd3b9366fe Add custom or 'prepared' diff field to synchronize module
This PR depends on pull requeest ansible/ansible#14105

rsync has a custom diff output that cannot easily be expressed as
`/usr/bin/diff before after`
9 years ago
Toshio Kuratomi d9e29752c1 Add an internal param instructing synchronize to replace localhost with the host that's being ssh'd from 9 years ago
Matt Martz 76925ef613 Merge pull request #2858 from sivel/issue/14064
Add note about precautions of using become with fetch
9 years ago
Matt Martz 3f232beb0a Add note about precautions of using become with fetch. Addresses https://github.com/ansible/ansible/issues/14064 9 years ago
Toshio Kuratomi 0b7469fa90 Fix documentation build 9 years ago
Toshio Kuratomi 76a478a226 Document that synchronize in 2.0.0.x has broken sudo behaviour.
Part of the changes for #13825
9 years ago
Toshio Kuratomi 78b4eac6fc Merge pull request #2722 from mscherer/fix_2630
Fix 2630
9 years ago
Brian Coca 48bd80c9cb adds diff info for file info 9 years ago
Michael Scherer 948900f7fb Fix doc inconsistency (#2630) 9 years ago
Brian Coca f500a2ec53 added mime option to stat module
it uses file magic to now return mime_type and charset of a file as
per output of `file -i /path`
9 years ago
Adam Fields 27f561dca2 added a reference to the template module for clarity 9 years ago
quoing 877daf970d Fix: Default ACL parameters are not correctly handled 9 years ago
Brian Coca db66144386 simplified lowercasing 9 years ago
quoing c93de2f930 Add "default" entry option back (removed in e95bcae), update will translate entry to standard parameters so compatibility with BDS is kept 9 years ago
Bert Van Vreckem 9556bcb9c2 Also show stdout when validation fails. This fixes #2498 9 years ago
Brian Coca 8a2459c643 Merge pull request #2590 from noseka1/devel
Fix ini_file module, avoid bracklets in key break idempotence
9 years ago
Ales Nosek 9c74272c9b Fix #2475 ini_file module: bracklets in key break idempotence
Escape the regex special characters in the option name.
9 years ago
krdlab 61a3625ed0 Fix 'stat' module document 9 years ago
Dylan Martin bfa7cdb5c4 improved error message when no handler found 9 years ago
Brian Coca c6fdd3809f fixed typo EEXISTS is actually EEXIST
fixes #2585
9 years ago
Brian Coca 9030ae996c Merge pull request #2569 from gerph/gerph-fix-docs-file
Update documentation for 'file' module to include 'diff_peek'.
9 years ago
Charles Ferguson 176b4103b6 Add documentation to 'file' AnsibleModule definition for internals.
The parameters 'diff_peek' and 'validate' are not expected to be used
by users. They are internal. To make it clear, this change adds the
comments 'Internal use only' to each of those definitions to make
it clear that they are actually used, just not by end-users.
9 years ago
Charles Ferguson 9325c0ae5f Update documentation for 'file' module to include 'diff_peek'.
The 'diff_peek' option isn't documented at all, and provides a
rudimentary check that the content isn't binary. Documentation is
added to explain the option.

The 'validate' option has a declaration, but isn't implemented.
Therefore it may as well be removed from the module.
9 years ago
Charles Paul 1bc0b6ee6a create non-existent ini file
fixing fail_json

more verbose fail msg
9 years ago
Maarten Claes e9c548da41 This fixes copy with the remote_src option
It was broken in 6e37f1dcef when the remote_src was added. Need to
pass the absolute path to copy2 instead of a tuple.
9 years ago
Brian Coca 6e37f1dcef fixed remote_src support, now actually copies and does not move 9 years ago
Timothy Appnel ca12ed5d98 Added the checksum_algo alias to the stats module. 9 years ago
Brian Coca e74dc8c1dd minor doc fixes 9 years ago
Ales Nosek 22790d301a Make the syntax work with Python 2.4 9 years ago
Ales Nosek 7f59773460 ini_file should only change what was specified and nothing more #5860
See also:
http://alesnosek.com/blog/2015/08/03/improving-ansibles-ini-file-module/
9 years ago
Brian Coca 45a9f0b453 since find doesn't make changes, support check mode and gather data for other tasks in check mode 9 years ago
Toshio Kuratomi 3993f4e967 Simplify logic to handle options set to empty string
Fixes #2125
9 years ago
Brian Coca 87b8086163 Merge pull request #2327 from ryansydnor/devel
Add capability for stat module to use more hash algorithms
9 years ago
Brian Coca 486d233cbe Merge pull request #2262 from bcoca/find_regex
added regex support to find
9 years ago
Ryan Sydnor fb10161510 Add capability for stat module to use more hash algorithms
Specifically, the stat module now has a checksum_algorithm parameter.
This lets the module utilize one of the hash algorithms available on the host
to return the checksum of the file.

This change is backwards compatible. The checksum_algorithm defaults to
sha1 and still returns its result to the stat.checksum property.
9 years ago
Brian Coca 2b33c92e7a corrected docs for stat's lnk_source
fixes #12850
9 years ago
Brian Coca 074aad23e7 final form, use_regex now controls if patterns is glob or regex
- fixed cases in which stat fails (dangling symlink)
- now properly reports name of skipped paths
9 years ago
Brian Coca e603b1bb69 changed so regexes and shell globs work transparently 9 years ago
Brian Coca fdd88863d4 fixed bug in spec 9 years ago
Brian Coca bc4b40d8e7 added regex support to find, also added 'singular' aliasess to patterns and paths 9 years ago
Brian Coca 5893eb51a5 documented new remote_src option 9 years ago
varnav 07c5143a99 Fixed confusion in the docs
As 'path' is actually alias for 'dest', this could be confusing.
9 years ago
Toshio Kuratomi e9139ba4fa Change the example of rsync_opts to use a list instead of a string
Fixes #9889
9 years ago
James Cammarata 22d25de23c Fix syntax error in synchronize docstring 9 years ago
James Cammarata 627bd47fd3 Merge pull request #2055 from skylerbunny/patch-1
Explanation of privilege escalation in notes
9 years ago
Brian Coca f12a2135ca Merge pull request #1525 from mjuenema/devel
Removed check whether destination directory is writable from files/un…
9 years ago
skylerbunny 489f3e67f1 Explanation of privilege escalation in notes
An attempt to make clear how privilege escalation works with respect to the src/source host and dest/destination host. One existing note was incorporated into three new ones, iterating each.
9 years ago
James Cammarata 310cf77edc Merge pull request #1947 from astorije/astorije/fix-acl
Fix the acl module
9 years ago
Brian Coca 68ab025dac minor doc fixes 9 years ago
Jérémie Astori 72fb7a0a17 Fix physical walk on acl module for Linux
`-h` is for BSD [1] while `-P`/`--physical` is for Linux [2].
This commit fixes that option now that acl module is (temporarily)
only supported for Linux.
I will re-add `-h` when fixing BSD support.

[1]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[2]: http://linuxcommand.org/man_pages/setfacl1.html
9 years ago
Jérémie Astori 8eefd44aef Make sure entry is not sent when acl state=query 9 years ago
Jérémie Astori 0e659ad872 Make sure permission-less entries are accepted when state=absent
Also, remove that try condition as, at that stage, no permissions with
other than 2 or 3 fields are sent to the function.
9 years ago
Jérémie Astori e95bcaeb8a Remove support for `d[efault]:` in entry permissions
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.

On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.

Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.

[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
9 years ago
Brian Coca f925f7e01f Merge pull request #1734 from freym/assemble-file-validation
assemble: add file validation support.
9 years ago
Jérémie Astori 3ac990556d Fix wrong expectation regarding entry format in acl module 9 years ago
Jérémie Astori 421d3f12cf Fix wrong processing of lines returned by setfacl in test mode 9 years ago
Jérémie Astori 50c6425673 Fix minor whitespace issues 9 years ago
Brian Coca d61fde42ef updated encoding comment and expanded authors field 9 years ago
Brian Coca d4a39d23df Merge pull request #150 from astorije/recursive_acl
Add recursive support for ACL module
9 years ago
Jérémie Astori acfc2166b0 Set version number in recursive option description 9 years ago
Jérémie Astori f8027a7f0a Ensure Python 2.4 compatibility and Linux-restricted support
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
9 years ago
Marius Gedminas 9bcf69a155 Fix obvious copy-paste error in module docs 9 years ago
Toshio Kuratomi f39e5ffa1d Modify the default for synchronize's dest_port again 9 years ago
Toshio Kuratomi ed2d8121b3 Update docs to reflect precedence for synchronize's dest_port param 9 years ago
Toshio Kuratomi 0071fd0bf7 Allow mode as a synchronize parameter (handled in action plugin) 9 years ago
Brian Coca 697307f88c Merge pull request #1670 from mikeputnam/issue-1643-gpl-header
Add missing GPLv3 License header
9 years ago
Toshio Kuratomi 19741d75eb Fi the local_rsync_path parameter used by the action plugin 9 years ago
James Cammarata 2bfddb015d In copy, set the mode before running th validation
Because some programs that do validation (like visudo) may require
the permissions to be more restricted.

Fixes ansible/ansible#11385
9 years ago
Brian Coca 9b8470ae95 minor doc fixes 9 years ago
Brian Coca c688408385 fixed fragment docs 9 years ago
Jeff Widman fd6518179b Move validate command into doc fragment and fix a few typos 9 years ago
Brian Coca 46fa43d9e0 Merge pull request #988 from isaacsimmons/ini-file-catch-interpolation-error
Handle ini file properties that contain interpolation errors
9 years ago
Patrik Lundin 3849a6d87b synchronize: add flag for verifying target host.
Add the possibility to verify the target host using a "verify_host"
flag. It is disabled by default to not change the module behaviour.
9 years ago
Brian Coca 2e77041dae Merge pull request #1654 from bcoca/file_dir_exceptions
now captures any exceptions when trying to create directories
9 years ago
Matthias Frey 68a3c6ece4 assemble: add file validation support. 9 years ago
Brian Coca e916b04e91 Also document in example that unarchive download was added in 2.0 9 years ago
Mitchell Ludwig 9e11f5fd15 Improved stat documentation 9 years ago
Brian Coca e33f093075 added ignore hidden to assemble 9 years ago
Jérémie Astori ae1126c217 Add recursive support for ACL module (fix #5053, fix #5550, fix #7276) 10 years ago
Mike Putnam 6c0e264806 Add missing GPLv3 License header
Fixes #1643
10 years ago
Brian Coca 37506141a3 Merge pull request #1613 from verm666/issue-1575
unarchive: fix work with 0 bytes archives
10 years ago
Brian Coca ed179fe379 now captures any exceptions when trying to create directories 10 years ago
Matthew Gilliard 910728f6c3 Handle race condition in directory creation.
If we try to make a directory, but someone else creates the directory
at the same time as us, we don't need to raise that error to the user.
They asked for the directory to exist, and now it does. This fixes
the race condition which was causing that error to be raised, and
closes #1648.
10 years ago
verm666 8deee99fcc unarchive: fix @bcoca's remarks, issue #1575 10 years ago
Brian Coca 433ca93c42 Merge pull request #1605 from vladimirmartsul/patch-1
Add "force" description
10 years ago
Brian Coca 13116d8ac0 Merge pull request #839 from gimoh/patch-1
Do not insert extra newline if line already contains it
10 years ago
verm666 725a7b2f59 unarchive: fix work with 0 bytes archives
This change is in response to issue #1575
10 years ago
Toshio Kuratomi a5bba2488f Update version_added to 2.0 for the partial option 10 years ago
Vladimir Martsul 2206477b73 Add "force" description
Add "force" option description
10 years ago
Juan Picca 892212b9c4 synchronize module: add partial option 10 years ago
Toshio Kuratomi c5324f54e6 Bump amount of file to download in a chunk to 64k. 10 years ago
Toshio Kuratomi daa1472ccf Merge pull request #1448 from Jmainguy/unarchive_http
add download ability to unarchive module
10 years ago