Commit Graph

3018 Commits (67b76d79eb4a98f0863165d3ea9c855e968f1dbc)

Author SHA1 Message Date
Veeti Paananen a9eef029b6 Expand variables in configuration files
e.g. $HOME. Fixes #6373.
12 years ago
Nacho Coloma 979824eedc Moved import to the top 12 years ago
James Cammarata 6eac47e519 Use split_args instead of shlex.split for included params
Fixes #8296
12 years ago
James Cammarata 7344baeffa Make sure empty non-quoted tokens are not added to the arg params list 12 years ago
James Cammarata 3714c0742f Split args on single spaces only 12 years ago
James Cammarata 57f89b85eb Merge pull request #8271 from tksmd/fix-copy-set-fs-attributes-issue
fix an issue that copying directory will fail when trying to change file attributes
12 years ago
James Cammarata 63bcbd0af2 Fix for unicode decoding error in new splitting code
Also adds a new unicode integration test
12 years ago
James Cammarata 10a850c70f Merge branch 'new_arg_splitting' into devel 12 years ago
Michael DeHaan 8d42f5cbfa Smush ds removal 12 years ago
James Cammarata b8a4ba26f0 Refactoring split_args into sub-functions 12 years ago
Michael DeHaan 630f080cf0 Start of unit tests for split_args function, moved split_args to utils since not needed by modules (so far). 12 years ago
Michael DeHaan b5d64fdb36 Some notes/comment upgrades on split_args. 12 years ago
James Cammarata 43154e5101 Using custom splitting function for module param counting 12 years ago
Michael DeHaan e143d7dab7 Merge pull request #7543 from yangliping/fix_local_facts_file_checking_portability
Fix portability issue when checking local facts file permission.
12 years ago
Michael DeHaan 635bea645c Merge pull request #7992 from dehylton/devel
fix swap translation on 4.x openbsd with 2.5.4 python
12 years ago
James Cammarata b21875d5a9 Make sure 'item' variable is set when using first_available_file
Fixes #8220
12 years ago
someda 1b1d5d0d3d fix an issue that copying directory will fail when trying to change file attributes and the target file already exists on remote
- the issue was introduced by the commit 84759faa09
12 years ago
James Cammarata 2cc602beea Fixes for module param counting and additional shell quoting issues 12 years ago
Benno Joy ac85d8444b fix for unarchive 8257 12 years ago
Nacho Coloma 57428c48a2 Bugfix: bulletproof unexpected_error_msg at gce.py
This method was still failing for me with a "missing http_code" message. After applying this change, the error message is:

```
msg: Unexpected response: {'value': 'PyCrypto library required for Service Account Authentication.'}
```

I wanted to contribute a rock-solid `unexpected_error_msg` implementation.
12 years ago
James Cammarata 84759faa09 Security fixes:
* Strip lookup calls out of inventory variables and clean unsafe data
  returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
  duplicate params from superseding previous params (CVE-2014-4967)
12 years ago
James Cammarata 00e089e503 Revert "Explicitly set the user option for ssh connections"
This reverts commit 0f91add86f.

Fixes #8216
12 years ago
Joseph Benden da5e32b316 Needs additional divisor. 12 years ago
Michael DeHaan 0fad9575e9 Refine error message about invalid ops since people forget to indent tasks fairly often. 12 years ago
James Cammarata 0e5b0a2e97 Revert "Set Jinja2's keep_trailing_newline=True in template_from_string."
This reverts commit 7a8eb0b670.
12 years ago
Joseph Benden b55791ef43 Support for OS X 10.10 DP3. 12 years ago
James Cammarata 62e9cf63b7 Merge pull request #8170 from sergevanginderachter/issue_8159
Load existing group_vars file for new group_by group
12 years ago
Serge van Ginderachter 4e9a253bef Load existing group_vars file for new group_by group
if it was not loaded yet, which happens if that group
didn't exist yet in the inventory.

fixes #8159
12 years ago
James Cammarata 42b5294820 Merge branch 'devel' of https://github.com/leverich/ansible into leverich-devel 12 years ago
Felix Geyer 0ebd19e97b Fix regression: Sanitize sudo success_key from stdout
Commit 7e3dd10 caused a regression with sanitizing the sudo success_key from stdout.
There is no newline in front of SUDO-SUCCESS when using sudo.
This change adapts the regex to make the line break optional.

Tested on Ubuntu 14.04.
12 years ago
Ruggero Marchei 909955f2e2 fix get_distribution_version() on amazon linux 12 years ago
Jacob Leverich 7a8eb0b670 Set Jinja2's keep_trailing_newline=True in template_from_string.
Without this setting, the newline idempotence of scalar strings changes depending on whether
or not they contain any Jinja2 template blocks.
12 years ago
James Cammarata e74853300a Merge branch 'task-host-loop-bypass' of https://github.com/sivel/ansible into sivel-task-host-loop-bypass 12 years ago
James Cammarata cdb9f13559 Merge pull request #7605 from sivel/delegate-callback-hint
Show delegate_to hint in callback output
12 years ago
James Cammarata 4fc8d4b6fe Merge pull request #7649 from sivel/vault-password-script
Allow --vault-password-file to work with a script as well as a flat file
12 years ago
Serge van Ginderachter e8b45a9ef7 Invalidate host/group variables cache when loading
extra varsiables based on playbook basedir.
12 years ago
Serge van Ginderachter d39ff55688 Fix logic bug when loading vars for a new playbook basedir. 12 years ago
James Cammarata db96344966 Re-fixing ability to have empty json files after inventory refactoring 12 years ago
James Cammarata 4e5eb7559e Merge branch 'svg_and_inventory_refactor' into devel 12 years ago
Bjorn Neergaard 08f97c0b9d Fix hostname when get_distribution_version() returns a string.
The distro version is a string ('jessie/sid') on Debian unstable and testing.
Because load_platform_subclass() evaluations every subclass as it loops,
comparing numbers when get_distribution_version() does not return a number will
break.

This patch fixes that by returning a number (`0`) when we have an invalid
version, instead of returning `None` or a string.
12 years ago
Dan Slimmon 307a3e8a9c Fixed regex square-bracket bug.
Regexes were being parsed like ordinary ansible host patterns, so
square-bracket groups were getting interpolated wrongly.
12 years ago
James Cammarata b8ac094eaa Tweak to only show msg on assert failure if set 12 years ago
James Cammarata 16332b8488 Merge branch 'assert-with-msg' of https://github.com/darkk/ansible into darkk-assert-with-msg 12 years ago
James Cammarata aa261bdd14 Optimizing groups_for_host() lookup in inventory 12 years ago
James Cammarata fe892fccb1 Merge remote-tracking branch 'svg/varsplugins_refactor' into svg_and_inventory_refactor 12 years ago
James Cammarata 11a5fc85f4 Merge branch 'inventory_refactoring' into svg_and_inventory_refactor 12 years ago
James Cammarata bcf83cbc24 Merge branch 'sergevanginderachter-inventorytree' into svg_and_inventory_refactor 12 years ago
Serge van Ginderachter ff4119adc0 Performance optimization in resolving host patterns
Avoid resolving a pattern that is a plain host. When matching a hostname in the
hosts_cache, just use the host object from there.

When running a task on say 750 hosts, this yields a huge improvement.
12 years ago
Matt Martz 6591dd560d Show delegate_to hint in callbacks 12 years ago
Leonid Evdokimov d94395f48c assert: add optional `msg` argument
Sample playbook when it may be useful:
```
- uri: return_content=yes url={{ api_base }}/action/{{ inventory_hostname }}
  register: output
- assert:
    msg: '{{ output.json | to_nice_json }}'
    that:
      - output.json.foo != "bar"
      - output.json.boo == 42
```
12 years ago
James Cammarata 7f8de3a265 Merge pull request #8024 from kcghost/7941
removed port from domain name qualification, fixes #7941
12 years ago
James Cammarata ff04b2b532 Allow empty yaml vars files
Fixes #7843
12 years ago
Michael DeHaan 51e014d915 Merge pull request #8012 from cchurch/callback_cleanup
Callback plugin cleanup
12 years ago
Michael DeHaan c2ac8fda1e Data from inventory scripts should be able to use nested Jinja2 expressions. 12 years ago
Henry Finucane de64bbdc5f Support a whitelisted subset of jinja2 template options 12 years ago
Casey Fitzpatrick 7115cb1f37 removed port from domain name qualification, fixes 7941 12 years ago
James Cammarata 81f35323e9 Revert "Fix get_distribution() for platforms that may have spaces"
This reverts commit 2493020d9f.
12 years ago
Chris Church 955dadf743 Remove runner_on_error callback that is never used. 12 years ago
Chris Church 4e98e3785a Reset play attribute on callback plugins when a play fails. 12 years ago
Chris Church 30fae95efe Change variable from pattern to name to correctly indicate what is being passed to the callback. 12 years ago
James Cammarata 8ed6350e65 When parsing json from untrusted sources, remove templating tags 12 years ago
James Cammarata eeb597360e Further safe_eval fixes 12 years ago
dewey hylton 379e1a49cb fix swap translation on 4.x openbsd with 2.5.4 python 12 years ago
Michael Scherer f0a7139290 Fix exec_command prototype for the plugin 12 years ago
mesk41in 488aec3936 Fix unsupported regexp parameter in assemble 12 years ago
James Cammarata 539426f612 Performance tuning inventory functions for large inventories 12 years ago
James Cammarata 35368e531b Additional fixes for safe_eval 12 years ago
James Cammarata 5429b85b9f Change safe_eval to a strict white list 12 years ago
James Cammarata d8a7b49b59 Merge branch 'inventorytree' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-inventorytree 12 years ago
Matt Martz 19f5ce2c9c Allow --vault-password-file to work with a script as well as a flat file 12 years ago
James Cammarata 1adb6dfa05 Remove redundant 'self.user or' added by 0f91add 12 years ago
Thomas Mangin 0f91add86f Explicitly set the user option for ssh connections
Fixes #7170
12 years ago
Paul Sokolovsky f8bf9cdeec Handle TemplateNotFound to render more helpful error message.
At the point the exception is handled, it is likely due to error loading
a sub-template included from main template. Besides file not found, it
can be caused also by include path failing Jinja2 checks. Now, when
rendering the exception from Jinja, it will include exception name. This
will give basic context or *what* the error is.

Fixes #7103
Fixes #7105
12 years ago
James Cammarata 5d65c1c4a4 Merge branch 'Mbosco-patch-1' into devel 12 years ago
James Cammarata 6bd0621037 Merge branch 'devel' of https://github.com/ansible/ansible into devel 12 years ago
James Cammarata 1702c2fd50 Merge branch 'patch-1' of https://github.com/Mbosco/ansible into Mbosco-patch-1 12 years ago
James Cammarata 9564818e1e Merge branch 'fix_lineinfile_newlines' into devel 12 years ago
James Cammarata 59c5d6292b Merge pull request #7902 from jirutka/filter-relpath
Add os relpath filter
12 years ago
James Cammarata ce41b02300 Merge pull request #7887 from s0x/funtoo-gathering-facts
Check for empty os-release file, fixes #7885
12 years ago
Jakub Jirutka 726a61eb43 Add os relpath filter 12 years ago
Chris Church 6aaad5dc9b Fix missing arg for _remote_chmod method. 12 years ago
Ivo Senner f4fd9d366b Check for empty os-release file, fixes #7885 12 years ago
Chris Hoffman cf997beb07 Shell expand DEFAULT_ROLES_PATH fixes #4897 12 years ago
James Cammarata 94963290b9 Merge pull request #6981 from aliles/fix-localhost-executable-with-flags
Fix localhost tasks with complex executables
12 years ago
James Cammarata 3c3c710a58 Merge branch 'module_safe_eval' into fix_lineinfile_newlines 12 years ago
James Cammarata d8bb116c1a Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel 12 years ago
Michael DeHaan 5156794738 Merge pull request #7861 from cchurch/devel
Windows Remote Support
12 years ago
Chris Church 615f70e3f4 Fix missing space in script action plugin. 12 years ago
Chris Church dd3f7c2dab Fix trailing slash on returned temp path. 12 years ago
Chris Church 8a121fd6ae Squeeze a few more bytes out of put_file script. 12 years ago
Chris Church 4e738e6fa9 Optimize buffer size for put_file. 12 years ago
Matt Martz 09dd535296 Make helper functions more robust against undefined powershell objects 12 years ago
Chris Church 43a7a5a990 Collapse extra whitespace in encoded powershell scripts. 12 years ago
Matt Martz df8866b8bd Add examples for how to use powershell common functions 12 years ago
Matt Martz e4e610565c Add convenience function (Get-Attr) for getting an attribute/member from a powershell psobject 12 years ago
Matt Martz 90c98ada7c Add ConvertTo-Bool filter function in powershell common code 12 years ago
Chris Church 61c236be9e Fix for creating temp dir with older powershell versions. 12 years ago
Chris Church 243cd877ae Add integration tests for fetch/slurp, make powershell fetch/slurp work as close as possible to existing fetch/slurp modules. 12 years ago
Chris Church a8ca579761 Fix host parameter to vvvvv. 12 years ago
Matt Martz 97f4f56286 Add Exit-Json and Fail-Json powershell helper functions 12 years ago