get_interfaces() updated to read /proc/net/dev. This means it no
longer provides only interfaces that are up.
get_iface_hwaddr() updated to read from /sys/class/net/<iface>/address.
Added get_interface_facts() to pull in mac address and interface mtu.
Can be used later for additional interface-facts.
Added get_ipv6_facts(), which reads from /proc/net/if_inet6.
get_network_facts() renamed to get_ipv4_facts(). It still calls
ifconfig to determine ipv4 facts.
The Facts class and subclasses no longer take a dict argument for
instantiation. populate() now returns self.facts.
Other changes:
- Facts.__init__() takes over most of the work from populate() so that
subclasses can benefit from its knowledge.
- Drop setting unknown facts to 'NA' in __init__() in various
subclasses.
- Check for presence of facts in get_virtual_facts()
- Update ansible_facts() to use facts.update(<classname>().populate())
This changes and organizes facts into a base class Facts and several
sub classes that implement the necessary functionality. The classes
are:
- Facts: base class. Implements basic facts that should be common to a
number of platforms. It is also where SSH keys and SELinux facts are
set.
- Hardware: A subclass of Facts that should be further
subclassed per platform for CPU, memory, and related facts.
- LinuxHardware: subclass of Hardware for Linux platforms
- SunOSHardware: subclass of Hardware for SunOS platforms
- FreeBSDHardware: subclass of Hardware for FreeBSD
- Network: A subclass of Facts that that should be further
subclassed per platform for IP, both IPv4 and IPv6, information.
- LinuxNetwork: Currently only implementation for determining network
facts.
- Virtual: A subclass of Facts that that should be further
subclassed per platform to determine virtual environment facts.
- LinuxVirtual: Currently only implementation for determining virtual
facts.
If facts are needed for additional platforms, one of the above classes
(eg Network) can be further subclassed and implement the necessary
functionality.
In addition, it fixes get_network_facts() to work on Fedora17. That
broke due to changes to ifconfig output.
should be a huge reduction of total ansible source, at a slight cost of difficulty in original module development.
We need to apply this now to all modules, but may need to have some exemptions to things like command, which should
subclass this module.
The service module was printing stuff to stderr, returning two
JSON dicts, not using consistent 'failed' values, had dead code
and unused variables. Added detection for the case when service
status returns 'xxx is dead and pid file exists' and made the
code a bit easier to read.
commit 5b9d29e08fba6402efccaa1ca56d834ff58f4b55
Merge: 7286f3a111561f
Author: Michael DeHaan <michael.dehaan@gmail.com>
Date: Sun Jul 15 14:34:10 2012 -0400
Merge branch 'devel' of https://github.com/pas256/ansible into pasec2
commit 111561f782
Author: Peter Sankauskas <pas256@gmail.com>
Date: Mon Jul 16 16:13:48 2012 -0700
Reading the config file from the same directory as the script, and
fixing typo in security group name
commit e63659d04e
Author: Peter Sankauskas <pas256@gmail.com>
Date: Mon Jul 16 10:56:59 2012 -0700
Adding list of variables to documentation
commit d0aecf025e
Author: Peter Sankauskas <pas256@gmail.com>
Date: Fri Jul 13 15:35:00 2012 -0700
Finished EC2 external inventory script
commit 136b8a5082
Author: Peter Sankauskas <pas256@gmail.com>
Date: Thu Jul 12 18:01:44 2012 -0700
Almost done, just a few more types to deal with
commit 09f92052ce
Author: Peter Sankauskas <pas256@gmail.com>
Date: Tue Jul 10 23:43:30 2012 -0700
Adding region options to config, and getting host details happening, but
need to figure out complex types
commit a940c9b8fb
Author: Peter Sankauskas <pas256@gmail.com>
Date: Tue Jul 10 18:06:05 2012 -0700
Converting to a class, commenting methods, reading settings from a
config file, and starting to work on the host variables
commit 43eb3214a6
Author: Peter Sankauskas <pas256@gmail.com>
Date: Mon Jul 9 13:11:27 2012 -0700
First pass of the Ansible EC2 inventory script
Stephen Fromm