Commit Graph

45841 Commits (65e0f37fc05500dcd8f68b2e4a3294fb1db6849a)
 

Author SHA1 Message Date
Shachaf92 7ddcaafee5 many pslint fixes (#55862)
* Handles:

PSAvoidTrailingWhitespace
PSAvoidGlobalVars
PSAvoidAssignmentToAutomaticVariable
PSAvoidUsingCmdletAliases
PSAvoidUsingWriteHost
PSUseDeclaredVarsMoreThanAssignments
PSUsePSCredentialType
PSAvoidUsingPositionalParameters
PSAvoidUsingEmptyCatchBlock
PSAvoidUsingWMICmdlet

Replaced Write-Host with Write-Output
Added smart reboot check for win_domain feature installation
Modify the Creation of the pagefileto fit to CIM
Changelog fragment addition
Ignore.txt without fixes

* Changes after community reviews

* Change Out-Null to '> $null'

* Fixes after jborean93 comments

* Test

* Revert "Test"

This reverts commit 35c5c0648fa9d2868a18094d84954e53ffa28880.

* Removed all  > $null since they broke the module since the output got dumped

* run test again

* Revert "run test again"

This reverts commit 80eaf07143f9d8cb0116cbbc68a6a69c0ace840c.

* Changes after community review

* ignore PSUseDeclaredVarsMoreThanAssignments that are on a diffrent PR

* CI failed on extra line in ignore.txt

* Review changes

* PSlint errors

* Trail space

* send to null breaks the tests for  Set-Workgroup

* Lint stuff

* win_domain_user issue of indent.

* Update win_domain_user.ps1

* Update win_domain_membership.ps1

* Fix redirect to null

* lint space issue

* removed return from set-workgroup

* removed send to null
5 years ago
Max Calzavara 5689cc08ce Add examples (#58819)
* Add examples to the ios_vlan docs: vlan using aggregate and move vlan interface example
5 years ago
Nicolas Boutet 6a5bc5f206 Fix wrong unit in documentation example of ec2_metric_alarm (#58622) 5 years ago
Will Thames 88364d4cfd Add purge_tags to s3_bucket to allow preservation of existing tags (#58754)
* Add purge_tags to s3_bucket to allow preservation of existing tags

Adding `purge_tags` with default `True` to maintain existing behaviour
allows users to set it to `False` to preserve existing tags

Fixes #29366

* s3_bucket: Add further tests and improve tag handling further

Additional tests for purge_tags: False suggested some incorrect
logic and thus further improvements

Increase wait timeout on bucket deletion as it wasn't always completing
in the default 100 seconds
5 years ago
François Deppierraz 737da1853e os_user_role: add support for named domain (#49891)
Fixes #49859.
5 years ago
Abhijeet Kasurde 79fdc2190a role: Fix role's hash_params (#55263)
* role: Fix role's hash_params

Fix based upon work done by alikins.

Fixes: #20596

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* review comments

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
AndyG 894d19b108 Update ec2_snapshot.py (#58753)
ansible ec2_snapshot ValueError: time data '2019-05-27T12:08:49.929Z' does not match format '%Y-%m-%dT%H:%M:%S.000Z'
5 years ago
Lindsay Hill 5b2d1cc24d Fix broken slxos_config due to changed backup options (#58804) 5 years ago
Lindsay Hill 2eb499cbb3 Minor typo in sros_config docstrings (#58803)
Changed `f` to `If`
5 years ago
Diane Wang 9c140d26d5 VMware: add new module vmware_guest_network (#52075) 5 years ago
Shachaf92 5b953581b4 win_domain_user - MAke the query user try catch block more accurate (#58782)
* win_domain_user - MAke the query user try catch block more accurate for missing identity

* change to minor_changes

* Update win_domain_user-make-query-try-catch-accurate.yml

* Update win_domain_user-make-query-try-catch-accurate.yml
5 years ago
Dominik Holler 6e4c2c61bd Remove redundant line in os_port (#57838)
* Remove redundant line in os_port

The renaming of the key 'vnic_type' to 'binding:vnic_type'
is reduced to a single line.
The old key is removed to avoid to possibility of
inconsistency.

* Add missing parameter in example of os_port

In the example "Create port of type 'direct'" the parameter
"network" is added, because this parameter is required on
creating new ports.
5 years ago
Josh VanDeraa 73db7e2901 Changed command for next-hop-self to next-hop-self instead of activate (#58789) 5 years ago
Klaas Demter faf50dbace Fix nagios module to recognize if file exists and is fifo pipe (#58569)
add felixfontein suggestion to changelogs/fragments/58569-nagios-fifo-fix.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
5 years ago
smile37773 8ff97edd1a Add the singlePlacementGroup in the virtual machine scale set module (#58320) 5 years ago
Toshio Kuratomi 0c992d5ae4 Fix for skipping of gitlab_runner test.
Correct variable name for skipping of the gitlab test when gitlab python
client is not installed.
5 years ago
Toshio Kuratomi fed90efc4d Fix unicode error in changelog generation 5 years ago
Joseph 4f642daae5 Correct machinectl become plugin function arguments (#58734)
* Correct get_option function name and change flags to become_flags

* Remove the '--' from the returned command

* add changelog fragment

* change changelog fragment description

* move the -q argument to machinectl before the shell argument to resolve issues with machinectl v230 (see #56571)
5 years ago
Dag Wieers 61647731e2
Fix regression in cron module (#58751)
This reverts the changes to cron from #28662

This fixes #58493
5 years ago
Nilashish Chakraborty 709fbcf804
Fix fetching existing AS (#58756)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
5 years ago
Nilashish Chakraborty 83f92987b8
Change default behaviour for network resource facts (#58750)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
5 years ago
Abhijeet Kasurde 5e2471485a
VMware: Warn user about dvswitch permissions (#58579)
Warn user about dvswitch permissions since permissions for
a distributed switch must be defined and managed on either
the datacenter or a folder containing the switch.

Fixes: #55248

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Sunil Raj 641f7c4ae3 VMware: Updates the DRS rule without deletion (#57119)
* The DRS rule will be updated if any changes in the configuration without deleting the existing rule.
The rule itself is updated by the given configuration.
* Lint errors fixed
* VMware: update vmware_vm_vm_drs_rule testcases
5 years ago
Mariusz Mazur 2fb06650a7 kubevirt: even more unit tests (#58593) 5 years ago
Ganesh Nalawade ff4001f470
Update junos module utils (#58730)
*  Add utils fucntion to build xml
   subtree
5 years ago
Abhijeet Kasurde 1bd91279d0
Fixed fail_json call in command module (#58615)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Trishna Guha 5c5d9ad669
Refactor nxos_facts to support resource module (#58705)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
5 years ago
Shachaf92 a6b7d0d00b win_domain_user and win_domain_group: add created result boolean (#57901)
* win_domain_user and win_domain_group: add created result boolean

* Fix YML

* add docs

* brackets

* Update win_domain_group.py

* Update win_domain_user.py

* Update win_domain_user.ps1

* fix indent
5 years ago
Shachaf92 07edcab051 win_acl: Fix problems with special IDRef in different languages than english (#57281)
* Change special id ref recognitionto avoid language diff

* Changelog added

* specialIdRefPrefixes to array

* Changed to the more generic option
5 years ago
Shachaf92 e0b8bc1ef9 win_firewall_rule: Only report changed when change is made (#57267)
* Fix bug https://github.com/ansible/ansible/issues/44450

* Added tests

* I will make this CI work

* Update win_firewall_rule.ps1
5 years ago
Shachaf92 6e319ff088 win_psmodule - Missing SkipPublisherCheck in Prerq installations (#58090)
* win_psmodule - Missing SkipPublisherCheck in Prerq installations

* Handle different minors of PS5

* community revisions

* Update win_psmodule.ps1
5 years ago
PRASOON KARUNAN V db5656cf6e Add support for pester tags (#57918)
* correct argument name

* added documentation

* adding missing version_added to doc

* correcting description in docs

* change type to list

* add tests

* correct test file
5 years ago
Shachaf92 48a518d9a3 win_get_url - Fix proxy_url not used correctly (#58738) 5 years ago
Will Thames 60fb9fc208 Fix EC2 test suite to work with testing policies (#44387)
* Update testing policies to ensure all required permissions are present
* Tidy up security policies to reduce duplicate permissions
* Make roles static so that they can be present before CI is run,
  meaning that role creation permission is not required by the CI
  itself, only by someone setting up the roles prior to testing
* Move contents to cloudfront policy to network policy to ensure policy
  count (maximum of 10) stays low
* Maintain compute policy below 6144 bytes
5 years ago
Andrey Klychkov 6cf722fed6 postgresql_query module: add autocommit parameter (#58704)
* postgresql_query: add autocommit parameter

* postgresql_query: add autocommit parameter, add CI tests

* postgresql_query: add autocommit parameter, add a changelog fragment

* postgresql_query: add autocommit parameter, fix sanity

* postgresql_query: add autocommit parameter, cosmetic fix
5 years ago
Trishna Guha 7b20535063
Fix repetitive ansible_net key in gather_subset (#58702)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
5 years ago
Sumit Jaiswal 8b844b67b5
fix 57711 (#58618)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
5 years ago
Pierre Riteau 1eb3fba51f Fix os_quota when volume service not available (#57364)
os_quota checks the current quotas for compute, network and volume
services and fails when no volume service is found in the catalog.

Since openstack test deployments without volume services are common,
os_quota shouldn't fail if such service is missing.

This was originally fixed in d31a09ceb7
and later adapted to catch exceptions raised by shade. Since then, this
module moved to using openstacksdk, which doesn't catch the exception
raised by keystoneauth1.

Fixes #41240
5 years ago
Avishay Bar 89be328a29 - Fixed error handling on aws_kms (#58690)
While alias creation failes, this PR fixes the requirement of passing 2 arguments for the `fail_json_aws` method.
5 years ago
Brian Coca 9808ffecc7
Add JSON output option to ansible-doc (#58209)
* allow json from ansible-doc

* save the var

* try to yaml load

* let examples stay as text blob
5 years ago
Manuel Mendez b4f4cb9b87 Fix 32910 part2 (#38709)
* cloud/packet: remove bogus mutual exclusions

operating_system is a required parameter, for custom ipxe it should be
set to custom_ipxe. The always_pxe and ipxe_script_url parameters are
only valid when operating_system==custom_ipxe, but they are not mutually
exclusive.

* cloud/packet: disallow custom_ipxe settings for supported oses.
5 years ago
Sandra McCann 3bfe32b9d9 fixed formatting and spelling issues (#58686) 5 years ago
Martin Nečas 7db2ffcf5e add docs about retry (#58625) 5 years ago
Sam Doran d50c8c2b83
Improve setup_docker tests to work with RHEL 8 GA (#58649)
- use include_vars to set appropriate packages and pip packages per distribution and version
- install an older version of Docker CE on RHEL 8 since a dependency is unavailable
- disable warnings on tasks that are ok
- skip tests for CentOS/RHEL 6
5 years ago
Sviatoslav Sydorenko ce79c8eb27 Fix typos in the Collections Tech Preview doc page (#58669) 5 years ago
Matt Martz 737dbefd78
Get copy tests passing with split controller/target (#58516)
* Get copy tests passing with split controller/target

* Remove sudoers file

* add missed set_fact
5 years ago
Sam Doran 16d6fcf514
Improve dnf test formatting and fix RHEL 8 module name (#58648)
- use single include_vars task rather than multiple set_fact tasks
- use multi-line YAML to break up long conditionals
- use version() test rather than direct comparisions
- use different appstream package on RHEL since '@swig:3.0/default' is not working in the GA
5 years ago
Andrey Klychkov 2e9db87a1b azure_rm_gallery: add disabled to aliases (#58672) 5 years ago
Abhijeet Kasurde 96eccda23b
VMware: Add module vmware_vm_storage_policy_info (#56263)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
smile37773 8f0bf3e453 Add the azure_rm_..._info modules (#58576) 5 years ago