Commit Graph

17953 Commits (61d2620098643c3f624107808259853c0bcfe00c)

Author SHA1 Message Date
Brian Coca 0ddbcf8841 python3 fix 7 years ago
Ganesh Nalawade 3b6b004570 Add support for neighbor argument in ios_interface (#29035)
Add missing support for lldp neighbor argument in ios_interface
7 years ago
Matt Clay 08bdb6198e Migrate more Azure integration tests. (#29034) 7 years ago
Markus Juopperi d343a3abd1 elb_application_lb: when purging rules make deletion the first step (#28749)
This prevents errors when adding new rules that conflict with existing
ones that will be deleted. For example this allows adding a new rule
with the same priority of a rule that will be purged.
7 years ago
marinus81 d69c803353 Fixed typo in resolution_immediacy values dict 7 years ago
Jordan Borean eba01d5a8b fix for getting vars and hostvars without specifying the host 7 years ago
Roman Nozdrin 8a2f9b7e28 modules/postgresql_users: Adds user connection limit option to the module. (#28955)
* modules/postgresql_users: Adds user connection limit option to the module.

* Fix code according with PEP8.
7 years ago
Chenjun Shen 1b8f4558f7 add 2 quota variables for openstack: loadbalancer and pool (#26010)
* add 2 quota variables for openstack: loadbalancer and pool. In neutron, they're set to 10 by default. So in the real production environment, you would hit this limit very soon.

* specify version_added for new options
7 years ago
Yaacov Zamir 534c1b8342 Flatten manageiq provider UI (#28967)
* flatten the endpoints arguments into first level

* flatten the endpoints arguments into first level, update the docs
7 years ago
Dag Wieers a200ecf966 aci_rest: Accept YAML input and validate content input
This PR includes:
- Accept inline YAML, YAML string, inline JSON, JSON string input and
  XML string input
- Validate YAML, JSON and XML input
7 years ago
Dag Wieers a796391c9b aci_rest: Implement idempotency
This PR includes:
- A new function to modify query strings in URLs
- Add rsp-subtree=modified to post/delete requests
- Test the ACI response for changes and report back
- Return the used URL back to the user
- Remove check-mode support (as it was non-functional anyway)
- Fix a bug related to method=delete and not having content set

This fixes datacenter/aci-ansible#111
7 years ago
Ganesh Nalawade cc9ed352dd Ensure proper conversion while backing up of junos config (#28958)
* Ensure proper conversion while backing up of junos config

* Minor changes

* Fix review comment

*  Open config backup file in binary mode
7 years ago
René Moser f23f2468ec openssl_certificate: fix arg docs for not_before (#28985) 7 years ago
Jacob McGill 6e79dfb5f3 ACI_BD_*: Fix missing default for state parameter 7 years ago
Nathaniel Case 8bfdbd0f73 nxos_bgp_neighbor: Fix regex &report warnings (#28888)
* Fix over-detection of log-neighbor-as

* Report nxos warnings

* Update nxos_bgp_neighbor unit tests to test remove-private-as
7 years ago
Abhijeet Kasurde 8027aad4b8 Add support for Python3 in vmware_guest_find
* Remove redundant get_obj method
* Fix testcase
* Correct logic for compile_folder_path_for_object

Fixes: #25984

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Brian Coca c51a4bc57d ansible-config view fixes 7 years ago
Nathaniel Case de2096e3d0 Move networking provider options to subspec (#28894)
* Add EOS provider options as subspec

* Add IOS provider options as subspec

* Add IOS XR provider options as subspec

* Add Junos provider options as subspec

* Add NX-OS provider options as subspec

* Add Vyos provider options as subspec

* Remove password checks from check_args

* Do the same to aireos, aruba, ce, dellos*, & sros, as they work the same way

* VyOS does not support `transport`
7 years ago
Mike Wiebe fb1aa54341 Rel240/fix nxos interface ospf (#28898)
* Fixes 28897 nxos_interface_ospf idempotence

* Handle all characters upper or lower with tests
7 years ago
mikedlr 506a30cf3e lambda - more limited exception trap when doing get_function for better errors (#28918) 7 years ago
Nathaniel Case ae6d27fa29 Revert "Bring nxos_snmp_host in line"
This reverts commit 43247c8dfe.

Revert "Bring nxos_snmp_community in line"

This reverts commit 0df77408d7.

Revert "Clean up nxos_snmp_contact & nxos_snmp_location"

This reverts commit 9e4cdd2fce.

I should probably not be up this early
7 years ago
Nathaniel Case 43247c8dfe Bring nxos_snmp_host in line 7 years ago
Nathaniel Case 0df77408d7 Bring nxos_snmp_community in line 7 years ago
Nathaniel Case 9e4cdd2fce Clean up nxos_snmp_contact & nxos_snmp_location 7 years ago
Ken Evensen c95e03d213 Added check mode (#28882) 7 years ago
Brian Coca 1d9a62e2bd removed warning that was appearing in every run 7 years ago
Trishna Guha 252efcebf5 module should fail if eos_user is added without configured_password or nopassword or sshkey (#28780)
* module should fail if eos_user is added without configured_password or nopassword or sshkey

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix eos_user unit test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix eos_user integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Sloane Hertel cef40cb54a [cloud] ec2_group: Allow rule source to be a security group in a peered VPC. (#28876) 7 years ago
rahushen 07c1d7e1ca update nxos_facts to handle n3k power table (#28891)
* handle power table for n3k
7 years ago
Sam Doran 31dc5342f3 Do not try to process an empty metai/main.yml file
If an empty meta/main.yml file exists, ansible-galaxy threw an unhelpful exception. Now, a warning message is printed and the installation does not fail.

See https://stackoverflow.com/questions/45432994/ansible-galaxy-fails-on-dependency-with-empty-meta-main-yml
7 years ago
Martin Krizek f31696f77f yum: do not use get_exception() (#28826)
Python 2.4 support was dropped in Ansible 2.4.
7 years ago
Giovanni Sciortino d733f5af06 Add note in documentation and add warning related to retries parameter used without until (#28078) 7 years ago
Adrian Likins 51c0d46056 Fix config base.yml defs with wrong keywords. (#28833)
Mostly vault related items using 'desc' instead of 'description'
7 years ago
Nathaniel Case 74daf2381b Fix nxos_config `save` parameter (#28838)
Also fix saving in general
7 years ago
Lukas Bednar 2b1a7b7d75 [docs] Fixed example for os_image_fact (#28873)
There is typo in example, which results in error when running it.
7 years ago
Ganesh Nalawade a6af204cee Fix junos_user purge option failures (#28867)
* Fix junos_user pruge option failures

Fixes #25989

Add seperate handling for purge option which
fetches configured users on remote device
and delete the one not present in aggregate
list.

* Minor changes
7 years ago
Dag Wieers effa5085ca Remove trailing whitespace 7 years ago
Dag Wieers 1c140cd90d More changes. 7 years ago
Andreas Olsson f2c0969d27 Clarify the apt_key module's absent state behavior
Currently the apt_key module only supports removing keys based on
explicitly stated key ids. The documentation should reflect that.

Related to #26005
7 years ago
Brock R 07acc579db Removed a force conditional (#28851)
This `if not force:` conditional will never be false.  So there is no need for it.
7 years ago
Sergey Scherbakov c16d258a27 Fix encoding error on grp.gr_name, which can contain non-ascii chars at domain PCs (#25804)
* Fix encoding errors on grp.gr_name, which can contain non-ascii character at LDAP/AD domain workstations

* fix: utils.to_text() is now used instead of py3-incompatible unicode() method
7 years ago
Abdul Anshad A 272c0ce68c fixes #5732 - Add support for using network ID (#22503) 7 years ago
Jordan Borean 5d35ab00af added info regarding registry acl's (#28814) 7 years ago
Antoine Cotten fcc6f148db azure_rm_storageaccount module: add 'access_tier' module parameter (#26088)
* Add 'access_tier' module parameter
* Fix condition on 'custom_domain' update
7 years ago
Abhijeet Kasurde dd9db65a9a PEP8 fixes for smartos module
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Steve Jacobs 374872cac4 ipa modules never updated to use 'name' attributes such as cn, uid, fqdn. This fixes. (#25851) 7 years ago
Sloane Hertel 70e20bb571 [cloud] cloudformation: create changeset when stack is in ROLLBACK_COMPLETE. Fixes #27853 (#28832)
Fix appearance of failure when creating a cloudformation changeset after a rollback. When creating a cloudformation changeset it shouldn't matter if the last event was. 

_ROLLBACK_COMPLETE since creating a changeset is not an event. Fixes #27853.
7 years ago
Steffen Neubauer bf73377394 consul: Always fail if no service_name was provided. (#25877)
Fixes a subtile bug introduced in PR #21737
7 years ago
Matthias Bertschy 754ef34acb Add support for ! in parameters (#25891)
Fixes #25684
7 years ago
Fobhep 72d977057f Added datacenter as variable to expample block, since it is a required variable (#25944) 7 years ago
Abhijeet Kasurde a2c8481395 Add testcases for github_issue (#26309)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
ppanczyk c9b74a3af3 Fixed 'only_upgrade' so that the status was not always 'changed' (#25213) 7 years ago
Abhijeet Kasurde dca887a6dc Use correct variable from response in github_key (#25846)
Before fix, logic tries to access info from 're' library
which raises AttributeError.
Fix adds correct variable usage for accessing next/previous
search results from github api.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Felipe Garcia Bulsoni fd304d9b5b Added support to SAN Manager resource in HPE OneView (#28787)
- Added unit tests
7 years ago
silverwind 5ccbe61258 Fix ansible_virtualization_role fact on CloudLinux (#27191)
CloudLinux and OpenVZ have common roots, but CloudLinux does not really
provide OS virtualization so it should not be regarded as a 'openvz'
system. This change adds a check for the existance of the LVE kernel
module which only exists on CloudLinux.

Fixes: https://github.com/ansible/ansible/issues/26424
7 years ago
Brian Coca 421fa393bc minor doc change to use module ref in rst 7 years ago
Brian Coca 0571014f2f bypass get_hosts and use dictionary directly
removed redundant consistency fallback
inventory reconciliation already takes care of this a priori
removed unused imports
7 years ago
Felipe Garcia Bulsoni 1e785d4117 FcoeNetworkFactsModule for HPE OneView (#28728)
* Add FcoeNetworkFactsModule for retrieving HPE OneView FCoE Networks

- Allow querying for FCoE Network resources in HPE OneView
- Adds unit tests to new module

* Fix "required: no"
7 years ago
Felipe Garcia Bulsoni 6ea2099ee4 EthernetNetworkFactsModule for HPE OneView (#28723)
* Adds EthernetNetworkFactsModule for retrieve HPE OneView

- Allows retrieving Ethernet Network resources from HPE OneView
- Adds unit tests

* Removed required: no
7 years ago
Felipe Garcia Bulsoni a4ae8536d9 NetworkSetFactsModule for HPE OneView (#28730)
* Add NetworkSetFactsModule for retrieving HPE OneView Network Sets

- Allow querying for Network Set resources in HPE OneView
- Adds unit tests to new module
- Updates oneview_module_loader copyright header to short GPL3 version

* Adding possibility to pass in credentials as parameters

* Removed required false and changed format of filter_by_name declaration

* Updated examples in docs to reflect new way to pass in credentials

- All examples of the oneview_network_set_facts updated to use
credential parameters
- All required=False from oneview base module removed
- Shared docs updated to bring attention to API version being used
7 years ago
Brian Coca 9f12d66506 fix ansible-config view 7 years ago
Christopher Torgalson 7138742bcc Clarifies File module docs re: absent state (#28748)
- The passage beginning "Note that file will not fail..." was slightly
  unclear about the fact that it referred to the behavior of the module
  when `state` is set to `absent`.
- Fixes #23203
7 years ago
Laurent Ribot b8da5ee5ef Module maven_artifact : manage file dest attributes (#24965) 7 years ago
Jacob McGill 8ffb842963 ACI Config Rollback: Add new module to support config rollbacks in ACI (#28811)
* ACI Config Rollback: Add new module to support config rollbacks in ACI

* Fix EXAMPLES

* Fix whitespace
7 years ago
Jacob McGill 42db02c249 aci_config_snapshot: Module to manage ACI config snapshots (#28784)
* ACI Config Snapshot: Add module to support managing config snapshots on the APIC.

* add comma back

* Fix docstring errors

* Fix typo

* add quotes for notes section
7 years ago
Dag Wieers 47be50a450 mail callback: Much improved version (#28501)
So 5 years after the original version, it's time to give this callback
plugin some needed rework.

This PR includes:
- Reuse same logic for failed, unreachable or Async errors
- Add playbook and task information at the top (easier to find context)
- Improve the sections (ie. indented content)
7 years ago
Jordan Borean 9fdda46aea updated deprecated version based on changelog (#28810) 7 years ago
Jordan Borean 113635e44c win_chocolatey: fixes for proxy support (#28809) 7 years ago
Yaacov Zamir a41da28f3f New model manageiq manageiq provider (#28273)
* New Model manageiq manageiq_provider

* update docs, port is not required, region is provider-region

* add example of using token

* loop on endpoints instead of creating them one by one

* add alerts endpoint

* Simplify boilerplate and reorganize docs

Tried to make it clearer how the suboptions are laid out.

* Flatten out suboptions in order to make tests pass

These will not render properly in the HTML docs. Simplifying how this module accepts options should be addressed in a future PR.
7 years ago
Dag Wieers 513b582ba3 win_reboot: Use more conforming parameter names (#26466)
This is part of the effort to make windows parameters conform to
other modules. Usually parameters don't include the unit in the
parameter name.

See also #20160
7 years ago
Thomas Stringer 8a6ae51f90 Add support for Azure Functions (#28566)
* add template for az func

* (wip) add basic azure functions support

* add support to add app settings to azure function

* add support for updating based off of app settings

* add integration tests and refactor required param

* support check mode and add facts module

* add test for azure functions facts module

* add necessary checks and registrations for web client

* fix documentation

* change return type from complex to dict

* disable azure_rm_functionapp tests until stable

* remove dict comprehension for py2.6

* pepe has whitespace tumor
7 years ago
Julien Stroheker fe1153c0af Azure acs module (azure_rm_acs.py) (#28522)
* Adding acs module

* linter issue

* Reduce the VM Size for the int. tests

* Short the name of the cluster

* Fixing the asserts and title

* Fixing VM Scale count in int. tests

* Changing the location of the tests

* trying eastus2

* disabling acs CI tests until stabilized
7 years ago
Dag Wieers 99b7cb2068 win_chocolatey Important fix for non-zero return codes (#28756)
This PR includes:
- Important fix for handling non-zero return code correctly
- Add a version to the DeprecationWarning
- Simplify code by calling Fail-Json instead of catching exceptions
- Deprecate choco-specific result values
- Simplify Remove/Install logic (and fix missing -skipscripts)
- Improve output based on verbosity
- Fix CLI options (causing issues)
- Upgrade chocolatey when older than v0.10.5
- Add (hidden) downgrade functionality
7 years ago
Ozi Boms 3045c58c83 new facts module for dns zone (#28803)
* new facts module for dns zone

integration tests and new module for dns zone facts

* use vairable for domain name

* add nondeterministic piece to domain name

* fix azure_rm_dnszone_facts examples
7 years ago
Ozi Boms 950165ba70 Azure Module for Retrieving Facts for Record Sets (#28805)
* create new module for record set facts

added new module to get facts for dns zone record sets

* use variable for domain name

* correct lint error

* add nondeterministic piece to name

* fix azure_rm_dnsrecordset_facts examples
7 years ago
Dag Wieers 908a4dc4f7 Add option names to Fail-Json and Exit-Json
Small fix.
7 years ago
jhawkesworth 8f9b885113 Windows: A module for creating Toast notifications on Modern Windows versions. (#26675)
* replace duff commit version of win_toast

* change expire_mins to expire_secs and add example showing use of async

* fix metadata version to keep sanity --test validate-modules happy

* code review fixes and change expire_secs to expire_seconds

* add first pass integration tests for win_toast

* win_toast no longer fails if there are no logged in users to notify (it sets a toast_sent false if this happens)

* yaml lint clean up of setup.yml in win_toast integration tests

* improve exception and stack trace if the notifier cannot be created, following feedback from dag

* removed unwanted 'echo' input parameters from return vals; added to CHANGELOG.md, removed _seconds units from module params; updated tests to match
7 years ago
Dag Wieers 4ba7d05e9d win_get_url: ExtendedWebClient with Timeout support (#28755) 7 years ago
Julien Stroheker d9ee3c09ca Adding check_state support and warning
lint

Update integration test

handle check_mode
handle warnings

Removing the empty tags check

Updating author handle

To use github handle

Changing from warn to fail

disabled tests
7 years ago
Matt Clay 7377dfaa98 Fix metadata version. 7 years ago
Deepakkothandan 8222662d55 added module ec2_snapshot_copy (#26578)
* added module ec2_snapshot_copy

* added RETURN documentation

* Fix copyright for ec2_snapshot_copy and make requested changes.
7 years ago
Calle Kabo 24dfe024ea dnsmadeeasy: Change A and AAAA record checks to allow round robin setup (#28656) 7 years ago
Bruno 4c36286779 Azure managed disks module (#28424)
* First version of managed disks: Multiple methods for creating, one get and one delete

* My name is too cool to be there

* Passing pep8 test

* Create and delete empty working

* Module for testing, lacks sense of setting state changed for unchanged operations

* Checking that actual changes are done to update status changed

* First version of the integration test

* Adding the dictionary to translate the facts, without using serializer

* Adding the serializer to managed disk

* Using native serializer in managed disks facts

* Added DiskSku to pass the whole class to the disk instead of a string

* Bumping version

* Passing sanity checks

* Aparently they Id is not returned by the serilizer

* Integration test

* Latest version

* Using my own serializer, the one in commons is not working for me

* Managed disks module support for ansible

* Updating my github account username in the file

* Sanity checks were missing  in facts and integration test

* Fixing typo in source_resource_uri and removed AzureHTTPErrors

* Update tags are working now

* Integration test for tags

* Added support for tags, added check mode, corrected style
7 years ago
Sam Doran 80c00d3238 Create urlsplit filter (#28537)
* Improve tests for uri filter

* Create URL Split docs

* Add urlsplit filter

* Py3 compatibility

* Use helper method and eliminate query options

* Add options, cleanup output, fix tests

* Update docs

* Add parenthesis to boilerplate import

* Add debug task to tests

* Use exclude option to filter returned values

* Filter out additional option for Python 3
7 years ago
David Peterson 15bfdd634a Update azure_rm_resourcegroup_facts.py (#28573)
Corrected Examples section.
7 years ago
Dag Wieers eed6a724ea Bugfix to check-mode and async support, and features (#28448)
This PR includes:

- Check-mode support, the module will now report as if it was rebooted,
  without making the actual reboot.
- Async-support, this potentially fixes #23835
- The module now also returns the elapsed time, like the wait_for and wait_for_connection modules.
  This fixes #18108
- Add post_reboot_delay_sec parameter
7 years ago
Thomas Stringer 40b7dffea8 Azure load balancer support (#26099)
* (wip) add partial loadbalancer module

* (wip) add ability to use a public ip for a load balancer

* fix shebang

* add backend address pool to load balancer

* remove unncessary error variable

* add probe support to load balancer

* add ability to add load distribution rule to load balancer

* add nat pool functionality to azure load balancer

* fix pep8 errors from sanity check

* add documentation for load balancer

* refactor imports

* fix license header copyright

* add facts module for azure load balancer

* fix ansible-test failures

* add integration tests for load balancer

* fix metadata version

* add complex integration test to azure_rm_loadbalancer
7 years ago
James Kassemi 48c5b9665a s3_sync: add delete option - fixes #25884 (#28249)
* s3_sync: add delete option - fixes #25884

Add `delete` option. Maintain existing upload strategies. When delete
is requested files present on remote that are not in source list are
removed after upload.

* S3_sync: Delete objects in chunks of 1000 instead of one at a time.
7 years ago
Sertaç Özercan 07fec47a86 Azure Virtual Machine data disks and managed OS disk support (#28132)
* added managed os disk support for vms

* added managed_disk_type to documentation

* added data disk (storage account and managed disk) support

* deleting data disk blob when absent

* update differences

* update docs

* fix test failures

* fix test failure

* multiple data disk support

* fix test failures

* fix test failures

* fix for multiple vm data disk name conflict

* changed data disks naming syntax

* fix data disk caching
7 years ago
Liran Nisanov 0d9f9a246f Adds win_pagefile module (#25605)
* Adds win_pagefile module

* Fixed win_pagefile doc

* Fix win_pagefile doc

* Fix win_pagefile doc variable convention

* Added check_mode

* Changed win_pagefile module&doc to the convention

* added win_pagefile integration tests

* Changed check_mode blocks to whatif, fixed a bug

* Added whatif to set-wmiinstance, changed docs

Added whatif in Set-WMIInstance
Added dots to end of decription lines

* Returns to original state at the end, more tests

Added override and no override integration tests
Pagefiles now return to same state as before at the end of the integration test

* Remove extra line

* Added test_path var to win_pagefile

* Set test_path as 'no' in integration

* Added unit to docs and enclosed exception message

* More granular try-catch blocks

* Added workaround to avoid value out of range

* Deleted wrong line ending

* Changed license to one-line

* Removed space in line ending

* Try to fix python2.6 error

* Try 2 to fix python2.6 error

* Add separating line again
7 years ago
Sertaç Özercan 2ea017a794 Azure Virtual Machine Scale Set support (azure_rm_virtualmachine_scaleset) (#28381)
* initial virtual machine scaleset implementation

* added docs

* fixed formatting

* added update feature for os disk caching and capacity

* add tier

* added return

* add integration tests

* add vmss facts

* add data disk support

* added data disks docs

* update integration test
7 years ago
jacky.chen 75998d3ca3 [cloud] Add the ability to modify shard count to kinesis_stream module (#24805)
* Add the ability to modify shard count to kinesis_stream module

* Fixed an issue in kinesis_stream where update() reports not changed when it is changed

* Remove unreachable message and make the try and catch block shorter
7 years ago
Mike Wiebe d9fc3def94 Fixes #28779 eth_mode key error (#28782)
* Fixes #28779 eth_mode key error

* Remove unused get_config references

* Addressed PR comment
7 years ago
Julien Stroheker 6b7e38555c Azure Availability Set facts module (azure_rm_availabilityset_facts) (#28378)
* Adding facts module and Int. Tests

* register results

* Upgrading metadata version

* Updating author handle

To use Github handle
7 years ago
Pierre Templier 6d5b936cf4 Add win_chocolatey proxy support (#21886) (#22515)
* Add win_chocolatey proxy support (#21886)

* Make win_chocolatey use proxy to download dependencies

* Write errors results without Set-Attr
7 years ago
nwsparks 61335a42c2 added windows module win_power_plan with integration test (#27966)
* added windows module win_power_plan with integration test

integration testing updated to handle skipping 2008 while testing that
module provides helpful error

* minor docs fix

* my fault, too many spaces
7 years ago
Sophie Herold ad9e39636e [parted] Fixes incorrect arg spec and check (#27839)
* [parted] Fixes incorrect arg spec and check

* [parted] Fixes spaces around parameter
7 years ago
Artem Zinenko 06fadefbdc [18807] win_firewall_rule module uses HNetCfg.FwPolicy2 COM Object (#27381)
* #18807 win_firewall_rule uses HNetCfg.FwPolicy2 COM object

* Added missing tests

* Added support for InterfaceTypes property

* Added support for EdgeTraversalOptions property

* Added SecureFlags property

* Port ranges are not possible in W2K8

* Added windows version checks

* Fixed doc: removed 'force' option and all notes

* Fixed copirights and docs
7 years ago
opapy 38a5033b48 support ecs task resource for cloudwatchevent_rule (#28495)
* add support ecs

* add role_arn parameters
7 years ago
Ryan S. Brown 9647a4c94f Fix silent kinesis_stream error
In cases where the boto3 call to create a Kinesis stream failed, the
error message was silently ignored because the error message wasn't
returned out of `stream_action`

Also switch `str` calls to `to_native`
7 years ago