Commit Graph

2192 Commits (6051ee0df52b9f3319fccf5f94263f55b3e74021)

Author SHA1 Message Date
Ferenc Grecu 56642f9b04 Remove unused parameter from _get_config 11 years ago
Jesse Keating 8cef210aea Make sure ssh pipes are empty before moving on
Resolves issue #5082

Code as it was would hit a scenario where one of the FDs was not ready for
reading the first time through -- but p.poll() would show the process as
complete. This would cause ansible to continue on, while leaving some content
left in a pipe.

The other scenario -- the one that causes the unclosed quote, is if we go
through select.select() and we do get stdout in the ready for reading -- we
read from it (9000 bytes), but that's not all that is there. Again we'd get to
the p.poll() check and it would be indeed not none, but we would have left some
of stdout on the FD and thus the json blob would be malformed.

Tested with and without full ssh debugging.
Tested with and without ControlPersist
Tested with and without ControlPersist sockets already created
11 years ago
Michael DeHaan 929f8a5c93 Had to revert commits due to async. 11 years ago
Michael DeHaan 74e4ccb59b Revert "ssh_alt.py / decrease # of ssh roundtrips"
This reverts commit 7f8863f96d.
11 years ago
jeromew 7f8863f96d ssh_alt.py / decrease # of ssh roundtrips 11 years ago
jeromew db182ba498 copy ssh.py to ssh_alt.py 11 years ago
Steve Smith 5b81f88c8f Cast the retrieved `retries` var to an int before incrementing as it may be in string form.
For example, the following method of calculating the value will result in a type error:

    appstatus_waitfor: 4  # Minutes
    appstatus_delay: 5 # seconds
    appstatus_retries: "{{ mins * 60 / delay }}"
11 years ago
James Tanner bf78d8cf73 Addresses #5090 setup module was using path.is_file instead of path.isfile 11 years ago
jctanner 7aa35d64c2 Merge pull request #5091 from EspadaV8/5089_assemble_fix
#5089 hack-fix assemble module
11 years ago
Michael DeHaan 801ca96a8b Merge pull request #5152 from sivel/too-many-ps
The word skipped only has 2 p's not 3
11 years ago
Matt Martz 5f0f3566a6 Skipped only has 2 p's not 3 11 years ago
Matt Martz 8873c3675b Ensure we are looking for the right import to determine if the module_style is new. Fixes #5148 11 years ago
jctanner 2670529671 Merge pull request #5090 from dragon3/hostname_support_amazon_linux
hostname module: add support for Amazon Linux
11 years ago
James Tanner d227614529 Fixes #5109 synchronize module ssh port
Added a parameter for dest_port and also check ansible_ssh_port inventory variable.
11 years ago
jctanner 93159cb9cd Merge pull request #4996 from sivel/rax-module-utils
Implement ansible.module_utils.rax
11 years ago
James Cammarata 9101c2af98 Fix traceback in template error detection code
Fixes #5081
11 years ago
Andrew Smith eed32ea70c dest_contents isn’t always defined, so don’t pass it around
I think this is also a bit of a hack since it should probably be set
before being used, I’m just not sure what it should be set to.
11 years ago
Andrew Smith e2d03173d2 The file module doesn’t have it’s module_args reset
I believe that this should be reset in the same way that the copy module
does
11 years ago
Andrew Smith 7b01c83159 Passing in complex_args throws ‘unsupported parameter for module’ errors
When using assemble only params (e.g. remote_src) the copy (and I’m
guessing file) modules throw an error that the param isn’t supported.
Simply removing the complex_args param fixes it for me, but I’m not sure
that’s the correct thing to do
11 years ago
Andrew Smith da44a7f0cb I think that resultant is meant to be the contents of the combined file
It is used for the transfer and as a diff param but isn’t actually
defined anywhere before it’s used. This seemed like the least bad place
to set it.
11 years ago
Andrew Smith 4503413baa ReturnData is used throughout but not actually imported 11 years ago
dragon3 d39e6fda92 hostname module: add support for Amazon Linux 11 years ago
Andrew Smith 7d007cac16 Correct the invocation of ‘_assemble_from_fragments’ 11 years ago
jctanner 920bc6e75b Merge pull request #5086 from j2sol/fix-accelerate_inventory
Avoid a traceback when using accelerate
11 years ago
James Tanner b6879ca2bd Fixes #5030 compare connection user and sudo user and disable sudo if identical 11 years ago
Jesse Keating 5522d489e3 Avoid a traceback when using accelerate
This bit of code is attempting to access accelerate_inventory_host,
which may not have been set/created. This will cause a traceback.
Instead use getattr with a fallback to False.
11 years ago
James Tanner 12ed39ef7b Fixes #5056 Append new hosts to the groups cache 11 years ago
James Cammarata 1f80aa768a Fix bug in error detection code, where a zero-length string was causing a traceback
Fixes #5064
11 years ago
Brian Coca 65885feeeb fixed typo for assemble function 11 years ago
James Tanner b8146e3bc7 Fixes #4979 Check for the correct context when inside the inventory_hostnames plugin 11 years ago
James Tanner 903c4cae7b Fixes #5031 Template the delay value and cast to float for loops 11 years ago
Antonio Zanardo 8dbd91b5ad fix typo in deprecation warning 11 years ago
James Tanner bca2634d54 Fix missing eval for string search in ssh controlpersist 11 years ago
James Tanner a16fe923ed Addresses #5011 check for proper string in smartos ssh error output 11 years ago
jctanner 5c84d7e445 Merge pull request #5002 from ovcharenko/devel
Allow to specify ansible_ssh_private_key_file location related to user home directory
11 years ago
James Tanner 512ebdb971 Revert "Merge pull request #5001 from ovcharenko/devel"
This reverts commit d6c3103a00, reversing
changes made to b11f96eaa4.
11 years ago
Aleksey Ovcharenko 9af44b1b42 Update to 4 space indent 11 years ago
Aleksey Ovcharenko 30678e04ac Make tests happy 11 years ago
Aleksey Ovcharenko 2222f6df58 Allow to specify ansible_ssh_private_key_file location related to user home directory 11 years ago
Matt Martz 3f2cbb7583 Add ansible.module_utils.rax 11 years ago
James Tanner 9b991b9154 Version bump for 1.5 11 years ago
James Tanner b815a09529 Fix pep8 error in password lookup 11 years ago
James Tanner e81c976636 Fix pep8 errors in unarchive module 11 years ago
jctanner 68afd9da9f Merge pull request #4866 from sergevanginderachter/known_hosts_sudo
Check real user's known_hosts when sudo ansible...
11 years ago
Brian Coca 34c33f7ea1 now correctly spell symmetric
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 460bbfaec1 added union filter
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca afe30a6633 added difference and symetric difference filters
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan fc909b453f Make the legacy template detection system not hit a false positive when
replacing a \$ with $.
11 years ago
jctanner 93223510af Merge pull request #4936 from stoned/group-get_hosts-perf2
Improve Group.get_hosts() performance.
11 years ago
Matt Haggard 389602b8dd Merge pull request #4920 from iffy/ansible
Collect all stdout over ssh transport before returning data
11 years ago