3 Commits (5e2184c683838285dd1d88985f62ccb25926a763)

Author	SHA1	Message	Date
Clark Boylan	a65e34ce77	Fix synchronize retries (#18535) ... * Fix synchronize retries The synchronize module munges its task args on every invocation of run(). This was problematic because the munged data was not fit for use by a second pass of the synchronize module. Correct this by using a copy of the task args on every invocation of run() so that the original args are not affected. Local testing using this playbook seems to confirm that things work as expected: - hosts: all tasks: - delay: 2 register: task_result retries: 1 until: task_result.rc == 0 synchronize: dest: /tmp/out mode: pull src: /tmp/nonexistent/ fixes #18281 * Update synchroncization fixture assertions When we started operating on a copy of the task args the test assertions were no longer asserting things about the munged state but of the pristine state. Convert the copy of task args to a class member so that it can be compared against later in testing and update the assertions to check this munged copy. * Shuffle objects around for cleaner testing Attach the temporary args dict to the task rather than the action as this makes updating the existing tests cleaner.	8 years ago
jctanner	587d3c368b	Fix synchronize+vagrant dest assertions that were incorrect. (#16291) ... Addresses #16284	9 years ago
jctanner	c52cea8db3	Add a framework, fixtures and test for common synchronize scenarios. (#15983) ... * Add a framework, fixtures and test for common synchronize scenarios. Addresses #15905	9 years ago