Commit Graph

46353 Commits (5df90753862efcfa9aa50d3260feaa786b9907d5)
 

Author SHA1 Message Date
Sloane Hertel 1d3f2c7764
disable s3_lifecycle tests (#59311) 5 years ago
Felix Fontein 4a574c4d0c Option parsing: warn if both an option and its alias are specified for a module (#53698)
* Print warning when both an option and its alias is specified.

* Improve output.

* Put warnings into self._warnings directly, resp. use self.warn() when handling subspecs.

* Add changelog.

* Add unit test.
5 years ago
Sam Doran f231f21669
Handle situation where ansible_architecure may not be defined when gathering facts (#55466) 5 years ago
Nilashish Chakraborty bb006db7c8
Add exclusive configuration mode support (#59289)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
5 years ago
Abhijeet Kasurde 4b152235ff
Typo fixes (#59227)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Raul Mahiques fd2116e26a Added state "remount" which will remount the device (#52649) 5 years ago
Martin Krizek a752e2a467
Clear 'connection related' plugin vars for next loop iteration (#59024)
Fixes #58876
5 years ago
Denis Afonso da047eec59 cloudformation_facts: Fixes PhysicalResourceId KeyError(#55990)
Fixes: #38033
5 years ago
yanzhangi e7c9c9585e update ce_vrrp to fix a bug (#59185)
* update ce_vrrp to fix a bug

* update module ce_vrrp 20190718

* update ce_vrrp to fix bugs
5 years ago
Toshio Kuratomi 87601969a3 Correct places where match was intended
pytest.raises has two parameters, message and match.  message is meant
to be the error message that pytest gives when the tested code does not
raise the expected exception.  match is the string that pytest expects
to be a match for the repr of the exception.  Unfortunately, it seems
that message is often mistakenly used where match is meant.  Fix those
cases.

message is also deprecated so removed our usage of it.  Perhaps we
should write a sanity test later that prevents the use of
pytest.raises(message) to avoid this mistake.

seealso: https://docs.pytest.org/en/4.6-maintenance/deprecations.html#message-parameter-of-pytest-raises

Also update the exception message tested for as we're now properly
detecting that the messages have changed.
5 years ago
Pedro Magalhães c010a6d288 Fix maven_artifact.py when your maven is behind a cloudflare (#53495)
Cloudflare has a feature that checks Browser Integrity Check, when the user agent is not present, it can fail on BIC.

Since we are defining the default value of variable "self.module.params['http_agent']" to None, this will cause that
User-Agent header will not be added, because of the conditional if present on module_utils/urls.py [1]

[1] https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/urls.py#L1135-L1136

This fix will ensure that the "self.module.params['http_agent']" will be defined

URLs:
https://support.cloudflare.com/hc/en-us/articles/200171806-Error-1010-The-owner-of-this-website-has-banned-your-access-based-on-your-browser-s-signature
https://support.cloudflare.com/hc/en-us/articles/200170086-What-does-the-Browser-Integrity-Check-do-
5 years ago
Simon Dodsley 4acbb83c84 Add checks for VG and Pod existence when creating volume (#58857) 5 years ago
Simon Dodsley a1220268b2 Add new facts for Pure Storage FlashArray (#58894)
* Update purefa_facts module to support NVMe and preferred arrays

* Update purefa_facts with new information available from array
5 years ago
Simon Dodsley aeb0245ebd Add check for correct API version before trying to execute (#59205) 5 years ago
The Magician 5f222c478d Bug fixes for GCP modules (#59130) 5 years ago
The Magician 6128d0cd8b New Module: gcp_mlengine_model_facts (#59223) 5 years ago
The Magician de92ea6b3d New Module: gcp_mlengine_version_facts (#59225) 5 years ago
Sam Doran eeb97e9ceb Label kubectl connection plugin as community (#59265) 5 years ago
Thomas Stringer c256e3565c remove trstringer as maintainer (#59256) 5 years ago
Sandra McCann 00699735e9 add eol banner (#59254) 5 years ago
Ewoud Kohl van Wijngaarden 44a0fb5a93 Add team_foreman to contrib/inventory/foreman.py (#59178)
This will allow team_foreman to merge fixes, but mostly I'd prefer to
close as wontfix to point users to the inventory plugin that also
exists.
5 years ago
Aljaž Košir 42073b6331 Add lambda_bucket_event module (#58059) 5 years ago
Jill R 1c1da3c11d
Re-enable ec2_vpc_vpn_facts test (#58893) 5 years ago
pratikgadiya12 393e4a41d0 Added support to create and delete multiple databases in MySQL (#58602)
* Added support to create/delete mulitiple databases in MySQL

Fixes: #58370

* Added additional tests cases and fixed documentation changes

* Code refactoring and added tests for better test coverage

- Removed db_exists usage from most of the code. Used existence_list
 and non_existence_list instead

- Added additional tests to cover all scenarios w.r.t creation and deletion
 on multiple databases

- Added tests for dump operations

* Minor fix

* Minor fix - create check mode test

* Added dump tests for better dump tests coverage

* Removed minor database connection details

* fixed error

* Added test case for import operations

* Code refactoring and review fixes

- Added dump all test case

* Fixed review comments

* Minor review comment fixes

* Altered db_create return value

* Removed db_list and altered "does exist" to just "exist"

* Kept db and db_list in module.exit_json

* Refactored tests

- Added removal of dump2 file

* Moved import tests to state_dump_import file

* Removed import tests from multi_db_create_delete

* Updated porting guide, added RETURN block

* Minor identation fix

* Added validation to check if databases are dumped
5 years ago
Felix Fontein cdf0947df0
Fix typo in import package name. (#59229) 5 years ago
Hannes Ljungberg 0e8eb1d17f pip: Remove unused option use_mirrors and remove all ignore.txt entries
PR #58977

* Remove unused option use_mirrors

* Add changelog fragment
5 years ago
Sam Doran d2edf1d435 User - Create parent directories if they do not exist in the specified home path (#51043)
* Create a user home directory if it has parents that do not exist

The useradd command line tool does not create parent directories. Check if the specified home path has parents that do not exist. If so, create them prior to running useradd, then set the proper permission on the created directory.

Add tests

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Use dict for default user group in tests

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Fix tests

Signed-off-by: Sam Doran <sdoran@redhat.com>
5 years ago
Chris Archibald 2fbc226509 Update to base Netapp.py for Azure, and Rest API (#59151)
* base changes

* updateS

* fixes

* fies

* updates

* fix issues

* updates
5 years ago
Sumit Jaiswal b2d8ef69f9
PR to support Ansible Checkmode in Checkpoint modules (#57695)
* added checkmode support

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
5 years ago
Sumit Jaiswal b01b1d40cf
PR to add Unit TC for Checkpoint network module (#57710)
* cp_network unit TC

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
5 years ago
Eitan Raviv 264945d75f ovirt-host-network: support commit on success (#59212)
In ovirt-engine 4.3 and onwards a 'commit on success' parameter is
available. It is used to commit a network configuration automatically
upon successful application of the configuration without needing a
separate save request.

Therefore since ansible 2.8 if the 'save' parameter is specified as
'true' the commit on success parameter will be set to true and used
instead of making an additional save request.
5 years ago
Martin Nečas 9489433a4d use sysprep only when needed (#59196) 5 years ago
Yunge Zhu cb201bfba1 add xmltodict to azure requirements file (#55748)
* add xmltodict

* fix lint
5 years ago
n3pjk 7e25a61464 snow: Call Refactored login from snow modules (#59201)
* Remove python shebang from snow_record*
* Add python shebang to all snow modules
* Remove NO_LOG from username
* Call Refactored login from snow modules
5 years ago
Sebastiaan Mannem d0538c0d7a postgresql_pg_hba: Exception when two lines with same weight are compared (#59198) 5 years ago
Abhijeet Kasurde 8a13b41823
VMware: Use managed object id to find VM (#59143)
* Based upon partial work of wilmardo
* Now, user can specify managed object id of virtual machine to find
an existing virtual machine

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
James Cassell 28259ee247 dzdo: fix password prompt (#59208) 5 years ago
Matt Davis 277690bcc6 add changelog 5 years ago
Michael Letterle b8a41a90b8 Wrap Get-MachineSid's body in a try/catch
It's not critical information and there's been a number of issues over
the years with trying to retrieve it. If an exception is thrown just
return null.

Fixes: #47813
5 years ago
Yunge Zhu 42c43a2822 add azure_rm_keyvaultkey_info module (#55754) 5 years ago
Matt Clay 13bbfacb04 Show ansible-test --explain errors in CI. 5 years ago
Toshio Kuratomi 5392d8697d
Docs scripts cleanup (#59169)
* Fix dump_keywords to require attribute docs

* Change the documentation commands to make definition files positional

Since the definition files are mandatory, make them positional
parameters instead of options.
5 years ago
Brian Coca c2253c8133
Allow for no role_versions to be present (#56519)
* Allow for no role_versions to be present

  fixes #46650

  better info on fetch, ensure list return

* use correct to_
5 years ago
Brian Coca 4ef2545eb5
if users are None/empty, dont assume sameness (#58875) 5 years ago
Brian Coca 48d4d6ec69
Stop ignoring merge hash behaviour in inventory (#58460)
* stop ignoring merge hash behaviour in inventory

fixes #58120

* added porting note

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
5 years ago
Andrey Klychkov 0e09800a9a Postgresql modules: tidying up of CI tests (#59099) 5 years ago
Brian Coca a39b721db5
fixes to config manager (#58530)
* skip unreadable ansible.cfg

* all types should check for type

* patch access for tests and fix tests that relied on missing files not being checked
5 years ago
Brian Coca 5ac2c6d4fe
remove unused and obsolete bsd port makefile (#58633)
freebsd itself has maintained and up to date version of port
5 years ago
dx0xm b8eba8e1f0 VMware: Add testcase for vmware_dvs_portgroup_facts (#59088)
* Tests for choosing specific DVS while gathering facts

Signed-off-by: dx0xm <52723266+dx0xm@users.noreply.github.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
5 years ago
Phillipe Smith ce907c8b90 New module os_group_info (#57120)
* Added domain_id param to get_group

* Added module os_group_facts based on os_project_facts

* Fix pep8 alarms and version_added to 2.9

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Fixes based on https://github.com/ansible/ansible/pull/57120#issuecomment-511338588

* Update lib/ansible/modules/cloud/openstack/os_group_info.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/openstack/os_group_info.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/openstack/os_group_info.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Removed availability_zone option

* Revert "Removed availability_zone option"

This reverts commit 20155c0b0f.

* Reverted to the original code to open a new Pull Request
5 years ago