Pierre-Louis Bonicoli
40298a8f24
remove unused variable
10 years ago
Pierre-Louis Bonicoli
25f595c2ba
Avoid to use the builtin 'echo'
...
By default, the interpretation of escape characters could be disabled (bash)
or enabled (dash).
10 years ago
Alexander Gubin
e15fba5156
lvol: Cast size(LogicalVolumeSize) to lower to fix the difference between lvs and lvcreate
10 years ago
Brian Coca
ffa8abf979
Merge pull request #120 from alxgu/lvol_fix_path
...
Fix lvol: Find LVM commands in PATH env - Bugfix Pull Request
10 years ago
Yuri Kunde Schlesner
1d60d33dc1
crypttab: Fix parameter checking with state=absent
...
Only the `name` parameter is required when removing an entry, but the module tried to ensure at least one other parameter was set.
10 years ago
Bert Mertens
3981872375
Fix getent behaviour with fail_key=False
10 years ago
Toshio Kuratomi
d4f5b6d41a
Fixes for docs building
10 years ago
Misho Krastev
5acc634549
fix lvol module to properly query the size of logical volumes
10 years ago
Sterfield
48ecbd037e
Missing import re
...
I don't even know how it magically worked, but the fact is the code was
correct, and ran OK without the import re.
10 years ago
Sterfield
c9656ff3b4
Now allow every type of locales + archlinux fix
...
The previous version of this code was supporting only locales using the
format "<language>_<territory>.<charset>". But all the locales that
doesn't have this format were not installable (such as "fr_FR" or
"fr_FR@euro").
Also, if an invalid locales was provided, the module kept sending a
"changed" status.
Now :
* if the user provides an invalid locales, the module failed. Locales
are verified using /etc/locale.gen or /usr/share/i18n/SUPPORTED if
Ubuntu
* Every types of valid locales are now supported.
* The locale module was not working on Archlinux, as there's no space
between the "#" and the locale. This is now supported. Credits goes
to danderson189, this is his code.
This module was tested on debian jessie, ubuntu 14 LTS and last
Archlinux.
10 years ago
Nicolas Brisac
5462748553
Merge remote-tracking branch 'upstream/devel' into devel
10 years ago
Brian Coca
3e7da5366b
Merge pull request #176 from bcoca/gluster_volume_docfix
...
fixed doc bug
10 years ago
John Barker
9efac37b1b
Add a note about debconf passwords always being recorded as changed
10 years ago
Brian Coca
2e6b94047d
fixed doc bug
10 years ago
Nikolai Lifanov
1be1aacadf
fix at.py module on non-glibc systems
10 years ago
Cosmo Petrich
443d7683a0
Remove default from 'permanent' and 'state' docs
...
These fields are both required, and thus do not actually have defaults.
10 years ago
Brian Coca
108db556a0
Merge pull request #136 from bcoca/gluster_revamp
...
revamp of gluster volume management
10 years ago
Brian Coca
fdd41fb95c
Merge pull request #1 from mscherer/devel
...
Add a new option immediate= to immediately apply a permanent change
10 years ago
Brian Coca
6725d5188d
revamp of gluster volume management
...
also implemented deleting a volume
10 years ago
Toshio Kuratomi
19e688b017
Fixes to documentation
10 years ago
Michael Scherer
62cae242cf
Add a new option immediate= to immediately apply a permanent change
...
Currently, either you apply the change in the configuration
of firewalld ( without permanent=True ), or you apply it live.
I most of the time want to do the 2 at the same time, ie open the
port ( so I can use the service ) and make sure it stay open on reboot.
10 years ago
Brian Coca
9e798ec6bc
Merge pull request #48 from rosmo/glusterfs-module
...
Added GlusterFS module.
10 years ago
Brian Coca
52f526c360
Merge pull request #17 from abompard/devel
...
Module alternatives: support RedHat-based OSes
10 years ago
Brian Coca
cbfabba9e3
Merge pull request #7 from groks/crypttab-module
...
New crypttab module for editing Linux /etc/crypttab file
10 years ago
Alexander Gubin
20ef2696bc
Fix lvol: Find LVM commands in PATH env
10 years ago
Brian Coca
e64751b0eb
Merge pull request #53 from bcoca/getent_doc_fixes
...
corrected and made better docs for getent
10 years ago
Sebastian Gumprich
040135dbba
Added documentation and example for port ranges.
...
Also added punctuation marks.
10 years ago
Nicolas Brisac
1e3645a9e3
Allow filtering of routed/forwarded packets
...
MAN page states the following :
Rules for traffic not destined for the host itself but instead for
traffic that should be routed/forwarded through the firewall should
specify the route keyword before the rule (routing rules differ
significantly from PF syntax and instead take into account netfilter
FORWARD chain conventions). For example:
ufw route allow in on eth1 out on eth2
This commit introduces a new parameter "route=yes/no" to allow just that.
10 years ago
Brian Coca
664858ec20
Merge pull request #56 from filipenf/fix-lvg
...
LVG module fix when using multiple devices (string to list)
10 years ago
Taneli Leppä
2d495f7e6e
Added .py extension to glusterfs module.
10 years ago
Simon Aquino
4dd6c8204a
Facter module should return custom facts
...
The ansible facter module should also return puppet custom facts by
default.
10 years ago
Chris West
613b3bdda0
Enable "ufw default allow routed"
...
* The policy is shown in `status verbose`, so all the check mode stuff should keep working.
* `--dry-run` works as expected.
* No idea whether it's legal as an argument to `interface`
10 years ago
Filipe Niero Felisbino
6cfb97a1c8
Replace dev_string to dev_list
10 years ago
Brian Coca
b0d5733fd0
corrected and made better docs for getent
10 years ago
Taneli Leppa
6dc09c966c
Added GlusterFS module.
10 years ago
Baptiste Mispelon
827da3ae1a
Fixed typo in locale_gen documentation.
10 years ago
jravetch
c89ce9e8d7
mkfs.xfs uses -f instead of -F flag
...
mkfs.xfs uses the -f instead of -F flag to force creating a filesystem on a devices that have an existing filesystem
10 years ago
Aurélien Bompard
6b5aa62854
Module alternatives: support RedHat-based OSes
...
RedHat-based OSes have a version of update-alternatives which comes from
the chkconfig package and does not support the --query parameter. Work
around that.
10 years ago
Aurélien Bompard
b645dd330c
Module alternatives: support check mode
10 years ago
Steve
26f58a8eb7
New crypttab module for editing Linux /etc/crypttab file
10 years ago
Michael DeHaan
110250d344
package files
10 years ago
Michael DeHaan
b1e789968b
File extensions!
10 years ago
Michael DeHaan
50f105578a
Restructuring.
10 years ago
Michael DeHaan
73123b69fa
Move modules into subdirectory.
10 years ago
Toshio Kuratomi
8b81062be0
The fix for gh-7284 causes problems for initscripts which have the
...
standards compliant return codes but return a verbose error message via
stdout. Limit the times when we invoke the heuristic to attempt to work
around this.
10 years ago
Michael Scherer
c9a0a7ae4b
Fix #9704 , correctly set changed as false when nothing is done
10 years ago
Toshio Kuratomi
7b100dd389
Be more specific in checking if a job restarted successfully.
...
Fixes : #9056
10 years ago
Toshio Kuratomi
36083c3b90
Failure to enable a service now fails the task
...
Fixes: 8855
10 years ago
Toshio Kuratomi
a50258d26a
remove debugging that was causing failure
10 years ago
Toshio Kuratomi
2e16bd3a44
Refactor the Linux service_enable() method
...
* Fix check_mode for initctl systems
Fixes #9009
10 years ago
Toshio Kuratomi
104401805b
Revert "Refactor the Linux service_enable() method" needs some debugging
...
This reverts commit e294e31fd3
.
10 years ago
Toshio Kuratomi
c362902f50
Refactor the Linux service_enable() method
...
* Fix check_mode for initctl systems
Fixes #9009
10 years ago
Toshio Kuratomi
a9928492f7
Make systemd vs rht detection more robust for centos
...
Centos 6.x and below use an old RHT style of configuring hostname.
CentOS 7.x and better use systemd. Instead of depending on the
distribution string which seems to have changed over the course of 6.x
we need to explicitly check the version.
Fixes #8997
10 years ago
James Cammarata
7edcf21bdc
Move initscript rc check to later in service status check
...
Fixes #7284
10 years ago
Michael DeHaan
5aa6ddef7f
Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules.
10 years ago
Patrik Lundin
0abf14ff19
service: use self.changed in service_enable_rcconf().
...
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
10 years ago
James Cammarata
30d6713bf0
Add additional checks to detect upstart services
...
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
10 years ago
Eri Bastos
6f8a29dc3d
Proposed fix for issue #7757
10 years ago
James Cammarata
c8376e296f
Tweaking change to documentation language for cron name param
10 years ago
James Cammarata
509761249c
Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel
10 years ago
James Cammarata
07e77c5bed
Merge pull request #8740 from mattparker/patch-1
...
Name appears to be a required parameter for cron module
10 years ago
James Cammarata
1f2727c607
Merge pull request #8729 from ercpe/openrc-hostname
...
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
10 years ago
Matt Parker
6086c505fe
Update cron documenation
...
The "name" parameter seems to be rather important as the identifying feature of a cron job. This is an update to the documentation to further emphasize this.
10 years ago
Matt Parker
5accd15ba6
Name appears to be a required parameter
...
As far as I can tell, `name` is a required parameter. The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear. Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too. However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
10 years ago
Johann Schmitz
7ef67e3f8b
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
10 years ago
Ding Deng
85c6434262
debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7).
10 years ago
Michael DeHaan
60ce2d3853
Fix documentation builds.
10 years ago
Michael DeHaan
f21d6c7980
Merge pull request #8002 from prune998/patch-2
...
added missing force flag on mkfs commandline
10 years ago
Michael DeHaan
185d5a6221
Merge branch 'spelling' of git://github.com/cgar/ansible into devel
...
Conflicts:
docsite/rst/guide_rax.rst
plugins/callbacks/mail.py
10 years ago
Michael DeHaan
66ec9089bd
Update docs.
10 years ago
Michael DeHaan
f6f184b36d
Updating docs.
10 years ago
Brian Coca
aeeefd046f
bumped to 1.7
10 years ago
Brian Coca
5aa2ca762a
added control to fail or not on missing key
...
made split 'smarter' but still overridable
10 years ago
Brian Coca
391f8ec600
added getent module to get system data as facts
10 years ago
Serge van Ginderachter
961d4b0d6c
execute the mount after path validation
...
This avoids a stale situation where name/path contains some impossible path,
but gets configured (faultly) in fstab, and the module only fails after that,
when creating that path.
10 years ago
Jonathan Mainguy
650003dd5c
Fixes issue #8339 where Scientific Linux incorrectly tries to use FedoraStrategy of hostnamectl
10 years ago
Michael DeHaan
e978dcf7eb
Merge pull request #8283 from ps-jay/sys_mount_fstype_doc
...
Add fstype arg to the mount examples
10 years ago
Michael DeHaan
bc01f2571e
Merge pull request #8311 from neersighted/wrap_distroversion
...
Wrap get_distribution_version() in the hostname module
10 years ago
Michael DeHaan
2212b64fd9
Cleaning up explanation of mount module states.
10 years ago
Bjorn Neergaard
cbc417ca1b
Wrap get_distribution_version() in the hostname module
...
We wrap get_distribution_version() with a new function,
_get_distribution_version(), that returns `0` when the result is a string or
`None`.
This accounts for the case when get_distribution_version() returns a string,
and we try to compare it to a float. We do this in the hostname module instead
of the module snippets because other modules may want the real string
version.module snippets because other modules may want the real string version.
10 years ago
Michael DeHaan
99ad691950
Merge branch 'ufw' of git://github.com/Trozz/ansible into devel
10 years ago
Michael DeHaan
caba7ac6a6
Merge pull request #7954 from alimony/patch-3
...
cron module: Use correct parameter name in error message.
10 years ago
James Cammarata
03f0d6bec8
Merge pull request #8308 from robinro/extend-hostname-distrolist
...
Extended distributions list for hostname module
10 years ago
Robin Roth
7920f4eaf5
Fix extra newline at end of hostname for Fedora
...
This fixes a bug introduced by 138b45e3
.
The hostname has an additional newline at the end which leads to the
state always being 'changed: true' even if the hostname is unchanged.
10 years ago
Robin Roth
a26bc9c926
Extended distributions list for hostname module
...
Implementations already present
10 years ago
Tom Lazar
d89adce760
FreeBSD 10 compatibility fix
...
On FreeBSD the whitespace around the ``=`` triggers a (cryptic) ``no such file or directory`` error. removing the whitespace like above fixes this.
10 years ago
Philip Jay
bb7b290ed8
Add fstype arg to the mount examples
...
Needed fstype in the examples, since fstype is a required argument for
mount.
10 years ago
Berend de Boer
f46c4ee093
Default for fstab missing, causing KeyError: 'fstab'
10 years ago
James Cammarata
6879e4ff0a
Merge pull request #8223 from renard/create-fstab-if-not-exists
...
Create fstab if not exists
10 years ago
Sébastien Gross
e0f7b3f39c
[mount] make sure fstab exists
...
This is mainly to prevent from failing with no such file or directory
during module execution.
10 years ago
Sébastien Gross
806052a9e5
[mount] Add documentation for fstab option
10 years ago
Hector Acosta
60edb6b04b
Add check_mode support to authorized_key. Fixes #7300
...
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
10 years ago
Yasser Nabi
8cc894bef2
Enable puppet facts
...
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.
In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.
The benefit is, filtering can be done based on facts set by Puppet.
10 years ago
Michael DeHaan
96fe275946
Merge pull request #8139 from peterkh/devel
...
Fix "TypeError: group id must be integer" if groupid passed in for group key
10 years ago
Ruggero Marchei
ae95ebd075
fix LooseVersion exception with empty distribution_version
10 years ago
Peter Hall
ae67002c15
Fix "TypeError: group id must be integer" if groupid passed in for group
...
key
10 years ago
Ruggero Marchei
8d01986617
fix issue #8102
10 years ago
Cristian Ciupitu
72d6e6d805
Remove useless code
10 years ago
Michael Leer
39b34b008c
add interfact documentation #7704
11 years ago
Prune
afb358af77
added missing force flag on mkfs commandline
...
even if the option ```force=yes``` is used in the playbook, it is not reflected in the mkfs command line.
As force option is dependent of the fs type, a "if-then-else" case have been added. Also, some FS types does not have a force option.
11 years ago
Markus Amalthea Magnuson
a58709ac1d
Use correct parameter name in error message.
...
The parameter is called `cron_file` but the error message uses `file` which is confusing.
11 years ago
James Cammarata
936daf6f63
Updating the other classes in the group module to match #7249
11 years ago
James Cammarata
4ca9ebf084
Merge pull request #7249 from jfchevrette/implement-group-checking-if-state-present
...
Allow group module to handle check_mode properly when group.state=present and group already exists
11 years ago
James Cammarata
236a2989cc
Merge branch 'lvg_dm_names' of https://github.com/ajsalminen/ansible into ajsalminen-lvg_dm_names
11 years ago
James Cammarata
ad4926e090
Update authors for modprobe module
11 years ago
James Cammarata
974693882e
Merge branch 'add_name' of https://github.com/stygstra/ansible into stygstra-add_name
11 years ago
James Cammarata
6ad83bb5ce
Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel
11 years ago
Michael DeHaan
4fbc2a83e0
Merge pull request #7861 from cchurch/devel
...
Windows Remote Support
11 years ago
David Stygstra
cae41d0931
Added author and copyright lines to modules I contributed
11 years ago
Michael DeHaan
8b262d775b
Slight tweak to windows wording.
11 years ago
Matt Martz
cab68bc579
Mention that with windows target hosts, fact_path and filter are not currently supported
11 years ago
James Cammarata
2c22cf46cf
Merge branch '7763' of https://github.com/rmarchei/ansible into rmarchei-7763
11 years ago
James Cammarata
34405ea905
Merge branch 'lvg_fix' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-lvg_fix
11 years ago
Ilya Rusalowski
b1a31ebb84
Set default vg_options to empty string
11 years ago
Ruggero Marchei
f522425415
move get_distribution_version() to basic.py
11 years ago
Ruggero Marchei
bd69e9f265
use different strategy for RHEL >= 7. Fixes 7763
11 years ago
James Cammarata
d35d5ac9d1
Merge pull request #7741 from mgcrea/devel
...
Add support for Linaro distribution in hostname module
11 years ago
James Cammarata
3e04d8c70c
Merge pull request #7737 from toddmowen/zfs-fix-7696
...
zfs: fix incompatibility - share.nfs vs sharenfs (issue #7696 )
11 years ago
Olivier Louvignes
158d6276eb
Add support for Linaro distribution in hostname module
11 years ago
Todd Owen
34517b0836
zfs: work around incompatibility by renaming share.nfs to sharenfs
...
Fixes #7696
11 years ago
rgbkrk
5591e8838d
Error checking and reporting on interface ufw rule
11 years ago
Ron Gomes
73246a49dc
Fix incorrect argument ordering in error message, which provokes a
...
printf-related TypeError.
11 years ago
Yann Coleu
f378ed643c
Add primary group in the first user module doc example
11 years ago
Nicolas Brisac
ecda1455bf
open_iscsi module: support RC 21 when listing logged-in target
11 years ago
Brian Coca
5c87e97a45
now module searches for update-alternatives vs hardcoding it
11 years ago
James Cammarata
3a8ebd4325
Pull the link out of the alternatives output when not specified
...
Fixes #7414
11 years ago
Adam Chainz
6b10cf756a
Fix grammar and value errors in cron documentation
11 years ago
Luca Berruti
eca36953c8
Make alternatives module python 5 compatible
11 years ago
Jean-Francois Chevrette
8756612599
this should return 0 to indicate a non-failure when check_mode is True
11 years ago
Antti Salminen
a6b482c500
Switch to mapper device name if pvs returns the wrong one.
11 years ago
Carlos E. Garcia
4dcaa9d9fb
multiple spelling error changes
11 years ago
Michael Scherer
4ed4bfff90
Do not fail if we try to generate a ssh key for a user without being root
...
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.
So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
11 years ago
Chris Lamb
b123b648a0
Correct/update debconf examples - need to specify vtype.
...
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
11 years ago
Michael Scherer
cf3365b99e
Add a better error message for service
...
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.
So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
11 years ago
Hernandes B. de Sousa
780b5e0bbf
Add missing info for the append option
...
Both 'default' and 'choices' options were missing at the documentation.
11 years ago
James Cammarata
0c96e2f33b
Check to make sure the firewalld client is connected before proceeding
...
Fixes #6911
11 years ago
Jonathan Davila
a90aa46ed2
Added example demonstrating other functionality
11 years ago
James Tanner
0025273fca
Fixes syntax error in cron module caused by #6870
11 years ago
Eric Lake
58dccfbc29
Adding bold to service doc to call up state and enabled.
11 years ago
MorrisA
ac72d44219
Modified Cron to add AIX Crontab support, changed according to suggestions
...
from mpdehaan and redone entirely.
11 years ago
Serge van Ginderachter
867702b26a
lvg module bugfix on vg_options patch
...
When no vg_options are passed to the module, 'vg_options' still exists
in the module.params dict with a value of None, so the default empty string in
the get method is never used. None cannot be "splitted", which backtraced.
11 years ago
Michael DeHaan
3d8997d219
Name is not required, update docs.
11 years ago
Michael DeHaan
7258c15ce1
Merge pull request #6831 from aresch/patch-1
...
Fix _parse_value always returning 0 when not true, false or None.
11 years ago
Andrew Resch
32e5383bef
Fix _parse_value always returning 0 when not true, false or None.
11 years ago
Joshua Lund
74962a0e35
Update cron module documentation. The 'name' parameter is required.
11 years ago
Michael DeHaan
5826e1354a
Slightly revise wording.
11 years ago
Michael DeHaan
ff2177442b
Merge branch 'authorized_key-manage_dir' of git://github.com/tyll/ansible into devel
11 years ago
Michael DeHaan
4917f4a48f
Merge pull request #6810 from bob-smith/debconf-text
...
debconf detail requirements and fix typos
11 years ago
James Cammarata
57adad7097
Fix issue with sysctl parameter parsing introduced by 0e8c7b1
...
Fixes #6806
11 years ago
Michael DeHaan
05551cfe51
Merge pull request #6826 from bob-smith/debconf-parsing
...
debconf correctly quote strings
11 years ago