ansible

Commit Graph

Author	SHA1	Message	Date
Matt Clay	dbf9634b1b	Enable more pylint rules and fix reported issues. (#30543 ) * Enable pylint invalid-encoded-data test. * Enable pylint anomalous-unicode-escape-in-string test.	7 years ago
Matt Clay	7714dcd04e	Enable more pylint rules and fix reported issues. (#30539 ) * Enable pylint unreachable test. * Enable pylint suppressed-message test. * Enable pylint redundant-unittest-assert test. * Enable pylint bad-open-mode test. * Enable pylint signature-differs test. * Enable pylint unnecessary-pass test. * Enable pylint unnecessary-lambda test. * Enable pylint raising-bad-type test. * Enable pylint logging-not-lazy test. * Enable pylint logging-format-interpolation test. * Enable pylint useless-else-on-loop test.	7 years ago
Matt Clay	442af3744e	Miscellaneous pylint fixes. The following rules are no longer disabled: - bad-format-string - duplicate-key - lost-exception - trailing-newlines - unexpected-keyword-arg - useless-suppression - using-constant-test	7 years ago
Matt Clay	68aeaa58a8	Fix dangerous default args. (#29839 )	7 years ago
Matt Clay	79bc49e150	Fix ansible-test unicode and sanity tests. (#29743 ) * Show warning when using pylint on Python 2.6. * Add pylint disable entries for Python 2. * Fix unicode handling in ansible-test. * Add missing documentation.	7 years ago
Matt Clay	f88750d665	Expand disabled pylint rules. (#29162 ) * Expand disabled pylint rules. * Fix pylint and unicode issues in ansible-test.	7 years ago
Toshio Kuratomi	21564cdb98	Add some features to the pylint sanity check * Enable specific tests (this lets us disable a group and then enable a particular test inside of it) * Comment out tests in the enable and disable files	7 years ago
Toshio Kuratomi	9f7b0dfc30	Remove automatic use of system six * Enable the pylint no-name-in-module check. Checks that identifiers in imports actually exist. When we do this, we also have to ignore _MovedItems used in our bundled six. This means pylint won't check for bad imports below ansible.module_utils.six.moves but that's something that pylint punts on with a system copy of six so this is still an improvement. * Remove automatic use of system six. The exec in the six code which tried to use a system library if available destroyed pylint's ability to check for imports of identifiers which did not exist (the no-name-in-module check). That test is important enough that we should sacrifice the bundling detection in favour of the test. Distributions that want to unbundle six can replace the bundled six in ansible/module_utils/six/__init__.py to unbundle. however, be aware that six is tricky to unbundle. They may want to base their efforts off the code we were using: `2fff690caa/lib/ansible/module_utils/six/__init__.py` * Update tests for new location of bundled six Several code-smell tests whitelist the bundled six library. Update the path to the library so that they work. * Also check for basestring in modules as the enabled pylint tests will also point out basestring usage for us.	7 years ago
Toshio Kuratomi	da3d3d512e	Enable pylint checking for undefined variables	7 years ago
Matt Clay	e7bb508ad6	Fix var precedence check to support python 3. (#23552 ) * Fix var precedence check to support python 3. * Run CI sanity tests using python 3.5. * Disable pylint non-iterator-returned test to pass on python 3.5.	8 years ago
Matt Clay	48eeab8a53	Fix errors reported by pylint. (#23282 ) * Fix pylint misplaced-bare-raise errors. * Fix pylint return-in-init error. * Fix pylint bad-format-character error. * Fix pylint too-many-format-args errors. * Fix pylint too-few-format-args errors. * Fix pylint truncated-format-string error.	8 years ago
Matt Clay	1daa69d685	Initial pylint support for ansible-test sanity.	8 years ago

12 Commits (5c3bbd4620c4a94ece7741ecfe5514a1bd06422b)