Matt Clay
f81238012b
Clean up pylint issues in test infra.
5 years ago
Matt Clay
6645054329
Code cleanup for test infrastructure. ( #59046 )
...
* Remove useless object inheritance in test code.
* Remove unnecessary pass statements from test code.
* Comment on why certain pylint rules are ignored.
* Add more pylint test contexts.
* Fix import order.
* Remove unused variables.
* Remove unnecessary pass statement.
* Fix bad continuations.
* Remove unnecessary elif.
* Allow legitimate broad except statements.
* Allow legitimate protected access.
* Clean up names to make pylint pass.
5 years ago
Matt Clay
3f2b766d10
Add future and metaclass boilerplate to test code.
...
Continue to ignore:
- test/integration/
- test/legacy/
- test/units/
5 years ago
Matt Clay
1f3a74c0c8
Improve import sanity test output handling. ( #52136 )
...
Handling of unexpected output for the following is improved:
- stdout
- stderr
- warnings
6 years ago
Toshio Kuratomi
175f3b51e5
Ensure that current uses of BaseException are required
...
* In some cases, it appears that Exception should have been used instead
as there's no need to catch sys.exit KeyboardInterrupt and similar.
* In a few cases, it appears that BaseException is used because
a library we depend on calls sys.exit() contrary to good coding
design. Comment those so that we know that those have been audited
and found to be correct and change to use (Exception, SystemExit)
instead.
6 years ago
Matt Clay
e2b6047514
Add symlinks sanity test. ( #46467 )
...
* Add symlinks sanity test.
* Replace legacy test symlinks with actual content.
* Remove dir symlink from template_jinja2_latest.
* Update import test to use generated library dir.
* Fix copy test symlink setup.
6 years ago
Matt Clay
6fb333faff
Fixes for ansible-test sanity import test. ( #45249 )
...
* Fix import test on Python 3.7.
* Fix path processing in import sanity test.
6 years ago
Pilou
a5d320f8e7
vdirect modules: fix 'import' sanity test ( #39706 )
...
* vdirect modules: fix 'import' sanity test
* Remove passing file from import skip list.
* vdirect modules: fix validate-modules warnings
- Arguments with a default should not be marked as required
- add choices in doc
* vdirect_runnable: use formatting function
7 years ago
Pierre-Louis Bonicoli
afef20827b
openshift_raw & openshift_scale: fix broken import
7 years ago
Pierre-Louis Bonicoli
5d72f29b1a
Remove passing file from import skip list.
7 years ago
Pierre-Louis Bonicoli
2f535a339c
azure_rm_storageaccount: fix broken import
7 years ago
Pilou
bc6b96d42e
webfaction modules: fix broken import ( #35024 )
...
* webfaction_app: fix broken import
* doc: use formatting functions
* webaction_db: fix broken import
* webfaction_domain: fix broken import
* webfaction_mailbox: fix broken import
* webaction_site: fix broken import
* webfaction modules: fix doc
7 years ago
Matt Clay
ac1698099d
Overhaul additional sanity tests. ( #36803 )
...
* Remove unnecessary sys.exit calls.
* Add files filtering for code-smell tests.
* Enhance test-constraints code-smell test.
* Simplify compile sanity test.
* Pass paths to importer on stdin.
* Pass paths to yamllinter on stdin.
* Add work-around for unicode path filtering.
* Enhance configure-remoting-ps1 code-smell test.
* Enhance integration-aliases code-smell test.
* Enhance azure-requirements code-smell test.
* Enhance no-illegal-filenames code-smell test.
7 years ago
Matt Clay
ff922ac2ad
Import sanity test for main() in Ansible modules.
7 years ago
Pilou
54882d4715
dimensiondata: fix broken import ( #35634 )
...
* Fix broken import
* Remove never reached statements
exit_json and fail_json methods call sys.exit, subsequent statements
can not be executed.
7 years ago
Pierre-Louis Bonicoli
2646ea9b86
yum_repository: Python 3.7 error have been fixed
...
See 232dc7110c
7 years ago
Matt Clay
b9c5147be2
Move import sanity test files into own directory. ( #35593 )
7 years ago
Matt Martz
c282e4e00f
Replace LooseVersion comparison with int/float comparison. Fixes #35435 ( #35519 )
7 years ago
Pilou
0ce8d389a4
azure_rm_dnsrecordset: fix broken import and minor updates ( #34983 )
...
* fix broken import
Error was:
lib/ansible/modules/cloud/azure/azure_rm_dnsrecordset.py:223:0: NameError: name 'ARecord' is not defined
* doc: use formatting functions
* remove unused dict
7 years ago
Pilou
00332a49d5
ec2_win_password: fix broken import and minor updates ( #34479 )
...
* fix broken import
* ansible.module_utils.ec2.HAS_BOTO is already used
* wait_timeout parameter: use 'int' type
* wait is always True there
* doc: use formatting function
7 years ago
Pilou
e9a5ff912a
nxos_file_copy: fix broken import and 2.6 compatibility ( #34480 )
...
* Fix broken import: paramiko could be missing
* doc: use formatting function
* Use Python 2.6 compatible format string
7 years ago
Matt Clay
ccbd788f6b
Remove passing files from import skip list.
7 years ago
Pilou
bd38359ddc
gcdns_zone: fix broken import ( #34076 )
...
* fix broken import
* whole project requires Python >= 2.6
7 years ago
Pilou
459adf8966
ios_static_route: fix broken import ( #34133 )
...
* Fix broken import
* doc: add ipaddress in requirements
7 years ago
Pilou
4713d9ea44
ce_file_copy: fix broken import ( #34023 )
...
* fix broken import
* doc: use formatting functions
7 years ago
Pilou
107934241e
gcdns_record: fix broken import ( #34024 )
7 years ago
Pilou
85871da03d
consul_acl: fix broken import ( #33729 )
7 years ago
Pilou
02e965ba20
maven_artifact: fix broken import ( #33749 )
...
* Fail when lxml isn't available
* whole project requires Python >= 2.6
7 years ago
Pilou
b6528ea19f
ovirt_disk: fix Python 3 compatibility (use six) ( #33730 )
7 years ago
Matt Clay
f9cd50411f
Enable Python 3.7 in ansible-test.
7 years ago
Tim Rupp
06363f6ede
Removes bigip_snmp from skip file ( #32530 )
7 years ago
Tim Rupp
53940670fd
Removes bigip_qkview from skip file ( #32529 )
7 years ago
Tim Rupp
45787f6ef2
Removes bigip_provision from skip file ( #32525 )
7 years ago
Tim Rupp
64871470e2
Removes bigip_pool from the skip file ( #32516 )
7 years ago
Tim Rupp
ab71a9de14
Removes bigip_irule from the skip file ( #32509 )
7 years ago
Tim Rupp
6b6df43eae
Removes bigip_iapp_template from the skip file ( #32488 )
7 years ago
Tim Rupp
015baf5149
Removes bigip_iapp_service from skip list ( #32482 )
7 years ago
Tim Rupp
cbc5c2d556
Removes bigip_hostname from skip file ( #32479 )
7 years ago
Tim Rupp
d5d4683047
Removes bigip_snmp_trap from skip file ( #32470 )
7 years ago
Tim Rupp
e3f1198a67
Removes bigip_ucs from skip file ( #32462 )
7 years ago
Tim Rupp
c239749052
Removes bigip_user from skip file ( #32451 )
7 years ago
Tim Rupp
83674af284
Removes virtual_address from skip file ( #32425 )
7 years ago
Tim Rupp
fc4580b4cc
Removes bigip ssl certificate from skip file ( #32424 )
7 years ago
Tim Rupp
6193d5bc65
Removes gtm wide ip from skip file ( #32422 )
7 years ago
Tim Rupp
8868b5fa85
Removes gtm pool from skip file ( #32419 )
7 years ago
Tim Rupp
daaf8ca86c
Fixes skip imports for bigip_configsync_action module ( #32413 )
7 years ago
Tim Rupp
8f2b243a3e
Fixes bigip_config to remove from skip file ( #32409 )
7 years ago
Tim Rupp
8c5cd9c530
Removes bigip_command from the skip file ( #32407 )
...
Includes fixes and enhancements to make it unnecessary to include this
module in the skip file
7 years ago
Pilou
840a57a4ed
s3_sync: fix broken import ( #31460 )
7 years ago
Pilou
870974e0be
ec2_vpc_route_table: fix broken import ( #31459 )
7 years ago