Commit Graph

10593 Commits (576224e2029625996b48eaa16f2b97dc4cdd3f3c)
 

Author SHA1 Message Date
James Cammarata 0af8ca3fee Merge pull request #7126 from mscherer/better_error_message_empty_task
Give more information when a task is empty
11 years ago
Michael Scherer 0f0f5ff1ce Give more information when a task is empty
I made a typo in a playbook and was great by:

    ERROR: expecting dict; got: None

The issue was a single - on the last line of a playbook.
With the name of the file, I was able to see right away where the
error was.
11 years ago
Richard Hoop 630367ebfc Creation complete 11 years ago
Richard Hoop 3e75e504e0 More config checks and clean up for vm_config settings 11 years ago
James Cammarata e83a494e41 Make sure VARS_CACHE for hosts are updated with the play vars too
Fixes #6979
11 years ago
James Cammarata a6068b09ac Fix collision in random filter name by merging functionality
Merges the functionality of the original jinja2 random filter with
the one we provide.

Fixes #7113
11 years ago
Bruce Pennypacker 2be8feebce Changed behavior of deregister. If an instance is not found in the ELB then simply return 'changed=false'. Otherwise always remove the instance from the ELB no matter what state its currently in. 11 years ago
James Cammarata d88ac5e24d Merge pull request #7076 from mscherer/better_message_service
Add a better error message for service
11 years ago
Mike Buzzetti 4cb41de987 Updated and corrected example section 11 years ago
Michael Heca 9ad6511be7 module docker - add docker version comment
Default docker version 0.9.1 from Ubuntu 14.04 LTS don't report APIVersion.
11 years ago
Michael Scherer 43d0fbd342 Add a better error message for service
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.

So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
11 years ago
James Cammarata c115c34a1f Set the default LANG to en_US.UTF-8 and also set LC_CTYPE
Fixes #6737
11 years ago
Michael DeHaan 491a00af21 Merge pull request #7108 from bcoca/freebsd_mtu_fix
should now work with versions older than 8.4
11 years ago
James Martin 8a21f226b5 ec2_eip integration tests. 11 years ago
Mike Buzzetti b2c5106833 Adding support for purging subnets 11 years ago
Brian Coca c3e559b914 should now work with versions older than 8.4 11 years ago
Richard Hoop 06c64785fb Large cleanups. Reintegrating all modules together for a guest 11 years ago
James Cammarata f1ce9abe0d Merge pull request #7099 from faust64/patch-2
Update facts.py
11 years ago
faust64 78b9a11ccf Update facts.py
Fixes #7093 --devel
11 years ago
James Cammarata 149339f620 Merge pull request #7089 from dagwieers/debug-docs
Add an example to show all hostvars using debug
11 years ago
James Cammarata 53754357f7 Merge pull request #7096 from CaptTofu/docker
Small bug - 'acts' should be 'facts'
11 years ago
James Cammarata afee14173e Merge pull request #7095 from radeksimko/pokemon-exc-fix
Prevent catching unrelated exceptions
11 years ago
James Cammarata 568b4a801c Merge pull request #7094 from radeksimko/apt-autoinstall-fix
Add check of return code for autoinstallation of python-apt
11 years ago
James Cammarata 68c30548e0 Properly catch and decode unicode strings in module _log_invocation()
Fixes #7084
11 years ago
James Cammarata 4f673b9497 Merge pull request #7083 from mscherer/better_message_multiple_action
Improve error message when multiple action are given
11 years ago
James Cammarata 39c6141b4a Merge pull request #7082 from bcoca/freebsd_mtu_fix
fixed issue with FreeBSD network facts
11 years ago
James Cammarata 086b877719 Merge pull request #7079 from mscherer/fix_error_whitespace_in_config
Clean a bit more the ssh_args configuration
11 years ago
James Cammarata 54f86099e4 Merge pull request #7078 from mscherer/fix_error_message_controlpersist
Enhance error message about missing ControlPersist
11 years ago
CaptTofu 2990db728a Small bug - 'acts' should be 'facts' 11 years ago
Radek Simko 1513d2bd64 Prevention for catching unrelated exceptions added 11 years ago
Michael DeHaan f09c0c7c64 Merge pull request #7081 from bcoca/freebsd_fact_fix
fixed ETIME issue on FreeBSD 8 through 10, which broke fact gather
11 years ago
Radek Simko 8bdd96b273 Explicit check of return code for autoinstallation of python-apt added
This will allow easier debugging through more meaningful error message.
11 years ago
Dag Wieers 3c15d64655 Add an example to show all hostvars using debug
This is a useful example to help debug how facts and vars are being collated.
11 years ago
Michael Scherer 1e34e95ba0 Improve error message when multiple action are given
This can be illustrated using this playbook:

    - command: id
      delegate_to: "{{ remote_server }}"
      user: "{{ remote_user }}"

The error is to use 'user' instead of 'remote_user', but the error message
do not really mention it, so it can be a bit hard to spot.
11 years ago
Brian Coca e5f297697a ifconfig changed on FreeBSD, tested this on 8,9 and 10 latest stable
versions and it now works
11 years ago
Brian Coca bc23926f42 fixed ETIME issue on FreeBSD 8 through 10, which broke all fact
gathering
11 years ago
Michael Scherer c87afc1109 Clean a bit more the ssh_args configuration
If someone add ssh_args = " " to his .ansible.cfg, it will result into
strange failure later :

    <server.example.org> ESTABLISH CONNECTION FOR USER: misc
    <server.example.org> REMOTE_MODULE ping
    <server.example.org> EXEC ['ssh', '-C', '-tt', '-q', ' ', '-o', 'KbdInteractiveAuthentication=no',
    '-o', 'PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey', '-o', 'PasswordAuthentication=no',
    '-o', 'ConnectTimeout=10', 'server.example.org', "/bin/sh -c 'mkdir -p /tmp/ansible-tmp-1397947711.21-5932460998838
    && chmod a+rx /tmp/ansible-tmp-1397947711.21-5932460998838 && echo /tmp/ansible-tmp-1397947711.21-5932460998838'"]
    server.example.org | FAILED => SSH encountered an unknown error during the connection. We recommend you re-run the
    command using -vvvv, which will enable SSH debugging output to help diagnose the issue

The root cause is the empty string between -q and -o, who kinda break mkdir.
11 years ago
Michael Scherer 3a09c99811 Enhance error message about missing ControlPersist
ansible_ssh_args is good for playbook, but in the ~/.ansible.cfg
file, it should be ssh_args in a specific section.
11 years ago
James Cammarata ae29e43f93 Merge branch 'issue_7009_nfs_selinux' into devel 11 years ago
Michael DeHaan bec0e596e8 Fix date in changelog for RPM builds off devel branch. 11 years ago
James Cammarata a32dd34359 Make sure HostVars object is instantiated before assigning it
Fixes #7006
11 years ago
James Cammarata cc6d213d72 Updating changelog/releases/packaging for 1.5.5 release 11 years ago
Jim Kleckner 46ec238613 Fix #7057 missing False default for vars_prompt
The test for default should be "is not None" since a boolean value of
False is a valid value.

See discussion at:
  https://groups.google.com/forum/#!topic/ansible-project/oc1_zE-FnyI
11 years ago
James Cammarata 75e0b7a5cf Make sure umask is set restrictively before creating any vault files 11 years ago
Bruce Pennypacker b57887bafd Fix for https://github.com/ansible/ansible/issues/7054 - when renaming an instance and waiting for the change to occur, force result.id to the name of the new instance so the subsequent call to get_current_resource succeeds. 11 years ago
James Cammarata 3715482d7c Determine selinux context for NFS mount points correctly
Fixes #7009
11 years ago
Michael Heca 4271613aa5 module docker_image - default tag latest
Fix constant rebuild of image if no tag specified.
11 years ago
Mike Buzzetti 5dada9403e Adds support for VPC subnets to ELB 11 years ago
Sébastien Gross 22d6572270 Honor ansible_private_key_file for delegated hosts
If a delegated host is not found in the inventory specified
private_key_file for primary host was not used.

This allows running playbooks without having to define any inventory at
all and to use the same ssh private key for both primary host and
delegated one.
11 years ago
Joshua Conner 4defd9a15a docker: exclude 'entrypoint' from comparing 'command' param with containers
The JSON the Docker API returns includes the container's ENTRYPOINT value (if it has one) with the 'Command' value. So instead of checking if `container['Command'] == module.params['command']`, we just check that `container['Command'].endswith(module.params['command'])` so the entrypoint won't affect a container being properly classified as matching the module params or not.

Also I refactored a super-long `if` statement into some temporary variables - I did it to help me figure out what was going wrong, and then it makes the code more readable so I kept it.
11 years ago