7 Commits (54a795896ac6b234223650bc979fe65329b4405a)

Author	SHA1	Message	Date
Andrey Klychkov	4e8df9a4b8	unit tests: remove unused imports (#59636)	5 years ago
Toshio Kuratomi	27c7d5bb01	Move the arguments module into cli/ and context_objects into utils ... * Note: Python2 is not as intelligent at detecting false import loops as Python3. context_objects.py cannot be added to cli/arguments because it would set up an import loop between cli/__init__.py, cli/arguments/context_objects.py, and context.py on Python2. ci_complete	6 years ago
Toshio Kuratomi	7e92ff823e	Split up the base_parser function ... The goal of breaking apart the base_parser() function is to get rid of a bunch of conditionals and parameters in the code and, instead, make code look like simple composition. When splitting, a choice had to be made as to whether this would operate by side effect (modifying a passed in parser) or side effect-free (returning a new parser everytime). Making a version that's side-effect-free appears to be fighting with the optparse API (it wants to work by creating a parser object, configuring the object, and then parsing the arguments with it) so instead, make it clear that our helper functions are modifying the passed in parser by (1) not returning the parser and (2) changing the function names to be more clear that it is operating by side-effect. Also move all of the generic optparse code, along with the argument context classes, into a new subdirectory.	6 years ago
Toshio Kuratomi	afdbb0d9d5	Save the command line arguments into a global context ... * Once cli args are parsed, they're constant. So, save the parsed args into the global context for everyone else to use them from now on. * Port cli scripts to use the CLIARGS in the context * Refactor call to parse cli args into the run() method * Fix unittests for changes to the internals of CLI arg parsing * Port callback plugins to use context.CLIARGS * Got rid of the private self._options attribute * Use context.CLIARGS in the individual callback plugins instead. * Also output positional arguments in default and unixy plugins * Code has been simplified since we're now dealing with a dict rather than Optparse.Value	6 years ago
Matt Clay	3033fd96b0	Move unit test compat code out of `lib/ansible/`. (#46996) ... * Move ansible.compat.tests to test/units/compat/. * Fix unit test references to ansible.compat.tests. * Move builtins compat to separate file. * Fix classification of test/units/compat/ dir.	6 years ago
Toshio Kuratomi	500de1f557	Remove hack for backwards compatible v2_playbook_on_start callback ... Just after release of 2.0.0 (in 2.0.0.1) we had a change to the API of callbacks without bumping the API version. We added the playbook to the arguments passed to the callbacks. This wasn't in the Tower callback at the time. In order to prevent breaking that callback we added a temporary hack to inspect the callback's API to decide if we needed to call it with arguments or not. We scheduled the hack for removal in January 2017. Since that's now past, removing the hack. Change signed off by matburt on the Tower side.	8 years ago
Steve Kuznetsov	0bc35354ce	Change `v2_playbook_on_start` logic to positively detect legacy plugins ... In order to support legacy plugins, the following two method signatures are allowed for `CallbackBase.v2_playbook_on_start`: def v2_playbook_on_start(self): def v2_playbook_on_start(self, playbook): Previously, the logic to handle this divergence checked to see if the callback plugin being called supported an argument named `playbook` in its `v2_playbook_on_start` method. This was fragile in a few ways: - if a plugin author did not use the literal `playbook` to name their method argument, their plugin would not be called correctly - if a plugin author wrapped their `v2_playbook_on_start` method and by doing so changed the argspec to no longer expose an argument with that literal name, their plugin would not be called correctly In order to continue to support both types of callback for backwards compatibility while making the call more robust for plugin authors, the logic can be reversed in order to have a positive check for the old method signature instead of a positive check for the new one. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>	8 years ago